fix(nfc): return the amiibo model number in native byte order #1747

Merged
llun merged 2 commits from Svartskogen/Longshot:fix/nfc-model-byte-order into main 2026-11-19 19:23:53 +00:00
Contributor

Type: fix · Risk: low · Tested on: CachyOS Linux, Radeon RX 9070 · Needs: Windows NFC smoke test

TL;DR

Amiibo scans could succeed but return ordinary random items instead of their model-specific rewards. This fixes the model number passed to the game; the player rebuilt locally and confirmed receiving both Young Link and Young Zelda masks in Hyrule Castle Town. A regression test reproduces the wrong model numbers on main and passes with the fix.

Breakdown

  • Who it helps: players scanning amiibo for model-specific rewards.
  • What was wrong: the tag's big-endian model number was copied into the SDK's native-endian field without conversion.
  • What changes: GetModelInfo returns the correct numeric model number.
  • What does not change: tag parsing, character and variant bytes, figure type, series, UID, application-area persistence and the renderer ABI.
  • How it was checked: compiled-source regression with GCC and Clang, whole-file compilation, and player-confirmed receipt of both special masks after a local rebuild.
  • What is still open: Windows compilation and a Windows/physical-reader smoke test; the known full-suite failures are listed below.
  • Risk: low; the conversion affects recognition of every model whose number has different high and low bytes.

Why

The NFC implementation added in #280 reads and mounts the tags successfully, but their model numbers can fail the game's reward lookup. The player reported that both new OoT tags gave ordinary random items, and confirmed both special masks after applying this fix.

Prior-work search covered open, merged and closed issues/PRs for NFC, GetModelInfo, amiibo, endianness, model number and byte order, plus recent team-room claims. No competing fix was found.

How to reproduce

Seen on: CachyOS Linux, Radeon RX 9070, RADV Mesa 26.2.6-arch3.1.
Settings and switches: existing game settings; no NFC debug switches.
Steps: in Hyrule Castle Town, enter the game's amiibo scan flow, select an owned tag in Insert > NFC and tap it; repeat with the other model.
Expected: Young Link and Young Zelda each give their special mask.
Actual: the original nightly returned ordinary random items, although its log showed that both tags were read.

The game-free reproduction is python -I -B tests/test_nfc_model_info.py with the new test applied to main: four unequal-byte synthetic model numbers are reversed.

What changed

The SDK result now contains the numeric model number expected by the game. The conversion changes only those two output bytes; the original tag and all other returned fields retain their existing values.

  • host/nn_nfp.c, GetModelInfo: retain the existing field copy and explicitly reverse only the two bytes of the model-number field for the SDK result. The tag itself is untouched.
  • tests/test_nfc_model_info.py: compile the actual function via tests/srccut.py and verify six synthetic model blocks, other fields, zeroed reserved bytes, output bounds, unchanged tag memory, five unmounted states and a null output pointer. No dumps or keys are used.
  • docs/tested/2026-11-19-nfc-model-number-svartskogen-run01.md: record the player's in-game acceptance run.
  • Commit order is the failing test first, then the fix.

Measurements

Verdict: four synthetic model-number mismatches become zero; the player confirms both masks after rebuilding with the identical function.

Hardware: CachyOS Linux; Radeon RX 9070, RADV Mesa 26.2.6-arch3.1; Ryzen 7 5700X3D, 32 GB RAM.
Scene: Hyrule Castle Town; 2560x1440 output. Performance was not measured: this is a conversion when a tag is queried, with no per-frame, rendering, loading or cache changes.
Method: compile the extracted main/fixed function with GCC and Clang; run two interleaved pairs per compiler. Each pair returns four wrong model numbers on main and zero with the fix (median 4 -> 0).
How to reproduce: run the new regression against main and this branch; CC=gcc and CC=clang select the compilers.

Check Before: main @ 8b0ea786 After: this PR @ 9ecf2ee1
Wrong model numbers / 6 synthetic models 4 / 4 in the two runs 0 / 0 in the two runs
Output bounds, other fields, reserved bytes, tag contents, unmounted states pass pass
Complete host file compiles with GCC and Clang pass; 25 existing warnings per compiler pass; identical 25 warnings per compiler

The repeated fixture measurements were first taken against a0868c6d and b816917f. Rebases onto d30b9479 and 8b0ea786 leave both the baseline and patched GetModelInfo functions byte-identical, so the conversion results remain applicable. The latest rebase also passed the NFC regression with GCC and Clang, the existing NFC list tests, and the tested-configuration checks.

main: 0x3412 != 0x1234; 0x01ab != 0xab01; 0xff00 != 0x00ff; 0x00ff != 0xff00
fix: PASS: 6 synthetic models, output guards, unchanged tag, 5 unmounted states, null output
GCC pairs: main 4, fix 0, main 4, fix 0 mismatches
Clang pairs: main 4, fix 0, main 4, fix 0 mismatches

In-game baseline: nightly-486-09a20cd6, source 41f3919f, ordinary rewards. In-game fixed build: the same nightly rebuilt locally, source fingerprint baa617b0; the player confirmed both masks in Hyrule Castle Town and supplied screenshots wearing each. The installed and PR GetModelInfo functions were compared byte for byte and match. This is not a claim that a full game built from the new main was played.

Flags and settings

None.

Testing

Tested:

  • The player personally tested the rebuilt game on this PC in Hyrule Castle Town and confirmed receiving both masks. The screenshots below are supplied by the player.
  • New regression fails for the intended numeric mismatch on main, passes with GCC and Clang after the fix, and fails again if one byte assignment is removed.
  • Existing NFC list tests and tested-configuration format checks pass.
  • The entire changed C file compiles with both GCC and Clang using the runtime headers, with the same 25 pre-existing warnings as main.
  • Full suite on the initial a0868c6d base plus this fix: 718 passed, 35 failed, 99 skipped (--jobs 8 --timeout 180). Three Tooling-location failures were resolved by setting MAGICBEAN_TOOLING; all three reruns passed. The remaining 31 deterministic failures were reproduced on unmodified a0868c6d and d30b9479. test_vbytes.py hit the imposed 180-second limit on both the PR run and unmodified d30b9479. The main comparison finished with 3 passes, the same 31 deterministic failures, and that timeout. No new failure was isolated to this NFC change.
  • Checks affected by the rebase onto d30b9479: 112 passed, 12 failed, 2 skipped; one is the resolved Tooling-location failure, and the other eleven are in main's failure set. The new NFC regression passes.
31 pre-existing deterministic failures (reproduced on unmodified main)
  • tests/test_bug_report_defaults.py
  • tests/test_capture_read_once.py
  • tests/test_crt_options.py
  • tests/test_damage_debug_menu.py
  • tests/test_dev_packs.py
  • tests/test_display_startup_failure.py
  • tests/test_dlss_feature_size.py
  • tests/test_failed_compile_keeps_objects.py
  • tests/test_guest_imported.py
  • tests/test_high_fps_fixes.py
  • tests/test_host_guest_writes.py
  • tests/test_hud_layout_row.py
  • tests/test_libc_hooks.py
  • tests/test_linux_preflight.py
  • tests/test_linux_pressure.py
  • tests/test_linux_update.py
  • tests/test_log_open_failure.py
  • tests/test_missing_nup.py
  • tests/test_mods_size_table.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_play_cache.py
  • tests/test_prepare_cache_save.py
  • tests/test_present_thread.py
  • tests/test_profiling_mode.py
  • tests/test_psychov35_fsr3_fg.py
  • tests/test_readback_timeout_source.py
  • tests/test_slow_frames.py
  • tests/test_song_note_cue.py
  • tests/test_upscaler_rows.py
  • tests/test_vcore_escape.py
  • tests/test_walk_key.py

Not tested: a full current-main game rebuild, Windows compilation/runtime, physical NFC reader, and multi-session application-area persistence. The change does not touch the reader or persistence paths. Windows compilation/runtime have not been verified and will not be performed by this contributor. The author has requested review with this limitation documented; Windows validation is deferred to reviewers and is not a contributor readiness condition.

Must be tested:

  • Windows, any GPU: scan an owned tag with a known model-specific reward using a file or the existing controller reader, expecting that specific reward instead of ordinary random items (by hand).

Screenshots

After applying the fix to nightly-486-09a20cd6 (source fingerprint baa617b0), Hyrule Castle Town. Screenshots supplied by the player; they show both rewards equipped. No before screenshot was supplied; the before/after numeric evidence is the compiled regression above.

After: locally rebuilt nightly with this PR's GetModelInfo function, Young Link mask

After: locally rebuilt nightly with this PR's GetModelInfo function, Young Zelda mask

Risks

What could break: reward recognition for tags whose model-number bytes differ; tests cover both byte orders, zero and equal bytes as well as preservation of all other returned fields.
Turning it off: revert the fix commit.
Compatibility: no new setting, save format, NFC dump format, shader cache change or MKWVK_API_VERSION bump. Existing dumps need no edits or conversion.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
  • Screenshots supplied for the functional result: both masks equipped after the fix (no rendering/UI change and no before screenshot claimed).
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • A game-free test added for the fix, failing on main and passing here.
  • Docs updated.
**Type:** fix · **Risk:** low · **Tested on:** CachyOS Linux, Radeon RX 9070 · **Needs:** Windows NFC smoke test ## TL;DR Amiibo scans could succeed but return ordinary random items instead of their model-specific rewards. This fixes the model number passed to the game; the player rebuilt locally and confirmed receiving both Young Link and Young Zelda masks in Hyrule Castle Town. A regression test reproduces the wrong model numbers on main and passes with the fix. ## Breakdown - **Who it helps:** players scanning amiibo for model-specific rewards. - **What was wrong:** the tag's big-endian model number was copied into the SDK's native-endian field without conversion. - **What changes:** GetModelInfo returns the correct numeric model number. - **What does not change:** tag parsing, character and variant bytes, figure type, series, UID, application-area persistence and the renderer ABI. - **How it was checked:** compiled-source regression with GCC and Clang, whole-file compilation, and player-confirmed receipt of both special masks after a local rebuild. - **What is still open:** Windows compilation and a Windows/physical-reader smoke test; the known full-suite failures are listed below. - **Risk:** low; the conversion affects recognition of every model whose number has different high and low bytes. ## Why The NFC implementation added in https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/280 reads and mounts the tags successfully, but their model numbers can fail the game's reward lookup. The player reported that both new OoT tags gave ordinary random items, and confirmed both special masks after applying this fix. Prior-work search covered open, merged and closed issues/PRs for NFC, GetModelInfo, amiibo, endianness, model number and byte order, plus recent team-room claims. No competing fix was found. ## How to reproduce **Seen on:** CachyOS Linux, Radeon RX 9070, RADV Mesa 26.2.6-arch3.1. **Settings and switches:** existing game settings; no NFC debug switches. **Steps:** in Hyrule Castle Town, enter the game's amiibo scan flow, select an owned tag in Insert > NFC and tap it; repeat with the other model. **Expected:** Young Link and Young Zelda each give their special mask. **Actual:** the original nightly returned ordinary random items, although its log showed that both tags were read. The game-free reproduction is `python -I -B tests/test_nfc_model_info.py` with the new test applied to main: four unequal-byte synthetic model numbers are reversed. ## What changed The SDK result now contains the numeric model number expected by the game. The conversion changes only those two output bytes; the original tag and all other returned fields retain their existing values. - `host/nn_nfp.c`, GetModelInfo: retain the existing field copy and explicitly reverse only the two bytes of the model-number field for the SDK result. The tag itself is untouched. - `tests/test_nfc_model_info.py`: compile the actual function via `tests/srccut.py` and verify six synthetic model blocks, other fields, zeroed reserved bytes, output bounds, unchanged tag memory, five unmounted states and a null output pointer. No dumps or keys are used. - `docs/tested/2026-11-19-nfc-model-number-svartskogen-run01.md`: record the player's in-game acceptance run. - Commit order is the failing test first, then the fix. ## Measurements **Verdict:** four synthetic model-number mismatches become zero; the player confirms both masks after rebuilding with the identical function. Hardware: CachyOS Linux; Radeon RX 9070, RADV Mesa 26.2.6-arch3.1; Ryzen 7 5700X3D, 32 GB RAM. Scene: Hyrule Castle Town; 2560x1440 output. Performance was not measured: this is a conversion when a tag is queried, with no per-frame, rendering, loading or cache changes. Method: compile the extracted main/fixed function with GCC and Clang; run two interleaved pairs per compiler. Each pair returns four wrong model numbers on main and zero with the fix (median 4 -> 0). How to reproduce: run the new regression against main and this branch; `CC=gcc` and `CC=clang` select the compilers. | Check | Before: main @ 8b0ea786 | After: this PR @ 9ecf2ee1 | |---|---|---| | Wrong model numbers / 6 synthetic models | 4 / 4 in the two runs | 0 / 0 in the two runs | | Output bounds, other fields, reserved bytes, tag contents, unmounted states | pass | pass | | Complete host file compiles with GCC and Clang | pass; 25 existing warnings per compiler | pass; identical 25 warnings per compiler | The repeated fixture measurements were first taken against a0868c6d and b816917f. Rebases onto d30b9479 and 8b0ea786 leave both the baseline and patched GetModelInfo functions byte-identical, so the conversion results remain applicable. The latest rebase also passed the NFC regression with GCC and Clang, the existing NFC list tests, and the tested-configuration checks. ```text main: 0x3412 != 0x1234; 0x01ab != 0xab01; 0xff00 != 0x00ff; 0x00ff != 0xff00 fix: PASS: 6 synthetic models, output guards, unchanged tag, 5 unmounted states, null output GCC pairs: main 4, fix 0, main 4, fix 0 mismatches Clang pairs: main 4, fix 0, main 4, fix 0 mismatches ``` In-game baseline: nightly-486-09a20cd6, source 41f3919f, ordinary rewards. In-game fixed build: the same nightly rebuilt locally, source fingerprint baa617b0; the player confirmed both masks in Hyrule Castle Town and supplied screenshots wearing each. The installed and PR GetModelInfo functions were compared byte for byte and match. This is not a claim that a full game built from the new main was played. ### Flags and settings None. ## Testing **Tested:** - The player personally tested the rebuilt game on this PC in Hyrule Castle Town and confirmed receiving both masks. The screenshots below are supplied by the player. - New regression fails for the intended numeric mismatch on main, passes with GCC and Clang after the fix, and fails again if one byte assignment is removed. - Existing NFC list tests and tested-configuration format checks pass. - The entire changed C file compiles with both GCC and Clang using the runtime headers, with the same 25 pre-existing warnings as main. - Full suite on the initial a0868c6d base plus this fix: 718 passed, 35 failed, 99 skipped (`--jobs 8 --timeout 180`). Three Tooling-location failures were resolved by setting `MAGICBEAN_TOOLING`; all three reruns passed. The remaining 31 deterministic failures were reproduced on unmodified a0868c6d and d30b9479. `test_vbytes.py` hit the imposed 180-second limit on both the PR run and unmodified d30b9479. The main comparison finished with 3 passes, the same 31 deterministic failures, and that timeout. No new failure was isolated to this NFC change. - Checks affected by the rebase onto d30b9479: 112 passed, 12 failed, 2 skipped; one is the resolved Tooling-location failure, and the other eleven are in main's failure set. The new NFC regression passes. <details> <summary>31 pre-existing deterministic failures (reproduced on unmodified main)</summary> - `tests/test_bug_report_defaults.py` - `tests/test_capture_read_once.py` - `tests/test_crt_options.py` - `tests/test_damage_debug_menu.py` - `tests/test_dev_packs.py` - `tests/test_display_startup_failure.py` - `tests/test_dlss_feature_size.py` - `tests/test_failed_compile_keeps_objects.py` - `tests/test_guest_imported.py` - `tests/test_high_fps_fixes.py` - `tests/test_host_guest_writes.py` - `tests/test_hud_layout_row.py` - `tests/test_libc_hooks.py` - `tests/test_linux_preflight.py` - `tests/test_linux_pressure.py` - `tests/test_linux_update.py` - `tests/test_log_open_failure.py` - `tests/test_missing_nup.py` - `tests/test_mods_size_table.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_play_cache.py` - `tests/test_prepare_cache_save.py` - `tests/test_present_thread.py` - `tests/test_profiling_mode.py` - `tests/test_psychov35_fsr3_fg.py` - `tests/test_readback_timeout_source.py` - `tests/test_slow_frames.py` - `tests/test_song_note_cue.py` - `tests/test_upscaler_rows.py` - `tests/test_vcore_escape.py` - `tests/test_walk_key.py` </details> **Not tested:** a full current-main game rebuild, Windows compilation/runtime, physical NFC reader, and multi-session application-area persistence. The change does not touch the reader or persistence paths. Windows compilation/runtime have not been verified and will not be performed by this contributor. The author has requested review with this limitation documented; Windows validation is deferred to reviewers and is not a contributor readiness condition. **Must be tested:** - Windows, any GPU: scan an owned tag with a known model-specific reward using a file or the existing controller reader, expecting that specific reward instead of ordinary random items (by hand). ## Screenshots After applying the fix to nightly-486-09a20cd6 (source fingerprint baa617b0), Hyrule Castle Town. Screenshots supplied by the player; they show both rewards equipped. No before screenshot was supplied; the before/after numeric evidence is the compiled regression above. ![After: locally rebuilt nightly with this PR's GetModelInfo function, Young Link mask](https://git.magicbean.dev/attachments/58945297-9af5-4780-9cd7-7b4150c2912a) ![After: locally rebuilt nightly with this PR's GetModelInfo function, Young Zelda mask](https://git.magicbean.dev/attachments/1bc79115-6391-4219-8650-184ce7270f93) ## Risks **What could break:** reward recognition for tags whose model-number bytes differ; tests cover both byte orders, zero and equal bytes as well as preservation of all other returned fields. **Turning it off:** revert the fix commit. **Compatibility:** no new setting, save format, NFC dump format, shader cache change or MKWVK_API_VERSION bump. Existing dumps need no edits or conversion. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] Screenshots supplied for the functional result: both masks equipped after the fix (no rendering/UI change and no before screenshot claimed). - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] Docs updated.
Assisted-by: Codex
fix(nfc): return the model number in native byte order
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
9917b32e04
Assisted-by: Codex
Author
Contributor

Tested in game: Player-tested on CachyOS Linux, Radeon RX 9070, RADV Mesa 26.2.6-arch3.1: Hyrule Castle Town, both Young Link and Young Zelda masks received after rebuilding nightly-486-09a20cd6 with this exact GetModelInfo function. The player supplied screenshots wearing both masks. Full current-main game rebuild not claimed.

Tested in game: Player-tested on CachyOS Linux, Radeon RX 9070, RADV Mesa 26.2.6-arch3.1: Hyrule Castle Town, both Young Link and Young Zelda masks received after rebuilding nightly-486-09a20cd6 with this exact GetModelInfo function. The player supplied screenshots wearing both masks. Full current-main game rebuild not claimed.
Author
Contributor

Added the player-supplied screenshots of both masks and the confirmed Hyrule Castle Town run. The new regression fails on main and passes with GCC and Clang; complete host compilation adds no warnings. Compared the unrelated suite failures against unmodified main: the same 31 deterministic failures and test_vbytes timeout reproduce there; the three Tooling-location failures pass after setting MAGICBEAN_TOOLING. Kept WIP because Windows host compilation remains untested.

Added the player-supplied screenshots of both masks and the confirmed Hyrule Castle Town run. The new regression fails on main and passes with GCC and Clang; complete host compilation adds no warnings. Compared the unrelated suite failures against unmodified main: the same 31 deterministic failures and test_vbytes timeout reproduce there; the three Tooling-location failures pass after setting MAGICBEAN_TOOLING. Kept WIP because Windows host compilation remains untested.
Author
Contributor

Ready for review at the author’s request. Windows compilation/runtime remain explicitly unverified and will not be performed by this contributor; that checklist item is left unticked. Linux in-game confirmation, screenshots and regression-test evidence are unchanged.

Ready for review at the author’s request. Windows compilation/runtime remain explicitly unverified and will not be performed by this contributor; that checklist item is left unticked. Linux in-game confirmation, screenshots and regression-test evidence are unchanged.
Svartskogen changed title from WIP: fix(nfc): return the amiibo model number in native byte order to fix(nfc): return the amiibo model number in native byte order 2026-11-19 15:20:54 +00:00
Svartskogen force-pushed fix/nfc-model-byte-order from 9917b32e04
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 9ecf2ee11a
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
2026-11-19 15:23:52 +00:00
Compare
Author
Contributor

Rebased the two NFC commits onto current main (8b0ea786). The NFC regression passes with GCC and Clang; existing NFC list and tested-configuration checks pass. Per the author’s decision, Windows validation is deferred to reviewers rather than used as a contributor readiness condition; it remains explicitly unverified in Testing. Removed the unticked Windows readiness item without claiming a Windows test was run. Workflow approval and the required independent review still need a maintainer.

Rebased the two NFC commits onto current main (8b0ea786). The NFC regression passes with GCC and Clang; existing NFC list and tested-configuration checks pass. Per the author’s decision, Windows validation is deferred to reviewers rather than used as a contributor readiness condition; it remains explicitly unverified in Testing. Removed the unticked Windows readiness item without claiming a Windows test was run. Workflow approval and the required independent review still need a maintainer.
llun approved these changes 2026-11-19 19:23:25 +00:00
llun merged commit a433db3283 into main 2026-11-19 19:23:53 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1747
No description provided.