test(pacing): characterize current cap and present policy #1591

Merged
HumanBean merged 1 commit from futondestroyer/Longshot:test/issue-1519-pacing-policy into main 2026-11-20 21:31:24 +00:00
Member

Summary

The host, renderer and FPS overlay make pacing decisions from the same settings. The game-free fixture in tests/test_pacing_policy.py records the current choices so later policy changes can identify which behavior moved. It covers movie caps, V-Sync and present modes, and fixed frame-generation image and slot counts. The refresh rebases the identical fixture onto main 89c3d21e, including the presenter rewrite in #1763. See #1519.

Testing

Tested: Windows with llvm-mingw at e62b8e90. All 13 focused checks passed, including the pacing matrix, presenter, swapchain semaphores and CPU acquire fence. The matrix checks 13 host and overlay rows, 192 present-mode combinations plus the empty-list fallback, and 16 fixed frame-generation allocation cases. The Windows strict suite completed in batches with 693 passes, 140 failures reproduced on exact main, and 48 declared platform skips. The Windows queue self-test additionally failed its RAM-filesystem case on both revisions and interrupted both suite invocations. Four intermittent candidate outcomes passed on targeted reruns. Pinned Ruff, actionlint and the Windows Gitleaks release passed. The Guide screenshots checker reports the same 33 review items on main and this head; see #1501.

Failures reproduced on main
  • nx2/test_mesh_first_types.py
  • nx2/test_nup_codec.py
  • nx2/test_nup_read_name.py
  • nx2/test_nup_stand_in.py
  • nx2/test_nup_verify.py
  • nx2/test_texture_init_barrier.py
  • tests/test_antilag.py
  • tests/test_appimage_player_build.py
  • tests/test_async_safe_frees.py
  • tests/test_auto_handheld.py
  • tests/test_bug_report_defaults.py
  • tests/test_build_long_paths.py
  • tests/test_capture_dimensions.py
  • tests/test_capture_read_once.py
  • tests/test_capture_readback_visibility.py
  • tests/test_capture_resources.py
  • tests/test_coopmat_probe_failures.py
  • tests/test_crash_dialog.py
  • tests/test_crt_options.py
  • tests/test_damage_debug_menu.py
  • tests/test_desc_counts.py
  • tests/test_dev_ab.py
  • tests/test_dev_build.py
  • tests/test_dev_migrate.py
  • tests/test_dev_packs.py
  • tests/test_device_policy.py
  • tests/test_discover.py
  • tests/test_display_startup_failure.py
  • tests/test_dlss_feature_size.py
  • tests/test_draw_binds.py
  • tests/test_draw_stream_visibility.py
  • tests/test_dummy_views.py
  • tests/test_dump_readback.py
  • tests/test_early_split_before_draw.py
  • tests/test_failed_compile_keeps_objects.py
  • tests/test_fallback_pipeline_state.py
  • tests/test_fastfp_fma.py
  • tests/test_fma_soft.py
  • tests/test_fpx_sticky.py
  • tests/test_frame_overlap.py
  • tests/test_framegen_resources.py
  • tests/test_framelog_sink.py
  • tests/test_fsr3_release_frees.py
  • tests/test_fsr3fi_hud_layer.py
  • tests/test_fsr3fi_hud_mask.py
  • tests/test_fsr3fi_hudless_colour.py
  • tests/test_fsr4_bind_dispatch.py
  • tests/test_fsr_image_retirement.py
  • tests/test_fsr_uniform_ownership.py
  • tests/test_game_menu_mouse_buttons.py
  • tests/test_guest_imported.py
  • tests/test_high_fps_fixes.py
  • tests/test_hold_gpu.py
  • tests/test_host_guest_writes.py
  • tests/test_hud_layout_row.py
  • tests/test_image_view_retry.py
  • tests/test_import_buffer_binding.py
  • tests/test_import_reach.py
  • tests/test_inline_write_order.py
  • tests/test_insn_fixed_convert.py
  • tests/test_job_queue.py
  • tests/test_libc_hooks.py
  • tests/test_lift_cache.py
  • tests/test_lift_lookups.py
  • tests/test_linux_preflight.py
  • tests/test_linux_pressure.py
  • tests/test_longshot_ctl.py
  • tests/test_lost_wait_said.py
  • tests/test_low_vram_texture_mips.py
  • tests/test_make_game_cache.py
  • tests/test_make_game_ngx.py
  • tests/test_mise_build.py
  • tests/test_missing_nup.py
  • tests/test_mods_list.py
  • tests/test_native_zstd.py
  • tests/test_ngx_sdk.py
  • tests/test_pads_after_menu.py
  • tests/test_pass_barrier.py
  • tests/test_pass_hazard.py
  • tests/test_pcache_header_read.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_cache_save.py
  • tests/test_pipeline_key_values.py
  • tests/test_pipeline_play_cache.py
  • tests/test_pipeline_state_portable.py
  • tests/test_pipeline_states.py
  • tests/test_prepare_cache_save.py
  • tests/test_present_queue_default.py
  • tests/test_present_source_crop.py
  • tests/test_profiling_mode.py
  • tests/test_program_answer_domains.py
  • tests/test_prompt_guide_lines.py
  • tests/test_prompt_hand_guides.py
  • tests/test_prompt_picture_tint.py
  • tests/test_prompt_speed.py
  • tests/test_psychov35_fsr3_fg.py
  • tests/test_push_state.py
  • tests/test_readback_early.py
  • tests/test_readback_late.py
  • tests/test_readback_timeout_source.py
  • tests/test_recorder_own_idle.py
  • tests/test_recorder_sync.py
  • tests/test_recording_admission.py
  • tests/test_replay_write_order.py
  • tests/test_same_draw.py
  • tests/test_same_dyn.py
  • tests/test_sampler_admission.py
  • tests/test_sdiv_overflow.py
  • tests/test_setup_tar_diagnostics.py
  • tests/test_slow_frames.py
  • tests/test_song_note_cue.py
  • tests/test_sparse_bind_failure.py
  • tests/test_sparse_bind_ranges.py
  • tests/test_spawn_emit.py
  • tests/test_split_before_draw.py
  • tests/test_split_ub_flush.py
  • tests/test_staging_burst.py
  • tests/test_taau_typed_dispatch.py
  • tests/test_table_track.py
  • tests/test_texel_buffer_ownership.py
  • tests/test_texture_staging_publication.py
  • tests/test_ub_snapshot_default.py
  • tests/test_ub_update_batch.py
  • tests/test_ui_record.py
  • tests/test_ui_texture_upload.py
  • tests/test_upscaler_rows.py
  • tests/test_vbytes.py
  • tests/test_vcore_escape.py
  • tests/test_vecfp.py
  • tests/test_vendor_fixes.py
  • tests/test_vertex_bind.py
  • tests/test_vertex_bind_range.py
  • tests/test_vfpx_elem.py
  • tests/test_vk_occlusion_queries.py
  • tests/test_vulkan_clear_mip.py
  • tests/test_vulkan_copy_span.py
  • tests/test_vulkan_copy_span_gpu_compile.py
  • tests/test_walk.py
  • tests/test_walk_key.py
  • tests/test_wb_diff_observations_gpu.py
  • tests/test_widen_alpha.py

Still to test: None for the fixture. Actual display cadence and VRR engagement are outside the fixture's scope.

Measurements

The change adds a game-free fixture. Performance measurement does not apply.

Risks

Source moves can require updates to the fixture's extraction points. Reverting the test commit removes the fixture.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.
## Summary The host, renderer and FPS overlay make pacing decisions from the same settings. The game-free fixture in `tests/test_pacing_policy.py` records the current choices so later policy changes can identify which behavior moved. It covers movie caps, V-Sync and present modes, and fixed frame-generation image and slot counts. The refresh rebases the identical fixture onto main `89c3d21e`, including the presenter rewrite in #1763. See #1519. ## Testing **Tested:** Windows with llvm-mingw at `e62b8e90`. All 13 focused checks passed, including the pacing matrix, presenter, swapchain semaphores and CPU acquire fence. The matrix checks 13 host and overlay rows, 192 present-mode combinations plus the empty-list fallback, and 16 fixed frame-generation allocation cases. The Windows strict suite completed in batches with 693 passes, 140 failures reproduced on exact main, and 48 declared platform skips. The Windows queue self-test additionally failed its RAM-filesystem case on both revisions and interrupted both suite invocations. Four intermittent candidate outcomes passed on targeted reruns. Pinned Ruff, actionlint and the Windows Gitleaks release passed. The Guide screenshots checker reports the same 33 review items on main and this head; see #1501. <details> <summary>Failures reproduced on main</summary> - `nx2/test_mesh_first_types.py` - `nx2/test_nup_codec.py` - `nx2/test_nup_read_name.py` - `nx2/test_nup_stand_in.py` - `nx2/test_nup_verify.py` - `nx2/test_texture_init_barrier.py` - `tests/test_antilag.py` - `tests/test_appimage_player_build.py` - `tests/test_async_safe_frees.py` - `tests/test_auto_handheld.py` - `tests/test_bug_report_defaults.py` - `tests/test_build_long_paths.py` - `tests/test_capture_dimensions.py` - `tests/test_capture_read_once.py` - `tests/test_capture_readback_visibility.py` - `tests/test_capture_resources.py` - `tests/test_coopmat_probe_failures.py` - `tests/test_crash_dialog.py` - `tests/test_crt_options.py` - `tests/test_damage_debug_menu.py` - `tests/test_desc_counts.py` - `tests/test_dev_ab.py` - `tests/test_dev_build.py` - `tests/test_dev_migrate.py` - `tests/test_dev_packs.py` - `tests/test_device_policy.py` - `tests/test_discover.py` - `tests/test_display_startup_failure.py` - `tests/test_dlss_feature_size.py` - `tests/test_draw_binds.py` - `tests/test_draw_stream_visibility.py` - `tests/test_dummy_views.py` - `tests/test_dump_readback.py` - `tests/test_early_split_before_draw.py` - `tests/test_failed_compile_keeps_objects.py` - `tests/test_fallback_pipeline_state.py` - `tests/test_fastfp_fma.py` - `tests/test_fma_soft.py` - `tests/test_fpx_sticky.py` - `tests/test_frame_overlap.py` - `tests/test_framegen_resources.py` - `tests/test_framelog_sink.py` - `tests/test_fsr3_release_frees.py` - `tests/test_fsr3fi_hud_layer.py` - `tests/test_fsr3fi_hud_mask.py` - `tests/test_fsr3fi_hudless_colour.py` - `tests/test_fsr4_bind_dispatch.py` - `tests/test_fsr_image_retirement.py` - `tests/test_fsr_uniform_ownership.py` - `tests/test_game_menu_mouse_buttons.py` - `tests/test_guest_imported.py` - `tests/test_high_fps_fixes.py` - `tests/test_hold_gpu.py` - `tests/test_host_guest_writes.py` - `tests/test_hud_layout_row.py` - `tests/test_image_view_retry.py` - `tests/test_import_buffer_binding.py` - `tests/test_import_reach.py` - `tests/test_inline_write_order.py` - `tests/test_insn_fixed_convert.py` - `tests/test_job_queue.py` - `tests/test_libc_hooks.py` - `tests/test_lift_cache.py` - `tests/test_lift_lookups.py` - `tests/test_linux_preflight.py` - `tests/test_linux_pressure.py` - `tests/test_longshot_ctl.py` - `tests/test_lost_wait_said.py` - `tests/test_low_vram_texture_mips.py` - `tests/test_make_game_cache.py` - `tests/test_make_game_ngx.py` - `tests/test_mise_build.py` - `tests/test_missing_nup.py` - `tests/test_mods_list.py` - `tests/test_native_zstd.py` - `tests/test_ngx_sdk.py` - `tests/test_pads_after_menu.py` - `tests/test_pass_barrier.py` - `tests/test_pass_hazard.py` - `tests/test_pcache_header_read.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_cache_save.py` - `tests/test_pipeline_key_values.py` - `tests/test_pipeline_play_cache.py` - `tests/test_pipeline_state_portable.py` - `tests/test_pipeline_states.py` - `tests/test_prepare_cache_save.py` - `tests/test_present_queue_default.py` - `tests/test_present_source_crop.py` - `tests/test_profiling_mode.py` - `tests/test_program_answer_domains.py` - `tests/test_prompt_guide_lines.py` - `tests/test_prompt_hand_guides.py` - `tests/test_prompt_picture_tint.py` - `tests/test_prompt_speed.py` - `tests/test_psychov35_fsr3_fg.py` - `tests/test_push_state.py` - `tests/test_readback_early.py` - `tests/test_readback_late.py` - `tests/test_readback_timeout_source.py` - `tests/test_recorder_own_idle.py` - `tests/test_recorder_sync.py` - `tests/test_recording_admission.py` - `tests/test_replay_write_order.py` - `tests/test_same_draw.py` - `tests/test_same_dyn.py` - `tests/test_sampler_admission.py` - `tests/test_sdiv_overflow.py` - `tests/test_setup_tar_diagnostics.py` - `tests/test_slow_frames.py` - `tests/test_song_note_cue.py` - `tests/test_sparse_bind_failure.py` - `tests/test_sparse_bind_ranges.py` - `tests/test_spawn_emit.py` - `tests/test_split_before_draw.py` - `tests/test_split_ub_flush.py` - `tests/test_staging_burst.py` - `tests/test_taau_typed_dispatch.py` - `tests/test_table_track.py` - `tests/test_texel_buffer_ownership.py` - `tests/test_texture_staging_publication.py` - `tests/test_ub_snapshot_default.py` - `tests/test_ub_update_batch.py` - `tests/test_ui_record.py` - `tests/test_ui_texture_upload.py` - `tests/test_upscaler_rows.py` - `tests/test_vbytes.py` - `tests/test_vcore_escape.py` - `tests/test_vecfp.py` - `tests/test_vendor_fixes.py` - `tests/test_vertex_bind.py` - `tests/test_vertex_bind_range.py` - `tests/test_vfpx_elem.py` - `tests/test_vk_occlusion_queries.py` - `tests/test_vulkan_clear_mip.py` - `tests/test_vulkan_copy_span.py` - `tests/test_vulkan_copy_span_gpu_compile.py` - `tests/test_walk.py` - `tests/test_walk_key.py` - `tests/test_wb_diff_observations_gpu.py` - `tests/test_widen_alpha.py` </details> **Still to test:** None for the fixture. Actual display cadence and VRR engagement are outside the fixture's scope. ## Measurements The change adds a game-free fixture. Performance measurement does not apply. ## Risks Source moves can require updates to the fixture's extraction points. Reverting the test commit removes the fixture. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold.
futondestroyer changed title from WIP: test(pacing): characterize current cap and present policy to test(pacing): characterize current cap and present policy 2026-11-18 14:53:42 +00:00
futondestroyer force-pushed test/issue-1519-pacing-policy from 14dd5f4de5
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
to 48f608ca5c
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 5s
2026-11-18 16:25:18 +00:00
Compare
Author
Member

Rebased onto main 876dc360. The new head is 48f608ca and the fixture is byte-identical to the reviewed 14dd5f4d. All 12 focused Windows checks passed. The full game-free suite recorded 616 passes, 44 failures reproduced on main, and 121 skips. The Guide screenshots failure also occurs on main and is tracked in #1501. Please confirm the new head against the existing review.

Rebased onto main `876dc360`. The new head is `48f608ca` and the fixture is byte-identical to the reviewed `14dd5f4d`. All 12 focused Windows checks passed. The full game-free suite recorded 616 passes, 44 failures reproduced on main, and 121 skips. The Guide screenshots failure also occurs on main and is tracked in #1501. Please confirm the new head against the existing review.
futondestroyer force-pushed test/issue-1519-pacing-policy from 48f608ca5c
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 5s
to e62b8e9092
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 11s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 17s
CI / Workflow lint (actionlint) (pull_request) Successful in 18s
Third-party parts / As their notes say (pull_request) Successful in 19s
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Website build and checks (pull_request) Failing after 2m22s
2026-11-20 13:13:11 +00:00
Compare
Author
Member

Rebased the unchanged fixture onto main 89c3d21e. The new head is e62b8e90. All 13 focused Windows checks passed, including the current presenter and CPU acquire-fence checks. The description names the strict-suite baseline failures and the Windows queue self-test interruption reproduced on both revisions. The Graphics guide review remains tracked in #1501. Please confirm the new revision pair in review.

Rebased the unchanged fixture onto main `89c3d21e`. The new head is `e62b8e90`. All 13 focused Windows checks passed, including the current presenter and CPU acquire-fence checks. The description names the strict-suite baseline failures and the Windows queue self-test interruption reproduced on both revisions. The Graphics guide review remains tracked in #1501. Please confirm the new revision pair in review.
HumanBean deleted branch test/issue-1519-pacing-policy 2026-11-20 21:31:24 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1591
No description provided.