fix(build): the build runs from, in and into folders past 260 characters #1132

Open
enum wants to merge 3 commits from enum/Longshot:fix/version-long-paths into main
First-time contributor

Type: fix · Risk: medium · Tested on: Windows 11, RTX 4070 · Needs: none

Why

The Windows build stops at "Compiling" with FileNotFoundError when the Builder sits deep in the file system, such as
a portable Longshot Launcher in Downloads. At that depth the deepest sources pass Windows' 260-character path limit
(MAX_PATH), and the build's own Python reads them by plain paths. Most PCs have Windows' long-paths setting off, so the
build can't finish. A work folder or a game folder deep enough fails the same way further on: the objects are named
after their sources (up to ~90 characters), and their stamps, the object cache and the link record are read and written
by plain paths too. Fixes #1115.

How to reproduce

Seen on: reported on Windows (#1115: a portable Launcher, nightly-346-8a4aa282). Here: Windows 11 Pro (26300),
RTX 4070, driver 616.56, long paths off (LongPathsEnabled=0, the default)
Settings and switches: defaults
Steps: put the Builder's tools folder 176 characters deep, as the report's
~\Downloads\QuiverLauncher-win-Portable\...\LongshotBuilder\tools\ is with an 8-letter user name, and build from it.
Without the Launcher: unpack git archive origin/main into a folder that deep, then
python -I <that folder>\nx2\make_game.py --nup <your .nup> --out <game> --work <work>
Expected: the build goes through
Actual: it stops in version.define() → fingerprint(), the report's traceback:
FileNotFoundError: [Errno 2] No such file or directory: '...\gpu\third_party\suyu\shader_recompiler\backend\glsl\emit_glsl_bitwise_conversion.cpp'.
With the work folder 180 characters deep as well, a build that gets past that stops in compile_one writing
...\sa\build\obj\vk_eden_shader_recompiler_backend_spirv_emit_spirv_barriers.o.sha1.

What changed

The build's Python reaches paths past 260 characters on Windows the way Python itself allows without Windows'
long-paths setting: in the extended-length form, \\?\C:\.... A new module does it for the standard file calls, and each
script the build runs installs it as it loads, so nothing in the build has to remember it. Only a path 248 characters or
more once absolute changes; for every path that worked before, the calls behave as they did. clang and the linker take
long paths already.

  • nx2/long_paths.py (new): install() wraps open (with os.open, and the copies tarfile/bz2 and the like kept as
    they loaded), os.stat and its kin, os.path.exists and its kin, the renames and links, shutil's copies and
    copytree. Each wrapper changes only the path: no argument, keywords, dir_fd and os.supports_* stay as they
    were, and what comes back is in the caller's spelling (scandir entries, os.walk either way round, shutil's
    destinations). os.walk, makedirs, rmtree, tempfile, pathlib, glob, zipfile and tarfile follow. Off
    Windows it does nothing.
  • entry scripts: make_game.py, build.py, lift.py (its spawned workers load it again, so they install too),
    nup.py, unpack.py, split_hot.py, shader_census.py, text_assets.py, prompt_assets.py,
    third_party_objects.py call long_paths.install() before anything reads a file.
  • nx2/version.py (long_path(), walk(), used by fingerprint()) and nx2/translator_files.py (files(),
    stamp()) keep long paths of their own, because scripts/dev_packs.py, the bake tools and the checks load them
    without the build. A folder skipped by the stamp's walk would change the shader stamp, and with it every player's
    shader caches.
  • tests/test_prompt_skip.py: the prompt step imports long_paths without it in the prompt key, as with kit;
    neither changes what is drawn. The check still fails for any other unfingerprinted import.
  • docs: docs/development.md (Layout) says every build script installs it, and a new one joins the per-script check; docs/worklist.md has a row for #1115 (S0, provisional reach 0.05, confidence 0.4), owner enum.

I first fixed the tools folder site by site (10 sites). Making the work folder and the game folder deep showed about
100 more file calls across build.py, make_game.py and the scripts they start, so one module at every entry replaced
the per-site edits. Two cold reviews by a separate agent went over it. The second one found short-path regressions in
the first version of the module (os.listdir() with no argument, open(file=...), os.supports_* membership) and
calls it missed (os.open through tempfile, copytree's default copy2, tarfile's and bz2's own open). All
of those are fixed here, and each has a case in tests/test_long_paths.py.

Measurements

Verdict: passes. The new checks fail on main and pass here. The whole game builds and plays with the Builder, its
work folder and its game folder 176-180 characters deep. For a tree that already worked, the fingerprint and the
shader stamp are unchanged.

Hardware: Windows 11 Pro (26300), RTX 4070 (616.56), Ryzen 9 7900X, 64 GB; llvm-mingw 23.1.5, Python 3.12.10; long
paths off
Scene: Kokiri Forest, the repository's kokiri-start save, headless (longshot_ctl.py launch --profile test)
Method: the checks; nx2/make_game.py run from git archive of each commit, unpacked 176 characters deep, with
--work and --out beside it (180), through scripts/job_queue.py --mode build; then the game folder started with the
control bridge, pressed into play, two screenshots, a stick walk, a stop
How to reproduce: the commands under How to reproduce, with this PR's commit in place of origin/main

Before: main @ 71b1edd8 After: this PR @ 48432422
nx2/test_version_long_paths.py 4 of 4 cases fail pass
tests/test_build_long_paths.py 20 of 21 cases fail pass
tests/test_long_paths.py (the module is new) pass
Game build, tools 176 / work 180 / game 180 characters deep stops: FileNotFoundError in fingerprint(); past it, in compile_one 0:06:30, 0 failed, both modules linked in the deep work folder
That game folder, played (no game folder) Kokiri Forest at ~60 fps after 9 presses, walked, a clean stop; no error in the log
Fingerprint / shader stamp of a normal checkout the same as this PR ea37367d / 2b1aa955fa54ed89, as main's code gives on the same tree
run_all.py (Windows) 28 failed 611 passed, 26 failed, 43 skipped: all 26 also fail on main
== main, builder 176 characters deep
  File "...\nx2\version.py", line 55, in fingerprint
    with open(p, "rb") as src:
FileNotFoundError: [Errno 2] No such file or directory: '...\gpu\third_party\suyu\shader_recompiler\backend\glsl\emit_glsl_bitwise_conversion.cpp'
== tools fixed, work folder 180 characters deep
  File "...\nx2\build.py", line 1483, in compile_one
    open(stamp, "w").write(key)
FileNotFoundError: [Errno 2] No such file or directory: '...-work\\sa\\build\\obj\\vk_eden_shader_recompiler_backend_spirv_emit_spirv_barriers.o.sha1'
== this PR, all three deep
version: unknown (source ea37367d)
compiled in 243s, 0 failed
the build took 0:06:30, compiled in 0:04:24
state after pressing through: play (after 9 presses)
frame 2383  fps 60.5  state play  draws 625  window 1920x1080  map KokiriForest_Child (child)  unknown (source ea37367d)
stopped: 0

Main's two extra suite failures (test_bug_report, test_hardware_report) came from running it in a throwaway
worktree; neither reads a file this PR changes.

Flags and settings

None. (LONGSHOT_VERSION appears only in nx2/test_version_long_paths.py, which clears it so the check reads the release from the tree, as nx2/test_version.py does.)

Testing

Tested:

  • Game-free checks on Windows 11 (above). On Linux under WSL Ubuntu (ext4, Python 3.14, g++): the new checks, the
    version, stamp, prompt and build fixture checks pass; the per-script check skips there (the module does nothing off
    Windows, and loading every script needs the build's packages).
  • In the game, twice, Windows 11, RTX 4070, driver 616.56: a game folder built by a Builder 176 characters deep
    (work and game folders short), and one built with the Builder, the work folder and the game folder 176-180
    characters deep, with the first one's shader caches copied in. Both pressed through the title into Kokiri Forest at
    about 60 fps, walked, and stopped cleanly, with no device lost and no error in longshot_log.txt.
  • Break checks: the module made to do nothing fails every case; one entry script's install removed fails that
    script's case; os.open unwrapped fails its case; each of the first version's 10 explicit sites reverted alone
    failed a case.

Not tested: the real portable Launcher, and the reporter's own PC. PCs with LongPathsEnabled=1 in the registry: plain paths work there already, so this PR changes
nothing for them. A current folder past ~258 characters (subprocess's cwd=, os.chdir): Windows takes none in any
form, and the build runs at most in the game folder.

Must be tested: None

Risks

What could break: the build's file calls on Windows. The module patches open and the os/shutil calls
process-wide in the build's own scripts. A path under 248 characters goes through unchanged, and the calls' conventions
(no argument, keywords, dir_fd, os.supports_*) are kept and tested. Only the standard library's earlier copies of
open are swept; code of ours keeps what it holds. Linux and macOS: nothing changes.

Turning it off: revert the commit

Compatibility: Nothing changes for a player whose folders worked: the same fingerprint, shader stamp and object
keys, so no shader cache is dropped and nothing extra is compiled. The prompt key is unchanged.

Issues

Fixes #1115

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** medium · **Tested on:** Windows 11, RTX 4070 · **Needs:** none ## Why The Windows build stops at "Compiling" with `FileNotFoundError` when the Builder sits deep in the file system, such as a portable Longshot Launcher in Downloads. At that depth the deepest sources pass Windows' 260-character path limit (MAX_PATH), and the build's own Python reads them by plain paths. Most PCs have Windows' long-paths setting off, so the build can't finish. A work folder or a game folder deep enough fails the same way further on: the objects are named after their sources (up to ~90 characters), and their stamps, the object cache and the link record are read and written by plain paths too. Fixes #1115. ## How to reproduce **Seen on:** reported on Windows (#1115: a portable Launcher, nightly-346-8a4aa282). Here: Windows 11 Pro (26300), RTX 4070, driver 616.56, long paths off (`LongPathsEnabled=0`, the default) **Settings and switches:** defaults **Steps:** put the Builder's tools folder 176 characters deep, as the report's `~\Downloads\QuiverLauncher-win-Portable\...\LongshotBuilder\tools\` is with an 8-letter user name, and build from it. Without the Launcher: unpack `git archive origin/main` into a folder that deep, then `python -I <that folder>\nx2\make_game.py --nup <your .nup> --out <game> --work <work>` **Expected:** the build goes through **Actual:** it stops in `version.define()` → `fingerprint()`, the report's traceback: `FileNotFoundError: [Errno 2] No such file or directory: '...\gpu\third_party\suyu\shader_recompiler\backend\glsl\emit_glsl_bitwise_conversion.cpp'`. With the work folder 180 characters deep as well, a build that gets past that stops in `compile_one` writing `...\sa\build\obj\vk_eden_shader_recompiler_backend_spirv_emit_spirv_barriers.o.sha1`. ## What changed The build's Python reaches paths past 260 characters on Windows the way Python itself allows without Windows' long-paths setting: in the extended-length form, `\\?\C:\...`. A new module does it for the standard file calls, and each script the build runs installs it as it loads, so nothing in the build has to remember it. Only a path 248 characters or more once absolute changes; for every path that worked before, the calls behave as they did. clang and the linker take long paths already. - `nx2/long_paths.py` (new): `install()` wraps open (with `os.open`, and the copies `tarfile`/`bz2` and the like kept as they loaded), `os.stat` and its kin, `os.path.exists` and its kin, the renames and links, `shutil`'s copies and `copytree`. Each wrapper changes only the path: no argument, keywords, `dir_fd` and `os.supports_*` stay as they were, and what comes back is in the caller's spelling (scandir entries, `os.walk` either way round, `shutil`'s destinations). `os.walk`, `makedirs`, `rmtree`, `tempfile`, `pathlib`, `glob`, `zipfile` and `tarfile` follow. Off Windows it does nothing. - entry scripts: `make_game.py`, `build.py`, `lift.py` (its spawned workers load it again, so they install too), `nup.py`, `unpack.py`, `split_hot.py`, `shader_census.py`, `text_assets.py`, `prompt_assets.py`, `third_party_objects.py` call `long_paths.install()` before anything reads a file. - `nx2/version.py` (`long_path()`, `walk()`, used by `fingerprint()`) and `nx2/translator_files.py` (`files()`, `stamp()`) keep long paths of their own, because `scripts/dev_packs.py`, the bake tools and the checks load them without the build. A folder skipped by the stamp's walk would change the shader stamp, and with it every player's shader caches. - `tests/test_prompt_skip.py`: the prompt step imports `long_paths` without it in the prompt key, as with `kit`; neither changes what is drawn. The check still fails for any other unfingerprinted import. - docs: `docs/development.md` (Layout) says every build script installs it, and a new one joins the per-script check; `docs/worklist.md` has a row for #1115 (S0, provisional reach 0.05, confidence 0.4), owner enum. I first fixed the tools folder site by site (10 sites). Making the work folder and the game folder deep showed about 100 more file calls across `build.py`, `make_game.py` and the scripts they start, so one module at every entry replaced the per-site edits. Two cold reviews by a separate agent went over it. The second one found short-path regressions in the first version of the module (`os.listdir()` with no argument, `open(file=...)`, `os.supports_*` membership) and calls it missed (`os.open` through `tempfile`, `copytree`'s default `copy2`, `tarfile`'s and `bz2`'s own `open`). All of those are fixed here, and each has a case in `tests/test_long_paths.py`. ## Measurements **Verdict:** passes. The new checks fail on `main` and pass here. The whole game builds and plays with the Builder, its work folder and its game folder 176-180 characters deep. For a tree that already worked, the fingerprint and the shader stamp are unchanged. Hardware: Windows 11 Pro (26300), RTX 4070 (616.56), Ryzen 9 7900X, 64 GB; llvm-mingw 23.1.5, Python 3.12.10; long paths off Scene: Kokiri Forest, the repository's `kokiri-start` save, headless (`longshot_ctl.py launch --profile test`) Method: the checks; `nx2/make_game.py` run from `git archive` of each commit, unpacked 176 characters deep, with `--work` and `--out` beside it (180), through `scripts/job_queue.py --mode build`; then the game folder started with the control bridge, pressed into play, two screenshots, a stick walk, a stop How to reproduce: the commands under How to reproduce, with this PR's commit in place of `origin/main` | | Before: main @ 71b1edd8 | After: this PR @ 48432422 | |---|---|---| | `nx2/test_version_long_paths.py` | 4 of 4 cases fail | pass | | `tests/test_build_long_paths.py` | 20 of 21 cases fail | pass | | `tests/test_long_paths.py` | (the module is new) | pass | | Game build, tools 176 / work 180 / game 180 characters deep | stops: `FileNotFoundError` in `fingerprint()`; past it, in `compile_one` | 0:06:30, 0 failed, both modules linked in the deep work folder | | That game folder, played | (no game folder) | Kokiri Forest at ~60 fps after 9 presses, walked, a clean stop; no error in the log | | Fingerprint / shader stamp of a normal checkout | the same as this PR | ea37367d / 2b1aa955fa54ed89, as main's code gives on the same tree | | `run_all.py` (Windows) | 28 failed | 611 passed, 26 failed, 43 skipped: all 26 also fail on main | ``` == main, builder 176 characters deep File "...\nx2\version.py", line 55, in fingerprint with open(p, "rb") as src: FileNotFoundError: [Errno 2] No such file or directory: '...\gpu\third_party\suyu\shader_recompiler\backend\glsl\emit_glsl_bitwise_conversion.cpp' == tools fixed, work folder 180 characters deep File "...\nx2\build.py", line 1483, in compile_one open(stamp, "w").write(key) FileNotFoundError: [Errno 2] No such file or directory: '...-work\\sa\\build\\obj\\vk_eden_shader_recompiler_backend_spirv_emit_spirv_barriers.o.sha1' == this PR, all three deep version: unknown (source ea37367d) compiled in 243s, 0 failed the build took 0:06:30, compiled in 0:04:24 state after pressing through: play (after 9 presses) frame 2383 fps 60.5 state play draws 625 window 1920x1080 map KokiriForest_Child (child) unknown (source ea37367d) stopped: 0 ``` Main's two extra suite failures (`test_bug_report`, `test_hardware_report`) came from running it in a throwaway worktree; neither reads a file this PR changes. ### Flags and settings None. (`LONGSHOT_VERSION` appears only in `nx2/test_version_long_paths.py`, which clears it so the check reads the release from the tree, as `nx2/test_version.py` does.) ## Testing **Tested:** - Game-free checks on Windows 11 (above). On Linux under WSL Ubuntu (ext4, Python 3.14, g++): the new checks, the version, stamp, prompt and build fixture checks pass; the per-script check skips there (the module does nothing off Windows, and loading every script needs the build's packages). - In the game, twice, Windows 11, RTX 4070, driver 616.56: a game folder built by a Builder 176 characters deep (work and game folders short), and one built with the Builder, the work folder and the game folder 176-180 characters deep, with the first one's shader caches copied in. Both pressed through the title into Kokiri Forest at about 60 fps, walked, and stopped cleanly, with no device lost and no error in `longshot_log.txt`. - Break checks: the module made to do nothing fails every case; one entry script's install removed fails that script's case; `os.open` unwrapped fails its case; each of the first version's 10 explicit sites reverted alone failed a case. **Not tested:** the real portable Launcher, and the reporter's own PC. PCs with `LongPathsEnabled=1` in the registry: plain paths work there already, so this PR changes nothing for them. A current folder past ~258 characters (`subprocess`'s `cwd=`, `os.chdir`): Windows takes none in any form, and the build runs at most in the game folder. **Must be tested:** None ## Risks **What could break:** the build's file calls on Windows. The module patches `open` and the `os`/`shutil` calls process-wide in the build's own scripts. A path under 248 characters goes through unchanged, and the calls' conventions (no argument, keywords, `dir_fd`, `os.supports_*`) are kept and tested. Only the standard library's earlier copies of `open` are swept; code of ours keeps what it holds. Linux and macOS: nothing changes. **Turning it off:** revert the commit **Compatibility:** Nothing changes for a player whose folders worked: the same fingerprint, shader stamp and object keys, so no shader cache is dropped and nothing extra is compiled. The prompt key is unchanged. ## Issues Fixes #1115 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
A portable launcher in Downloads put the builder's tools 176 characters deep, and
145 of its sources past Windows' 260 (MAX_PATH): the build stopped at 'Compiling'
with FileNotFoundError in version.py's fingerprint(). Behind it the shader stamp,
the header blob, the object keys, the size table and a depfile's headers read the
same files by plain paths, a folder past 260 is left out of a walk without a word,
and with the work folder as deep, the objects' stamps, the object cache and the
link record fail the same way (the objects are named after their sources).

nx2/test_version_long_paths.py: the fingerprint and the shader stamp, loaded
alone as other tools load them. tests/test_build_long_paths.py: build.py's own
functions on sources and a work folder past 260, and each script the build runs
reading a file past 260 once loaded. On main, on Windows with long paths off,
4 of 4 and 20 of 21 of their cases fail.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
nx2/long_paths.py: on Windows, install() makes open (and os.open, and the copies
the standard library's modules kept of it), os.stat and its kin, os.path.exists
and its kin, the renames and links, and shutil's copies take a path that needs
it in Windows' extended-length form (\?\...), as Python itself accepts without
Windows' long-paths setting. Only a path 248 characters or more once absolute
changes; everything else about a call is as before (no argument, keywords,
dir_fd, os.supports_*), and what comes back is in the caller's spelling (scandir
entries, os.walk either way round, shutil's destinations). os.walk, makedirs,
rmtree, tempfile, pathlib, glob, zipfile and tarfile follow. Elsewhere it does
nothing. Not possible in any form: a current folder past ~258 characters
(os.chdir, subprocess's cwd=); the build runs in the game folder at most.

Each script the build runs installs it as it loads, before it reads a file:
make_game.py, build.py, lift.py (whose spawned workers load it again), nup.py,
unpack.py, split_hot.py, shader_census.py, text_assets.py, prompt_assets.py and
third_party_objects.py. nx2/version.py (fingerprint) and nx2/translator_files.py
(the shader stamp) keep long paths of their own, long_path() and walk(), as
scripts/dev_packs.py, the bake tools and the checks load them alone: on this
clone main and this change give the same fingerprint and shader stamp, so no
shader cache is dropped.

tests/test_long_paths.py checks the module. tests/test_prompt_skip.py lets the
prompt step import long_paths without it in the prompt key, as kit: neither
changes what is drawn.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
docs: the build scripts' long_paths.install() in the development guide, and #1115 in the worklist (S0, provisional reach 0.05, 0.4)
Some checks are pending
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
4843242235
Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
First-time contributor

Tested in game: Windows 11 Pro (26300), RTX 4070, NVIDIA 616.56, long paths off: built with make_game.py from this commit unpacked 176 characters deep (the report's depth), with the work folder and the game folder 180 characters deep too (0:06:30, 0 failed); played that game folder headless on the repo's kokiri-start save: through the title into Kokiri Forest at ~60 fps, a stick walk, a clean stop, no device lost or file error in longshot_log.txt. Also played a game folder built by a deep Builder with short work and game folders, the same. Main stops on the same deep Builder with this issue's FileNotFoundError in fingerprint().

Tested in game: Windows 11 Pro (26300), RTX 4070, NVIDIA 616.56, long paths off: built with make_game.py from this commit unpacked 176 characters deep (the report's depth), with the work folder and the game folder 180 characters deep too (0:06:30, 0 failed); played that game folder headless on the repo's kokiri-start save: through the title into Kokiri Forest at ~60 fps, a stick walk, a clean stop, no device lost or file error in longshot_log.txt. Also played a game folder built by a deep Builder with short work and game folders, the same. Main stops on the same deep Builder with this issue's FileNotFoundError in fingerprint().
Collaborator

Possibly related, for context:

  • PR #151 fix(setup): the setup copies the Builder from a zip unpacked deeper than MAX_PATH — Earlier merged MAX_PATH support for setup copying; this addresses the separate build-time Python path handling.
Possibly related, for context: - PR #151 fix(setup): the setup copies the Builder from a zip unpacked deeper than MAX_PATH — Earlier merged MAX_PATH support for setup copying; this addresses the separate build-time Python path handling.
enum changed title from WIP: fix(build): the build runs from, in and into folders past 260 characters to fix(build): the build runs from, in and into folders past 260 characters 2026-11-16 13:32:06 +00:00
Author
First-time contributor

Not a duplicate of #151, checked against its diff: #151 changed only the Windows setup (builder/setup/setup.c, long_path.h), so the setup can copy the Builder out of a zip unpacked deeper than MAX_PATH. This PR is the next step: the Builder once installed there, its Python build (make_game.py, build.py, lift.py and the steps they start) reading its sources and writing its work and game folders at that depth. Nothing here touches builder/setup/, and #151 touched no Python.

Prior work otherwise: none found in Longshot's open, merged and closed pull requests and issues (MAX_PATH, long path, 260 characters, extended-length, LongPathsEnabled), or in Hookshot's (MAX_PATH and LongPathsEnabled: none).

Not a duplicate of #151, checked against its diff: #151 changed only the Windows setup (`builder/setup/setup.c`, `long_path.h`), so the setup can copy the Builder out of a zip unpacked deeper than MAX_PATH. This PR is the next step: the Builder once installed there, its Python build (`make_game.py`, `build.py`, `lift.py` and the steps they start) reading its sources and writing its work and game folders at that depth. Nothing here touches `builder/setup/`, and #151 touched no Python. Prior work otherwise: none found in Longshot's open, merged and closed pull requests and issues (MAX_PATH, long path, 260 characters, extended-length, LongPathsEnabled), or in Hookshot's (MAX_PATH and LongPathsEnabled: none).
Some checks are pending
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/version-long-paths:enum-fix/version-long-paths'
git switch 'enum-fix/version-long-paths'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1132
No description provided.