Install: Windows build fails fingerprinting missing builder source file #1115
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#1115
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reported on Discord
What you used
Longshot Launcher nightly-100-5f30eea3 (portable), launcher channel nightly
Version
Build nightly-346-8a4aa282 (nightly)
Channel
Nightly
Where it stopped
Compiling, when
build.pyfingerprints the builder source tree.The error
Operating system and free space on the output drive
Microsoft Windows 10.0.26300 x64; 31 GB free. CPU: 32 threads; NVIDIA and AMD GPUs.
Settings
Memory and workers automatic; DLSS, FSR 4, and XeSS off.
Build and launcher log excerpts
The report says the source file named in the error is missing under the downloaded builder toolchain. The game files were already read and translation was copied from a prior work folder. Launcher log reports successful HTTP 200 responses for release/nightly checksums and signatures. The build failed before linking. No standalone log files were attached.
Related issue
Longshot #990 also concerns a Windows build failure, but that report has a generated-C compiler error rather than a missing builder source file; this appears to be a different failure.
Not known yet
Whether retrying or reinstalling the builder toolchain changes the result.
Claimed (enum, with an AI agent). Cause, reproduced on main
6c8d6e6aon Windows 11 with long paths off: the file path in the report is about 263 characters, past Windows' 260 (MAX_PATH).nx2/version.py'sfingerprint()walks and opens the sources by plain path, whilenx2/nup.pyandnx2/make_game.pyalready uselong_path()(\\?\) for the same reason. A 281-character file path gives the sameFileNotFoundError; a folder past 260 is skipped silently instead, so the fingerprint comes out wrong rather than as an error.Next: a game-free test that fails on main, then the fix, then a check of whether the compile of the same files needs the same.
Work-around until then: move the launcher's portable folder somewhere short (for example
C:\Games), or turn on Windows long paths.Update on the fix (enum, with an AI agent): the pull request will cover every folder the build uses being deep, not only the Builder's tools folder.
FileNotFoundErrorinfingerprint(). With the fix, the whole game builds (0:07:14, 0 failed) and plays: Kokiri Forest at 60 fps, RTX 4070, Windows 11 with long paths off. The fix covers more than the fingerprint: the shader stamp, the header hashes, the object keys and the size table read the same deep sources by plain paths, and so did the depfile check (a header past 260 characters was taken for deleted).work\sa\build\obj(compile_one, the sameFileNotFoundError). The objects are named after their source paths, up to about 90 characters, so a work folder deeper than about 170 characters fails. That is probably deeper than a portable Launcher puts it (about 126), but it is the same bug, so it goes in the same pull request.The game folder at that depth is in scope too: linking the game files into a folder 180 characters deep already works. I'll post the pull request here when it is up.
The fix is up for review: #1132
It covers the Builder's tools folder (this report), the work folder and the game folder. The build's Python now reaches paths past 260 characters on Windows in their extended-length form, through one module each build script installs as it loads; nothing changes for paths that worked before. Tested on Windows 11 with long paths off, RTX 4070: with all three folders 176-180 characters deep, the game builds (0:06:30, 0 failed) and plays in Kokiri Forest at about 60 fps; main stops on the same Builder with this issue's error.
Until it ships in a release, the work-around stands: move the Launcher's portable folder somewhere short (for example
C:\Games), or turn on Windows long paths.From Discord:
Reported on Longshot Launcher v1.0.0-rc.9 (portable), building v3.0.0-rc.5 (release candidate) on Windows 10.0.26300 x64, with 32 GB RAM, 16 threads, Intel and NVIDIA GPUs; memory/workers automatic, DLSS on. Build log shows FileNotFoundError while fingerprinting
tools\gpu\third_party\suyu\shader_recompiler\frontend\maxwell\translate\impl\floating_point_conversion_floating_point.cpp; translation was copied from a prior work folder, and build failed before linking. The error text and relevant logs are in the Discord attachment. Please also send the performance measurements requested for the unrelated stutter report only if applicable; this is an install/build failure, not a performance report.From Discord:
The reporter confirmed that moving the portable launcher folder fixed the build failure.
From Discord:
From Discord: Longshot Launcher v1.0.0-rc.9 portable, building v3.0.0-rc.5; Windows 10.0.26300 x64; compile stopped at 13% with FileNotFoundError opening
shader_recompiler\frontend\maxwell\translate\impl\floating_point_conversion_floating_point.cpp. The reporter's exact error is visible in the Discord screenshot. This is another reproduction with the missing translation source path. A prior report on this issue confirmed moving the portable launcher folder fixed it.From Discord:
The reporter asked what to move after seeing the workaround. Clarify that it is the entire portable launcher folder (the folder containing LongshotLauncher.exe), not the game files or saves. In this screenshot, the builder path is under
C:\Users\<user>\OneDrive\Desktop\Games\The Legend of Zelda Ocarina of Time Remake\LongshotLauncher-data\...; move the launcher folder to a short path such asC:\Gamesand launch it from there, then retry the build.