fix(build): the iGPU texture budget's caps build on Linux #2634
No reviewers
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot!2634
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/texture-budget-linux-build"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
maindoes not build on Linux since #2603: the renderer stops atgpu/vk/vk_texture.cpp(the iGPU texture budget's caps).Cause
On Linux,
uint64_tisunsigned long, while1536ull << 20isunsigned long long. Sostd::min(budget, 1536ull << 20)has two different argument types and does not compile. On Windows (llvm-mingw)uint64_tisunsigned long long, which is why Windows builds.Fix
The seven
std::min/std::maxcalls name the type:std::min<uint64_t>(budget, 1536ull << 20). Nothing else changes: the values and the logic are the same.Tested
hookshot-build --vk-onlyon Linux:hookshot_vk.sobuilds and the ABI check passes. Before this change it failed on these lines.github-sync referenced this pull request2026-11-12 06:22:54 +00:00