chore(main): release 2.2.0-rc.1 #2071

Open
github-actions[bot] wants to merge 1 commit from release-please--branches--main into main
github-actions[bot] commented 2026-11-11 01:46:15 +00:00 (Migrated from github.com)

This release is too large to preview in the pull request body. View the full release notes here: https://git.magicbean.dev/MagicBeanDev/Hookshot/src/branch/release-please--branches--main--release-notes/release-notes.md

This release is too large to preview in the pull request body. View the full release notes here: https://git.magicbean.dev/MagicBeanDev/Hookshot/src/branch/release-please--branches--main--release-notes/release-notes.md
hckrman101 (Migrated from github.com) requested changes 2026-11-11 02:16:10 +00:00
hckrman101 (Migrated from github.com) left a comment

DO NOT MERGE UNTIL 2026-11-11 morning~

DO NOT MERGE UNTIL 2026-11-11 morning~
hckrman101 (Migrated from github.com) reviewed 2026-11-11 22:21:41 +00:00
hckrman101 (Migrated from github.com) left a comment

Re-review at f2aef72 (the head moved on from the 284298e this was queued at). My earlier note was the hold until the morning of 2026-11-11; v2.1.0 was published today, so that hold is over. Cutting the release is NotRexed's call, so this is a comment, not an approval.

Checked:

  • Version: 2.1.0 -> 2.2.0-rc.1 is right for this range. There are 28 feat commits and no ! or BREAKING CHANGE, and docs/versioning.md says a feat after a release proposes the next minor at rc.1. The manifest is a one-line change and matches the compare link v2.1.0...v2.2.0-rc.1.
  • Changelog: all 159 commit links point at commits in v2.1.0..main; nothing already shipped in 2.1.0 is repeated (the stale last-release-sha in the config did not leak anything). Sections and counts match the commit types (28 feat, 87 fix, 15 perf, 9 build, 5 ci, 5 docs, 13 test, 2 chore). The non-conventional commits (readme and Discord link edits, the #1947 fix) are left out, as expected.

Open, none blocking:

  • The PR was generated from 9b7fa52, and main has moved since. Four newer commits are not in this changelog yet: #2119 (feat, the Aspect ratio row), #2513, #2524 (fixes) and #2518 (build). If the PR is merged as it is, the tag lands on a main that contains them but the notes omit them. Let the bot refresh it first (or merge only after it has), then re-check.
  • Nit: docs/versioning.md says the release PR also writes .release-please-version, but the PR touches only the manifest and CHANGELOG, and the file does not exist on main. Harmless for this release, but either the doc or the config is off.
  • No checks are reported on the release branch (normal for a PR pushed by the Actions token), so the usual CI has not run on this exact commit. It only changes the manifest and the changelog.
Re-review at f2aef72 (the head moved on from the 284298e this was queued at). My earlier note was the hold until the morning of 2026-11-11; v2.1.0 was published today, so that hold is over. Cutting the release is NotRexed's call, so this is a comment, not an approval. Checked: - **Version**: 2.1.0 -> 2.2.0-rc.1 is right for this range. There are 28 `feat` commits and no `!` or `BREAKING CHANGE`, and docs/versioning.md says a `feat` after a release proposes the next minor at `rc.1`. The manifest is a one-line change and matches the compare link `v2.1.0...v2.2.0-rc.1`. - **Changelog**: all 159 commit links point at commits in `v2.1.0..main`; nothing already shipped in 2.1.0 is repeated (the stale `last-release-sha` in the config did not leak anything). Sections and counts match the commit types (28 feat, 87 fix, 15 perf, 9 build, 5 ci, 5 docs, 13 test, 2 chore). The non-conventional commits (readme and Discord link edits, the #1947 fix) are left out, as expected. Open, none blocking: - The PR was generated from 9b7fa52, and main has moved since. Four newer commits are not in this changelog yet: #2119 (feat, the Aspect ratio row), #2513, #2524 (fixes) and #2518 (build). If the PR is merged as it is, the tag lands on a main that contains them but the notes omit them. Let the bot refresh it first (or merge only after it has), then re-check. - Nit: docs/versioning.md says the release PR also writes `.release-please-version`, but the PR touches only the manifest and CHANGELOG, and the file does not exist on main. Harmless for this release, but either the doc or the config is off. - No checks are reported on the release branch (normal for a PR pushed by the Actions token), so the usual CI has not run on this exact commit. It only changes the manifest and the changelog.
hckrman101 (Migrated from github.com) reviewed 2026-11-11 22:41:06 +00:00
hckrman101 (Migrated from github.com) left a comment

Re-checked at 7ae362e. The four entries I flagged earlier (#2119, #2513, #2524, #2518) are now in the notes, and the changelog has no duplicate commits. Every feat/fix/perf commit on main up to this push is covered. The version (2.2.0-rc.1) and the manifest (.: 2.2.0-rc.1) agree, and those are the only two files touched.

One thing to know: #2325 and #2407 merged to main after this push, so they are not in the notes yet. The bot should add them on its next refresh, so check for them before cutting the release.

Whether and when to release stays with @NotRexed.

Re-checked at 7ae362e. The four entries I flagged earlier (#2119, #2513, #2524, #2518) are now in the notes, and the changelog has no duplicate commits. Every feat/fix/perf commit on main up to this push is covered. The version (2.2.0-rc.1) and the manifest (`.`: 2.2.0-rc.1) agree, and those are the only two files touched. One thing to know: #2325 and #2407 merged to main after this push, so they are not in the notes yet. The bot should add them on its next refresh, so check for them before cutting the release. Whether and when to release stays with @NotRexed.
github-sync force-pushed release-please--branches--main from 88a8af1d9c to e6541fdd12 2026-11-12 06:19:03 +00:00 Compare
github-sync force-pushed release-please--branches--main from e6541fdd12 to 50fefbfd42 2026-11-12 08:30:50 +00:00 Compare
github-sync force-pushed release-please--branches--main from 50fefbfd42 to 7bc5ddc016 2026-11-12 09:31:54 +00:00 Compare
github-sync force-pushed release-please--branches--main from 7bc5ddc016 to 158d758c05 2026-11-12 10:34:12 +00:00 Compare
github-sync force-pushed release-please--branches--main from 158d758c05 to 188b78b3b7 2026-11-12 11:35:41 +00:00 Compare
Owner

@Joey-Magnus reviewed on GitHub · 2026-11-12 14:32 UTC · original

I re-checked this against the current head (188b78b3), generated from main at 51da0464, which is current main. The manifest and the compare link agree on 2.2.0-rc.1. That is the right version under docs/versioning.md, since there are feat commits since v2.1.0 and none marked breaking. Only the manifest and CHANGELOG.md change.

I matched every conventional commit in v2.1.0..origin/main against the notes. The new section has 252 commit links and no duplicates. Two commits are missing:

  • 75fa99f9 test: the fixtures that crash on purpose leave no core dump on Linux (#2293)
  • 2285bff2 test: the recorder exit check catches the old destructor on llvm-mingw too (#2240)

Both are test-only, so the notes lose nothing a player needs, but it's worth knowing in case the bot skips them again. Main is also moving fast today, so check the notes again after the bot's next refresh before cutting the release. Whether and when to release is NotRexed's call.

> [@Joey-Magnus](https://github.com/Joey-Magnus) reviewed on GitHub · 2026-11-12 14:32 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2071#pullrequestreview-5876205641) I re-checked this against the current head (188b78b3), generated from main at 51da0464, which is current main. The manifest and the compare link agree on 2.2.0-rc.1. That is the right version under docs/versioning.md, since there are feat commits since v2.1.0 and none marked breaking. Only the manifest and CHANGELOG.md change. I matched every conventional commit in `v2.1.0..origin/main` against the notes. The new section has 252 commit links and no duplicates. Two commits are missing: - `75fa99f9` test: the fixtures that crash on purpose leave no core dump on Linux (#2293) - `2285bff2` test: the recorder exit check catches the old destructor on llvm-mingw too (#2240) Both are test-only, so the notes lose nothing a player needs, but it's worth knowing in case the bot skips them again. Main is also moving fast today, so check the notes again after the bot's next refresh before cutting the release. Whether and when to release is NotRexed's call. <!-- github-sync:r:5876205641 -->
github-sync force-pushed release-please--branches--main from 188b78b3b7 to 3df259213d 2026-11-12 16:54:35 +00:00 Compare
github-sync force-pushed release-please--branches--main from 3df259213d to cb9e1fefdc 2026-11-12 17:57:54 +00:00 Compare
github-sync force-pushed release-please--branches--main from cb9e1fefdc to 69bd46817e 2026-11-12 19:01:06 +00:00 Compare
Commenting is not possible because the repository is archived.
No description provided.