refactor(builder): name the DLSS license flag apart from the dialog text, and finish its comment #2565

Open

LNDF wants to merge 1 commit from LNDF/windows-dlss-license-nits into main

LNDF commented

2026-11-11 23:28:32 +00:00

(Migrated from github.com)

The two nits from the review of #2528, which merged before I could address them.

The field dlssLicense sat beside the existing DlssLicense constant (the license dialog's text) in MainWindow.xaml.cs. It is dlssLicenseAccepted now.
Its comment read as cut off ("…and its runtime went"). It now says in full that the update built the folder without DLSS and removed its DLSS runtime.

No change in behaviour. The UpdateBuild fixture (tests/builder_dlss_update_test.cs, run on .NET 10 here) still passes its 63 checks; python -I -B tests/run_all.py on Linux: nothing new fails.

🤖 Generated with Claude Code

The two nits from the review of #2528, which merged before I could address them. - The field `dlssLicense` sat beside the existing `DlssLicense` constant (the license dialog's text) in `MainWindow.xaml.cs`. It is `dlssLicenseAccepted` now. - Its comment read as cut off ("…and its runtime went"). It now says in full that the update built the folder without DLSS and removed its DLSS runtime. No change in behaviour. The `UpdateBuild` fixture (`tests/builder_dlss_update_test.cs`, run on .NET 10 here) still passes its 63 checks; `python -I -B tests/run_all.py` on Linux: nothing new fails. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

github-sync referenced this pull request

2026-11-12 14:42:56 +00:00

fix: readme's work/ffx-sdk, and the build log names an FSR 4 tick without AMD's license #2553

github-sync commented

2026-11-12 14:43:02 +00:00

Owner

@Joey-Magnus approved on GitHub · 2026-11-12 14:33 UTC · original

I merged this into current main. Nothing else in builder/ or tests/ refers to dlssLicense by name: I grepped main and the open #2591 branch, so the rename breaks no source-reading check. tests/test_ffx_sdk.py passes. The .NET fixture (tests/builder_dlss_update_test.cs) needs the SDK, which I don't have here, so for that I'm relying on your run and the Builder package job, which is green. I also merged it on top of #2591 and #2553 and it applies cleanly with both, so the three can land in any order.

The red Python shards fail only test_env_on (HOS_FPS_LOG in host/oot_high_fps.c, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them come from this change, and a re-run should clear them.

> [@Joey-Magnus](https://github.com/Joey-Magnus) approved on GitHub · 2026-11-12 14:33 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2565#pullrequestreview-5876216233) I merged this into current main. Nothing else in builder/ or tests/ refers to `dlssLicense` by name: I grepped main and the open #2591 branch, so the rename breaks no source-reading check. tests/test_ffx_sdk.py passes. The .NET fixture (tests/builder_dlss_update_test.cs) needs the SDK, which I don't have here, so for that I'm relying on your run and the Builder package job, which is green. I also merged it on top of #2591 and #2553 and it applies cleanly with both, so the three can land in any order. The red Python shards fail only test_env_on (HOS_FPS_LOG in host/oot_high_fps.c, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them come from this change, and a re-run should clear them.

github-sync referenced this pull request

2026-11-12 14:43:12 +00:00

feat(builder): an up-to-date game without a ticked DLSS or FSR 4 offers Update, not Play #2591

Commenting is not possible because the repository is archived.

No reviewers