fix: readme's work/ffx-sdk, and the build log names an FSR 4 tick without AMD's license #2553

Open

roblesleo wants to merge 1 commit from roblesleo/fix/fsr4-followup into main

roblesleo commented

2026-11-11 23:07:01 +00:00

(Migrated from github.com)

Follow-up to #1866's review.

readme: the default HOOKSHOT_FFX_SDK folder read work<0x0C>fx-sdk (a \f had turned into a form feed). It reads work/ffx-sdk now.
Windows Builder: an AMD FSR 4 tick saved before the builder asked for AMD's license still builds with FSR 4 and fetches nothing, as before. The build log now says so in one line: "AMD's license not accepted yet: tick AMD FSR 4 again to have its runtime fetched". tests/test_ffx_sdk.py's source check covers the line.

Ran locally on Windows: test_ffx_sdk, test_make_game_ngx, test_builder_dlss_update and dotnet build of the Builder, all passing.

🤖 Generated with Claude Code

Follow-up to #1866's review. - **readme:** the default `HOOKSHOT_FFX_SDK` folder read `work<0x0C>fx-sdk` (a `\f` had turned into a form feed). It reads `work/ffx-sdk` now. - **Windows Builder:** an AMD FSR 4 tick saved before the builder asked for AMD's license still builds with FSR 4 and fetches nothing, as before. The build log now says so in one line: "AMD's license not accepted yet: tick AMD FSR 4 again to have its runtime fetched". `tests/test_ffx_sdk.py`'s source check covers the line. Ran locally on Windows: `test_ffx_sdk`, `test_make_game_ngx`, `test_builder_dlss_update` and `dotnet build` of the Builder, all passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

github-sync commented

2026-11-12 14:42:56 +00:00

Owner

@Joey-Magnus approved on GitHub · 2026-11-12 14:33 UTC · original

I merged this into current main. tests/test_ffx_sdk.py and test_make_game_ngx.py pass, and tests/test_env_on.py passes too. I checked that main's readme still has the form feed: line 839 reads work^Lfx-sdk in cat -A, so the readme fix is still needed.

The new log line at MainWindow.xaml.cs:1012 fires only in Run when the tick is on, fsr is false and the license wasn't accepted. That is exactly the legacy-tick case, where StartBuild passes --fsr without the fetch. With #2591 on top, UpdateBuild also passes --fsr for a saved tick without the license, and the message still fits that path. It merges cleanly with #2591 and #2565 in either order.

The red jobs are test_env_on (HOS_FPS_LOG, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them touch the Builder, so a re-run should turn them green.

> [@Joey-Magnus](https://github.com/Joey-Magnus) approved on GitHub · 2026-11-12 14:33 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2553#pullrequestreview-5876215359) I merged this into current main. tests/test_ffx_sdk.py and test_make_game_ngx.py pass, and tests/test_env_on.py passes too. I checked that main's readme still has the form feed: line 839 reads `work^Lfx-sdk` in `cat -A`, so the readme fix is still needed. The new log line at MainWindow.xaml.cs:1012 fires only in `Run` when the tick is on, `fsr` is false and the license wasn't accepted. That is exactly the legacy-tick case, where `StartBuild` passes `--fsr` without the fetch. With #2591 on top, `UpdateBuild` also passes `--fsr` for a saved tick without the license, and the message still fits that path. It merges cleanly with #2591 and #2565 in either order. The red jobs are test_env_on (HOS_FPS_LOG, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them touch the Builder, so a re-run should turn them green.

github-sync referenced this pull request

2026-11-12 14:43:02 +00:00

refactor(builder): name the DLSS license flag apart from the dialog text, and finish its comment #2565

github-sync referenced this pull request

2026-11-12 14:43:12 +00:00

feat(builder): an up-to-date game without a ticked DLSS or FSR 4 offers Update, not Play #2591

Commenting is not possible because the repository is archived.

No reviewers