test: the finish checks give the build its arguments, read since #1866 #2102

Closed
jarynclouatre wants to merge 1 commit from test/finish-checks-build-args into main
jarynclouatre commented 2026-11-11 02:45:01 +00:00 (Migrated from github.com)

Main's checks are red on every OS since #1866. The end of make_game.py's build now reads the build's arguments (fsr_wanted(a, out)) to decide whether AMD's FSR 4 runtime goes beside the game. The two checks that run that part of the real build, tests/test_finish_output.py and tests/test_linux_update.py, have no a to give it: NameError: name 'a' is not defined, in five cases of the first and one of the second.

Both now pass the arguments of a build without AMD FSR 4, so the same lines run as before and the new one takes its "not asked for" branch. #2092 does not touch these two files.

Testing (Linux): both tests fail on f915af9 with the NameError and pass with this change.

Main's checks are red on every OS since #1866. The end of `make_game.py`'s build now reads the build's arguments (`fsr_wanted(a, out)`) to decide whether AMD's FSR 4 runtime goes beside the game. The two checks that run that part of the real build, `tests/test_finish_output.py` and `tests/test_linux_update.py`, have no `a` to give it: `NameError: name 'a' is not defined`, in five cases of the first and one of the second. Both now pass the arguments of a build without AMD FSR 4, so the same lines run as before and the new one takes its "not asked for" branch. #2092 does not touch these two files. **Testing (Linux):** both tests fail on f915af9 with the NameError and pass with this change.
hckrman101 commented 2026-11-11 15:50:55 +00:00 (Migrated from github.com)

Heads-up: this conflicts with main now. Could you rebase onto main and resolve the conflicts? Thanks!

Heads-up: this conflicts with main now. Could you rebase onto main and resolve the conflicts? Thanks!
jarynclouatre commented 2026-11-11 16:19:49 +00:00 (Migrated from github.com)

Main already made the same fix in #2109 (7d24a73), so this one isn't needed anymore. Closing.

Main already made the same fix in #2109 (7d24a73), so this one isn't needed anymore. Closing.
Commenting is not possible because the repository is archived.
No description provided.