test: main's red checks after #1866 and #2041 (finish-block 'a'; vsync fixture getenv deprecation) #2109

Merged

NotRexed merged 2 commits from test/finish-stub-a into main

2026-11-11 03:32:43 +00:00

NotRexed commented

2026-11-11 03:09:12 +00:00

(Migrated from github.com)

Main is red again. #1866 added this to the finish block of make_game.main():

if fsr_wanted(a, out) and getattr(a, "fetch_fsr_runtime", False):

tests/test_finish_output.py and tests/test_linux_update.py (test_a_packaged_build_puts_the_launcher_in_the_folder_and_the_game_in_bin) run that block on its own, without a, so both fail with NameError: name 'a' is not defined.

Both tests now pass an argument namespace with FSR off (fsr=False, no_fsr=False, update=None, fetch_fsr_runtime=False). The production code is unchanged.

Checked locally: test_finish_output passes. The test_linux_update case only runs on Linux; CI covers it. Locally on Windows that file has unrelated symlink failures that are the same before and after this change.

This unblocks #1999 and the other open PRs.

🤖 Generated with Claude Code

Main is red again. [#1866](https://git.magicbean.dev/MagicBeanDev/Hookshot/pulls/1866) added this to the finish block of `make_game.main()`: ```python if fsr_wanted(a, out) and getattr(a, "fetch_fsr_runtime", False): ``` `tests/test_finish_output.py` and `tests/test_linux_update.py` (`test_a_packaged_build_puts_the_launcher_in_the_folder_and_the_game_in_bin`) run that block on its own, without `a`, so both fail with `NameError: name 'a' is not defined`. Both tests now pass an argument namespace with FSR off (`fsr=False, no_fsr=False, update=None, fetch_fsr_runtime=False`). The production code is unchanged. Checked locally: test_finish_output passes. The test_linux_update case only runs on Linux; CI covers it. Locally on Windows that file has unrelated symlink failures that are the same before and after this change. This unblocks #1999 and the other open PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

NotRexed commented

2026-11-11 03:16:23 +00:00

(Migrated from github.com)

Also: tests/test_vsync_row.py (from #2041) failed on Windows because its fixture uses getenv under -Werror. It now passes -D_CRT_SECURE_NO_WARNINGS, as the other fixture tests do.

Also: `tests/test_vsync_row.py` (from #2041) failed on Windows because its fixture uses `getenv` under `-Werror`. It now passes `-D_CRT_SECURE_NO_WARNINGS`, as the other fixture tests do.