test: restore renderer regressions after main changes #1498

Merged

Arkex-ai merged 3 commits from test/renderer-regression-fixtures into main

2026-11-10 05:47:59 +00:00

Arkex-ai commented

2026-11-10 05:13:49 +00:00

(Migrated from github.com)

Keep the BC attachment-before-storage fallback check across the allocation-hint refactor, and include <algorithm> directly for FSR math.
Supply the new inert Discord startup dependency and per-thread pass-end state in the existing recording fixtures; verify stale state resets at recording boundaries.
Extend presentation fixtures for HDR conversion success, failure and native-PQ bypass, plus failed HDR-toggle swapchain recreation and retry.

Only seven test files change; no production behavior, dependencies, game assets or generated output change.

Validation at 00ebb7f on main 8240446: all seven affected tests pass with Windows LLVM and Linux GCC. The original a34542a fixtures fail in all seven negative controls. Four production mutations (BC fallback order, recording reset, HDR output width, HDR-toggle recreation) are detected by assertion failures; sources were restored afterward. The full Windows strict suite reports 214 passed / 3 failed / 22 skipped. The three remaining local limitations are NUP symlink privileges, the legacy FPS fixture's missing initializer_list include, and native Windows SDK precompilation; this does not claim a green full suite. Linux Clang is unavailable on the test host. Exact-head fork workflows follow.

The duplicate formatter currently blocking the standalone backend build is repaired separately in #1496; this test-maintenance PR does not include that production fix. No game run is claimed for this fixtures-only change.

Current head 1ad4179 is based on main b2e1c5a, including merged #1496. Two additional CI portability repairs are included:

The Linux font fixture preserves fc-match argument/call boundaries when its format argument contains a newline. Glyph rasterization and every call's lang=en requirement remain checked. Linux GCC passes, and removing the production language restriction still fails.
Pin Linux source-check glslang to the official16.6.0 release used for the checked-in shaders, with a fixed SHA256 verified before extraction. Ubuntu's15.1 compiler lowers the unchanged actor fragment's discard differently;16.6 reproduces its checked-in SPIR-V exactly. The other three DLSS headers match both15.1 and16.6. Existing binary comparisons are retained, with no shader or generated-header edits. All six glslang-using checks pass with16.6 (DLSS actors, scale/sharpen, FSR math/shaders, HDR and TAAU/FXAA).

The earlier full-suite214/3/22 result belongs to00ebb7f; the two portability repairs have separate Linux causal checks and exact-head workflows are redispatched. Eight fixture files plus one workflow change; production sources remain unchanged.

Current-head validation

Current head 1ad4179, based on main b2e1c5a. Earlier local/runtime results describe their recorded source hashes.

Linux AppImage: in_progress.
Windows builder: success.
Game-free source regressions: in_progress.

Fork runs are separate from upstream Actions approval; no maintainer approval gate is bypassed.

Recent target-pool, HDR and host-startup changes left several source-slicing regression fixtures unable to compile or reach their assertions. Restore those fixtures so CI can exercise the current renderer again, retaining their original behavior checks. - Keep the BC attachment-before-storage fallback check across the allocation-hint refactor, and include `<algorithm>` directly for FSR math. - Supply the new inert Discord startup dependency and per-thread pass-end state in the existing recording fixtures; verify stale state resets at recording boundaries. - Extend presentation fixtures for HDR conversion success, failure and native-PQ bypass, plus failed HDR-toggle swapchain recreation and retry. Only seven test files change; no production behavior, dependencies, game assets or generated output change. Validation at `00ebb7f` on main `8240446`: all seven affected tests pass with Windows LLVM and Linux GCC. The original a34542a fixtures fail in all seven negative controls. Four production mutations (BC fallback order, recording reset, HDR output width, HDR-toggle recreation) are detected by assertion failures; sources were restored afterward. The full Windows strict suite reports **214 passed / 3 failed / 22 skipped**. The three remaining local limitations are NUP symlink privileges, the legacy FPS fixture's missing initializer_list include, and native Windows SDK precompilation; this does not claim a green full suite. Linux Clang is unavailable on the test host. Exact-head fork workflows follow. The duplicate formatter currently blocking the standalone backend build is repaired separately in #1496; this test-maintenance PR does not include that production fix. No game run is claimed for this fixtures-only change.  Current head `1ad4179` is based on main `b2e1c5a`, including merged #1496. Two additional CI portability repairs are included: - The Linux font fixture preserves fc-match argument/call boundaries when its format argument contains a newline. Glyph rasterization and every call's lang=en requirement remain checked. Linux GCC passes, and removing the production language restriction still fails. - Pin Linux source-check glslang to the official16.6.0 release used for the checked-in shaders, with a fixed SHA256 verified before extraction. Ubuntu's15.1 compiler lowers the unchanged actor fragment's discard differently;16.6 reproduces its checked-in SPIR-V exactly. The other three DLSS headers match both15.1 and16.6. Existing binary comparisons are retained, with no shader or generated-header edits. All six glslang-using checks pass with16.6 (DLSS actors, scale/sharpen, FSR math/shaders, HDR and TAAU/FXAA). The earlier full-suite214/3/22 result belongs to00ebb7f; the two portability repairs have separate Linux causal checks and exact-head workflows are redispatched. Eight fixture files plus one workflow change; production sources remain unchanged.  ### Current-head validation Current head `1ad4179`, based on main `b2e1c5a`. Earlier local/runtime results describe their recorded source hashes. - [Linux AppImage](https://github.com/Arkex-ai/Hookshot/actions/runs/42762480230): in_progress. - [Windows builder](https://github.com/Arkex-ai/Hookshot/actions/runs/42762476550): success. - [Game-free source regressions](https://github.com/Arkex-ai/Hookshot/actions/runs/42762472980): in_progress. Fork runs are separate from upstream Actions approval; no maintainer approval gate is bypassed.

Commenting is not possible because the repository is archived.

No reviewers