fix(vk): remove duplicate motion deadzone formatter #1496

Merged

Arkex-ai merged 1 commit from fix/motion-deadzone-redefinition into main

2026-11-10 05:16:59 +00:00

Arkex-ai commented

2026-11-10 05:06:40 +00:00

(Migrated from github.com)

Current main does not compile because vk_menu.cpp defines tx_deadzone(int) twice after the recent menu merges. Both definitions are identical; remove the second copy while keeping the original formatter and Motion row binding.

The labels and clamping are unchanged. This is a build repair with no visible game change.

Validation: the official standalone Vulkan backend build (RX_VK_ONLY=1, llvm-mingw, pinned Vulkan/SPIR-V headers) now compiles and links with zero failures at d36ae74 on8240446; before the repair the compiler reports the duplicate definitions. Existing test_motion.py and test_menu_hit.py pass. Exact-head fork workflows follow. No game data or build output included.

Current-head validation

Current head d36ae74, based on main 8240446. Earlier local/runtime results describe their recorded source hashes.

Linux AppImage: in_progress.
Windows builder: success.
Game-free source regressions: failure.

Fork runs are separate from upstream Actions approval; no maintainer approval gate is bypassed.

Current main does not compile because `vk_menu.cpp` defines `tx_deadzone(int)` twice after the recent menu merges. Both definitions are identical; remove the second copy while keeping the original formatter and Motion row binding. The labels and clamping are unchanged. This is a build repair with no visible game change. Validation: the official standalone Vulkan backend build (`RX_VK_ONLY=1`, llvm-mingw, pinned Vulkan/SPIR-V headers) now compiles and links with zero failures at d36ae74 on8240446; before the repair the compiler reports the duplicate definitions. Existing `test_motion.py` and `test_menu_hit.py` pass. Exact-head fork workflows follow. No game data or build output included.  ### Current-head validation Current head `d36ae74`, based on main `8240446`. Earlier local/runtime results describe their recorded source hashes. - [Linux AppImage](https://github.com/Arkex-ai/Hookshot/actions/runs/42760042173): in_progress. - [Windows builder](https://github.com/Arkex-ai/Hookshot/actions/runs/42760039375): success. - [Game-free source regressions](https://github.com/Arkex-ai/Hookshot/actions/runs/42760036939): failure. Fork runs are separate from upstream Actions approval; no maintainer approval gate is bypassed.

Commenting is not possible because the repository is archived.

No reviewers