Test AppImage source header dependency closure #1010

Merged

monsterlag merged 2 commits from fix/appimage-oot-cheat-header into main

2026-11-09 15:15:28 +00:00

monsterlag commented

2026-11-09 05:47:36 +00:00

(Migrated from github.com)

PR #1012 by Solar-Ibex fixed the
missing oot_cheat_items.h packaging behind #990. This PR now adds only regression
coverage and an explicit Windows skip for the POSIX packaging check. The
production packaging script is identical to current main.

The game-free check executes the actual AppImage source-copy block, then follows
repository-local quoted includes transitively. An authored missing-header/include
cycle case verifies both detection and the complete closure. The regression is
unchanged from the earlier PR head.

After normally merging main 3b4347d3, both cases pass through
tests/run_all.py --strict appimage_source_headers; bash -n and
git diff --check also pass. The original b2765ba6 packaging failure on the
missing shared header remains historical negative evidence, not a new test of
current main.

No full AppImage/game build or native compilation was run. This covers literal
repository-local includes, not system, macro-generated or include-search-path
dependencies. No game or generated build data is involved. Refs #990.

Hosted checks on f2760a1b: Linux AppImage, Linux source regressions, Windows source regressions, Windows renderer, Builder package, SPIR-V checks and workflow lint all pass. Release publication was intentionally skipped for this pull request.

[PR #1012](https://git.magicbean.dev/MagicBeanDev/Hookshot/pulls/1012) by Solar-Ibex fixed the missing `oot_cheat_items.h` packaging behind #990. This PR now adds only regression coverage and an explicit Windows skip for the POSIX packaging check. The production packaging script is identical to current main. The game-free check executes the actual AppImage source-copy block, then follows repository-local quoted includes transitively. An authored missing-header/include cycle case verifies both detection and the complete closure. The regression is unchanged from the earlier PR head. After normally merging main `3b4347d3`, both cases pass through `tests/run_all.py --strict appimage_source_headers`; `bash -n` and `git diff --check` also pass. The original `b2765ba6` packaging failure on the missing shared header remains historical negative evidence, not a new test of current main. No full AppImage/game build or native compilation was run. This covers literal repository-local includes, not system, macro-generated or include-search-path dependencies. No game or generated build data is involved. Refs #990. Hosted checks on `f2760a1b`: [Linux AppImage](https://github.com/NotRexed/Hookshot/actions/runs/42579893399/job/129035871835), [Linux source regressions](https://github.com/NotRexed/Hookshot/actions/runs/42579893428/job/129035872111), [Windows source regressions](https://github.com/NotRexed/Hookshot/actions/runs/42579893428/job/129035871792), [Windows renderer](https://github.com/NotRexed/Hookshot/actions/runs/42579893429/job/129035872297), Builder package, SPIR-V checks and workflow lint all pass. Release publication was intentionally skipped for this pull request.

Commenting is not possible because the repository is archived.

No reviewers