Compilation step error stops build #990
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#990
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Builder version
v2.0.6
How you built
Linux AppImage
Game files given to it
A .nup
The error
Visual Studio or Build Tools version, and Windows SDK version
No response
Operating system and free space on the output drive
CachyOS Linux 2TB Free Space
Before you send it
I added the file at local/share/hookshot/builder/versions/v2.0.6/usr/share/hookshot/gpu/vk/ by downloading it from the repo at https://git.magicbean.dev/MagicBeanDev/Hookshot/src/branch/main/gpu/vk/oot_cheat_items.h and the compilation finished. if it can help in the mean time
Same here on CachyOS (RTX 4070 Ti).
Cause: v2.0.6 added
#include "../gpu/vk/oot_cheat_items.h"tohost/hos_main.c, butscripts/linux/appimage.shonly copiesgpu/vk/vk_api.hinto the AppImage (line 50), so the new header isn’t packaged.Fix: add this line after line 50 of
scripts/linux/appimage.sh:Workaround until a new AppImage is out (tested, the build finishes):
then run the build again.
I tried the workaround and it's not working for me. Guess I'll wait.
Workaround isn't working for me either. Tried updating from 2.0.5 appimage, downloading 2.0.6 appimage from latest and updating my build from that, and rebuilding the game entirely using 2.0.6, all give me the same 'oot_cheat_items.h' file not found error, even after using @Solar-Ibex's workaround, and even after transplanting the file into /gpu/vk myself using the file explorer
Same here on CachyOS : (14700k/4080)
NUP file
The release candidate doesn't allow the build to work because it wants to download 2.0.6 apparently before it will run. And so it just generates the same error after you click "update builder".
Might be worth offering the option to build without updating in future.
Update: why the workaround above fails, and what actually fixes it
The packaging bug is only half the story. The builder assembles
~/.local/share/hookshot/builder/versions/<tag>from thehookshot-linux.txtmanifest of the latest release, andreleases/lateststill points to v2.0.6 — itsusr/share/hookshotpart isHookshotLinux-usr-share-hookshot-eecf57f64738.zip, which containsgpu/vk/vk_api.hbut lacksgpu/vk/oot_cheat_items.h. So v2.0.7-rc.1 ships the same broken zip and fixes nothing.Worse: when running an rc build,
hookshot_builder.py(begin_update()) compares the running AppImage's VERSION (v2.0.7-rc.1) against the manifest tag (v2.0.6), and on mismatch it reinstallsversions/v2.0.6from the zip every time the AppImage starts — which wipes any manually added header before the build runs. That is why the curl workaround above appears "not working": the next launch deletes it again.Workaround A (only requires re-running the build in the already-open builder window — no relaunch, so no wipe):
Workaround B (survives AppImage relaunches): use the builder's own
HOOKSHOT_LINUX_LISToverride with a locally patched zip:(Verified: the builder's own
linux_update.install()unpacks the patched zip into a complete tree with the header included.)The real fix: add
cp -a gpu/vk/oot_cheat_items.h "$T/gpu/vk/"toscripts/linux/appimage.shand regenerate the linux-parts zip +hookshot-linux.txton the latest release — every build that re-downloads the broken part keeps failing until that zip is rebuilt.