MagicBeanDev/Hookshot
Archived
Watch
2
0
Fork
You've already forked Hookshot
 0
Code Issues 125 Pull requests 205 Activity

docs(readme): the option table has the Skip opening row, so main's readme check passes #2857

Closed
github-sync wants to merge 1 commit from github/pr/2857 into main
pull from: github/pr/2857
merge into: MagicBeanDev:main
Conversation 4 Commits 1 Files changed 1 +1
github-sync commented 2026-11-12 17:57:17 +00:00
Owner

@nullifyshot opened this pull request on GitHub · 2026-11-12 17:14 UTC · original

tests/test_readme_menu_rows.py fails on main: the Gameplay tab's new Skip opening row (#2827) has no line in the readme's option table, which #2105 made list every row of the menu. The two merged close together, so neither saw the other.

  • Adds the Skip opening line to the option table, in the menu's order (after Discord status, before Bug report): Off / On, default Off, with what it skips as the row's help text says.
  • python -I -B tests/run_all.py readme_menu_rows: fails on main (menu rows with no line in readme.md's option table: ['Skip opening']), passes with this.
  • Full tests/run_all.py on Windows (llvm-mingw): 434 passed; the 4 failures (fpx_sticky, spawn_emit, bake_portability, lift_cache) fail on main here too.
  • Docs only, nothing in the game changes, so no game run.

Before opening I checked the 57 open PRs that edit readme.md and the 28 PRs merged since 16:30 UTC: none adds this line.

🤖 Generated with Claude Code

> [@nullifyshot](https://github.com/nullifyshot) opened this pull request on GitHub · 2026-11-12 17:14 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2857) `tests/test_readme_menu_rows.py` fails on main: the Gameplay tab's new Skip opening row (#2827) has no line in the readme's option table, which #2105 made list every row of the menu. The two merged close together, so neither saw the other. - Adds the Skip opening line to the option table, in the menu's order (after Discord status, before Bug report): Off / On, default Off, with what it skips as the row's help text says. - `python -I -B tests/run_all.py readme_menu_rows`: fails on main (`menu rows with no line in readme.md's option table: ['Skip opening']`), passes with this. - Full `tests/run_all.py` on Windows (llvm-mingw): 434 passed; the 4 failures (fpx_sticky, spawn_emit, bake_portability, lift_cache) fail on main here too. - Docs only, nothing in the game changes, so no game run. Before opening I checked the 57 open PRs that edit `readme.md` and the 28 PRs merged since 16:30 UTC: none adds this line. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- github-sync:item:2857 -->
#2827 added the Gameplay tab's Skip opening row and #2105 made the readme's
option table list every row of the menu; they merged close together, so
tests/test_readme_menu_rows.py fails on main with "menu rows with no line in
readme.md's option table: Skip opening".

Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-sync commented 2026-11-12 18:00:03 +00:00
Author
Owner

@nullifyshot commented on GitHub · 2026-11-12 17:32 UTC · original

Rebased onto main dae1930 (still merges with 376d068); tests/test_readme_menu_rows.py passes on this branch and still fails on main. Overlap: #2561 (the docs rewrite) also adds a Skip opening line to the readme's option table. This one is the small fix for main's red check; if #2561 merges first, this can close. If this goes first, #2561 keeps its own wording on rebase.

> [@nullifyshot](https://github.com/nullifyshot) commented on GitHub · 2026-11-12 17:32 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2857#issuecomment-6831035471) Rebased onto main dae1930 (still merges with 376d068); `tests/test_readme_menu_rows.py` passes on this branch and still fails on main. Overlap: #2561 (the docs rewrite) also adds a Skip opening line to the readme's option table. This one is the small fix for main's red check; if #2561 merges first, this can close. If this goes first, #2561 keeps its own wording on rebase. <!-- github-sync:c:6831035471 -->
github-sync commented 2026-11-12 18:00:03 +00:00
Author
Owner

@Arkex-ai commented on GitHub · 2026-11-12 17:52 UTC · original

Applied the README-only delta at edf69f77 over main 65a4d874 and ran main's tests/test_readme_menu_rows.py: all 5 checks pass. Clean main fails 2 checks because the Skip opening row is missing and the order differs.

This checks the patch against main's actual menu/test inputs. Full suites, native builds and gameplay were not run for this review.

> [@Arkex-ai](https://github.com/Arkex-ai) commented on GitHub · 2026-11-12 17:52 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2857#issuecomment-6831520619) Applied the README-only delta at `edf69f77` over main `65a4d874` and ran main's `tests/test_readme_menu_rows.py`: **all 5 checks pass**. Clean main fails 2 checks because the Skip opening row is missing and the order differs. This checks the patch against main's actual menu/test inputs. Full suites, native builds and gameplay were not run for this review. <!-- github-sync:c:6831520619 -->
github-sync commented 2026-11-12 18:00:03 +00:00
Author
Owner

@mooki000 commented on GitHub · 2026-11-12 17:56 UTC · original

Tested on Linux: with this merged onto main 65a4d874, tests/test_readme_menu_rows.py passes again, all 5 cases (head edf69f77). On plain main the same file fails 2 of them (Skip opening has no line, and the order check).

For whoever merges: main has two more red source checks today, test_program_cache_one_variant.py (#2861 fixes it) and, on Windows only, test_wb_shadow_remake.py (a fix is coming as its own pull request).

> [@mooki000](https://github.com/mooki000) commented on GitHub · 2026-11-12 17:56 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2857#issuecomment-6831612589) Tested on Linux: **with this merged onto main `65a4d874`, `tests/test_readme_menu_rows.py` passes again**, all 5 cases (head `edf69f77`). On plain main the same file fails 2 of them (Skip opening has no line, and the order check). For whoever merges: main has two more red source checks today, `test_program_cache_one_variant.py` (#2861 fixes it) and, on Windows only, `test_wb_shadow_remake.py` (a fix is coming as its own pull request). <!-- github-sync:c:6831612589 -->
github-sync closed this pull request 2026-11-12 19:02:52 +00:00
github-sync commented 2026-11-12 19:02:53 +00:00
Author
Owner

@nullifyshot commented on GitHub · 2026-11-12 18:28 UTC · original

Closing in favor of #2883.

> [@nullifyshot](https://github.com/nullifyshot) commented on GitHub · 2026-11-12 18:28 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2857#issuecomment-6832334585) Closing in favor of #2883. <!-- github-sync:c:6832334585 -->
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
autorelease: pending

   
autorelease: tagged

   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
testing wanted

   
wontfix
This will not be worked on

No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Hookshot!2857
No description provided.