fix(tests): main's readme and Windows write-back checks pass again #2883

Closed

github-sync wants to merge 1 commit from github/pr/2883 into main

github-sync commented

2026-11-12 19:00:58 +00:00

Owner

@SadTransGirl opened this pull request on GitHub · 2026-11-12 18:25 UTC · original
Merged on GitHub in a997297f22

Every pull request is red right now because two checks fail on main itself, not because of anything in the PRs. This fixes both in one merge so main's CI goes green again.

What fails

tests/test_readme_menu_rows.py (Linux and Windows): the Gameplay tab's Skip opening row (#2827) has no line in readme.md's option table, which #2105 made list every row of the menu. Adds the line in the menu's order (after Discord status, before Bug report): Off / On, default Off.
tests/test_wb_shadow_remake.py (Windows only): the fixture reads the environment through getenv, which MSVC's headers mark deprecated, so the build stops under -Werror:
```
gpu/vk/compat/hookshot_env.h:53:21: error: 'getenv' is deprecated: ... [-Werror,-Wdeprecated-declarations]
3 errors generated.
```
Adds -D_CRT_SECURE_NO_WARNINGS, as the other fixtures already do.

(tests/test_program_cache_one_variant.py, the third failure in the same runs, is already fixed on main by #2861.)

Relation to #2857 and #2868

These are the same two changes as @nullifyshot's #2857 and @mooki000's #2868, combined. Each of those alone still fails the other's check, so neither can show green CI by itself. Merge this, or merge both of those; either way main ends up the same. Whichever goes second has nothing left to do.

Tested

On Windows 11 with LLVM clang++, on main 4cf785a0:

before: test_readme_menu_rows FAILED (Skip opening missing), test_wb_shadow_remake failed to compile with the three getenv errors above;
after: python -I -B tests/run_all.py readme wb_shadow_remake one_variant: 3 passed, 0 failed.

Failing checks were taken from the run summaries of eight recent PRs' "Game-free source regressions" runs (every one had a subset of these three). Tests and docs only; nothing in the game changes, so no game run.

🤖 Generated with Claude Code

> [@SadTransGirl](https://github.com/SadTransGirl) opened this pull request on GitHub · 2026-11-12 18:25 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2883) > **Merged on GitHub** in https://git.magicbean.dev/MagicBeanDev/Hookshot/commit/a997297f223f98f3ae656dfbbb64fb76adbe9a8f Every pull request is red right now because two checks fail on main itself, not because of anything in the PRs. This fixes both in one merge so main's CI goes green again. ## What fails - **`tests/test_readme_menu_rows.py`** (Linux and Windows): the Gameplay tab's **Skip opening** row (#2827) has no line in `readme.md`'s option table, which #2105 made list every row of the menu. Adds the line in the menu's order (after Discord status, before Bug report): Off / On, default Off. - **`tests/test_wb_shadow_remake.py`** (Windows only): the fixture reads the environment through `getenv`, which MSVC's headers mark deprecated, so the build stops under `-Werror`: ``` gpu/vk/compat/hookshot_env.h:53:21: error: 'getenv' is deprecated: ... [-Werror,-Wdeprecated-declarations] 3 errors generated. ``` Adds `-D_CRT_SECURE_NO_WARNINGS`, as the other fixtures already do. (`tests/test_program_cache_one_variant.py`, the third failure in the same runs, is already fixed on main by #2861.) ## Relation to #2857 and #2868 These are the same two changes as @nullifyshot's #2857 and @mooki000's #2868, combined. Each of those alone still fails the other's check, so neither can show green CI by itself. Merge this, or merge both of those; either way main ends up the same. Whichever goes second has nothing left to do. ## Tested On Windows 11 with LLVM clang++, on main 4cf785a0: - before: `test_readme_menu_rows` FAILED (`Skip opening` missing), `test_wb_shadow_remake` failed to compile with the three `getenv` errors above; - after: `python -I -B tests/run_all.py readme wb_shadow_remake one_variant`: 3 passed, 0 failed. Failing checks were taken from the run summaries of eight recent PRs' "Game-free source regressions" runs (every one had a subset of these three). Tests and docs only; nothing in the game changes, so no game run. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

github-sync added 1 commit

2026-11-12 19:00:58 +00:00

fix(tests): main's readme and Windows write-back checks pass again e3b6463931

Two checks fail on main, so every pull request merged with it is red:

- tests/test_readme_menu_rows.py (Linux and Windows): the Gameplay tab's
  Skip opening row (#2827) has no line in readme.md's option table, which
  #2105 made list every menu row. Adds the line in the menu's order, after
  Discord status: Off / On, default Off.
- tests/test_wb_shadow_remake.py (Windows only): its fixture reads the
  environment through getenv, which MSVC's headers mark deprecated, an
  error under -Werror. Adds -D_CRT_SECURE_NO_WARNINGS as the other
  fixtures do.

The same two changes as #2857 and #2868, together, so one merge makes
main green (each of those alone still fails the other's check).

Assisted-by: Claude Code (claude-opus-5-5)
Co-Authored-By: Claude Opus 5.5 <[email protected]>

github-sync referenced this pull request from a commit

2026-11-12 19:00:59 +00:00

fix(tests): main's readme and Windows write-back checks pass again (#2883)

github-sync referenced this pull request from a commit

2026-11-12 19:01:06 +00:00

fix(vk): stop requiring vertex strides for mesh fallback draws (#2796)

github-sync referenced this pull request

2026-11-12 19:01:28 +00:00

feat(control): stream OoT state through the control bridge #2292

github-sync referenced this pull request

2026-11-12 19:01:44 +00:00

feat(menu): text fields in the Insert menu, and a Custom output size typed in it #2594