fix(tests): the one-variant cache test builds with the compressed program cache in the tree #2861

Closed

github-sync wants to merge 1 commit from github/pr/2861 into main

github-sync commented

2026-11-12 17:57:25 +00:00

Owner

@hckrman101 opened this pull request on GitHub · 2026-11-12 17:29 UTC · original
Merged on GitHub in fe5e2cb829

The one-variant cache test does not compile on main since #2760 was merged together with #1630: the save and read its fixture cuts from vk_progcache.cpp now name disk_zstd and the zstd calls. #2760 was merged before its CI finished on the merge with main, so this was not caught there.

Test files only:

the fixture gets the stand-ins the cleanup test already has for the compressed cache;
one new case: with the compressed cache on, a record is not read without its code (the read that unpacks is used).

tests/test_program_cache_one_variant.py passes on Linux with this on current main. The renderer is not changed.

> [@hckrman101](https://github.com/hckrman101) opened this pull request on GitHub · 2026-11-12 17:29 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2861) > **Merged on GitHub** in https://git.magicbean.dev/MagicBeanDev/Hookshot/commit/fe5e2cb8290e3e6bd6e4136773a56dd2e3d483d1 The one-variant cache test does not compile on main since #2760 was merged together with #1630: the save and read its fixture cuts from `vk_progcache.cpp` now name `disk_zstd` and the zstd calls. #2760 was merged before its CI finished on the merge with main, so this was not caught there. Test files only: - the fixture gets the stand-ins the cleanup test already has for the compressed cache; - one new case: with the compressed cache on, a record is not read without its code (the read that unpacks is used). `tests/test_program_cache_one_variant.py` passes on Linux with this on current main. The renderer is not changed.

github-sync added 1 commit

2026-11-12 17:57:25 +00:00

fix(tests): the one-variant cache test builds with the compressed program cache in the tree a36da047ee

Since #1630 the save and read this test's fixture cuts from vk_progcache.cpp name disk_zstd and the zstd calls, so the
fixture did not compile on main once #2760 was merged with it. The fixture gets the stand-ins the cleanup test has, and
one new case: with the compressed cache on, a record is not read without its code (the read that unpacks is used).

Co-Authored-By: Claude Fable 5.2 <[email protected]>

github-sync referenced this pull request

2026-11-12 17:57:29 +00:00

ci: execute authored Vulkan fixtures on lavapipe #2866

github-sync referenced this pull request

2026-11-12 18:00:03 +00:00

docs(readme): the option table has the Skip opening row, so main's readme check passes #2857

github-sync commented

2026-11-12 18:00:11 +00:00

Author

Owner

@mooki000 commented on GitHub · 2026-11-12 17:56 UTC · original

Tested on Linux: with this merged onto main 65a4d874, tests/test_program_cache_one_variant.py builds and passes again, with GCC 16.2 and with Clang 23.1 (head a36da047). The 19 other checks that take their source from vk_progcache.cpp pass too, both compilers.

I had a fixture fix of my own in work when you opened this; it is dropped in favour of yours. Not tested here: Windows (your pull request's own checks cover that).

> [@mooki000](https://github.com/mooki000) commented on GitHub · 2026-11-12 17:56 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2861#issuecomment-6831612018) Tested on Linux: **with this merged onto main `65a4d874`, `tests/test_program_cache_one_variant.py` builds and passes again**, with GCC 16.2 and with Clang 23.1 (head `a36da047`). The 19 other checks that take their source from `vk_progcache.cpp` pass too, both compilers. I had a fixture fix of my own in work when you opened this; it is dropped in favour of yours. Not tested here: Windows (your pull request's own checks cover that).

github-sync referenced this pull request

2026-11-12 19:00:48 +00:00

fix(tests): the write-back shadow remake check builds on Windows #2868

github-sync referenced this pull request

2026-11-12 19:00:49 +00:00

fix(vk): the first start of the game after a preparation warms the pipeline cache itself #2869

github-sync referenced this pull request from a commit

2026-11-12 19:00:50 +00:00

fix(tests): the one-variant cache test builds with the compressed program cache in the tree (#2861)

github-sync referenced this pull request from a commit

2026-11-12 19:00:50 +00:00

fix(vk): the first start of the game after a preparation warms the pipeline cache itself (#2869)