fix(menu): the Ultrawide row says Off (16:9) when it is off #2078

Merged
jarynclouatre merged 1 commit from fix/ultrawide-off-label into main 2026-11-11 02:49:38 +00:00
jarynclouatre commented 2026-11-11 01:50:18 +00:00 (Migrated from github.com)

With Ultrawide off, the Graphics tab showed "Ultrawide: 16:9". On a 3440x1440 monitor that read as if ultrawide were already on, so the game stayed at a 16:9 2560x1440 with bars at the sides, and 100% render resolution stayed well below the screen's width. The off value now reads "Off (16:9)". "Monitor's shape" is unchanged, so the translations in #1864 still match it. The readme's settings table follows.

Testing: tests/test_menu_restart.py, tests/test_output_resolution.py and tests/test_widescreen_shapes.py pass on Linux. It is a label change only; I have not seen it in the game yet.

With Ultrawide off, the Graphics tab showed "Ultrawide: 16:9". On a 3440x1440 monitor that read as if ultrawide were already on, so the game stayed at a 16:9 2560x1440 with bars at the sides, and 100% render resolution stayed well below the screen's width. The off value now reads "Off (16:9)". "Monitor's shape" is unchanged, so the translations in #1864 still match it. The readme's settings table follows. **Testing:** `tests/test_menu_restart.py`, `tests/test_output_resolution.py` and `tests/test_widescreen_shapes.py` pass on Linux. It is a label change only; I have not seen it in the game yet.
hckrman101 (Migrated from github.com) approved these changes 2026-11-11 02:18:05 +00:00
hckrman101 (Migrated from github.com) left a comment

Small and correct: the off value of the Ultrawide row now reads "Off (16:9)", the "Monitor's shape" text is untouched (so the #1864 translations still match), and the readme row and default follow. I found no test that matches the old "16:9" string, and no other place that builds this label.

CI: the two Windows Python source jobs fail, but the source-regressions run on main has been failing too, so I don't blame this label change; ubuntu is still pending. As the description says, not seen in game; one look at the Graphics tab with the row off would be enough.

Small and correct: the off value of the Ultrawide row now reads "Off (16:9)", the "Monitor's shape" text is untouched (so the #1864 translations still match), and the readme row and default follow. I found no test that matches the old "16:9" string, and no other place that builds this label. CI: the two Windows Python source jobs fail, but the source-regressions run on main has been failing too, so I don't blame this label change; ubuntu is still pending. As the description says, not seen in game; one look at the Graphics tab with the row off would be enough.
Commenting is not possible because the repository is archived.
No description provided.