fix(agent): accept coordinator-owned tester tags in tickets #31

Merged
HumanBean merged 1 commit from futondestroyer/Beanstalk-contributions:codex/tester-ticket-match into main 2026-11-15 23:50:45 +00:00
Member

PR 27's tester-targeting works in the coordinator and PlanTarget.Matches, but a second tag check in TicketVerifier.CheckTarget still requires every tag to be present in the agent's locally detected capabilities. The first real targeted PR 815 job reached the intended Windows worker and was refused because tester-futondestroyer is deliberately coordinator-owned.

Apply the same tester-prefix rule in this redundant local tag precheck as PlanTarget.Matches already applies. Other OS/GPU/custom tags and size/model requirements are still checked. Signature verification, expiry, accepted job ID, agent ID binding, commit validation, server-side ownership matching and rejection of agent-supplied tester tags are unchanged. No tags are spoofed or added to local capabilities.

Validation:

  • New signed-ticket regression fails on main with the exact missing-tester-tag refusal, then passes with the fix.
  • Negative cases retain OS/GPU checks and rejection of wrong-agent and expired tickets; the existing signature, target-membership and model/size checks remain enabled.
  • 1,583 Windows agent core checks pass.
  • Locked Release build passes with zero warnings and zero errors; git diff --check passes.

Live reproducer: MagicBeanDev/Longshot#815 (comment) (target restricted to windows+nvidia+tester-futondestroyer). The worker has not been switched to an unreviewed build. After reviewed rollout, requeue the targeted job through the normal coordinator workflow; no manual ticket or assignment workaround is used.

PR 27's tester-targeting works in the coordinator and PlanTarget.Matches, but a second tag check in TicketVerifier.CheckTarget still requires every tag to be present in the agent's locally detected capabilities. The first real targeted PR 815 job reached the intended Windows worker and was refused because tester-futondestroyer is deliberately coordinator-owned. Apply the same tester-prefix rule in this redundant local tag precheck as PlanTarget.Matches already applies. Other OS/GPU/custom tags and size/model requirements are still checked. Signature verification, expiry, accepted job ID, agent ID binding, commit validation, server-side ownership matching and rejection of agent-supplied tester tags are unchanged. No tags are spoofed or added to local capabilities. Validation: - New signed-ticket regression fails on main with the exact missing-tester-tag refusal, then passes with the fix. - Negative cases retain OS/GPU checks and rejection of wrong-agent and expired tickets; the existing signature, target-membership and model/size checks remain enabled. - 1,583 Windows agent core checks pass. - Locked Release build passes with zero warnings and zero errors; git diff --check passes. Live reproducer: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/815#issuecomment-30972 (target restricted to windows+nvidia+tester-futondestroyer). The worker has not been switched to an unreviewed build. After reviewed rollout, requeue the targeted job through the normal coordinator workflow; no manual ticket or assignment workaround is used.
fix(agent): accept coordinator-owned tester tags in tickets
Some checks failed
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 4s
CI / Coordinator tests (pull_request) Has been cancelled
CI / Agent build and checks (pull_request) Has been cancelled
CI / Coordinator image (pull_request) Has been cancelled
84a061dd2a
Match the tester-prefix handling already used by PlanTarget.Matches while retaining the signed ticket agent binding and hardware restrictions.

Assisted-by: OpenAI Codex

Co-Authored-By: Codex <[email protected]>
Author
Member

Verified after rollout on signed nightly-56-bd292bbd: the normal tester-futondestroyer Windows/NVIDIA ticket for Longshot PR 815 was accepted, so the original ticket refusal is fixed. The farm then failed in the main base build before gameplay; report https://beanstalk.magicbean.dev/reports/rp_c19169027a9a2c13 . The separate private-temp-directory ACL failure is reproduced without game files and recorded at #35 . No sandbox workaround was installed.

Verified after rollout on signed nightly-56-bd292bbd: the normal tester-futondestroyer Windows/NVIDIA ticket for Longshot PR 815 was accepted, so the original ticket refusal is fixed. The farm then failed in the main base build before gameplay; report https://beanstalk.magicbean.dev/reports/rp_c19169027a9a2c13 . The separate private-temp-directory ACL failure is reproduced without game files and recorded at https://git.magicbean.dev/MagicBeanDev/Beanstalk/issues/35 . No sandbox workaround was installed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Beanstalk!31
No description provided.