fix(agent): accept coordinator-owned tester tags in tickets #31
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!31
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/Beanstalk-contributions:codex/tester-ticket-match"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR 27's tester-targeting works in the coordinator and PlanTarget.Matches, but a second tag check in TicketVerifier.CheckTarget still requires every tag to be present in the agent's locally detected capabilities. The first real targeted PR 815 job reached the intended Windows worker and was refused because tester-futondestroyer is deliberately coordinator-owned.
Apply the same tester-prefix rule in this redundant local tag precheck as PlanTarget.Matches already applies. Other OS/GPU/custom tags and size/model requirements are still checked. Signature verification, expiry, accepted job ID, agent ID binding, commit validation, server-side ownership matching and rejection of agent-supplied tester tags are unchanged. No tags are spoofed or added to local capabilities.
Validation:
Live reproducer: MagicBeanDev/Longshot#815 (comment) (target restricted to windows+nvidia+tester-futondestroyer). The worker has not been switched to an unreviewed build. After reviewed rollout, requeue the targeted job through the normal coordinator workflow; no manual ticket or assignment workaround is used.
Verified after rollout on signed nightly-56-bd292bbd: the normal tester-futondestroyer Windows/NVIDIA ticket for Longshot PR 815 was accepted, so the original ticket refusal is fixed. The farm then failed in the main base build before gameplay; report https://beanstalk.magicbean.dev/reports/rp_c19169027a9a2c13 . The separate private-temp-directory ACL failure is reproduced without game files and recorded at #35 . No sandbox workaround was installed.