feat: an All jobs page in the app, and Run on this PC for any queued job #29
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!29
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:feat/all-jobs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why: testers could only see the jobs that came to their own PC, with no way to run one that wasn't meant for it. Now the app shows everything on the farm, and a tester can run any queued job on their PC.
What the tester sees
How it works
GET /api/v1/jobs?state=queued|running|done(agent token) lists jobs withfits,why,can_run/run_blockedfor this agent.POST /jobs/{id}/acceptwith{"manual": true}is a manual take.job_id, and the ticket signsoff_targetandfor_job_id.allowed_authors.reports.off_target) are left out of the target's pass/fail/min_reports, its commit status, the state label, the dashboard counts and the outlier check.for_job_id, and the job id from the accept reply). Every other ticket check is kept.jobs.off_targetandreports.off_target, default false.docs/protocol.md,docs/using.md,docs/architecture.md,agent/README.md.Screenshots (this PR's app against the coordinator's dev server and its made-up data, a Linux build, 1180 × 860):
After: this PR, the main screen, with "All jobs on the farm" beside RECENT TESTS

After: this PR, Queued: one job for this PC, two for other hardware

After: this PR, Run on this PC on a job for other hardware asks first

After: this PR, Done: the result, the tester and See results

Testing
test_all_jobs.pycovers the listing, the manual take, every refusal, the separate job, the report left out of counts, status and label, cancelling rather than requeuing, the migration, and HTTP.win-x64build compiles.Also in this PR: CONTRIBUTING.md and AGENTS.md now ask for screenshots in any pull request that changes what shows on screen (the second commit).
Known gap: while an off-target run is still going,
@Beanstalkon that PR says the round is still running. That is on purpose for now: a new start doesn't cancel someone's manual run.The app's main screen links an All jobs page: every job on the farm, Queued / Running / Done, with Only this PC. A queued job says whether it is for this PC or why not, and has Run on this PC. Run on this PC takes the job as a real one. On a PC that matches the target it takes the queued job itself. On one that doesn't, after a confirm, the farm makes a separate off-target job for it (the queued job stays for a matching PC); its report posts to the PR marked off target and counts toward nothing: not the target's results, its status, the state label or the outlier check. Approval, the sandbox, the plan schema, the Windows gameplay gate, one job at a time and the tester's own failed/skipped/ran jobs still apply; the target's tags and the tester's allowed_authors don't. A manual run works while automatic testing is paused. - Coordinator: GET /api/v1/jobs?state=, accept with {"manual": true}, signed off_target and for_job_id in the ticket, migration 0010 (jobs.off_target, reports.off_target), off-target runs cancelled rather than requeued, an off-target table in the PR comment and chips on the dashboard. - Agent: the ticket check accepts an off-target ticket only for the job this PC asked for by hand; the client calls; JobRunner.RunNowAsync; the page, its confirm and the history's (off target). Assisted-by: Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <[email protected]>5e07938352dbc53ccdacRebased onto main
bd292bbd(#31 merged). The conflict was in Envelope.cs, where #31 and this PR both changed the ticket target check: an off-target ticket skips it, and otherwise tester- tags are left to the coordinator, as #31 does. Added screenshots of the page (main-screen link, Queued, the off-target confirm, Done). Taking them showed a bug, now fixed: a filter picked while the first load was still on its way left the page empty. Also added the screenshots rule to CONTRIBUTING.md and AGENTS.md. Coordinator tests 407 passed, agent checks 1670 passed.