feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana #206

Open
gab9281 wants to merge 17 commits from gab9281/Longshot:feat/perf-metrics into main
Member

Type: feat · Risk: low · Tested on: Linux, RTX 3060 Laptop · Needs: Windows, AMD and Intel GPUs, 32 GB of RAM

Why

Players report stutter, cutscenes that play badly and uneven frame pacing, and the team can't tell which GPUs, drivers, CPUs, systems, renderers or maps they come from. With this PR, a player who ticks Send performance statistics in the Longshot Launcher (off by default; LongshotLauncher#74) has the game count how its frames went on each map, and the launcher sends those counts to the team's Grafana, where each of these can be filtered on its own.

What changed

With send=1 in the game folder's longshot_perf.ini, which the launcher's tick writes, the game keeps a short summary of each map's frames and writes it to perf_pending/ every 5 minutes and when the window closes. Before the next start, the launcher sends what is waiting with nx2/perf_report.py to Longshot-api's telemetry service (/telemetry/perf), which counts it for Grafana. With the tick off, nothing is measured, written or sent.

  • game, gpu/vk/perf_report.h and perf_report.cpp. For each map, the summary holds:
    • frame-time and GPU-time histograms, and the FPS counter's parts (game, render, GPU wait, pace);
    • hitches by what they waited on most (pipelines, shader translation, texture uploads, memory sync, the GPU, read-backs, the game, pacing), pacing misses, and draws left out. A hitch is a frame twice the recent usual, so a game the GPU holds under its cap isn't a hitch on every frame;
    • rendering events: program failed, device lost, swapchain recreated, movie upscaler dropped, DLSS recreated, VRAM over budget;
    • cutscene playback: pictures shown, dropped and late, decoding time, decoder fallbacks;
    • VRAM and RAM, and the machine and settings: the GPU, driver, CPU, RAM, OS, kernel, upscaler, preset and cap.
  • when it writes: every 5 minutes (RX_VK_PERF_INTERVAL, 60 to 840 s) and when the window closes (mkwvk_close_asked in vk_main.cpp, since ExitProcess is _exit on Linux and atexit never runs); once on a lost device (vk_replay.cpp device_lost). The game reads the tick again before each summary and stops when it was taken off during play. At most 48 summaries wait on disk.
  • before the first map: the summary's map is "Preparing shaders" while the start-up screen prepares them, then "Title and intro", the names #141's crash report uses.
  • game, vk_fps.cpp: while the summary is on, the FPS counter takes its Breakdown's timings and passes each frame to perf_frame() (add_frame: 6-16 ns). With the tick off, the only cost is one load of perf_measure per frame.
  • host: the map Link is in and the movies' totals, through MkwVkHost::perf_info (MKWVK_API_VERSION 23):
    • hos_main.c hos_perf_info;
    • nn_video.c counts each picture as the game takes it, so a movie still playing at a summary is counted;
    • dav1d_av1.c counts a decoder that didn't start.
  • nx2, perf_report.py, run by the launcher:
    • --tick on|off [--keep-sent off]: writes send=1 (and keep_sent=0 when the launcher's Keep a copy of what was sent is off, which also deletes the copies), or deletes the file, what is waiting and the copies of what was sent;
    • --send: oldest first, with the version and the release flag filled in (as the crash report has them). A summary the service took or refused is deleted; one it couldn't reach, or a 429/5xx, stays for next time. Each one taken is kept, exactly as sent, in perf_sent/ (the newest 48), unless the copies are off, so a player or tester can read what went to the team;
    • polite by default: every summary over one kept connection (Relay: one TLS handshake for them all; through a system proxy, urllib's one request each, as before), at most 12 a start, and a service that answers busy (429, 5xx) left alone until its Retry-After, else an hour, doubled each time it is busy again up to a day (perf_pending/.next). A kept connection the service let go is tried once more on a new one: the summary never arrived, so none is sent twice;
    • its switches, each with that default, clamped or defaulted with a word on stderr: LONGSHOT_PERF_MAX_SENDS, LONGSHOT_PERF_TIMEOUT, LONGSHOT_PERF_BACKOFF, LONGSHOT_PERF_KEEP_SENT, LONGSHOT_PERF_URL (Flags and settings);
    • the logs read from logs/, as main keeps them.
  • nx2, addresses.ini/addresses.py: the service's address (perf_reports = https://api.magicbean.gmatte.xyz/telemetry/perf), out of the code. The file is the same as #141's, crash addresses included, so whichever merges second has no conflict.
  • docs: docs/performance-statistics.md (what is sent and never sent, how the parts fit, the switches, the cost), a README line, longshot_perf.ini and RX_VK_PERF_INTERVAL in docs/development.md, and the measured runs in docs/tested/.
  • tests: tests/test_perf_report.cpp (the summary's functions, the interval's rule); tests/test_perf_report.py (the launcher side against a stand-in service over HTTP/1.1: --tick, --keep-sent, one connection, a dropped one, the share a start, Retry-After and the doubling, the switches; and the wiring in the game, the pre-map names included); the video tests' fixtures get the new counter.

The telemetry service and the Grafana dashboard ("Longshot performance", with a perf index by map and graphics card) are deployed (Longshot-api, Bean-Ops).

Measurements

Verdict: no cost that stands out from the noise on this PC. With the tick off, this PR was 2% behind main in the medians (124.4 against 127.0 fps), but main's own runs spread over 15 fps (121.5 to 136.7) as the PC slowed from round to round, and in the last round the tick off was ahead of main. The tick on cost about as much as the tick off (122.9 fps, 6.75 against 6.78 ms). The earlier A/Bs on main fbd42024 and 6c9edffe, with the same method, found the same: within a percent or two, either way.

Hardware: NVIDIA GeForce RTX 3060 Laptop GPU (6 GB), NVIDIA 620.70.06, AMD Ryzen 7 6800H, 15 GB, CachyOS (Linux 7.3.4), KDE Wayland
Scene: the game's start, the intro and title (no save on this PC), output 2048x1152, preset Auto (DLSS), no frame generation, HOS_FPS_MAX=1000 (uncapped), HOS_AUDIO=0
Method: 75 s a run, started through CachyOS's game-performance, with RX_VK_FRAME_LOG, ended with the control bridge's quit (the window's close path). Frames from 20 s on. Main, then this PR with the tick off, then on, 3 rounds interleaved; each value is the median of the 3 runs.
How to reproduce: two runtimes on one base (scripts/dev_packs.py rt), one with main's longshot and longshot_vk.so, one with this PR's; HOS_FPS_MAX=1000; longshot_perf.ini with send=1 for "on"; quit with python -I scripts/longshot_ctl.py quit.

Before: main @ e090cc48 After, tick off: this PR @ 9981a39a After, tick on: this PR @ 9981a39a
fps (uncapped), median of 3 127.0 124.4 122.9
1% low fps 50.7 49.9 49.8
median frame time 6.46 ms 6.78 ms 6.75 ms
summaries written none none one a run (3)
main  runs 3  fps 127.0 (136.7, 127.0, 121.5)  1% low 50.7 (57.7, 50.7, 49.5)  frame 6.46 ms (5.88, 6.46, 7.13)
off   runs 3  fps 124.4 (129.3, 124.4, 122.1)  1% low 49.9 (52.3, 49.9, 49.2)  frame 6.78 ms (6.42, 6.81, 6.78)
on    runs 3  fps 122.9 (127.2, 122.8, 122.9)  1% low 49.8 (51.7, 49.8, 47.7)  frame 6.75 ms (6.45, 6.77, 6.75)

Reading: each round ran main first, and every side got slower each round (main 136.7, 127.0, 121.5), with the PC busy (another app using most of a core) and swapping, so the order favours main. The per-frame work this PR adds is add_frame (6-16 ns, tests/test_perf_report.cpp) with the tick on and one load with it off: far below what these runs can resolve. The earlier sets: main 6c9edffe 135.6, off 136.3, on 134.4 fps; main fbd42024 150.9, off 149.1, on 149.1 (docs/tested/). A quieter PC (test requests below) can settle a 1-2% difference.

Since the measured 9981a39a, a401573b changes nothing a frame does but compare against the interval read once at the start (period) instead of a constant; the rest is the launcher's sending, after the game. The numbers above still hold.

Flags and settings

Two ini keys, written by the launcher's settings, and six switches with polite defaults that need no setting (docs/performance-statistics.md, "Switches"). The sender's are read from the launcher's environment, the game's from its environment or longshot_env.txt.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
longshot_perf.ini send=1 (the launcher's Send performance statistics) The game measures its frames and writes a summary every 5 minutes and at close; the launcher sends them none off (no file) on: the summaries written and sent; off: nothing measured, written or sent helps: finding which hardware, driver, system or map stutters or plays cutscenes badly (Linux, NVIDIA tested); untested: Windows, AMD and Intel GPUs off by default: sending anything is the player's choice
longshot_perf.ini keep_sent=0 (the launcher's Keep a copy of what was sent) No copy of what was sent kept in perf_sent/ none on (no line) off: no copies, and those kept deleted helps: a player who wants nothing left on disk (Linux tested) on by default: the player can read what went out
RX_VK_PERF_INTERVAL (game) Seconds of play between summaries none (300 fixed) 300 (60 to 840) longer: fewer summaries and requests, more lost at a crash untested beyond its checks 300
LONGSHOT_PERF_MAX_SENDS Summaries sent at one start none (all, up to 48) 12 (1 to 48) the rest wait for the next start helps: a player back after hours of play doesn't send 48 at once (checked by its tests) 12
LONGSHOT_PERF_TIMEOUT One request's time limit none (10 s fixed) 10 s (2 to 60) a slow link: longer untested beyond its checks 10 s
LONGSHOT_PERF_BACKOFF Leaves a busy service alone none (asked at every start) on off: asked at every start helps: a busy service isn't asked by every player at once (checked by its tests) on
LONGSHOT_PERF_KEEP_SENT The copies, over keep_sent none unset (the launcher's choice) on/off for one run helps: a tester unset
LONGSHOT_PERF_URL Where the summaries go none (addresses.ini) unset (https, or http to this PC) a local service for a test helps: testing without the team's service unset

Testing

Tested:

  • python -I -B tests/run_all.py on Linux, at a401573b on main e090cc48 (v3.0.0-rc.4): 564 passed, 14 failed, 16 skipped. 13 of the failures fail on main on this PC too (appimage_player_build, cpm_discovery, env_on, finish_output, lift_cleanup_error, linux_preflight, linux_update, make_game_cache, pipeline_tour, readback_late, vk_pgo, vram_budget_row, walk_key); the 14th, test_crash_dialog, fails on main too and is fixed by #141. tests/test_perf_report.py and tests/test_perf_report.cpp pass, with g++ and clang++.
  • The renderer alone at a401573b (RX_VK_ONLY=1 nx2/build.py --standalone): Linux compiled and linked longshot_vk.so, Windows with llvm-mingw (20261104, RX_TARGET=windows) longshot_vk.dll, 0 failed each; the changed host files (hos_main.c, nn_video.c, dav1d_av1.c, rx_backend.c) compile with no error and the same warnings as main's.
  • End to end with the launcher, at 9981a39a with LongshotLauncher#74 @ f7518c6, on the hardware above, a stand-in launcher home with the tick on, against the deployed service:
    • the launcher's --play wrote longshot_perf.ini send=1, and the game logged "performance statistics on (the launcher's Send performance statistics)";
    • closed with the window's close: a summary in perf_pending/ ("Title and intro", 82 s, the GPU, driver, CPU, OS and settings right);
    • the next --play sent it before the game started: it moved to perf_sent/, and Grafana's longshot_perf_reports_total{result="accepted"} went 3 → 4, with longshot_sessions_total for v3.0.0-rc.4-14-g9981a39a labelled RTX 3060 Laptop, NVIDIA 620.70, Ryzen 7 6800H, CachyOS, kernel 7.3, DLSS, preset Auto, cap 60, "Title and intro";
    • twice more (a second close, a third start): accepted 4 → 5, sessions 1 → 2. Each session ended cleanly ("display: window closed, exiting").
  • The polite sending, at a401573b, against the deployed service (https://api.magicbean.gmatte.xyz/telemetry/perf, behind Traefik):
    • 5 waiting summaries sent over 1 TLS connection (counted at HTTPSConnection.connect), all taken;
    • Grafana's accepted went 5 → 12 over this PR's sends today, one for each summary sent, none twice.
  • Keep a copy of what was sent, end to end with LongshotLauncher#74 @ d807edd (the setting off in a stand-in launcher home): the launcher's --play wrote send=1 and keep_sent=0, the 3 copies kept before were deleted, the game still logged "performance statistics on"; quit through the control bridge (scripts/longshot_ctl.py quit), its summary was sent at the next --play, and perf_sent/ stayed empty.
  • RX_VK_PERF_INTERVAL=60, in the game built from a401573b (a pack over the shared base): logged "a summary every 60 s", wrote a summary of "Title and intro" 60.0 s, then one of 34.9 s at the quit.
  • Before the rebase (fbd42024 and 6c9edffe), in the game on the same PC:
    • in a run that reached play (a new game into Kokiri Forest), the time split by map: "KokiriForest_Child (child)" 44.4 s, and the intro 178.2 s;
    • a save continued in Hyrule Field, 3 sessions of 4-5 minutes, sent and shown on the dashboard's map × graphics card panels;
    • the intro's movie counted: 1506 pictures shown, 107 dropped, 29 late;
    • with the tick taken off during play, the game logs "performance statistics off" and writes nothing more.

Not tested:

  • Windows in the game: this PC is Linux only.
  • "Preparing shaders" in a summary: the start-up screen's preparation presents no game frames, so the name shows only for a preparation behind play (an update).
  • A summary from a lost device, and the 5-minute summaries over a long session: longer runs on this PC were ended by the kernel's out-of-memory killer in Hyrule Field after 2-5 minutes (the game's own memory, about 6 GB there; the summary keeps a few kB a map).
  • A release's flag: CI doesn't write source= yet, so every summary is "not a release" for now, as in the crash report.

Must be tested:

  • Windows 10/11, any GPU: put send=1 in the game folder's longshot_perf.ini (or tick it in LongshotLauncher#74), play 10 minutes on 2 maps, close the window, then run python -I nx2/perf_report.py <folder> --send, expecting a summary in perf_pending\ with those maps and the right GPU, driver, CPU and OS, then perf_pending\ empty and the same summary in perf_sent\ (by hand: request T-ULGD; paste the summary's top lines)
  • AMD and Intel GPUs, any OS: the same steps, expecting the summary's gpu and driver to name the card and its driver (for example radv Mesa 25.2) and its fps to match the game's FPS counter (by hand: request T-WNBH)
  • 32 GB of RAM or more: an hour over several maps with the tick on, then send, expecting a summary in perf_pending/ every 5 minutes, each with the maps since the one before, and those maps on the dashboard's map × graphics card panels after sending (by hand: request T-AAC7)

Risks

What could break: with the tick on, each frame does a little more work (Measurements); a summary is written every 5 minutes, a few kB. With it off, the game reads one small file at its first frame and one load a frame. Privacy: a summary holds no paths, user name or ID, the log, saves, or anything from the game files; docs/performance-statistics.md lists what is sent.

Turning it off: untick it (the launcher deletes longshot_perf.ini, what is waiting and the copies), or delete longshot_perf.ini; to stop all sending, remove perf_reports from nx2/addresses.ini; or revert.

Compatibility: MKWVK_API_VERSION 22 → 23 (the renderer and the game are built together). Saves, longshot_options.ini and the caches don't change. A game folder gains perf_pending/ and perf_sent/ only with the tick on.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • MKWVK_API_VERSION bumped (gpu/vk/vk_api.h's MkwVkHost or MkwVkRenderer changed).
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • Docs updated.

🤖 Generated with Claude Code

https://claude.ai/code/session_015KgSKmeEEMir1hCDFZ8BmR

**Type:** feat · **Risk:** low · **Tested on:** Linux, RTX 3060 Laptop · **Needs:** Windows, AMD and Intel GPUs, 32 GB of RAM ## Why Players report stutter, cutscenes that play badly and uneven frame pacing, and the team can't tell which GPUs, drivers, CPUs, systems, renderers or maps they come from. With this PR, a player who ticks **Send performance statistics** in the Longshot Launcher (off by default; [LongshotLauncher#74](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/74)) has the game count how its frames went on each map, and the launcher sends those counts to the team's Grafana, where each of these can be filtered on its own. ## What changed With `send=1` in the game folder's `longshot_perf.ini`, which the launcher's tick writes, the game keeps a short summary of each map's frames and writes it to `perf_pending/` every 5 minutes and when the window closes. Before the next start, the launcher sends what is waiting with `nx2/perf_report.py` to Longshot-api's telemetry service (`/telemetry/perf`), which counts it for Grafana. With the tick off, nothing is measured, written or sent. - **game**, `gpu/vk/perf_report.h` and `perf_report.cpp`. For each map, the summary holds: - frame-time and GPU-time histograms, and the FPS counter's parts (game, render, GPU wait, pace); - hitches by what they waited on most (pipelines, shader translation, texture uploads, memory sync, the GPU, read-backs, the game, pacing), pacing misses, and draws left out. A hitch is a frame twice the recent usual, so a game the GPU holds under its cap isn't a hitch on every frame; - rendering events: program failed, device lost, swapchain recreated, movie upscaler dropped, DLSS recreated, VRAM over budget; - cutscene playback: pictures shown, dropped and late, decoding time, decoder fallbacks; - VRAM and RAM, and the machine and settings: the GPU, driver, CPU, RAM, OS, kernel, upscaler, preset and cap. - **when it writes:** every 5 minutes (`RX_VK_PERF_INTERVAL`, 60 to 840 s) and when the window closes (`mkwvk_close_asked` in `vk_main.cpp`, since `ExitProcess` is `_exit` on Linux and `atexit` never runs); once on a lost device (`vk_replay.cpp` `device_lost`). The game reads the tick again before each summary and stops when it was taken off during play. At most 48 summaries wait on disk. - **before the first map:** the summary's map is "Preparing shaders" while the start-up screen prepares them, then "Title and intro", the names #141's crash report uses. - **game**, `vk_fps.cpp`: while the summary is on, the FPS counter takes its Breakdown's timings and passes each frame to `perf_frame()` (`add_frame`: 6-16 ns). With the tick off, the only cost is one load of `perf_measure` per frame. - **host:** the map Link is in and the movies' totals, through `MkwVkHost::perf_info` (`MKWVK_API_VERSION` 23): - `hos_main.c` `hos_perf_info`; - `nn_video.c` counts each picture as the game takes it, so a movie still playing at a summary is counted; - `dav1d_av1.c` counts a decoder that didn't start. - **nx2**, `perf_report.py`, run by the launcher: - `--tick on|off [--keep-sent off]`: writes `send=1` (and `keep_sent=0` when the launcher's **Keep a copy of what was sent** is off, which also deletes the copies), or deletes the file, what is waiting and the copies of what was sent; - `--send`: oldest first, with the version and the release flag filled in (as the crash report has them). A summary the service took or refused is deleted; one it couldn't reach, or a 429/5xx, stays for next time. Each one taken is kept, exactly as sent, in `perf_sent/` (the newest 48), unless the copies are off, so a player or tester can read what went to the team; - **polite by default:** every summary over one kept connection (`Relay`: one TLS handshake for them all; through a system proxy, urllib's one request each, as before), at most 12 a start, and a service that answers busy (429, 5xx) left alone until its `Retry-After`, else an hour, doubled each time it is busy again up to a day (`perf_pending/.next`). A kept connection the service let go is tried once more on a new one: the summary never arrived, so none is sent twice; - its switches, each with that default, clamped or defaulted with a word on stderr: `LONGSHOT_PERF_MAX_SENDS`, `LONGSHOT_PERF_TIMEOUT`, `LONGSHOT_PERF_BACKOFF`, `LONGSHOT_PERF_KEEP_SENT`, `LONGSHOT_PERF_URL` (Flags and settings); - the logs read from `logs/`, as main keeps them. - **nx2**, `addresses.ini`/`addresses.py`: the service's address (`perf_reports = https://api.magicbean.gmatte.xyz/telemetry/perf`), out of the code. The file is the same as #141's, crash addresses included, so whichever merges second has no conflict. - **docs:** `docs/performance-statistics.md` (what is sent and never sent, how the parts fit, the switches, the cost), a README line, `longshot_perf.ini` and `RX_VK_PERF_INTERVAL` in `docs/development.md`, and the measured runs in `docs/tested/`. - **tests:** `tests/test_perf_report.cpp` (the summary's functions, the interval's rule); `tests/test_perf_report.py` (the launcher side against a stand-in service over HTTP/1.1: `--tick`, `--keep-sent`, one connection, a dropped one, the share a start, `Retry-After` and the doubling, the switches; and the wiring in the game, the pre-map names included); the video tests' fixtures get the new counter. The telemetry service and the Grafana dashboard ("Longshot performance", with a perf index by map and graphics card) are deployed (Longshot-api, Bean-Ops). ## Measurements **Verdict:** no cost that stands out from the noise on this PC. With the tick off, this PR was 2% behind main in the medians (124.4 against 127.0 fps), but main's own runs spread over 15 fps (121.5 to 136.7) as the PC slowed from round to round, and in the last round the tick off was ahead of main. The tick on cost about as much as the tick off (122.9 fps, 6.75 against 6.78 ms). The earlier A/Bs on main fbd42024 and 6c9edffe, with the same method, found the same: within a percent or two, either way. Hardware: NVIDIA GeForce RTX 3060 Laptop GPU (6 GB), NVIDIA 620.70.06, AMD Ryzen 7 6800H, 15 GB, CachyOS (Linux 7.3.4), KDE Wayland Scene: the game's start, the intro and title (no save on this PC), output 2048x1152, preset Auto (DLSS), no frame generation, `HOS_FPS_MAX=1000` (uncapped), `HOS_AUDIO=0` Method: 75 s a run, started through CachyOS's `game-performance`, with `RX_VK_FRAME_LOG`, ended with the control bridge's quit (the window's close path). Frames from 20 s on. Main, then this PR with the tick off, then on, 3 rounds interleaved; each value is the median of the 3 runs. How to reproduce: two runtimes on one base (`scripts/dev_packs.py rt`), one with main's `longshot` and `longshot_vk.so`, one with this PR's; `HOS_FPS_MAX=1000`; `longshot_perf.ini` with `send=1` for "on"; quit with `python -I scripts/longshot_ctl.py quit`. | | Before: main @ e090cc48 | After, tick off: this PR @ 9981a39a | After, tick on: this PR @ 9981a39a | |---|---|---|---| | fps (uncapped), median of 3 | 127.0 | 124.4 | 122.9 | | 1% low fps | 50.7 | 49.9 | 49.8 | | median frame time | 6.46 ms | 6.78 ms | 6.75 ms | | summaries written | none | none | one a run (3) | ``` main runs 3 fps 127.0 (136.7, 127.0, 121.5) 1% low 50.7 (57.7, 50.7, 49.5) frame 6.46 ms (5.88, 6.46, 7.13) off runs 3 fps 124.4 (129.3, 124.4, 122.1) 1% low 49.9 (52.3, 49.9, 49.2) frame 6.78 ms (6.42, 6.81, 6.78) on runs 3 fps 122.9 (127.2, 122.8, 122.9) 1% low 49.8 (51.7, 49.8, 47.7) frame 6.75 ms (6.45, 6.77, 6.75) ``` Reading: each round ran main first, and every side got slower each round (main 136.7, 127.0, 121.5), with the PC busy (another app using most of a core) and swapping, so the order favours main. The per-frame work this PR adds is `add_frame` (6-16 ns, `tests/test_perf_report.cpp`) with the tick on and one load with it off: far below what these runs can resolve. The earlier sets: main 6c9edffe 135.6, off 136.3, on 134.4 fps; main fbd42024 150.9, off 149.1, on 149.1 (`docs/tested/`). A quieter PC (test requests below) can settle a 1-2% difference. Since the measured 9981a39a, a401573b changes nothing a frame does but compare against the interval read once at the start (`period`) instead of a constant; the rest is the launcher's sending, after the game. The numbers above still hold. ### Flags and settings Two ini keys, written by the launcher's settings, and six switches with polite defaults that need no setting (`docs/performance-statistics.md`, "Switches"). The sender's are read from the launcher's environment, the game's from its environment or `longshot_env.txt`. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `longshot_perf.ini` `send=1` (the launcher's **Send performance statistics**) | The game measures its frames and writes a summary every 5 minutes and at close; the launcher sends them | none | off (no file) | on: the summaries written and sent; off: nothing measured, written or sent | helps: finding which hardware, driver, system or map stutters or plays cutscenes badly (Linux, NVIDIA tested); untested: Windows, AMD and Intel GPUs | off by default: sending anything is the player's choice | | `longshot_perf.ini` `keep_sent=0` (the launcher's **Keep a copy of what was sent**) | No copy of what was sent kept in `perf_sent/` | none | on (no line) | off: no copies, and those kept deleted | helps: a player who wants nothing left on disk (Linux tested) | on by default: the player can read what went out | | `RX_VK_PERF_INTERVAL` (game) | Seconds of play between summaries | none (300 fixed) | 300 (60 to 840) | longer: fewer summaries and requests, more lost at a crash | untested beyond its checks | 300 | | `LONGSHOT_PERF_MAX_SENDS` | Summaries sent at one start | none (all, up to 48) | 12 (1 to 48) | the rest wait for the next start | helps: a player back after hours of play doesn't send 48 at once (checked by its tests) | 12 | | `LONGSHOT_PERF_TIMEOUT` | One request's time limit | none (10 s fixed) | 10 s (2 to 60) | a slow link: longer | untested beyond its checks | 10 s | | `LONGSHOT_PERF_BACKOFF` | Leaves a busy service alone | none (asked at every start) | on | off: asked at every start | helps: a busy service isn't asked by every player at once (checked by its tests) | on | | `LONGSHOT_PERF_KEEP_SENT` | The copies, over `keep_sent` | none | unset (the launcher's choice) | on/off for one run | helps: a tester | unset | | `LONGSHOT_PERF_URL` | Where the summaries go | none (`addresses.ini`) | unset (https, or http to this PC) | a local service for a test | helps: testing without the team's service | unset | ## Testing **Tested:** - `python -I -B tests/run_all.py` on Linux, at a401573b on main e090cc48 (v3.0.0-rc.4): 564 passed, 14 failed, 16 skipped. 13 of the failures fail on main on this PC too (appimage_player_build, cpm_discovery, env_on, finish_output, lift_cleanup_error, linux_preflight, linux_update, make_game_cache, pipeline_tour, readback_late, vk_pgo, vram_budget_row, walk_key); the 14th, `test_crash_dialog`, fails on main too and is fixed by #141. `tests/test_perf_report.py` and `tests/test_perf_report.cpp` pass, with g++ and clang++. - The renderer alone at a401573b (`RX_VK_ONLY=1 nx2/build.py --standalone`): Linux compiled and linked `longshot_vk.so`, Windows with llvm-mingw (20261104, `RX_TARGET=windows`) `longshot_vk.dll`, 0 failed each; the changed host files (`hos_main.c`, `nn_video.c`, `dav1d_av1.c`, `rx_backend.c`) compile with no error and the same warnings as main's. - **End to end with the launcher**, at 9981a39a with [LongshotLauncher#74](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/74) @ f7518c6, on the hardware above, a stand-in launcher home with the tick on, against the deployed service: - the launcher's `--play` wrote `longshot_perf.ini` `send=1`, and the game logged "performance statistics on (the launcher's Send performance statistics)"; - closed with the window's close: a summary in `perf_pending/` ("Title and intro", 82 s, the GPU, driver, CPU, OS and settings right); - the next `--play` sent it before the game started: it moved to `perf_sent/`, and Grafana's `longshot_perf_reports_total{result="accepted"}` went 3 → 4, with `longshot_sessions_total` for `v3.0.0-rc.4-14-g9981a39a` labelled RTX 3060 Laptop, NVIDIA 620.70, Ryzen 7 6800H, CachyOS, kernel 7.3, DLSS, preset Auto, cap 60, "Title and intro"; - twice more (a second close, a third start): accepted 4 → 5, sessions 1 → 2. Each session ended cleanly ("display: window closed, exiting"). - **The polite sending**, at a401573b, against the deployed service (`https://api.magicbean.gmatte.xyz/telemetry/perf`, behind Traefik): - 5 waiting summaries sent over 1 TLS connection (counted at `HTTPSConnection.connect`), all taken; - Grafana's `accepted` went 5 → 12 over this PR's sends today, one for each summary sent, none twice. - **Keep a copy of what was sent**, end to end with LongshotLauncher#74 @ d807edd (the setting off in a stand-in launcher home): the launcher's `--play` wrote `send=1` and `keep_sent=0`, the 3 copies kept before were deleted, the game still logged "performance statistics on"; quit through the control bridge (`scripts/longshot_ctl.py quit`), its summary was sent at the next `--play`, and `perf_sent/` stayed empty. - **`RX_VK_PERF_INTERVAL=60`**, in the game built from a401573b (a pack over the shared base): logged "a summary every 60 s", wrote a summary of "Title and intro" 60.0 s, then one of 34.9 s at the quit. - Before the rebase (fbd42024 and 6c9edffe), in the game on the same PC: - in a run that reached play (a new game into Kokiri Forest), the time split by map: "KokiriForest_Child (child)" 44.4 s, and the intro 178.2 s; - a save continued in Hyrule Field, 3 sessions of 4-5 minutes, sent and shown on the dashboard's map × graphics card panels; - the intro's movie counted: 1506 pictures shown, 107 dropped, 29 late; - with the tick taken off during play, the game logs "performance statistics off" and writes nothing more. **Not tested:** - Windows in the game: this PC is Linux only. - "Preparing shaders" in a summary: the start-up screen's preparation presents no game frames, so the name shows only for a preparation behind play (an update). - A summary from a lost device, and the 5-minute summaries over a long session: longer runs on this PC were ended by the kernel's out-of-memory killer in Hyrule Field after 2-5 minutes (the game's own memory, about 6 GB there; the summary keeps a few kB a map). - A release's flag: CI doesn't write `source=` yet, so every summary is "not a release" for now, as in the crash report. **Must be tested:** - Windows 10/11, any GPU: put `send=1` in the game folder's `longshot_perf.ini` (or tick it in LongshotLauncher#74), play 10 minutes on 2 maps, close the window, then run `python -I nx2/perf_report.py <folder> --send`, expecting a summary in `perf_pending\` with those maps and the right GPU, driver, CPU and OS, then `perf_pending\` empty and the same summary in `perf_sent\` (by hand: request T-ULGD; paste the summary's top lines) - AMD and Intel GPUs, any OS: the same steps, expecting the summary's `gpu` and `driver` to name the card and its driver (for example `radv Mesa 25.2`) and its fps to match the game's FPS counter (by hand: request T-WNBH) - 32 GB of RAM or more: an hour over several maps with the tick on, then send, expecting a summary in `perf_pending/` every 5 minutes, each with the maps since the one before, and those maps on the dashboard's map × graphics card panels after sending (by hand: request T-AAC7) ## Risks **What could break:** with the tick on, each frame does a little more work (Measurements); a summary is written every 5 minutes, a few kB. With it off, the game reads one small file at its first frame and one load a frame. Privacy: a summary holds no paths, user name or ID, the log, saves, or anything from the game files; `docs/performance-statistics.md` lists what is sent. **Turning it off:** untick it (the launcher deletes `longshot_perf.ini`, what is waiting and the copies), or delete `longshot_perf.ini`; to stop all sending, remove `perf_reports` from `nx2/addresses.ini`; or revert. **Compatibility:** `MKWVK_API_VERSION` 22 → 23 (the renderer and the game are built together). Saves, `longshot_options.ini` and the caches don't change. A game folder gains `perf_pending/` and `perf_sent/` only with the tick on. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] `MKWVK_API_VERSION` bumped (`gpu/vk/vk_api.h`'s `MkwVkHost` or `MkwVkRenderer` changed). - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_015KgSKmeEEMir1hCDFZ8BmR
gab9281 force-pushed feat/perf-metrics from 88404d20bb
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 6s
PR description / Description follows the template (pull_request_target) Successful in 3s
to 6702528faf
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Third-party parts / As their notes say (pull_request) Successful in 6s
2026-11-13 15:03:07 +00:00
Compare
gab9281 force-pushed feat/perf-metrics from 910b654999
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Third-party parts / As their notes say (pull_request) Successful in 7s
to ac41919db9
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Third-party parts / As their notes say (pull_request) Successful in 7s
2026-11-13 15:27:56 +00:00
Compare
gab9281 force-pushed feat/perf-metrics from ac41919db9
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Third-party parts / As their notes say (pull_request) Successful in 7s
to 2c95213061
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
CI / Workflow lint (actionlint) (pull_request) Successful in 8s
Third-party parts / As their notes say (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Successful in 8s
2026-11-13 15:28:09 +00:00
Compare
gab9281 force-pushed feat/perf-metrics from 9e6c4c61ff
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 18s
CI / Workflow lint (actionlint) (pull_request) Successful in 31s
Third-party parts / As their notes say (pull_request) Successful in 38s
PR description / Description follows the template (pull_request_target) Successful in 27s
to edda0942ae
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 3s
2026-11-13 18:56:47 +00:00
Compare
gab9281 changed title from WIP: feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana to feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana 2026-11-13 18:57:08 +00:00
gab9281 force-pushed feat/perf-metrics from edda0942ae
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 3s
to 65c63546ca
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
2026-11-13 19:08:01 +00:00
Compare
gab9281 force-pushed feat/perf-metrics from 65c63546ca
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
to b271368d0b
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 6s
PR description / Description follows the template (pull_request_target) Successful in 3s
2026-11-13 19:08:14 +00:00
Compare
fix(perf): a hitch is a frame twice the usual, not every frame of a game held under its cap
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
e5d64b9d12
The summaries sent from a laptop held at about 19 fps in Hyrule Field under
the 60 cap counted 4,694 hitches in 5,269 frames: against the cap's 16.7 ms,
every 50 ms frame was one, and the dashboard showed 34,000 hitches an hour.
A hitch is now measured against the longer of the target and the recent
average frame (before this one); slow frames still show in the fps and the
frame-time histograms. The pacing miss keeps the cap's target.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015KgSKoUqUvce5UXG89NBgi
gab9281 force-pushed feat/perf-metrics from e5d64b9d12
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
to efa3bd239f
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 7s
CI / Conventional Commit title (pull_request) Successful in 6s
CI / Workflow lint (actionlint) (pull_request) Successful in 9s
Third-party parts / As their notes say (pull_request) Successful in 13s
2026-11-14 23:52:41 +00:00
Compare
gab9281 force-pushed feat/perf-metrics from efa3bd239f
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 7s
CI / Conventional Commit title (pull_request) Successful in 6s
CI / Workflow lint (actionlint) (pull_request) Successful in 9s
Third-party parts / As their notes say (pull_request) Successful in 13s
to 6a00da2a2e
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 6s
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 8s
Third-party parts / As their notes say (pull_request) Successful in 11s
2026-11-14 23:53:23 +00:00
Compare
fix(perf): nx2/addresses.ini the same as #141's: the crash addresses too, so the second to merge has no conflict
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 6s
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 8s
Third-party parts / As their notes say (pull_request) Successful in 13s
f79fe484df
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015KgSKmeEEMir1hCDFZ8BmR
docs(perf): the A/B on main 6c9edffe in tested configurations
All checks were successful
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 3s
7fe3e98170
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015KgSKmeEEMir1hCDFZ8BmR
gab9281 changed title from feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana to WIP: feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana 2026-11-15 01:05:03 +00:00
Author
Member

Back to WIP until it is tested end to end with the launcher: the tick in LongshotLauncher#74, a game run that writes the summaries, and the launcher sending them to Longshot-api's telemetry (now deployed at https://api.magicbean.gmatte.xyz/telemetry/perf; 3 summaries from this PR's A/B runs were taken and counted there). The new A/B on main 6c9edffe is in docs/tested-configurations.md (7fe3e981); the description follows.

Back to WIP until it is tested end to end with the launcher: the tick in LongshotLauncher#74, a game run that writes the summaries, and the launcher sending them to Longshot-api's telemetry (now deployed at https://api.magicbean.gmatte.xyz/telemetry/perf; 3 summaries from this PR's A/B runs were taken and counted there). The new A/B on main 6c9edffe is in docs/tested-configurations.md (7fe3e981); the description follows.
gab9281 force-pushed feat/perf-metrics from 7fe3e98170
All checks were successful
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 3s
to 9981a39acf
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 16s
CI / Conventional Commit title (pull_request) Successful in 15s
CI / Workflow lint (actionlint) (pull_request) Successful in 21s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 21s
Third-party parts / As their notes say (pull_request) Successful in 29s
2026-11-15 04:57:50 +00:00
Compare
docs(perf): the measured runs as files in docs/tested/, and the A/B on main e090cc48
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 11s
PR description / Description follows the template (pull_request_target) Successful in 5s
c70c0f88e5
Main froze the table in docs/tested-configurations.md: the six rows the rebase put
there move to files of their own, and the A/B on main e090cc48 (v3.0.0-rc.4) is
added the same way.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015KgSKmeEEMir1hCDFZ8BmR
Author
Member

Rebased on main e090cc48 (v3.0.0-rc.4) and tested end to end with LongshotLauncher#74 @ f7518c6, against the deployed telemetry service:

  • the launcher's tick wrote send=1; the game wrote a summary at each window close; the next start sent it (perf_sent/). Grafana: longshot_perf_reports_total{result="accepted"} 3 → 5, longshot_sessions_total for v3.0.0-rc.4-14-g9981a39a 2, with every hardware label right;
  • measured again on e090cc48 (Measurements): no cost that stands out from this PC's drift;
  • the measured runs moved out of the frozen table into docs/tested/ (c70c0f88), as main now asks;
  • Windows: the renderer and the changed host files build with llvm-mingw.

The description is rewritten to the current template.

Rebased on main e090cc48 (v3.0.0-rc.4) and tested end to end with LongshotLauncher#74 @ f7518c6, against the deployed telemetry service: - the launcher's tick wrote `send=1`; the game wrote a summary at each window close; the next start sent it (`perf_sent/`). Grafana: `longshot_perf_reports_total{result="accepted"}` 3 → 5, `longshot_sessions_total` for `v3.0.0-rc.4-14-g9981a39a` 2, with every hardware label right; - measured again on e090cc48 (Measurements): no cost that stands out from this PC's drift; - the measured runs moved out of the frozen table into `docs/tested/` (c70c0f88), as main now asks; - Windows: the renderer and the changed host files build with llvm-mingw. The description is rewritten to the current template.
Author
Member

Description: Must be tested items now say what to expect, with the test request beside each.

Description: Must be tested items now say what to expect, with the test request beside each.
gab9281 changed title from WIP: feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana to feat(perf): opt-in performance statistics, sent from the launcher to the team's Grafana 2026-11-15 05:30:26 +00:00
feat(perf): polite sending with switches, and copies of what was sent made optional
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
CI / Workflow lint (actionlint) (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 6s
Third-party parts / As their notes say (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Successful in 4s
a401573b2b
The sender (nx2/perf_report.py) sends the waiting summaries over one kept
connection (one TLS handshake for them all; through a system proxy, one request
each, as before), at most LONGSHOT_PERF_MAX_SENDS (12) a start, and leaves a busy
relay alone: until its Retry-After, else an hour doubled each time it is busy
again, up to a day (perf_pending/.next; LONGSHOT_PERF_BACKOFF=off asks it at
every start). A kept connection the relay let go is tried once more on a new
one: the summary never arrived, so none is sent twice.

- LONGSHOT_PERF_TIMEOUT (10 s, 2 to 60), LONGSHOT_PERF_URL (https, or http to
  this PC for a local relay), each clamped or defaulted with a word on stderr.
- Copies of what was sent: --tick on --keep-sent off writes keep_sent=0 (the
  launcher's Keep a copy of what was sent, LongshotLauncher#74), which keeps no
  copies and deletes those kept; LONGSHOT_PERF_KEEP_SENT overrides it.
- The game: RX_VK_PERF_INTERVAL, the seconds between summaries (300; 60 to 840,
  a minute under the relay's 900 s for the frame that ends a summary).
- docs/performance-statistics.md's Switches; the interval in development.md.
- tests: one connection, a dropped one, the share a start, Retry-After and the
  doubling, the copies and their switches, LONGSHOT_PERF_URL; the interval's
  rule in tests/test_perf_report.cpp.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015KgSKmeEEMir1hCDFZ8BmR
Author
Member

a401573b: polite sending. One kept connection for every waiting summary (5 sent over 1 TLS connection to the deployed service), at most 12 a start, and a busy service left alone until its Retry-After or an hour doubling to a day. Switches with those defaults: LONGSHOT_PERF_MAX_SENDS, _TIMEOUT, _BACKOFF, _KEEP_SENT, _URL, and the game's RX_VK_PERF_INTERVAL (60 to 840 s, checked in the game at 60). Copies of what was sent are optional: --keep-sent off / keep_sent=0, the launcher's Keep a copy of what was sent (LongshotLauncher#74 d807edd, tested end to end). run_all as before (564 passed, the same 14 that fail on main); the renderer builds for Linux and Windows.

a401573b: polite sending. One kept connection for every waiting summary (5 sent over 1 TLS connection to the deployed service), at most 12 a start, and a busy service left alone until its Retry-After or an hour doubling to a day. Switches with those defaults: LONGSHOT_PERF_MAX_SENDS, _TIMEOUT, _BACKOFF, _KEEP_SENT, _URL, and the game's RX_VK_PERF_INTERVAL (60 to 840 s, checked in the game at 60). Copies of what was sent are optional: --keep-sent off / keep_sent=0, the launcher's Keep a copy of what was sent (LongshotLauncher#74 d807edd, tested end to end). run_all as before (564 passed, the same 14 that fail on main); the renderer builds for Linux and Windows.
gab9281 force-pushed feat/perf-metrics from a401573b2b
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
CI / Workflow lint (actionlint) (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 6s
Third-party parts / As their notes say (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Successful in 4s
to 962c5aad37
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 7s
Third-party parts / As their notes say (pull_request) Successful in 9s
2026-11-15 18:37:56 +00:00
Compare
gab9281 force-pushed feat/perf-metrics from 962c5aad37
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 7s
Third-party parts / As their notes say (pull_request) Successful in 9s
to 13e858af3a
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 4s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
2026-11-15 19:38:17 +00:00
Compare
HumanBean left a comment

Code review only (no tests run). Read the whole diff and every PR comment, including the end-to-end and test-request results. The game side is careful: API version bumped (22 to 23), perf_info appended last and null-checked, no ID or path in the summary, off by default, opt-in read from longshot_perf.ini, Windows paths wide via game_dir_path(), locking is sound (mu is never held across a call that can reach device_lost, at_exit only try-locks, summarize(true) on close/device-lost). Nothing I'd block on; a few things worth deciding before merge:

  1. Sender deletes summaries on responses that aren't the service saying no (nx2/perf_report.py answer()): every non-2xx other than 429/5xx is "refused" and the file is deleted. A 404 from Traefik while Longshot-api is redeployed or its route is missing, a 3xx (the Relay does not follow redirects, urllib does only in the proxied path), 408 or 425 would silently drop up to 12 summaries per start. Suggest treating 3xx, 404, 408, 425 as "later" (keep, no backoff or the backoff path), and keeping "refused" for 400/413/415/422.

  2. Two senders can overlap (start_sending): each launcher start spawns a detached --send; if the previous one is still on its 10 s timeout (or a slow link) a second reads the same perf_pending/ and posts the same summaries, which the service then counts twice (the docs rely on 'deleted after'). A lock file (O_EXCL perf_pending/.sending, stale after a few minutes) would make that safe; the relay has no dedupe because summaries carry no ID.

  3. Hot-path cost is described as smaller than it is (docs/performance-statistics.md 'a few array increments', PR 'add_frame 6-16 ns'). Per frame with the tick on, perf_frame also takes mu, copies prof_ns, reads two atomics, and calls menu_target_ms() -> fps_target_ms() -> menu_vsync() + display_refresh_mhz(); and host->fps_timing(1) makes the host clock its sleeps. All probably sub-microsecond, but the A/B on that PC can't resolve it (main alone spread 15 fps, PR 'off' 2% behind main, 'on' about equal to 'off'). That the PR is honest about the noise is good; I'd either say 'sub-microsecond, not resolved by the runs' instead of 'a few array increments', or cache the target (it only changes with menu/display changes) in perf_frame. The test-request runs on a quieter PC will settle it.

  4. Minor: the 5-minute summarize(false) runs on the presenting thread (reads longshot_perf.ini, where_now, vram_usage_now, /proc/self/statm, builds the JSON, spawns a thread). One slightly longer frame per period, and that frame's time lands in the next frame's histogram, possibly as one hitch (other). Harmless, but the JSON build could move into the writer thread by copying maps instead.

  5. Nit: in vk_menu.cpp the new fps_cap_now() and its comment were inserted between fps_target_ms()'s doc comment and the function, so fps_target_ms() lost its doc and fps_cap_now() has two stacked ones.

  6. Question: perf_reports in nx2/addresses.ini points at api.magicbean.gmatte.xyz, the same host as the crash reports (agreed in #141, I assume). Players' summaries go there with their IP visible to whoever runs it; worth the privacy page saying who operates it (it says 'Bean-Ops') and that the server logs/retention are the team's, since 'no ID' is claimed.

Otherwise: the 'Must be tested' items (Windows, AMD/Intel, 32 GB RAM) are requested with test IDs, which is right for what this PC can't run.

Nit ( near line 2828): fps_cap_now() now sits between fps_target_ms()'s doc comment (above, 2824) and the function: the target lost its doc and this has two. Move the new function above that comment.

Code review only (no tests run). Read the whole diff and every PR comment, including the end-to-end and test-request results. The game side is careful: API version bumped (22 to 23), `perf_info` appended last and null-checked, no ID or path in the summary, off by default, opt-in read from `longshot_perf.ini`, Windows paths wide via `game_dir_path()`, locking is sound (`mu` is never held across a call that can reach `device_lost`, `at_exit` only try-locks, `summarize(true)` on close/device-lost). Nothing I'd block on; a few things worth deciding before merge: 1. **Sender deletes summaries on responses that aren't the service saying no** (`nx2/perf_report.py` `answer()`): every non-2xx other than 429/5xx is "refused" and the file is deleted. A 404 from Traefik while Longshot-api is redeployed or its route is missing, a 3xx (the Relay does not follow redirects, urllib does only in the proxied path), 408 or 425 would silently drop up to 12 summaries per start. Suggest treating 3xx, 404, 408, 425 as "later" (keep, no backoff or the backoff path), and keeping "refused" for 400/413/415/422. 2. **Two senders can overlap** (`start_sending`): each launcher start spawns a detached `--send`; if the previous one is still on its 10 s timeout (or a slow link) a second reads the same `perf_pending/` and posts the same summaries, which the service then counts twice (the docs rely on 'deleted after'). A lock file (O_EXCL `perf_pending/.sending`, stale after a few minutes) would make that safe; the relay has no dedupe because summaries carry no ID. 3. **Hot-path cost is described as smaller than it is** (docs/performance-statistics.md 'a few array increments', PR 'add_frame 6-16 ns'). Per frame with the tick on, `perf_frame` also takes `mu`, copies `prof_ns`, reads two atomics, and calls `menu_target_ms()` -> `fps_target_ms()` -> `menu_vsync()` + `display_refresh_mhz()`; and `host->fps_timing(1)` makes the host clock its sleeps. All probably sub-microsecond, but the A/B on that PC can't resolve it (main alone spread 15 fps, PR 'off' 2% behind main, 'on' about equal to 'off'). That the PR is honest about the noise is good; I'd either say 'sub-microsecond, not resolved by the runs' instead of 'a few array increments', or cache the target (it only changes with menu/display changes) in `perf_frame`. The test-request runs on a quieter PC will settle it. 4. Minor: the 5-minute `summarize(false)` runs on the presenting thread (reads `longshot_perf.ini`, `where_now`, `vram_usage_now`, `/proc/self/statm`, builds the JSON, spawns a thread). One slightly longer frame per period, and that frame's time lands in the next frame's histogram, possibly as one hitch (`other`). Harmless, but the JSON build could move into the writer thread by copying `maps` instead. 5. Nit: in `vk_menu.cpp` the new `fps_cap_now()` and its comment were inserted between `fps_target_ms()`'s doc comment and the function, so `fps_target_ms()` lost its doc and `fps_cap_now()` has two stacked ones. 6. Question: `perf_reports` in `nx2/addresses.ini` points at `api.magicbean.gmatte.xyz`, the same host as the crash reports (agreed in #141, I assume). Players' summaries go there with their IP visible to whoever runs it; worth the privacy page saying who operates it (it says 'Bean-Ops') and that the server logs/retention are the team's, since 'no ID' is claimed. Otherwise: the 'Must be tested' items (Windows, AMD/Intel, 32 GB RAM) are requested with test IDs, which is right for what this PC can't run. **Nit ( near line 2828):** `fps_cap_now()` now sits between `fps_target_ms()`'s doc comment (above, 2824) and the function: the target lost its doc and this has two. Move the new function above that comment.
@ -0,0 +47,4 @@
- **The game** (`gpu/vk/perf_report.cpp`, `perf_report.h`):
- `perf_report_init()` reads `longshot_perf.ini` at the first frame. Off, nothing else runs.
- On, the FPS counter (`vk_fps.cpp`) times every frame's parts as its Breakdown does and hands each frame to
`perf_frame()`, which adds it to the current map's totals (a few array increments).
Owner

'a few array increments' understates it (mutex, prof_ns copy, target lookup, the host timing its sleeps): say 'sub-microsecond a frame, not resolved by the A/B runs'.

'a few array increments' understates it (mutex, prof_ns copy, target lookup, the host timing its sleeps): say 'sub-microsecond a frame, not resolved by the A/B runs'.
@ -0,0 +283,4 @@
// average, before this frame: a frame twice the usual, never every frame of a game the GPU holds under its cap)
const double usual = avg_ms ? avg_ms : f.ms;
avg_ms = usual * 0.98 + f.ms * 0.02;
const double cap_ms = menu_target_ms();
Owner

Per frame this goes through fps_target_ms() (menu_vsync, display_refresh_mhz) and the mu lock above, so the docs' 'a few array increments' is generous. Likely negligible, but the target only changes with the menu or display: could be cached and refreshed with since_map.

Per frame this goes through `fps_target_ms()` (menu_vsync, display_refresh_mhz) and the `mu` lock above, so the docs' 'a few array increments' is generous. Likely negligible, but the target only changes with the menu or display: could be cached and refreshed with `since_map`.
@ -0,0 +288,4 @@
pr::add_frame(*current, f, w, target, last_ms, usual);
last_ms = f.ms;
since_map += f.ms / 1000.0, since_summary += f.ms / 1000.0;
if (since_summary >= period) summarize(false), since_summary = 0;
Owner

The summary (ticked() file read, where_now, vram_usage_now, statm, JSON build) is made on the presenting thread inside mu. Fine once per 5 minutes, but copying maps and building the JSON in the writer thread would keep that frame clean.

The summary (ticked() file read, where_now, vram_usage_now, statm, JSON build) is made on the presenting thread inside `mu`. Fine once per 5 minutes, but copying `maps` and building the JSON in the writer thread would keep that frame clean.
@ -0,0 +406,4 @@
pass
def start_sending(folder, python=None, python_args=()):
Owner

Nothing stops a second --send from starting while the first is still running (a 10 s timeout, or a slow link, outlasts a quick relaunch): both read the same perf_pending/ and post the same files, which the service counts twice. An O_EXCL lock file in perf_pending/ (ignored once a few minutes old) would do.

Nothing stops a second `--send` from starting while the first is still running (a 10 s timeout, or a slow link, outlasts a quick relaunch): both read the same `perf_pending/` and post the same files, which the service counts twice. An O_EXCL lock file in `perf_pending/` (ignored once a few minutes old) would do.
@ -0,0 +200,4 @@
return "sent", None
if code == 429 or code >= 500:
return "busy", wait_of(retry_after)
return "refused", None
Owner

Everything that is not 2xx/429/5xx comes back 'refused' and the summary is deleted. A 404 during a redeploy (no Traefik route), a 3xx, 408 or 425 would drop it for good. Keep those for next time ('later'), delete only on 400/413/415/422-style answers.

Everything that is not 2xx/429/5xx comes back 'refused' and the summary is deleted. A 404 during a redeploy (no Traefik route), a 3xx, 408 or 425 would drop it for good. Keep those for next time ('later'), delete only on 400/413/415/422-style answers.
fix(perf): statistics go to data-services.magicbean.dev, the telemetry service's new address
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 8s
96bd681161
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 8s
This pull request has changes conflicting with the target branch.
  • docs/development.md
  • gpu/vk/vk_api.h
  • gpu/vk/vk_dlss.cpp
  • gpu/vk/vk_main.cpp
  • gpu/vk/vk_menu.cpp
  • gpu/vk/vk_shader.cpp
  • host/rx_backend.c
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/perf-metrics:gab9281-feat/perf-metrics'
git switch 'gab9281-feat/perf-metrics'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!206
No description provided.