MagicBeanDev/LongshotLauncher

Watch

Fork 22

fix(screenshots): set GpuCards, now that LauncherService.Gpus is read-only #99

Closed

drcrow wants to merge 1 commit from drcrow/LongshotLauncher:fix/screenshots-gpucards into main

drcrow commented

2026-11-15 13:15:11 +00:00

Member

Why

main doesn't build: the screenshots tool (#85) still assigns LauncherService.Gpus, which #87 made read-only (it now derives from GpuCards). dotnet build LongshotLauncher.slnx fails with CS0200 in tools/screenshots/Program.cs (lines 44, 47, 49).

What changed

fix(screenshots): the three scenes set GpuCards = [new Gpu(...)] instead of Gpus.

Testing

dotnet build LongshotLauncher.slnx (.NET 10.0.404): 0 errors, 0 warnings. Found while rebasing #65; CircleCI's first main build would fail without it, so this should merge before #65.

## Why `main` doesn't build: the screenshots tool (#85) still assigns `LauncherService.Gpus`, which #87 made read-only (it now derives from `GpuCards`). `dotnet build LongshotLauncher.slnx` fails with CS0200 in `tools/screenshots/Program.cs` (lines 44, 47, 49). ## What changed - fix(screenshots): the three scenes set `GpuCards = [new Gpu(...)]` instead of `Gpus`. ## Testing `dotnet build LongshotLauncher.slnx` (.NET 10.0.404): 0 errors, 0 warnings. Found while rebasing #65; CircleCI's first main build would fail without it, so this should merge before #65.

drcrow added 1 commit

2026-11-15 13:15:11 +00:00

fix(screenshots): set GpuCards, now that LauncherService.Gpus is read-only

CI / Compile and test (pull_request) Has been skipped

Details

CI / Conventional Commit title (pull_request) Successful in 3s

Details

840564ad0c

The screenshots tool (#85) still assigned Gpus, which #87 made read-only, so the solution no longer builds on main.

circleci-bot scheduled this pull request to auto merge when all checks succeed

2026-11-15 13:26:05 +00:00

circleci-bot canceled auto merging this pull request when all checks succeed

2026-11-15 13:36:11 +00:00

mooki approved these changes

2026-11-15 13:39:02 +00:00

HumanBean commented

2026-11-15 17:49:13 +00:00

Owner

Thanks for this! The same fix landed on main in the meantime: #93 switched these scenes to GpuCards = [new Gpu(...)], and #97's Intel scenes build on it. Rebased onto main, this PR comes out empty, so I'm closing it as already fixed.

Thanks for this! The same fix landed on main in the meantime: #93 switched these scenes to `GpuCards = [new Gpu(...)]`, and #97's Intel scenes build on it. Rebased onto main, this PR comes out empty, so I'm closing it as already fixed.

HumanBean closed this pull request

2026-11-15 17:49:13 +00:00

CI / Compile and test (pull_request) Has been skipped

Details

CI / Conventional Commit title (pull_request) Successful in 3s

Details

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/LongshotLauncher!99

No description provided.

Rows
Columns