docs(release): the build tools are generic packages, not a tools release #6
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/ui
area/updates
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!6
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/tools-packages-wording"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
scripts/release.pyand two comments inCore/still mention a "tools" release, but the build tools are generic packages now. Longshot's setup also gets a fix for installing thethird-partytool into the builder zip'stools/third_party, and the shareddocs/releases.mdneeds the same edit here so the two copies stay identical.What changed
scripts/release.py's docstrings (channel_of,prune) no longer mention the tools release, and the unusedTOOLS_TAGconstant is gone. The file is byte-identical with Longshot's on its PR: MagicBeanDev/Longshot#117 (MagicBeanDev/Longshot#117).ReleaseManifestandToolsLocksay the build tools are generic packages. The first URL is Longshot's package; the others are where the archive came from.docs/releases.md, "Installing": a tool merges, file by file, into a<dest>the builder already has (the Windows zip'sLongshotBuilder/tools/third_party). A file both sides have is refused. The file is identical with Longshot's.tests/launcher_core/ScreenChecks.cs, the Windows install check's zip now hasLongshotBuilder/tools/third_party/a64-kit/lift/a64emit.cpp, and its tools.lock has athird-partytool (a64emit.dll,SDL3.dll). The check verifies that the tool's files land among the zip's sources, on the first install and when the next version keeps the tool, without a second download.The launcher needed no code change.
Toolchains.Unpackwrites each file withFileMode.CreateNewinto the staging folder, so the tool's files go among the zip's and a file both sides have stops the install.Reuselinks or copies a tool by its own recorded files, never by its whole folder.Testing
python -I tests/test_launcher_core.py, two runs each on main and on this branch, alternating: main 524 checks passed (both runs), this branch 526 checks passed (both runs).python -I tests/test_release.py: OK on both, two runs each.cmp scripts/release.pyandcmp docs/releases.mdagainst Longshot's branch: identical.RELEASING.mdhas no "tools release" wording left, and is identical in both repositories.