fix: accurate disk space and drive name on Linux, through links #29
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/ui
area/updates
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!29
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/disk-space-drive-name"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On Linux, a build folder reached through a link was measured on the wrong drive. On Bazzite
/homeis a link to/var/home, so the launcher reported 0 GB free and wouldn't build. This carries korbo's fix from #27 and fixes the drive name the settings step shows next to it.What changed
Core/Disk.cs(korbo's commit): on Linux,FreeBytesasks the folder's own filesystem (new DriveInfo(dir)), which follows links.Core/Disk.cs(this PR's commit):DriveNamestill named the mount by the path as written. So on Bazzite the settings step said "N GB free on /" or "/ is too full for the build" while measuring/var.FreeBytesandDriveNamenow share one step,Existing(): the nearest folder that exists, with every link along the path followed (Real(), as realpath does).tests/launcher_core/ScreenChecks.cs:/proc:/procalways reports 0 bytes free, so a check that didn't follow the link would see the test folder's drive instead.DriveNamenames/procthrough the link.Testing
python -I tests/test_launcher_core.pyon Linux (CachyOS): 607 checks pass.DriveNamechange taken out, the new check fails ("A linked folder is named by the drive its free space is measured on.").python -I tests/test_release.py: OK.Co-authored-by: korbo
🤖 Generated with Claude Code