test(checks): the cache contract reads Longshot's scripts/devtools/packs.py, and the launcher carries its two new caches #238
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!238
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/ci-devtools-packs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
"Compile and test" has failed on every push to
mainsince Longshot#1802 movedscripts/dev_packs.pytoscripts/devtools/packs.py: the core tests stop at the missing file, so nothing on main has been checked since, and the next stable can't be cut on a green main.Summary
tests/test_launcher_core.pyreads Longshot's cache list fromscripts/devtools/packs.py(itsCACHESandPLAY_FILESare unchanged in form).Core/ShaderCaches.cs: Longshot'sCACHESgained two files since the launcher last matched it, andNamesnow lists them, in its order:longshot_vk_pipelines.base(Longshot#1927), which the launcher already knew as aNewercache "into Names once the pin has them";Newergoes.longshot_textures_drawn.bin(Longshot#1122, the textures a draw sampled, forRX_VK_TEX_AHEAD).So both are carried to a new build with the other caches, as Longshot's own packs copy them.
Testing
python3 -I -B tests/test_launcher_core.py --strict --longshot <Longshot main @ origin/main, from git archive>, as CI runs it: 2656 checks passed (before the change:FileNotFoundError: .../scripts/dev_packs.py, then theNamesmismatch).Risks
longshot_vk_pipelines.baseandlongshot_textures_drawn.binwhen they exist; an older Longshot ignores files it doesn't know.🤖 Generated with Claude Code