fix(saves): no Longshot version has the save editor yet, and the Saves page no longer says a newer one has it #230
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!230
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/save-editor-note"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Saves page tells players "This version has no save editor yet. A newer version has it." when Progress is off, but no Longshot version has the save editor yet, so players who are up to date go looking for an update that does not exist (#217). This makes the note say what is true and what to do.
Fixes #217
Summary
scripts/longshot_save_editor.pyfrom the default build's own tools (SaveEditing.Find,Core/SaveEditor.cs:155). That script is Longshot#1401, still open: it is in no Longshot tag, stable (up to v3.0.0, v3.0.1-rc.3) or nightly, and not on Longshot's main. So every player getsSaveEditorWhy.NoEditor, andSaveEditing.Say(Core/SaveEditor.cs:175) answered it with "A newer version has it". The decision itself is right (the editor must be the build's own version's, as the checks already require); the words were wrong. The reporter's screenshot is launcher v1.0.0 on an up-to-date build.docs/saves.md: "What it needs" says no release has the editor yet and links Longshot#1401.tests/launcher_core/SaveEditorChecks.cs: a new check that the no-editor note does not say a newer version has it, names the version up to which none has, and says to update Longshot; the old check's label no longer claims a newer version has it.Testing
Linux (CachyOS), .NET 10, no game, no save:
python -I tests/test_launcher_core.py: 2600 checks passed, build 0 warnings.LAUNCHER=$PWD python -I ../Tooling/tests/test_release.py(Tooling at.tooling-rev0b0059a): 42 tests, 3 failures (Bump.test_the_bump,Bump.test_the_next_stable,Publish.test_check_tag_against_the_published_releases), the same 3 on unchanged main in the same checkout: they depend on the local tags, not this change.tools/screenshots(saves-progress-off), screenshot in the first comment.🤖 Generated with Claude Code
The Saves page with the new note (drawn by tools/screenshots, scene saves-progress-off; no real save):