fix(saves): no Longshot version has the save editor yet, and the Saves page no longer says a newer one has it #230

Merged
HumanBean merged 1 commit from HumanBean/LongshotLauncher:fix/save-editor-note into main 2026-11-21 19:15:13 +00:00
Owner

The Saves page tells players "This version has no save editor yet. A newer version has it." when Progress is off, but no Longshot version has the save editor yet, so players who are up to date go looking for an update that does not exist (#217). This makes the note say what is true and what to do.

Fixes #217

Summary

  • Cause. Progress runs Longshot's scripts/longshot_save_editor.py from the default build's own tools (SaveEditing.Find, Core/SaveEditor.cs:155). That script is Longshot#1401, still open: it is in no Longshot tag, stable (up to v3.0.0, v3.0.1-rc.3) or nightly, and not on Longshot's main. So every player gets SaveEditorWhy.NoEditor, and SaveEditing.Say (Core/SaveEditor.cs:175) answered it with "A newer version has it". The decision itself is right (the editor must be the build's own version's, as the checks already require); the words were wrong. The reporter's screenshot is launcher v1.0.0 on an up-to-date build.
  • What changes. The note now reads: "Progress needs Longshot's save editor, and this Longshot version has none: no version up to 3.0.0 has it. Once a Longshot update brings it, update Longshot and Progress turns on by itself." A comment beside it says to move the version on (or name the version that has it) when a release follows. No new behaviour; the text is not in any language catalog yet, so no translation changes.
  • docs/saves.md: "What it needs" says no release has the editor yet and links Longshot#1401.
  • tests/launcher_core/SaveEditorChecks.cs: a new check that the no-editor note does not say a newer version has it, names the version up to which none has, and says to update Longshot; the old check's label no longer claims a newer version has it.

Testing

Linux (CachyOS), .NET 10, no game, no save:

  • python -I tests/test_launcher_core.py: 2600 checks passed, build 0 warnings.
  • LAUNCHER=$PWD python -I ../Tooling/tests/test_release.py (Tooling at .tooling-rev 0b0059a): 42 tests, 3 failures (Bump.test_the_bump, Bump.test_the_next_stable, Publish.test_check_tag_against_the_published_releases), the same 3 on unchanged main in the same checkout: they depend on the local tags, not this change.
  • The Saves page drawn by tools/screenshots (saves-progress-off), screenshot in the first comment.

🤖 Generated with Claude Code

The Saves page tells players "This version has no save editor yet. A newer version has it." when Progress is off, but no Longshot version has the save editor yet, so players who are up to date go looking for an update that does not exist (#217). This makes the note say what is true and what to do. Fixes #217 ## Summary - **Cause.** Progress runs Longshot's `scripts/longshot_save_editor.py` from the default build's own tools (`SaveEditing.Find`, `Core/SaveEditor.cs:155`). That script is [Longshot#1401](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1401), still open: it is in no Longshot tag, stable (up to v3.0.0, v3.0.1-rc.3) or nightly, and not on Longshot's main. So every player gets `SaveEditorWhy.NoEditor`, and `SaveEditing.Say` (`Core/SaveEditor.cs:175`) answered it with "A newer version has it". The decision itself is right (the editor must be the build's own version's, as the checks already require); the words were wrong. The reporter's screenshot is launcher v1.0.0 on an up-to-date build. - **What changes.** The note now reads: "Progress needs Longshot's save editor, and this Longshot version has none: no version up to 3.0.0 has it. Once a Longshot update brings it, update Longshot and Progress turns on by itself." A comment beside it says to move the version on (or name the version that has it) when a release follows. No new behaviour; the text is not in any language catalog yet, so no translation changes. - `docs/saves.md`: "What it needs" says no release has the editor yet and links Longshot#1401. - `tests/launcher_core/SaveEditorChecks.cs`: a new check that the no-editor note does not say a newer version has it, names the version up to which none has, and says to update Longshot; the old check's label no longer claims a newer version has it. ## Testing Linux (CachyOS), .NET 10, no game, no save: - `python -I tests/test_launcher_core.py`: 2600 checks passed, build 0 warnings. - `LAUNCHER=$PWD python -I ../Tooling/tests/test_release.py` (Tooling at `.tooling-rev` 0b0059a): 42 tests, 3 failures (`Bump.test_the_bump`, `Bump.test_the_next_stable`, `Publish.test_check_tag_against_the_published_releases`), the same 3 on unchanged main in the same checkout: they depend on the local tags, not this change. - The Saves page drawn by `tools/screenshots` (`saves-progress-off`), screenshot in the first comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(saves): no Longshot version has the save editor yet, and the Saves page no longer says a newer one has it
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 20s
e590222887
The Saves page told every player "A newer version has it" when the default
build's tools lack scripts/longshot_save_editor.py. No Longshot release has
the editor (it is Longshot#1401, still open), so up-to-date players went
looking for an update that does not exist (#217). The note now says no
version up to 3.0.0 has it and to update Longshot once one brings it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Owner

The Saves page with the new note (drawn by tools/screenshots, scene saves-progress-off; no real save):

saves-progress-off.png

The Saves page with the new note (drawn by tools/screenshots, scene saves-progress-off; no real save): ![saves-progress-off.png](https://git.magicbean.dev/attachments/75087770-6d02-41c4-970e-32752e763be9)
HumanBean deleted branch fix/save-editor-note 2026-11-21 19:15:14 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!230
No description provided.