test(checks): the suite on main runs green again #225

Open
omgitsgela wants to merge 2 commits from omgitsgela/LongshotLauncher:fix/main-suite-red into main
Member

Why this is needed

Main's own suite aborts at its first check, so no pull request can show a green "Compile and test" run right now. On main as it is, tests/test_launcher_core.py stops at UnlistedChecks.cs:45, and SavesChecks and BuildReportChecks fail after it. Three main-side changes left these checks behind: #208 (no more release candidates), #211 (saves in the game's user/), #164 (the shared scrubbing rule).

What it does

  • Leftovers.Find: a folder whose stamp names something that is not a version — an old release candidate, dev — is on no channel, and #208 says an old rc is "never offered". It was offered anyway (an unknown version falls to the stable track). The scan now offers a folder whose stamp names a release or a nightly, or none at all (a build that stopped before its first finish, offered by its folder's name).
  • UnlistedChecks: expects stable (2) v3.0.3 offered, with the rc and dev folders not offered.
  • LeftoverChecks: the folder the player kept is a stable (v3.0.1), since a release candidate is no longer a version.
  • SavesChecks: after #211 a game's saves live in its own user/, and an import lands in the game's own profile folder (Saves.UserId); the check compared it with the fixture's profile id. It now expects the game's.
  • BuildReportChecks: #164's scrubbing takes a home folder out where a path starts it, not inside a longer word, so the over-long test line puts the home after a space — the shape a real log line has (reading /home/ana/x).

The review's points, folded in

  • The outer and user-mod fixtures stamped a version that is not a version, so the new filter excluded them before their containment and mods protections were reached — the checks had gone vacuous. They keep their folder names and get real versions.
  • The over-long log line uses 285 characters of filler, not 290, so the 300-byte cut falls inside the home folder rather than just before it: a scrub-after-cut reversal now leaves part of the name where the check can see it.
  • An old release candidate is asserted absent from Find and present in All, so Storage still lists it while the home offers it to nothing.

What was checked

launcher core: 2502 checks passed on this branch, which is main plus these changes and nothing else.

Not in this PR

Nothing about any feature. Three of the four checks test behaviour the earlier pull requests changed; the fourth (Leftovers.Find) is the one line of production code involved, and it is what #208's own description says should happen.

## Why this is needed Main's own suite aborts at its first check, so **no pull request can show a green "Compile and test" run** right now. On `main` as it is, `tests/test_launcher_core.py` stops at `UnlistedChecks.cs:45`, and `SavesChecks` and `BuildReportChecks` fail after it. Three main-side changes left these checks behind: #208 (no more release candidates), #211 (saves in the game's `user/`), #164 (the shared scrubbing rule). ## What it does - **`Leftovers.Find`**: a folder whose stamp names something that is not a version — an old release candidate, `dev` — is on no channel, and #208 says an old rc is "never offered". It was offered anyway (an unknown version falls to the stable track). The scan now offers a folder whose stamp names a release or a nightly, or none at all (a build that stopped before its first finish, offered by its folder's name). - **`UnlistedChecks`**: expects `stable (2) v3.0.3` offered, with the rc and `dev` folders not offered. - **`LeftoverChecks`**: the folder the player kept is a stable (`v3.0.1`), since a release candidate is no longer a version. - **`SavesChecks`**: after #211 a game's saves live in its own `user/`, and an import lands in the game's own profile folder (`Saves.UserId`); the check compared it with the fixture's profile id. It now expects the game's. - **`BuildReportChecks`**: #164's scrubbing takes a home folder out where a path starts it, not inside a longer word, so the over-long test line puts the home after a space — the shape a real log line has (`reading /home/ana/x`). ## The review's points, folded in - The `outer` and `user-mod` fixtures stamped a version that is not a version, so the new filter excluded them before their containment and mods protections were reached — the checks had gone vacuous. They keep their folder names and get real versions. - The over-long log line uses 285 characters of filler, not 290, so the 300-byte cut falls inside the home folder rather than just before it: a scrub-after-cut reversal now leaves part of the name where the check can see it. - An old release candidate is asserted absent from `Find` and present in `All`, so Storage still lists it while the home offers it to nothing. ## What was checked `launcher core: 2502 checks passed` on this branch, which is main plus these changes and nothing else. ## Not in this PR Nothing about any feature. Three of the four checks test behaviour the earlier pull requests changed; the fourth (`Leftovers.Find`) is the one line of production code involved, and it is what #208's own description says should happen.
test(checks): the suite on main runs green again
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
e8cb56e003
Main's suite aborts at its first check, so no pull request can show a green
"Compile and test" run: the launcher core checks stop at UnlistedChecks today,
and the next two groups fail after that. Three main-side changes left them
behind; none of the checks below was touched by the pull request that changed
the behaviour.

- #208 made release candidates no longer a version: an old rc "is on no
  channel and never offered". Leftovers.Find still offered them (and a stamp
  naming "dev"), because a version that is not a version falls to the stable
  track. It now offers a folder whose stamp names something on a channel —
  a release or a nightly — or no stamp at all (a first build that stopped,
  offered by its folder's name). UnlistedChecks expects exactly that, and
  LeftoverChecks uses a stable, not an rc, for the folder the player kept.
- #196 moved a game's saves into its own user/ folder and made an import land
  in the game's own profile folder (Saves.UserId). SavesChecks compared the
  import target with the fixture's profile id; it now expects the game's.
- #164's scrub takes a home folder out where a path starts it (not inside a
  longer word), so BuildReportChecks' 300-byte line puts the home after a
  space, the shape a real log line has ("reading /home/ana/x").

launcher core: 2501 checks passed (all of them, on main as it is).

Assisted-by: Hermes Agent
test(checks): the review's points: real versions, a cut inside the home, an old rc in Storage
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
7a43136194
- LeftoverChecks: the fixtures for "a folder holding a build" and "mods under user"
  stamped versions that are not versions ("outer", "user-mod"), which the new
  channel filter now excludes on its own — their assertions had gone vacuous.
  Both keep their folder names and get real versions (v3.0.2, v3.0.3).
- BuildReportChecks: 285 characters of filler, not 290, so the 300-byte cut falls
  INSIDE the home folder ("/home/ana" on Linux, "C:\Users\Ana" on Windows): a
  scrub-after-cut reversal now leaves part of the name and the check sees it.
- LeftoverChecks: an old release candidate is asserted absent from Find and
  present in All, so Storage still lists it while the home offers it to nothing.

launcher core: 2502 checks passed.

Assisted-by: Hermes Agent
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/main-suite-red:omgitsgela-fix/main-suite-red'
git switch 'omgitsgela-fix/main-suite-red'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!225
No description provided.