test(checks): the suite on main runs green again #225
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!225
Loading…
Reference in a new issue
No description provided.
Delete branch "omgitsgela/LongshotLauncher:fix/main-suite-red"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why this is needed
Main's own suite aborts at its first check, so no pull request can show a green "Compile and test" run right now. On
mainas it is,tests/test_launcher_core.pystops atUnlistedChecks.cs:45, andSavesChecksandBuildReportChecksfail after it. Three main-side changes left these checks behind: #208 (no more release candidates), #211 (saves in the game'suser/), #164 (the shared scrubbing rule).What it does
Leftovers.Find: a folder whose stamp names something that is not a version — an old release candidate,dev— is on no channel, and #208 says an old rc is "never offered". It was offered anyway (an unknown version falls to the stable track). The scan now offers a folder whose stamp names a release or a nightly, or none at all (a build that stopped before its first finish, offered by its folder's name).UnlistedChecks: expectsstable (2) v3.0.3offered, with the rc anddevfolders not offered.LeftoverChecks: the folder the player kept is a stable (v3.0.1), since a release candidate is no longer a version.SavesChecks: after #211 a game's saves live in its ownuser/, and an import lands in the game's own profile folder (Saves.UserId); the check compared it with the fixture's profile id. It now expects the game's.BuildReportChecks: #164's scrubbing takes a home folder out where a path starts it, not inside a longer word, so the over-long test line puts the home after a space — the shape a real log line has (reading /home/ana/x).The review's points, folded in
outeranduser-modfixtures stamped a version that is not a version, so the new filter excluded them before their containment and mods protections were reached — the checks had gone vacuous. They keep their folder names and get real versions.Findand present inAll, so Storage still lists it while the home offers it to nothing.What was checked
launcher core: 2502 checks passedon this branch, which is main plus these changes and nothing else.Not in this PR
Nothing about any feature. Three of the four checks test behaviour the earlier pull requests changed; the fourth (
Leftovers.Find) is the one line of production code involved, and it is what #208's own description says should happen.- LeftoverChecks: the fixtures for "a folder holding a build" and "mods under user" stamped versions that are not versions ("outer", "user-mod"), which the new channel filter now excludes on its own — their assertions had gone vacuous. Both keep their folder names and get real versions (v3.0.2, v3.0.3). - BuildReportChecks: 285 characters of filler, not 290, so the 300-byte cut falls INSIDE the home folder ("/home/ana" on Linux, "C:\Users\Ana" on Windows): a scrub-after-cut reversal now leaves part of the name and the check sees it. - LeftoverChecks: an old release candidate is asserted absent from Find and present in All, so Storage still lists it while the home offers it to nothing. launcher core: 2502 checks passed. Assisted-by: Hermes AgentView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.