fix(release): a read the forge cuts off or fails with a 5xx is made again, and uploads are retried as in Longshot's copy #197
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!197
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/release-read-retry"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux (CachyOS, kernel 7.3.3), Python 3.12.16: the release tests (42, three new); the launcher's core tests stop at main's own Linux failure (the home folder cut from a log line), which this leaves alone · Needs: nothing: CI's next publish runs it
TL;DR
v1.0.0-rc.11's Sign and publish failed after every file was built and signed: git.magicbean.dev cut the list of releases off mid-answer, and
release.py publishstopped. Reading something changes nothing, so a GET to the forge is now made again, four times in all, before a release fails.scripts/release.pyandtests/test_release.pyare also the same as Longshot's again: the launcher never got Longshot's upload retries.Breakdown
api()read each answer once. A connection cut mid-answer (http.client.IncompleteRead, not anOSError) or a 5xx on a GET ended the run.Why
Run 634 (the tag v1.0.0-rc.11), step Publish:
That evening the CI runner on a maintainer's PC also logged connection resets against git.magicbean.dev, and a long listing of Longshot's issues broke off the same way.
What changed
scripts/release.py:api()makes a GET again,READ_TRIES(4) times, afterREAD_PAUSE× the attempt (5 s). The single request isapi_once().http.client.HTTPExceptioncounts as server trouble, so a cut-off answer is retried (and an upload's retry catches one too).UPLOAD_TRIES,ServerTroubleandupload_file()(Longshot#598), which the launcher's copy never got.tests/test_release.py: Longshot's file (its upload retry tests), plus:api()..nxamong the files never released (#77), and the nightly-news docstring without Longshot's nightly name.How it was tested
python -I tests/test_release.py: 42 tests, OK.tries = 1), and passes with it.python -I tests/test_launcher_core.py: stops at main's own Linux failure, "The home folder taken out before a line is cut: no cut leaves part of the user's name" (#196 saw it too). This changes no C# file.Not tested
Risks
Overlaps
docs/releases.mddiffers between the repositories too (Longshot's third-party objects, play profiles). That's Longshot's text, not touched here.Questions for you
release.py, which would retry nothing.🤖 Generated with Claude Code