fix(settings): Intel shader compiles has Auto, the game's own choice, and leaves the game's row free to change #157
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!157
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/intel-compiles-auto"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
With the launcher's Intel shader compiles on Side by side, every game started from the launcher had its own Intel shader compiles row locked: the launcher set
RX_VK_NO_INTEL_SERIAL=1, and the game shows a row that variable holds fixed (its hint names the launcher since Longshot#781). The launcher's One at a time was wrong too: it set nothing, so on an Arc B-series card with driver 101.9154 or newer it was the game's Auto, side by side (Longshot#500), while its line said "Recommended: slower, but safe".What changes
RX_VK_NO_INTEL_SERIAL=1, as before.RX_VK_NO_INTEL_SERIAL=0, so it really is one at a time on every Intel GPU. Every game version with the variable reads0as one at a time (since Longshot#252).LauncherSettings.IntelSideBySide(bool) is replaced byIntelCompiles(int). A savedintelSideBySide: trueloads as Side by side. A savedfalse, the old One at a time, set nothing, so it loads as Auto and behaves the same as before. The old field is read but no longer written. A value outside the three loads as Auto.GamePlay.IntelSideBySideVaris renamedIntelCompilesVar.GamePlay.IntelCompilesValuegives the variable's value for a choice (null for Auto), and both the build's environment and Play use it.Introduced by #97. Nothing changes in the game.
Checks
tests/launcher_core/Program.cs:1,0, and nothing for Auto, on Windows only.trueandfalse, an out-of-range value, and that a save no longer writesintelSideBySide.scripts/translations.py: the new texts are plainTr.Tliterals, and no catalog has the two replaced texts, so nothing is left over.settings-windows-intelshot now shows Auto.🤖 Generated with Claude Code