fix(settings): Intel shader compiles has Auto, the game's own choice, and leaves the game's row free to change #157

Merged
HumanBean merged 1 commit from HumanBean/LongshotLauncher:fix/intel-compiles-auto into main 2026-11-17 00:46:42 +00:00
Owner

With the launcher's Intel shader compiles on Side by side, every game started from the launcher had its own Intel shader compiles row locked: the launcher set RX_VK_NO_INTEL_SERIAL=1, and the game shows a row that variable holds fixed (its hint names the launcher since Longshot#781). The launcher's One at a time was wrong too: it set nothing, so on an Arc B-series card with driver 101.9154 or newer it was the game's Auto, side by side (Longshot#500), while its line said "Recommended: slower, but safe".

What changes

  • Three choices, as the game's row has them: Auto (the default), Side by side, One at a time. They use the game's numbers (0, 1, 2).
    • Auto sets nothing for the build or the game. The game's own Auto decides (side by side on the Arc B-series from driver 101.9154, one at a time on other Intel graphics), and its in-game row stays free.
    • Side by side sets RX_VK_NO_INTEL_SERIAL=1, as before.
    • One at a time now sets RX_VK_NO_INTEL_SERIAL=0, so it really is one at a time on every Intel GPU. Every game version with the variable reads 0 as one at a time (since Longshot#252).
    • Side by side and One at a time still hold the game's row, since a change there would be overridden at the next start. Their lines say "over its own setting".
  • Settings carry over. LauncherSettings.IntelSideBySide (bool) is replaced by IntelCompiles (int). A saved intelSideBySide: true loads as Side by side. A saved false, the old One at a time, set nothing, so it loads as Auto and behaves the same as before. The old field is read but no longer written. A value outside the three loads as Auto.
  • GamePlay.IntelSideBySideVar is renamed IntelCompilesVar. GamePlay.IntelCompilesValue gives the variable's value for a choice (null for Auto), and both the build's environment and Play use it.
  • README's settings step describes the three choices.

Introduced by #97. Nothing changes in the game.

Checks

  • tests/launcher_core/Program.cs:
    • The build and Play checks now cover all three choices: 1, 0, and nothing for Auto, on Windows only.
    • The settings checks cover the default (Auto), an old true and false, an out-of-range value, and that a save no longer writes intelSideBySide.
  • scripts/translations.py: the new texts are plain Tr.T literals, and no catalog has the two replaced texts, so nothing is left over.
  • I didn't build or run the test suites on this PC; CI runs them.
  • Not run on Windows with Intel graphics. The screenshots tool's settings-windows-intel shot now shows Auto.

🤖 Generated with Claude Code

With the launcher's **Intel shader compiles** on Side by side, every game started from the launcher had its own Intel shader compiles row locked: the launcher set `RX_VK_NO_INTEL_SERIAL=1`, and the game shows a row that variable holds fixed (its hint names the launcher since [Longshot#781](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/781)). The launcher's One at a time was wrong too: it set nothing, so on an Arc B-series card with driver 101.9154 or newer it was the game's Auto, side by side ([Longshot#500](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/500)), while its line said "Recommended: slower, but safe". ## What changes - **Three choices, as the game's row has them:** Auto (the default), Side by side, One at a time. They use the game's numbers (0, 1, 2). - **Auto** sets nothing for the build or the game. The game's own Auto decides (side by side on the Arc B-series from driver 101.9154, one at a time on other Intel graphics), and its in-game row stays free. - **Side by side** sets `RX_VK_NO_INTEL_SERIAL=1`, as before. - **One at a time** now sets `RX_VK_NO_INTEL_SERIAL=0`, so it really is one at a time on every Intel GPU. Every game version with the variable reads `0` as one at a time (since [Longshot#252](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/252)). - Side by side and One at a time still hold the game's row, since a change there would be overridden at the next start. Their lines say "over its own setting". - **Settings carry over.** `LauncherSettings.IntelSideBySide` (bool) is replaced by `IntelCompiles` (int). A saved `intelSideBySide: true` loads as Side by side. A saved `false`, the old One at a time, set nothing, so it loads as Auto and behaves the same as before. The old field is read but no longer written. A value outside the three loads as Auto. - `GamePlay.IntelSideBySideVar` is renamed `IntelCompilesVar`. `GamePlay.IntelCompilesValue` gives the variable's value for a choice (null for Auto), and both the build's environment and Play use it. - README's settings step describes the three choices. Introduced by [#97](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/97). Nothing changes in the game. ## Checks - `tests/launcher_core/Program.cs`: - The build and Play checks now cover all three choices: `1`, `0`, and nothing for Auto, on Windows only. - The settings checks cover the default (Auto), an old `true` and `false`, an out-of-range value, and that a save no longer writes `intelSideBySide`. - `scripts/translations.py`: the new texts are plain `Tr.T` literals, and no catalog has the two replaced texts, so nothing is left over. - I didn't build or run the test suites on this PC; CI runs them. - Not run on Windows with Intel graphics. The screenshots tool's `settings-windows-intel` shot now shows Auto. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(settings): Intel shader compiles has Auto, the game's own choice, and leaves the game's row free to change
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
9c0c8817a9
Side by side set RX_VK_NO_INTEL_SERIAL=1 for every game run, which the game
shows as its Intel shader compiles row fixed. One at a time set nothing, so on
an Arc B-series card with driver 101.9154 or newer it was the game's Auto, side
by side, despite its line calling it safe.

The choice is now Auto (the default, nothing set), Side by side (=1) and One at
a time (=0), numbered as the game's row. A saved Side by side stays one; a
saved One at a time, which set nothing, reads as Auto.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean deleted branch fix/intel-compiles-auto 2026-11-17 00:46:43 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!157
No description provided.