WIP: fix: a build needs about 60 GB free, the same figure as the requirements #150

Draft
TrashPanda wants to merge 1 commit from TrashPanda/LongshotLauncher:fix/build-needs-60gb into main
Contributor

Step 2 stopped Build when fewer than 45 GB were free, the figure from the old builders. The requirements card on the same screen, and Longshot's requirements, already say a build needs about 60 GB. A player with 50 GB free was told both that they were short and that they could continue.

What changed

Disk.BuildBytes is 60 GiB, and the advisory check uses that constant, so the warning and the stop cannot drift apart again.

  • Core/Disk.cs: the free space a build needs, and the comment on why it is no longer 45 GB. The stores still add at most one new translation while a build runs; that is not why the number moved (see #72).
  • Core/SystemRequirements.cs: the yellow "about 60 GB" warning compares against Disk.BuildBytes.
  • Core/Problems.cs, App/Views/SettingsStepView.axaml, and the catalogs: the disk-full sentence and the step 2 note say 60 GB. The number in each translation changed; the wording did not.
  • README.md: the disk-space bullet matches.
  • tests/launcher_core/RequirementsChecks.cs: the check's disk default is Disk.BuildBytes, and one assertion ties that constant to 60 GiB.

A copy of a shader cache (ShaderCaches.Room) leaves room for this same figure, so it asks for 15 GB more free space than before.

Testing

python -I tests/test_launcher_core.py: 1375 checks passed, 0 warnings. python -I tests/test_release.py: 37 tests OK. The window was not opened, so there is no screenshot of the step 2 note. The catalogs that already lacked texts still lack the same kind of count; these two strings are translated.

Prior work: #72 kept 45 GB when the stores landed, because the stores are not a second copy of the build. #57 (closed) noted that an update needs less than a first build and left the 45 GB stop as it was.

Step 2 stopped **Build** when fewer than 45 GB were free, the figure from the old builders. The requirements card on the same screen, and Longshot's requirements, already say a build needs about 60 GB. A player with 50 GB free was told both that they were short and that they could continue. ## What changed `Disk.BuildBytes` is 60 GiB, and the advisory check uses that constant, so the warning and the stop cannot drift apart again. - `Core/Disk.cs`: the free space a build needs, and the comment on why it is no longer 45 GB. The stores still add at most one new translation while a build runs; that is not why the number moved (see https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/72). - `Core/SystemRequirements.cs`: the yellow "about 60 GB" warning compares against `Disk.BuildBytes`. - `Core/Problems.cs`, `App/Views/SettingsStepView.axaml`, and the catalogs: the disk-full sentence and the step 2 note say 60 GB. The number in each translation changed; the wording did not. - `README.md`: the disk-space bullet matches. - `tests/launcher_core/RequirementsChecks.cs`: the check's disk default is `Disk.BuildBytes`, and one assertion ties that constant to 60 GiB. A copy of a shader cache (`ShaderCaches.Room`) leaves room for this same figure, so it asks for 15 GB more free space than before. ## Testing `python -I tests/test_launcher_core.py`: 1375 checks passed, 0 warnings. `python -I tests/test_release.py`: 37 tests OK. The window was not opened, so there is no screenshot of the step 2 note. The catalogs that already lacked texts still lack the same kind of count; these two strings are translated. Prior work: https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/72 kept 45 GB when the stores landed, because the stores are not a second copy of the build. https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/57 (closed) noted that an update needs less than a first build and left the 45 GB stop as it was.
fix: a build needs about 60 GB free, the same figure as the requirements
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Compile and test (pull_request) Blocked by required conditions
db8637d8c8
Step 2 stopped Build below 45 GB, the old builders' figure, while the requirements card and Longshot's docs already said about 60 GB.

Assisted-by: Agent Hub growth agent
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Compile and test (pull_request) Blocked by required conditions
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/build-needs-60gb:TrashPanda-fix/build-needs-60gb'
git switch 'TrashPanda-fix/build-needs-60gb'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!150
No description provided.