WIP: fix: a build needs about 60 GB free, the same figure as the requirements #150
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!150
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/LongshotLauncher:fix/build-needs-60gb"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Step 2 stopped Build when fewer than 45 GB were free, the figure from the old builders. The requirements card on the same screen, and Longshot's requirements, already say a build needs about 60 GB. A player with 50 GB free was told both that they were short and that they could continue.
What changed
Disk.BuildBytesis 60 GiB, and the advisory check uses that constant, so the warning and the stop cannot drift apart again.Core/Disk.cs: the free space a build needs, and the comment on why it is no longer 45 GB. The stores still add at most one new translation while a build runs; that is not why the number moved (see #72).Core/SystemRequirements.cs: the yellow "about 60 GB" warning compares againstDisk.BuildBytes.Core/Problems.cs,App/Views/SettingsStepView.axaml, and the catalogs: the disk-full sentence and the step 2 note say 60 GB. The number in each translation changed; the wording did not.README.md: the disk-space bullet matches.tests/launcher_core/RequirementsChecks.cs: the check's disk default isDisk.BuildBytes, and one assertion ties that constant to 60 GiB.A copy of a shader cache (
ShaderCaches.Room) leaves room for this same figure, so it asks for 15 GB more free space than before.Testing
python -I tests/test_launcher_core.py: 1375 checks passed, 0 warnings.python -I tests/test_release.py: 37 tests OK. The window was not opened, so there is no screenshot of the step 2 note. The catalogs that already lacked texts still lack the same kind of count; these two strings are translated.Prior work: #72 kept 45 GB when the stores landed, because the stores are not a second copy of the build. #57 (closed) noted that an update needs less than a first build and left the 45 GB stop as it was.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.