ci(release): Sign and publish takes the launchers from Forgejo's own address, and Wine installs while they build #142
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!142
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:ci/release-faster"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
A launcher nightly spends more time waiting than building. In nightly-100's run (#437), Sign and publish took 2 min 8 s, and 79 s of that was the download of the launchers' artifact (~188 MB) through Forgejo's public address behind Cloudflare: out over the home uplink and back in. The build job also installs Wine (~20 s) only after
package.shhas finished.What changed
scripts/release.py artifacts <folder> --run <run id> <name>...(the same command as Longshot's, MagicBeanDev/Longshot#1110): it fetches the run's named artifacts fromFORGEJO_UPLOAD_API(Forgejo's own address on the quick runner's network, where artifacts are on its disk) and unpacks them. It refuses a missing or duplicated name and any entry that is not a plain file name, and writes nothing until every artifact is fetched.release.yml, Sign and publish: a new first step uses it. Thedownload-artifactsteps run only if it failed (the fallback, with its retry).release.yml, build job: Wine (installed in the background) starts the same apt commands detached, beforepackage.sh. The Windows program starts waits for its status (10 min cap) and shows the apt log on failure.tests/test_release.py:Artifacts, against a fake Forgejo on 127.0.0.1.Measurements
Verdict: expected to save ~1.5 min per launcher release (~75 s in Sign and publish, ~20 s in the build job). The real number comes from the first nightly after merge, since the internal address can't be reached from my PC.
Testing
Tested: the same command in Longshot's copy against a real run's artifacts (Linux, public address): unpacked by name, and a missing name refused. The background-install pattern in a local shell: the first step returns at once and the status passes through. The workflow parses (PyYAML).
Not tested:
tests/test_release.py(left to CI). Whether the job token may read the artifacts API: if it can't, the fallback runs as today.Must be tested: the first nightly after merge: The launchers, from Forgejo's own address passes, and the download-artifact steps are skipped.
Note: main's nightly fails today, independently of this PR: run #448,
App/FontCheck.cs(91,45): error IL3000(Assembly.Locationin a single-file publish), from #137.Risks
If the artifacts API refuses the job token or answers differently, the release goes through the old download-artifact path. Revert the commit to undo. Nothing changes for players.
🤖 Generated with Claude Code
https://claude.ai/code/session_017vw8dzkpXRZ2cBAf7vu5YQ
WIP: ci(release): Sign and publish takes the launchers from Forgejo's own address, and Wine installs while they buildto ci(release): Sign and publish takes the launchers from Forgejo's own address, and Wine installs while they build