fix(settings): Intel XeSS's line no longer says it is for Intel graphics only, and is never red #127
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!127
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/xess-any-gpu"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Intel XeSS's switch said "For Intel Arc and Iris Xe graphics." and, on a PC without Intel graphics, "This PC has no Intel graphics." in red, which reads as if XeSS only works on Intel. It doesn't: it runs on other makers' cards too where their Vulkan driver has what XeSS asks for, and Longshot puts no vendor gate on it. Fixes #126.
What changes
VK_EXT_mutable_descriptor_type), which only the game can tell at its start; it says so in the Upscaler row's hint and the log.SystemInfo.XessRunsis renamedXessIntelto say that's all it means.On the issue's suggested wording ("Shader Model 6.4+ and DP4a"): SM 6.4 is XeSS's Direct3D 12 requirement (
XESS_RESULT_ERROR_UNSUPPORTED_DEVICEinthird_party/xess/inc/xess/xess.h). Longshot runs XeSS through Vulkan, where Intel's library asks for its own extensions instead, so that wording doesn't fit here, and it's too technical for the row anyway.Checks
dotnet build App: succeeds, 0 warnings.tests/launcher_core/ScreenChecks.cs: the XeSS check now coversXessIntel(Intel graphics, named or known only by maker; not another maker's); the check that said XeSS goes red without Intel is removed, as that is the behaviour this PR removes.🤖 Generated with Claude Code
WIP: fix(settings): Intel XeSS's line no longer says it is for Intel graphics only, and is never redto fix(settings): Intel XeSS's line no longer says it is for Intel graphics only, and is never red