fix(home): a build whose update was left in another folder plays it again, and that game is never offered as an old version #125

Merged
HumanBean merged 1 commit from HumanBean/LongshotLauncher:fix/lost-update-folder into main 2026-11-15 23:51:28 +00:00
Owner

Fixes #102. A portable launcher's player couldn't press Play: their v3.0.0-rc.3 row said "not built: its game is missing" while a working v3.0.0-rc.4 sat unlisted in builds\v3.0.0-rc.4. On main the launcher would also offer to delete that rc.4 folder as an "old version" (#121), which is the player's only working game.

What happened

Before #104, an update built the new version in a new folder and moved its row there at the end. When the row didn't follow (the launcher closed, or builds.json wasn't written), the row kept the old folder and the new game stayed unlisted. The issue's screenshot (launcher rc.6) shows that state: the rc.3 row, 34.9 GB listed, no game, and an rc.4 folder the player starts by hand.

What changes

  • Leftovers.LostUpdate: for a row whose folder has no game, the newest unlisted game folder directly in the builds folder that plays, is on the row's channel (a stable counts on rc) and is newer than the row's version. When the home opens, LauncherService.RelistLostUpdates gives it back to the row with BuildRegistry.Replace (id, default and place kept), saves builds.json, logs it and shows a toast: "{0} was found in its own folder and is listed again." This runs before the leftovers are looked for. After that, the old rc.3 folder is offered for deletion as #121 intended.
  • Leftovers.Find no longer offers a game that plays when no listed build that plays has its channel's version as new. That's the newest game of its channel, not an old version: the case above, or a row that ForgetGone already dropped.
  • Step 1 of an update (the second part of the issue): it said "The file you built it from is picked" even when that file had moved and nothing was picked. Now it says the file is no longer where it was and to pick it again, since the game is built from it again. The game file really is needed: an update recompiles the game from the dump.
  • Translated into every catalog (en-GB and fr-CA only list what differs).
  • BusyChecks: the CanStartBuild check had been failing on main since #121 added && !deletingLeftovers. It now expects that.

Testing

Linux (CachyOS), .NET SDK 10.0.404.

  • python -I tests/test_launcher_core.py: 1375 checks passed. LeftoverChecks adds the issue's layout: an rc.3 row with no game, an unlisted rc.4 that plays, plus an older rc.2 and a nightly. It checks:
    • the row takes rc.4 back, but not a listed folder, and not when the row plays
    • rc.4 and the nightly aren't offered for deletion
    • after Replace, rc.2 and rc.3 are offered
  • python -I tests/test_release.py: 31 tests, OK.
  • dotnet build App/LongshotLauncher.csproj: 0 errors.

Not tested: a real launcher on the reporter's folders. No screenshot: what shows on screen is a toast and one changed line of step 1's text.

🤖 Generated with Claude Code

Fixes #102. A portable launcher's player couldn't press Play: their v3.0.0-rc.3 row said "not built: its game is missing" while a working v3.0.0-rc.4 sat unlisted in `builds\v3.0.0-rc.4`. On main the launcher would also offer to delete that rc.4 folder as an "old version" (#121), which is the player's only working game. ## What happened Before #104, an update built the new version in a new folder and moved its row there at the end. When the row didn't follow (the launcher closed, or builds.json wasn't written), the row kept the old folder and the new game stayed unlisted. The issue's screenshot (launcher rc.6) shows that state: the rc.3 row, 34.9 GB listed, no game, and an rc.4 folder the player starts by hand. ## What changes - **`Leftovers.LostUpdate`**: for a row whose folder has no game, the newest unlisted game folder directly in the builds folder that plays, is on the row's channel (a stable counts on rc) and is newer than the row's version. When the home opens, `LauncherService.RelistLostUpdates` gives it back to the row with `BuildRegistry.Replace` (id, default and place kept), saves builds.json, logs it and shows a toast: "{0} was found in its own folder and is listed again." This runs before the leftovers are looked for. After that, the old rc.3 folder is offered for deletion as #121 intended. - **`Leftovers.Find`** no longer offers a game that plays when no listed build that plays has its channel's version as new. That's the newest game of its channel, not an old version: the case above, or a row that `ForgetGone` already dropped. - **Step 1 of an update** (the second part of the issue): it said "The file you built it from is picked" even when that file had moved and nothing was picked. Now it says the file is no longer where it was and to pick it again, since the game is built from it again. The game file really is needed: an update recompiles the game from the dump. - Translated into every catalog (en-GB and fr-CA only list what differs). - `BusyChecks`: the `CanStartBuild` check had been failing on main since #121 added `&& !deletingLeftovers`. It now expects that. ## Testing Linux (CachyOS), .NET SDK 10.0.404. - `python -I tests/test_launcher_core.py`: 1375 checks passed. `LeftoverChecks` adds the issue's layout: an rc.3 row with no game, an unlisted rc.4 that plays, plus an older rc.2 and a nightly. It checks: - the row takes rc.4 back, but not a listed folder, and not when the row plays - rc.4 and the nightly aren't offered for deletion - after `Replace`, rc.2 and rc.3 are offered - `python -I tests/test_release.py`: 31 tests, OK. - `dotnet build App/LongshotLauncher.csproj`: 0 errors. Not tested: a real launcher on the reporter's folders. No screenshot: what shows on screen is a toast and one changed line of step 1's text. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(home): a build whose update was left in another folder plays it again, and that game is never offered as an old version (#102)
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
2fdf75035a
An update before #104 built the new version in a new folder and moved its row there at the end. When the row didn't
follow, it kept the old folder ("not built: its game is missing", Play off) while the new game stayed unlisted, and
#121 would offer to delete it as an old version. Such a row now takes the game back when the home opens, and a game no
playing build of its channel matches is never offered. An update whose game file moved says so in step 1 instead of
saying it is picked.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean deleted branch fix/lost-update-folder 2026-11-15 23:51:29 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!125
No description provided.