fix(home): a build whose update was left in another folder plays it again, and that game is never offered as an old version #125
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!125
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/lost-update-folder"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #102. A portable launcher's player couldn't press Play: their v3.0.0-rc.3 row said "not built: its game is missing" while a working v3.0.0-rc.4 sat unlisted in
builds\v3.0.0-rc.4. On main the launcher would also offer to delete that rc.4 folder as an "old version" (#121), which is the player's only working game.What happened
Before #104, an update built the new version in a new folder and moved its row there at the end. When the row didn't follow (the launcher closed, or builds.json wasn't written), the row kept the old folder and the new game stayed unlisted. The issue's screenshot (launcher rc.6) shows that state: the rc.3 row, 34.9 GB listed, no game, and an rc.4 folder the player starts by hand.
What changes
Leftovers.LostUpdate: for a row whose folder has no game, the newest unlisted game folder directly in the builds folder that plays, is on the row's channel (a stable counts on rc) and is newer than the row's version. When the home opens,LauncherService.RelistLostUpdatesgives it back to the row withBuildRegistry.Replace(id, default and place kept), saves builds.json, logs it and shows a toast: "{0} was found in its own folder and is listed again." This runs before the leftovers are looked for. After that, the old rc.3 folder is offered for deletion as #121 intended.Leftovers.Findno longer offers a game that plays when no listed build that plays has its channel's version as new. That's the newest game of its channel, not an old version: the case above, or a row thatForgetGonealready dropped.BusyChecks: theCanStartBuildcheck had been failing on main since #121 added&& !deletingLeftovers. It now expects that.Testing
Linux (CachyOS), .NET SDK 10.0.404.
python -I tests/test_launcher_core.py: 1375 checks passed.LeftoverChecksadds the issue's layout: an rc.3 row with no game, an unlisted rc.4 that plays, plus an older rc.2 and a nightly. It checks:Replace, rc.2 and rc.3 are offeredpython -I tests/test_release.py: 31 tests, OK.dotnet build App/LongshotLauncher.csproj: 0 errors.Not tested: a real launcher on the reporter's folders. No screenshot: what shows on screen is a toast and one changed line of step 1's text.
🤖 Generated with Claude Code