ci(release): release.py released-as, the checked release a tag's commit already has #11
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/ui
area/updates
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!11
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:release-speed"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
Longshot's release workflow now asks, on a tag, for the checked release CI already made of the same commit, so a tag skips the build checks that release's run passed.
scripts/release.py,tests/test_release.py,docs/releases.mdandRELEASING.mdare byte-identical with MagicBeanDev/Longshot's, so the same change lands here.What changed
scripts/release.py:released-as <commit> [--not <tag>](released_as(),download()) finds the published release of the commit: a nightly whose tag is that commit, or a stable's release candidate. It takes that release only when a trusted key signed itsSHA256SUMSand the list names exactly its files; a release that fails either check stops the caller. WhenFORGEJO_UPLOAD_APIis set, files come through its host.tests/test_release.py:ReleasedAscovers the lookup, the verification, the address without Cloudflare and the command.docs/releases.md,RELEASING.md: what a Longshot tag does with it, and the correctedassemble cpm --addline (Longshot's dav1d job is gone).release.ymldoes not change. The launcher's files carry the tag too (-p:LongshotTag), so they can't be reused, and its build has no check that ships no file.Longshot's PR: MagicBeanDev/Longshot#143. The four files are identical in both repositories (
cmp).Testing
python -I -B tests/test_release.py: 24 tests pass here and in Longshot.released-aswas checked from Longshot against git.magicbean.dev: it foundnightly-34-545618fc, signed with the real key.Risk and rollback
Nothing in this repository calls
released-as; reverting the commit is enough.