test(host): the crash window's check runs through on Linux with g++ and clang #626

Open

zeldaootr wants to merge 1 commit from zeldaootr/Longshot:fix-crash-dialog-check-fixture into main

pull from: zeldaootr/Longshot:fix-crash-dialog-check-fixture

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 1 Commits 1 Files changed 1 +11 -7

zeldaootr commented 2026-11-15 00:56:00 +00:00

Contributor

• Copy link
• Copy Markdown

Type: test · Risk: low · Tested on: Linux, no GPU (game-free check, g++ 13.3 and clang 23.1.5) · Needs: Windows, any GPU (game-free)

Why

tests/test_crash_dialog.py has failed on main since the crash window merged (#593): it never got past its own fixtures on Linux, so main is red before a release candidate and the crash window's real-run checks have not run at all. The crash window's code is right in everything the check reached once its fixtures were fixed. No open pull request or claim covers it.

How to reproduce

Seen on: Linux (Ubuntu 24.04), no GPU; g++ 13.3 and clang 23.1.5
Settings and switches: none
Steps: on main aa95d35f, run python -I -B tests/test_crash_dialog.py --cxx g++, then --cxx clang++
Expected: every PASS line, through PASS: Report: the clipboard's text has ...
Actual: with g++: AssertionError at assert run(exe, "args", *good).strip() == "1|1234|..." (the fixture prints 0|0||||NULL); with clang: clang++: error: '-x none' after last input file has no effect [-Werror,-Wunused-command-line-argument] building the fixture

What changed

Test-only, four faults of the check's own, each found once the one before it was out of the way. No product file changes, and every assertion is as it was.

• args and options fixtures: they passed hos_crash_args argv + 1, so the program-name slot held their own command word and argv[1] was longshot: every helper command line read as the game's (0). They pass argv + 2, as main passes its own argv (host/hos_crash_dialog.c). (options, the settings file after the log, came with #729 and copied the same argv + 1: with only the args repair the check stopped there, at run(exe, "options", *good) == "1|NULL".)
• Compiles: the fixture's -x none came after the last input, an error under clang's -Werror; it is dropped. The real-run driver's four C files each get their own -x c: g++ applies a single -x c to the first file only and compiled hos_crash_dialog.c and the rest as C++ ('_Bool' was not declared).
• Real runs: the driver's stderr is /dev/null. hos_crash_record_start takes a regular file on stderr for the game's log (the game's own stderr is its log), so with the check's output in a file the helper looked for the run in that file, found no log, and the window named no stage (during the start missing).
• Report runs: the second one in the same folder read the first one's events from out.txt; it is removed first, as the check already does elsewhere.

Measurements

Verdict: passes: the check fails on main and passes on this branch, with g++ and with clang, in two interleaved rounds.

Hardware: Linux (Ubuntu 24.04, kernel 6.8), x86-64, no GPU used; g++ 13.3.0, clang 23.1.5 (llvm-mingw's, --target=x86_64-linux-gnu), Python 3.15
Scene: no game: the game-free check, with its real helper runs against stand-in game processes
Method: the check run alone with --cxx g++ and with --cxx clang++, round 1 on main then this branch, round 2 the same again; failed runs per round (2 a round), and the PASS lines reached
How to reproduce: python -I -B tests/test_crash_dialog.py --cxx g++ (and --cxx clang++) on each commit, its output to a file

	Before: main @ aa95d35f	After: this PR @ 89fd00f1
Failed runs of 2, round 1 / round 2	2 / 2	0 / 0
PASS lines reached of 14	1	14

main@aa95d35f r1 test_crash_dialog.py g++ rc=1 pass=1 | AssertionError at assert run(exe, "args", *good).strip() == "1|1234|..."
main@aa95d35f r1 test_crash_dialog.py clangxx rc=1 pass=1 | clang++: error: '-x none' after last input file has no effect [-Werror,-Wunused-command-line-argument]
fix-crash-dialog-check-fixture@89fd00f1 r1 test_crash_dialog.py g++ rc=0 pass=14 | PASS: Report: the clipboard's text has the version, GPU, system, settings, record and log end, and nothing private
fix-crash-dialog-check-fixture@89fd00f1 r1 test_crash_dialog.py clangxx rc=0 pass=14 | PASS: Report: the clipboard's text has the version, GPU, system, settings, record and log end, and nothing private
(round 2: the same four results)

Flags and settings

None

Testing

Tested: on Linux, the whole check with g++ and clang, failing on main aa95d35f and passing here in two interleaved rounds, with its output both in a file and in the runner's pipe. The check has failed since a0dac82e (#593's merge), the only commit that touched it, hos_crash_dialog.c or hos_crash_dialog.h. The full suite (python -I -B tests/run_all.py, Linux, g++, LONGSHOT_VULKAN_HEADERS set) ran once on main aa95d35f with the other open fixes from the same sweep merged locally (ac6a1e97, not pushed, with this PR's head before the rebase, db15e4d5): 550 passed, 5 failed, 51 skipped. All five fail on clean main aa95d35f too: tests/test_make_game_cache.py, tests/test_options_budget_once.py, tests/test_mods_size_table.py, tests/test_walk_key.py, and this check, which there stopped at the options fixture this rebase repairs; with it, the check passes whole (above).

Not tested: Windows. There the check builds the same args fixture (the argv + 2 and the dropped -x none apply) and skips the real runs.

Must be tested:

• Windows, any GPU (game-free, llvm-mingw clang): python -I -B tests/test_crash_dialog.py --cxx clang++, expecting every PASS line through PASS: the issue link: ... and the note that the real helper runs are Linux only (by hand: any Windows contributor; or the Test Farm: @Beanstalk windows, run tests/test_crash_dialog.py)

Risks

What could break: only this check.

Turning it off: revert the commit

Compatibility: Nothing changes

Checklist

Everyone

• One topic.
• The title is a Conventional Commit (type(scope): description) of the status line's type.
• Why gives the reason plainly and links the issues that fit (the tracker searched).
• Measurements has a verdict, or one line saying why there is nothing to measure.
• Testing names what was tested, what wasn't, and what must still be tested, where and how.
• Rebased on current main.
• python -I -B tests/run_all.py passes (any failure that also fails on main is named).
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported.

**Type:** test · **Risk:** low · **Tested on:** Linux, no GPU (game-free check, g++ 13.3 and clang 23.1.5) · **Needs:** Windows, any GPU (game-free) ## Why `tests/test_crash_dialog.py` has failed on `main` since the crash window merged (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/593): it never got past its own fixtures on Linux, so `main` is red before a release candidate and the crash window's real-run checks have not run at all. The crash window's code is right in everything the check reached once its fixtures were fixed. No open pull request or claim covers it. ## How to reproduce **Seen on:** Linux (Ubuntu 24.04), no GPU; g++ 13.3 and clang 23.1.5 **Settings and switches:** none **Steps:** on `main` aa95d35f, run `python -I -B tests/test_crash_dialog.py --cxx g++`, then `--cxx clang++` **Expected:** every PASS line, through `PASS: Report: the clipboard's text has ...` **Actual:** with g++: `AssertionError` at `assert run(exe, "args", *good).strip() == "1|1234|..."` (the fixture prints `0|0||||NULL`); with clang: `clang++: error: '-x none' after last input file has no effect [-Werror,-Wunused-command-line-argument]` building the fixture ## What changed Test-only, four faults of the check's own, each found once the one before it was out of the way. No product file changes, and every assertion is as it was. - `args` and `options` fixtures: they passed `hos_crash_args` `argv + 1`, so the program-name slot held their own command word and `argv[1]` was `longshot`: every helper command line read as the game's (0). They pass `argv + 2`, as `main` passes its own `argv` (`host/hos_crash_dialog.c`). (`options`, the settings file after the log, came with https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/729 and copied the same `argv + 1`: with only the `args` repair the check stopped there, at `run(exe, "options", *good) == "1|NULL"`.) - Compiles: the fixture's `-x none` came after the last input, an error under clang's `-Werror`; it is dropped. The real-run driver's four C files each get their own `-x c`: g++ applies a single `-x c` to the first file only and compiled `hos_crash_dialog.c` and the rest as C++ (`'_Bool' was not declared`). - Real runs: the driver's stderr is `/dev/null`. `hos_crash_record_start` takes a regular file on stderr for the game's log (the game's own stderr is its log), so with the check's output in a file the helper looked for the run in that file, found no log, and the window named no stage (`during the start` missing). - Report runs: the second one in the same folder read the first one's events from `out.txt`; it is removed first, as the check already does elsewhere. ## Measurements **Verdict:** passes: the check fails on `main` and passes on this branch, with g++ and with clang, in two interleaved rounds. Hardware: Linux (Ubuntu 24.04, kernel 6.8), x86-64, no GPU used; g++ 13.3.0, clang 23.1.5 (llvm-mingw's, `--target=x86_64-linux-gnu`), Python 3.15 Scene: no game: the game-free check, with its real helper runs against stand-in game processes Method: the check run alone with `--cxx g++` and with `--cxx clang++`, round 1 on main then this branch, round 2 the same again; failed runs per round (2 a round), and the PASS lines reached How to reproduce: `python -I -B tests/test_crash_dialog.py --cxx g++` (and `--cxx clang++`) on each commit, its output to a file | | Before: main @ aa95d35f | After: this PR @ 89fd00f1 | |---|---|---| | Failed runs of 2, round 1 / round 2 | 2 / 2 | 0 / 0 | | PASS lines reached of 14 | 1 | 14 | ``` main@aa95d35f r1 test_crash_dialog.py g++ rc=1 pass=1 | AssertionError at assert run(exe, "args", *good).strip() == "1|1234|..." main@aa95d35f r1 test_crash_dialog.py clangxx rc=1 pass=1 | clang++: error: '-x none' after last input file has no effect [-Werror,-Wunused-command-line-argument] fix-crash-dialog-check-fixture@89fd00f1 r1 test_crash_dialog.py g++ rc=0 pass=14 | PASS: Report: the clipboard's text has the version, GPU, system, settings, record and log end, and nothing private fix-crash-dialog-check-fixture@89fd00f1 r1 test_crash_dialog.py clangxx rc=0 pass=14 | PASS: Report: the clipboard's text has the version, GPU, system, settings, record and log end, and nothing private (round 2: the same four results) ``` ### Flags and settings None ## Testing **Tested:** on Linux, the whole check with g++ and clang, failing on main aa95d35f and passing here in two interleaved rounds, with its output both in a file and in the runner's pipe. The check has failed since a0dac82e (#593's merge), the only commit that touched it, `hos_crash_dialog.c` or `hos_crash_dialog.h`. The full suite (`python -I -B tests/run_all.py`, Linux, g++, `LONGSHOT_VULKAN_HEADERS` set) ran once on `main` aa95d35f with the other open fixes from the same sweep merged locally (ac6a1e97, not pushed, with this PR's head before the rebase, db15e4d5): 550 passed, 5 failed, 51 skipped. All five fail on clean `main` aa95d35f too: `tests/test_make_game_cache.py`, `tests/test_options_budget_once.py`, `tests/test_mods_size_table.py`, `tests/test_walk_key.py`, and this check, which there stopped at the `options` fixture this rebase repairs; with it, the check passes whole (above). **Not tested:** Windows. There the check builds the same `args` fixture (the `argv + 2` and the dropped `-x none` apply) and skips the real runs. **Must be tested:** - Windows, any GPU (game-free, llvm-mingw clang): `python -I -B tests/test_crash_dialog.py --cxx clang++`, expecting every PASS line through `PASS: the issue link: ...` and the note that the real helper runs are Linux only (by hand: any Windows contributor; or the Test Farm: @Beanstalk windows, run tests/test_crash_dialog.py) ## Risks **What could break:** only this check. **Turning it off:** revert the commit **Compatibility:** Nothing changes ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported.

zeldaootr added 1 commit 2026-11-15 00:56:00 +00:00

make the crash window's check run as it was written ... db15e4d5a1

Since #593 it never got past its fixtures on Linux:
- the `args` fixture handed `hos_crash_args` its own command word as the program name, so every helper command line read as the game's (0)
- `-x none` after the last input is an error under clang's `-Werror`; g++ takes one `-x c` for the first file only, and compiled the helper's other C files as C++
- with the check's output in a file, `hos_crash_record_start` took that file (the driver's stderr) for the game's log, so no stage was found
- the second Report run read the first one's events from `out.txt`, which is now removed before it, as elsewhere

Assisted-by: Claude

sheep referenced this pull request from a commit 2026-11-15 05:15:02 +00:00

test(host): the crash window's check runs through on Linux with g++ and clang

d4nkn3ss referenced this pull request 2026-11-15 13:07:53 +00:00

test(build): the make_game checks let go of the work folder's lock, so Windows can delete their temporary folders #804

zeldaootr referenced this pull request 2026-11-15 13:32:17 +00:00

fix(menu): longshot_options.ini is replaced whole or not at all #550

zeldaootr referenced this pull request 2026-11-15 13:32:20 +00:00

test(vk): the env_on and late readback checks match the render thread's source #622

zeldaootr commented 2026-11-15 13:32:24 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Rebased onto main aa95d35f (89fd00f1): #729 added an options fixture to this check that copied the same argv + 1, so with only the args repair the check stopped at run(exe, "options", *good) == "1|NULL"; it now passes argv + 2 too.
The whole check passes again with g++ and clang (14 of 14 PASS lines, two interleaved rounds; main reaches 1).

Rebased onto `main` aa95d35f (89fd00f1): #729 added an `options` fixture to this check that copied the same `argv + 1`, so with only the `args` repair the check stopped at `run(exe, "options", *good) == "1|NULL"`; it now passes `argv + 2` too. The whole check passes again with g++ and clang (14 of 14 PASS lines, two interleaved rounds; `main` reaches 1).

zeldaootr force-pushed fix-crash-dialog-check-fixture from db15e4d5a1 to 89fd00f127 2026-11-15 13:32:24 +00:00 Compare

mooki added the

kind

chore

platform/linux

priority

low

labels 2026-11-15 13:56:38 +00:00

zeldaootr referenced this pull request 2026-11-15 17:11:55 +00:00

fix(linux): a saves move that fails part way brings back what it moved #557

zeldaootr referenced this pull request 2026-11-15 17:12:09 +00:00

fix: a log file that cannot be opened no longer closes stderr #558

HumanBean referenced this pull request from a commit 2026-11-15 17:57:45 +00:00

fix(menu): longshot_options.ini is replaced whole or not at all (#550)

MaikelJSQ referenced this pull request 2026-11-15 18:05:02 +00:00

Game: Longshot closed unexpectedly while you were playing #859

Some checks are pending

Hide checks

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request) Blocked by required conditions

Details

PR description / Description follows the template (pull_request_target) Successful in 3s

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

Some workflows are waiting to be reviewed.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'fix-crash-dialog-check-fixture:zeldaootr-fix-crash-dialog-check-fixture'

git switch 'zeldaootr-fix-crash-dialog-check-fixture'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/upscaling

DLSS, FSR, frame generation

  

beanstalk: approved @ 1697603

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 2c5a62e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 4fd82b7

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 64d6d09

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 6f91fae

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 70a78f9

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8d361dc

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 9d8356e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ abf2227

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ d82f202

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ e5f1e40

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ ee8ab5f

Set by Beanstalk for show; the farm's database is what counts

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/upscaling

beanstalk: approved @ 1697603

beanstalk: approved @ 2c5a62e

beanstalk: approved @ 4fd82b7

beanstalk: approved @ 64d6d09

beanstalk: approved @ 6f91fae

beanstalk: approved @ 70a78f9

beanstalk: approved @ 8d361dc

beanstalk: approved @ 9d8356e

beanstalk: approved @ abf2227

beanstalk: approved @ d82f202

beanstalk: approved @ e5f1e40

beanstalk: approved @ ee8ab5f

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!626

No description provided.