fix(vk): honor cache-off for rolling pipeline files #415

Open

klimovich008 wants to merge 2 commits from klimovich008/Longshot:fix/pipeline-cache-off into main

pull from: klimovich008/Longshot:fix/pipeline-cache-off

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 3 Commits 2 Files changed 6 +95 -11

klimovich008 commented 2026-11-14 11:49:23 +00:00

Contributor

• Copy link
• Copy Markdown

Why

RX_VK_PCACHE_LOAD=0 still imported and saved rolling pipeline-cache files.

What changed

vk_draw.cpp: guard imports/generations. Extend existing fixtures/docs.

Flags and settings

None added. Existing RX_VK_PCACHE_LOAD=0 skips application persistence; defaults unchanged.

Measurements

main: 5e072fc8 (2026-11-14)
this PR: fix/pipeline-cache-off @ ddcf10f6

Fixture	main @ 5e072fc8	this PR @ ddcf10f6
OFF failures	4/19	0/19

Game, RX 9070 XT, AMD 26.10.2, Ryzen 7 5700X3D, Windows 11: the standard test (Hyrule, 16:9, 20 s, unlocked), defaults (the switch unset; the fix only acts with it off), both runtimes from the same cache seed; this fix (backport 57f06de8) on base 839e85ff against 839e85ff. 3 alternating pairs, no warm-ups, all valid; diagnostic:

	839e85ff	+ this PR
fps (median)	61.74, 62.54, 63.09 (62.54)	63.19, 63.44, 64.79 (63.44)
CPU ms a frame (median)	65.21	65.44

Runs in docs/tested/. No gain claimed (the controls' stalls). With RX_VK_PCACHE_LOAD=0 main merged three play files; this PR merged none and rebuilt pipelines at start-up, too long for a timed run.

Testing

Tested: Windows: python -I -B tests/test_pipeline_play_cache.py --cxx clang++; fails on old code, passes now. Full suites: 516/9/36 pass/fail/skip each. Shared failures: test_check_third_party, test_fpx_sticky, test_framegen_resources, test_module_ids, test_oot_state_tap, test_pad_layout, test_release, test_spawn_emit, test_tested_configurations. Linux (WSL Ubuntu): vk_draw.cpp as an object with clang 21 and the build's Linux flags; the 19-case fixture passes there.

Not tested: current-main gameplay; linked Linux game.

Needs other testers: Linux OFF behavior (T-7NCG).

Screenshots

Nothing on screen.

Risk and rollback

Temporary cleanup and driver caching remain. Revert.

Reviewer notes

None.

Issues

None.

Checklist

For everyone

• One topic.
• The title is a Conventional Commit.
• Rebased on current main.
• python -I -B tests/run_all.py run; shared-main failures named above.
• Tested in the game, or untested scope named.
• Testing filled in: what ran, gaps and test requests.
• Measured: main and this PR at named commits, same PC/scene/settings, at least two interleaved runs each; medians.
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder needs PROVENANCE.md).
• The license is OK: GPL-3.0-or-later; compatible source, nothing decompiled.

If applicable

• AI assistance recorded with Assisted-by:/Co-Authored-By: trailers.
• Flags noted, and the switch reference updated.
• A file in docs/tested/ for each measured run, per guide.
• A game-free test added: fails on main, passes here.
• A check under tests/ that reads changed source updated without weakening.
• Host code builds on Windows/Linux with UTF-8 paths. Linux: object and fixture only; full build T-7NCG.
• Docs updated.

## Why `RX_VK_PCACHE_LOAD=0` still imported and saved rolling pipeline-cache files. ## What changed `vk_draw.cpp`: guard imports/generations. Extend existing fixtures/docs. ## Flags and settings None added. Existing `RX_VK_PCACHE_LOAD=0` skips application persistence; defaults unchanged. ## Measurements main: 5e072fc8 (2026-11-14) this PR: fix/pipeline-cache-off @ ddcf10f6 | Fixture | main @ 5e072fc8 | this PR @ ddcf10f6 | |---|---|---| | OFF failures | 4/19 | 0/19 | Game, RX 9070 XT, AMD 26.10.2, Ryzen 7 5700X3D, Windows 11: the standard test (Hyrule, 16:9, 20 s, unlocked), defaults (the switch unset; the fix only acts with it off), both runtimes from the same cache seed; this fix (backport 57f06de8) on base 839e85ff against 839e85ff. 3 alternating pairs, no warm-ups, all valid; diagnostic: | | 839e85ff | + this PR | |---|---|---| | fps (median) | 61.74, 62.54, 63.09 (62.54) | 63.19, 63.44, 64.79 (63.44) | | CPU ms a frame (median) | 65.21 | 65.44 | Runs in `docs/tested/`. No gain claimed (the controls' stalls). With `RX_VK_PCACHE_LOAD=0` main merged three play files; this PR merged none and rebuilt pipelines at start-up, too long for a timed run. ## Testing **Tested:** Windows: `python -I -B tests/test_pipeline_play_cache.py --cxx clang++`; fails on old code, passes now. Full suites: 516/9/36 pass/fail/skip each. Shared failures: test_check_third_party, test_fpx_sticky, test_framegen_resources, test_module_ids, test_oot_state_tap, test_pad_layout, test_release, test_spawn_emit, test_tested_configurations. Linux (WSL Ubuntu): `vk_draw.cpp` as an object with clang 21 and the build's Linux flags; the 19-case fixture passes there. **Not tested:** current-main gameplay; linked Linux game. **Needs other testers:** Linux OFF behavior (T-7NCG). ## Screenshots Nothing on screen. ## Risk and rollback Temporary cleanup and driver caching remain. Revert. ## Reviewer notes None. ## Issues None. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run; shared-main failures named above. - [x] Tested in the game, or untested scope named. - [x] Testing filled in: what ran, gaps and test requests. - [x] Measured: main and this PR at named commits, same PC/scene/settings, at least two interleaved runs each; medians. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder needs `PROVENANCE.md`). - [x] The license is OK: GPL-3.0-or-later; compatible source, nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:`/`Co-Authored-By:` trailers. - [x] Flags noted, and the switch reference updated. - [x] A file in `docs/tested/` for each measured run, per guide. - [x] A game-free test added: fails on main, passes here. - [x] A check under `tests/` that reads changed source updated without weakening. - [x] Host code builds on Windows/Linux with UTF-8 paths. Linux: object and fixture only; full build T-7NCG. - [x] Docs updated.

klimovich008 added 1 commit 2026-11-14 11:49:24 +00:00

fix(vk): honor cache-off for rolling pipeline files ... 24dfba29e6

Skip rolling imports and play-generation persistence with RX_VK_PCACHE_LOAD=0.
Required pipelines still build in memory; default cache handling is unchanged.
Extend the existing real-function fixture to cover startup and OFF routing.

Assisted-by: OpenAI Codex

klimovich008 commented 2026-11-14 11:50:07 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Description only: the Linux test request is open as T-7NCG (claimable once a maintainer adds the testing wanted label). Main has moved two commits since 0caf0618 (5e072fc8: #59, #400); this head still merges cleanly and was not rebased, so the fixture and suite results above stay those of 0caf0618. Still WIP.

Description only: the Linux test request is open as T-7NCG (claimable once a maintainer adds the testing wanted label). Main has moved two commits since 0caf0618 (5e072fc8: #59, #400); this head still merges cleanly and was not rebased, so the fixture and suite results above stay those of 0caf0618. Still WIP.

mooki added the

kind

bug

priority

high

labels 2026-11-14 12:24:54 +00:00

klimovich008 commented 2026-11-14 12:44:30 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Description only: the Rebased on current main box is unticked. This head is on 0caf0618, main is 5e072fc8; it merges cleanly, but it has not been rebased. Still WIP.

Description only: the Rebased on current main box is unticked. This head is on 0caf0618, main is 5e072fc8; it merges cleanly, but it has not been rebased. Still WIP.

klimovich008 force-pushed fix/pipeline-cache-off from 24dfba29e6 to ddcf10f609 2026-11-14 15:25:04 +00:00 Compare

klimovich008 commented 2026-11-14 15:26:07 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Rebased onto main 5e072fc8 (Codex: a03dc0ad, same four files) plus the run records (ddcf10f6). The fixture fails its OFF cases on main and passes here (19/19, also on Linux); full suite 516/9/36 with the same 9 failures as clean main. Measured: the standard test with defaults on both arms from the same cache seed, 3 valid pairs, no gain claimed. With RX_VK_PCACHE_LOAD=0, main merged three play files and this PR merged none; an OFF-arm timed run cannot finish here because the start-up rebuilds the pipelines. Linux: object and fixture with clang 21; T-7NCG for the full build. Taking it out of WIP.

Rebased onto main 5e072fc8 (Codex: a03dc0ad, same four files) plus the run records (ddcf10f6). The fixture fails its OFF cases on main and passes here (19/19, also on Linux); full suite 516/9/36 with the same 9 failures as clean main. Measured: the standard test with defaults on both arms from the same cache seed, 3 valid pairs, no gain claimed. With RX_VK_PCACHE_LOAD=0, main merged three play files and this PR merged none; an OFF-arm timed run cannot finish here because the start-up rebuilds the pipelines. Linux: object and fixture with clang 21; T-7NCG for the full build. Taking it out of WIP.

klimovich008 changed title from WIP: fix(vk): honor cache-off for rolling pipeline files to fix(vk): honor cache-off for rolling pipeline files 2026-11-14 15:26:27 +00:00

mooki added the

area/renderer

label 2026-11-14 16:27:52 +00:00

Some checks are pending

Hide checks

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request) Blocked by required conditions

Details

PR description / Description follows the template (pull_request_target) Successful in 29s

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

Some workflows are waiting to be reviewed.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'fix/pipeline-cache-off:klimovich008-fix/pipeline-cache-off'

git switch 'klimovich008-fix/pipeline-cache-off'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/upscaling

DLSS, FSR, frame generation

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Linux only

  

platform/steam-deck

Steam Deck

  

platform/windows

Windows only

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/upscaling

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!415

No description provided.