MagicBeanDev/Longshot

Watch

Fork 71

fix(vk): the page files' room to grow counts before the commit rule cuts the textures #346

Open

jarynclouatre wants to merge 1 commit from jarynclouatre/Longshot:fix/commit-room-growing-page-file into main

jarynclouatre commented

2026-11-14 03:03:33 +00:00

Contributor

Why

Issue 336: "Sometimes when I open my inventory menu or open the list to switch my items the game freezes for a second and the textures go black. It then goes back to normal." (RTX 5070 Ti, Ryzen 7 9800X3D, 32 GB, Windows, v3.0.0-rc.3.)

The issue's log shows the commit rule of #77 cutting the texture cache for about 90 minutes on a PC that was never at Windows' commit limit:

boot: 31849 MB of memory, 2048 MB of swap: a commit limit of 33.9 GB at the start.
487 vk: commit limit near: lines (one every 600 frames at most) between presents 98,400 and 422,280, with 308 to 2,556 MB of commit left.
The game's own commit (private in the vk: memory: line) plus the commit left rose from 24.3 GB to 36.1 GB over those lines. That is above the 33.9 GB limit of the start with every other program counted as nothing, so the limit itself grew. No mem: commit ... at the commit limit line in the log: Windows refused no commit.
In that time the budget count of the textures retired lines adds up to 292,526 textures. 473 of the 707 VRAM: lines show the textures' budget cut, to between 0 and 4,180 MB (11,000 MB otherwise), with 6.8 to 10.7 GB used of 15.2 GB allowed. After present 246,720 three evictions in a row (416, 361 and 56 textures) took the cache from 2,378 MB to 502 MB.

The rule reads GlobalMemoryStatusEx's ullAvailPageFile: what is left under the limit as it is now, RAM plus the page files at their size of the moment. A page file Windows manages (the default, and what the game's own low-memory notice asks for: "let it manage the page file's size") grows when the commit nears the limit, and the limit with it. So on such a PC the reading stays small for as long as the game's commit grows, and the rule takes textures away that are then made again.

What changed

vk (gpu/vk/commit_room.h, new; gpu/vk/vk_texture.cpp, commit_headroom): below the reserve, the headroom is what is left under the limit now plus what the page files can still grow by. Each file counts up to its maximum, and the files of one drive together no further than the drive has free. The sizes and maximums come from NtQuerySystemInformation's SystemPageFileInformationEx (0x90), the free space from GetDiskFreeSpaceExW; both are read at most once a second, and only while the commit left is below the reserve.
A file at its maximum, a fixed-size file, a full drive, a file whose drive is not in its name, or a failed query count for nothing. A PC at its real limit (#77's 16 GB PC with a fixed 32 GB page file, #333's with a fixed 16 GB one) is treated as before.
The log says vk: commit: N MB left under Windows' limit as it is now, and the page files can grow by N MB more: counted as room at most every 3600 frames while the growth is being counted.
docs: RX_VK_COMMIT_GROWTH=0 in docs/development.md's switch reference, and the RX_VK_COMMIT_RESERVE_MB row names it.
tests: tests/test_commit_room.py (new, with tests/test_commit_room.cpp) compiles and runs the rule: one file's growth, two files sharing a drive, a full drive, a file at or above its maximum, an unknown drive, the issue's numbers with and without the growth, and the reading of the query's records (a cut buffer, a name outside the buffer, a next offset that points back or past the end). It also checks that vk_texture.cpp uses the rule.

Flags and settings

Flag	New or changed	What it does	Default now	Goal: on by default?	Helps on	Doesn't help on	Untested on
`RX_VK_COMMIT_GROWTH=0`	New	The commit rule's headroom is what is left under the limit as it is now, as on `main`	Unset (the growth counts)	The change is on by default; the switch is for comparing	Windows PCs whose page file can still grow (Windows manages its size, or a custom size with a larger maximum)	A page file at its maximum or of a fixed size, a full drive; Linux (the rule is Windows only)	A 16 GB PC; AMD, Intel

Measurements

main: cf605c85 (2026-11-14)
this PR: fix/commit-room-growing-page-file @ 24c64183
Hardware: Windows 11, RTX 4070 Ti SUPER, Ryzen 7 9800X3D, 32 GB; the page file set to "Windows manages the size" for the runs (9,216 MB, a commit limit of 41,381 MB, 188 GB free on its drive)
Scene: Castle Town's gate and the guard house, by scripted input with one debug teleport, 22,200 presents a run, 1024x768
Method: the same exe (built from main), main's longshot_vk.dll against this PR's, four runs interleaved (main, PR, main, PR), each after a shader preparation of its own. The route does not reach the commit limit by itself (the game's own commit ends at 19 to 24 GB), so the rule was forced on all four runs as #77's test did: RX_VK_COMMIT_RESERVE_MB=21061, which is the commit left under the limit with the PC idle (36,061 MB) less 15,000 MB, so the rule acts once the game's commit passes about 15 GB. Both runs of a side are given, not a median.
How to reproduce: the two DLLs, a page file Windows manages, RX_VK_COMMIT_RESERVE_MB in longshot_env.txt set to the idle "left under the limit" less 15000, any route of a few minutes

	main @ `cf605c85` (run 1, run 2)	this PR @ `24c64183` (run 1, run 2)
`vk: commit limit near:` lines	26, 26	0, 0
lowest commit left under the limit of the moment	16,049 MB, 16,094 MB	no line; 20,292 MB and 20,355 MB at the first `vk: commit:` line
`vk: commit:` lines ("the page files can grow by 89088 MB more")	none	5, 5
`VRAM:` lines with the textures' budget cut (of 37)	25, 25, down to 0 MB	0, 0 (11,000 MB throughout)
textures retired for the budget	9,118 and 9,259	0 and 0
textures retired in all	22,279 and 22,308	14,195 and 12,403
refused commits (`mem: commit` lines)	0, 0	0, 0
the game's own commit at the end	19,345 MB, 18,977 MB	24,175 MB, 23,626 MB
fps at the last line	60.0, 59.9	59.8, 60.0
present intervals over 40 ms	22, 22	23, 26
present intervals of 30 to 40 ms	136, 146	252, 259

The 30 to 40 ms intervals: on both sides every 300 presents have 3 to 6 of them from the start of the run. On main they stop (0 to 2 in 300) from the point where the rule has cut the cache to a few hundred MB; on this PR they go on as before that point. So this PR's count is what main does while the rule is off, and what they are is not looked at here.

What the query gives for the page file on this PC, from a probe that uses the same header and calls (total, min, max in pages of 4 KB):

Windows manages the size:
ram 32165 MB, limit 41381 MB, left under it 36052 MB
record at 0: next 0 total 2359296 in_use 0 peak 0 min 2359296 max 25165824 (pages) name_bytes 38
file 0: drive C size 9216 MB max 98304 MB
drive C: free 188623 MB (ok 1)
growth 89088 MB, room 125140 MB
registry PagingFiles: ?:\pagefile.sys

A fixed size (this PC's own setting):
ram 32165 MB, limit 72165 MB, left under it 63611 MB
record at 0: next 0 total 10240000 in_use 0 peak 0 min 10240000 max 10240000 (pages) name_bytes 38
file 0: drive C size 40000 MB max 40000 MB
growth 0 MB, room 63611 MB
registry PagingFiles: c:\pagefile.sys 40000 40000

The game-free suite, python3 -I -B tests/run_all.py --jobs 4 --timeout 120 on a Linux x86-64 PC (gcc 15.2, Python 3.14.4), two runs each, interleaved:

	main @ `cf605c85`	this PR @ `24c64183`
`tests/run_all.py` (run 1, run 2)	473 passed, 4 failed, 82 skipped (both)	474 passed, 4 failed, 82 skipped (both)
failing checks	`test_bake_portability.py`, `test_menu_keys.py`, `test_module_ids.py`, `test_pad_layout.py`	the same four
`tests/test_commit_room.py`	fails: `vk_texture.cpp no longer has: #include "commit_room.h"`	passes

test_bake_portability.py fails here for a missing Python module (zstandard). test_menu_keys.py doesn't build with g++ and test_pad_layout.py's fixture lacks host/hold_toggle.h, both on main since #137 (#331 and #338 fix them). test_module_ids.py looks for a source marker that main no longer has.

Testing

Tested: the game on Windows 11 with a page file Windows manages, main's DLL against this PR's, two runs each, as in Measurements: with the rule forced, main cuts the textures' budget to 0 and retires about 9,200 textures for it in six minutes; this PR counts the 89,088 MB the page file can grow by, leaves the budget alone and retires none for it. The query on the same PC with the page file managed (a maximum of 98,304 MB, three times the RAM) and fixed (maximum = size, growth 0). The game-free suite on a Linux PC. longshot_vk.dll builds with llvm-mingw 20261104 (nx2/build.py --standalone, RX_VK_ONLY=1), no warning in the changed files.

Not tested: Windows growing the page file in play: the route stays far below the limit of the moment (the file stayed at its starting size), so the runs show the rule's reading, not the growth itself. For the growth there is issue 336's log, where the limit rose by more than 12 GB in play with no refused commit. A PC with 16 GB, two page files, and a drive that is nearly full, outside the game-free test.

Needs other testers: None.

Screenshots

Nothing on screen.

Risk and rollback

With the growth counted, a PC whose page file can still grow keeps its textures until Windows has grown the file to its maximum or the drive is full; from there the rule acts as on main. If Windows cannot grow the file as fast as the game commits, a commit can be refused for a moment: hos_commit and the first-touch handler already wait up to 5 s for that (#77), and the issue's log, where Windows grew the limit by more than 12 GB in play, has no refused commit. RX_VK_COMMIT_GROWTH=0 turns the change off; reverting the commit removes it.

Reviewer notes

SystemPageFileInformationEx is not in Microsoft's documentation (the record's layout is in phnt's ntexapi.h). The call is looked up in ntdll.dll at run time and its result is read inside the buffer only; if it fails, the headroom is ullAvailPageFile alone.
#341 (a host allocation at the limit waits, then says out of memory) is about a limit that was really reached and does not overlap.
memory_notice in host/hos_main.c also reads the limit of the moment (ullTotalPageFile) for its low-memory notice at the start. Not changed here.

Issues

For #336

Checklist

For everyone

One topic.
The title is a Conventional Commit (type(scope): description).
Rebased on current main.
python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
Tested in the game, or what wasn't is named under Testing.
Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
No game files, dumps, build output or generated files.
third_party/ untouched (a new folder with a PROVENANCE.md instead).
The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
A game-free test added for the fix, failing on main and passing here.
A check under tests/ that reads changed source updated in this PR, not weakened.
Flags noted, and the switch reference updated (docs/development.md, the README).
Docs updated.

## Why Issue 336: "Sometimes when I open my inventory menu or open the list to switch my items the game freezes for a second and the textures go black. It then goes back to normal." (RTX 5070 Ti, Ryzen 7 9800X3D, 32 GB, Windows, v3.0.0-rc.3.) The issue's log shows the commit rule of #77 cutting the texture cache for about 90 minutes on a PC that was never at Windows' commit limit: - `boot: 31849 MB of memory, 2048 MB of swap`: a commit limit of 33.9 GB at the start. - 487 `vk: commit limit near:` lines (one every 600 frames at most) between presents 98,400 and 422,280, with 308 to 2,556 MB of commit left. - The game's own commit (`private` in the `vk: memory:` line) plus the commit left rose from 24.3 GB to 36.1 GB over those lines. That is above the 33.9 GB limit of the start with every other program counted as nothing, so the limit itself grew. No `mem: commit ... at the commit limit` line in the log: Windows refused no commit. - In that time the `budget` count of the `textures retired` lines adds up to 292,526 textures. 473 of the 707 `VRAM:` lines show the textures' budget cut, to between 0 and 4,180 MB (11,000 MB otherwise), with 6.8 to 10.7 GB used of 15.2 GB allowed. After present 246,720 three evictions in a row (416, 361 and 56 textures) took the cache from 2,378 MB to 502 MB. The rule reads `GlobalMemoryStatusEx`'s `ullAvailPageFile`: what is left under the limit as it is now, RAM plus the page files at their size of the moment. A page file Windows manages (the default, and what the game's own low-memory notice asks for: "let it manage the page file's size") grows when the commit nears the limit, and the limit with it. So on such a PC the reading stays small for as long as the game's commit grows, and the rule takes textures away that are then made again. ## What changed - vk (`gpu/vk/commit_room.h`, new; `gpu/vk/vk_texture.cpp`, `commit_headroom`): below the reserve, the headroom is what is left under the limit now plus what the page files can still grow by. Each file counts up to its maximum, and the files of one drive together no further than the drive has free. The sizes and maximums come from `NtQuerySystemInformation`'s `SystemPageFileInformationEx` (0x90), the free space from `GetDiskFreeSpaceExW`; both are read at most once a second, and only while the commit left is below the reserve. - A file at its maximum, a fixed-size file, a full drive, a file whose drive is not in its name, or a failed query count for nothing. A PC at its real limit (#77's 16 GB PC with a fixed 32 GB page file, #333's with a fixed 16 GB one) is treated as before. - The log says `vk: commit: N MB left under Windows' limit as it is now, and the page files can grow by N MB more: counted as room` at most every 3600 frames while the growth is being counted. - docs: `RX_VK_COMMIT_GROWTH=0` in `docs/development.md`'s switch reference, and the `RX_VK_COMMIT_RESERVE_MB` row names it. - tests: `tests/test_commit_room.py` (new, with `tests/test_commit_room.cpp`) compiles and runs the rule: one file's growth, two files sharing a drive, a full drive, a file at or above its maximum, an unknown drive, the issue's numbers with and without the growth, and the reading of the query's records (a cut buffer, a name outside the buffer, a next offset that points back or past the end). It also checks that `vk_texture.cpp` uses the rule. ## Flags and settings | Flag | New or changed | What it does | Default now | Goal: on by default? | Helps on | Doesn't help on | Untested on | |---|---|---|---|---|---|---|---| | `RX_VK_COMMIT_GROWTH=0` | New | The commit rule's headroom is what is left under the limit as it is now, as on `main` | Unset (the growth counts) | The change is on by default; the switch is for comparing | Windows PCs whose page file can still grow (Windows manages its size, or a custom size with a larger maximum) | A page file at its maximum or of a fixed size, a full drive; Linux (the rule is Windows only) | A 16 GB PC; AMD, Intel | ## Measurements main: cf605c85 (2026-11-14) this PR: fix/commit-room-growing-page-file @ 24c64183 Hardware: Windows 11, RTX 4070 Ti SUPER, Ryzen 7 9800X3D, 32 GB; the page file set to "Windows manages the size" for the runs (9,216 MB, a commit limit of 41,381 MB, 188 GB free on its drive) Scene: Castle Town's gate and the guard house, by scripted input with one debug teleport, 22,200 presents a run, 1024x768 Method: the same exe (built from main), main's `longshot_vk.dll` against this PR's, four runs interleaved (main, PR, main, PR), each after a shader preparation of its own. The route does not reach the commit limit by itself (the game's own commit ends at 19 to 24 GB), so the rule was forced on all four runs as #77's test did: `RX_VK_COMMIT_RESERVE_MB=21061`, which is the commit left under the limit with the PC idle (36,061 MB) less 15,000 MB, so the rule acts once the game's commit passes about 15 GB. Both runs of a side are given, not a median. How to reproduce: the two DLLs, a page file Windows manages, `RX_VK_COMMIT_RESERVE_MB` in `longshot_env.txt` set to the idle "left under the limit" less 15000, any route of a few minutes | | main @ cf605c85 (run 1, run 2) | this PR @ 24c64183 (run 1, run 2) | |---|---|---| | `vk: commit limit near:` lines | 26, 26 | 0, 0 | | lowest commit left under the limit of the moment | 16,049 MB, 16,094 MB | no line; 20,292 MB and 20,355 MB at the first `vk: commit:` line | | `vk: commit:` lines ("the page files can grow by 89088 MB more") | none | 5, 5 | | `VRAM:` lines with the textures' budget cut (of 37) | 25, 25, down to 0 MB | 0, 0 (11,000 MB throughout) | | textures retired for the budget | 9,118 and 9,259 | 0 and 0 | | textures retired in all | 22,279 and 22,308 | 14,195 and 12,403 | | refused commits (`mem: commit` lines) | 0, 0 | 0, 0 | | the game's own commit at the end | 19,345 MB, 18,977 MB | 24,175 MB, 23,626 MB | | fps at the last line | 60.0, 59.9 | 59.8, 60.0 | | present intervals over 40 ms | 22, 22 | 23, 26 | | present intervals of 30 to 40 ms | 136, 146 | 252, 259 | The 30 to 40 ms intervals: on both sides every 300 presents have 3 to 6 of them from the start of the run. On main they stop (0 to 2 in 300) from the point where the rule has cut the cache to a few hundred MB; on this PR they go on as before that point. So this PR's count is what main does while the rule is off, and what they are is not looked at here. What the query gives for the page file on this PC, from a probe that uses the same header and calls (`total`, `min`, `max` in pages of 4 KB): ``` Windows manages the size: ram 32165 MB, limit 41381 MB, left under it 36052 MB record at 0: next 0 total 2359296 in_use 0 peak 0 min 2359296 max 25165824 (pages) name_bytes 38 file 0: drive C size 9216 MB max 98304 MB drive C: free 188623 MB (ok 1) growth 89088 MB, room 125140 MB registry PagingFiles: ?:\pagefile.sys A fixed size (this PC's own setting): ram 32165 MB, limit 72165 MB, left under it 63611 MB record at 0: next 0 total 10240000 in_use 0 peak 0 min 10240000 max 10240000 (pages) name_bytes 38 file 0: drive C size 40000 MB max 40000 MB growth 0 MB, room 63611 MB registry PagingFiles: c:\pagefile.sys 40000 40000 ``` The game-free suite, `python3 -I -B tests/run_all.py --jobs 4 --timeout 120` on a Linux x86-64 PC (gcc 15.2, Python 3.14.4), two runs each, interleaved: | | main @ cf605c85 | this PR @ 24c64183 | |---|---|---| | `tests/run_all.py` (run 1, run 2) | 473 passed, 4 failed, 82 skipped (both) | 474 passed, 4 failed, 82 skipped (both) | | failing checks | `test_bake_portability.py`, `test_menu_keys.py`, `test_module_ids.py`, `test_pad_layout.py` | the same four | | `tests/test_commit_room.py` | fails: `vk_texture.cpp no longer has: #include "commit_room.h"` | passes | `test_bake_portability.py` fails here for a missing Python module (zstandard). `test_menu_keys.py` doesn't build with g++ and `test_pad_layout.py`'s fixture lacks `host/hold_toggle.h`, both on main since #137 (#331 and #338 fix them). `test_module_ids.py` looks for a source marker that main no longer has. ## Testing **Tested:** the game on Windows 11 with a page file Windows manages, main's DLL against this PR's, two runs each, as in Measurements: with the rule forced, main cuts the textures' budget to 0 and retires about 9,200 textures for it in six minutes; this PR counts the 89,088 MB the page file can grow by, leaves the budget alone and retires none for it. The query on the same PC with the page file managed (a maximum of 98,304 MB, three times the RAM) and fixed (maximum = size, growth 0). The game-free suite on a Linux PC. `longshot_vk.dll` builds with llvm-mingw 20261104 (`nx2/build.py --standalone`, `RX_VK_ONLY=1`), no warning in the changed files. **Not tested:** Windows growing the page file in play: the route stays far below the limit of the moment (the file stayed at its starting size), so the runs show the rule's reading, not the growth itself. For the growth there is issue 336's log, where the limit rose by more than 12 GB in play with no refused commit. A PC with 16 GB, two page files, and a drive that is nearly full, outside the game-free test. **Needs other testers:** None. ## Screenshots Nothing on screen. ## Risk and rollback With the growth counted, a PC whose page file can still grow keeps its textures until Windows has grown the file to its maximum or the drive is full; from there the rule acts as on `main`. If Windows cannot grow the file as fast as the game commits, a commit can be refused for a moment: `hos_commit` and the first-touch handler already wait up to 5 s for that (#77), and the issue's log, where Windows grew the limit by more than 12 GB in play, has no refused commit. `RX_VK_COMMIT_GROWTH=0` turns the change off; reverting the commit removes it. ## Reviewer notes - `SystemPageFileInformationEx` is not in Microsoft's documentation (the record's layout is in phnt's `ntexapi.h`). The call is looked up in `ntdll.dll` at run time and its result is read inside the buffer only; if it fails, the headroom is `ullAvailPageFile` alone. - #341 (a host allocation at the limit waits, then says out of memory) is about a limit that was really reached and does not overlap. - `memory_notice` in `host/hos_main.c` also reads the limit of the moment (`ullTotalPageFile`) for its low-memory notice at the start. Not changed here. ## Issues For #336 ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Flags noted, and the switch reference updated (docs/development.md, the README). - [x] Docs updated.

jarynclouatre added 1 commit

2026-11-14 03:03:33 +00:00

fix(vk): the page files' room to grow counts before the commit rule cuts the textures

PR description / Description follows the template (pull_request_target) Successful in 4s

Details

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

24c6418328

The textures' budget gives commit back below a reserve of 2560 MB under
Windows' commit limit. The headroom was GlobalMemoryStatusEx's
ullAvailPageFile: the limit as it is now, RAM plus the page files at their
size of the moment. A page file Windows manages grows as the commit nears
that limit, and the limit with it.

In issue 336's log (32 GB, a 2 GB page file at the start, RTX 5070 Ti) the
rule was on for about 90 minutes with 0.3 to 2.5 GB left under the limit of the
moment. The game's own commit plus what was left rose from 24.3 to 36.1 GB,
above the 33.9 GB limit of the start, and no commit was refused. In that
time the rule took 292,526 textures out of the cache, with the budget down
to 0 at its lowest (2,378 MB of textures to 502 MB in three evictions): the
textures going black and coming back that the issue reports.

Below the reserve the headroom now adds what the page files can still grow
by: each file up to its maximum (NtQuerySystemInformation's
SystemPageFileInformationEx), the files of one drive together no further
than the drive has free. Read at most once a second, and only below the
reserve. A file at its maximum, a full drive or a failed query count for
nothing, so a PC at its real limit is treated as before.
RX_VK_COMMIT_GROWTH=0 is the old reading.

mooki added the

kind

bug

label

2026-11-14 03:55:09 +00:00

mooki added the

priority

high

label

2026-11-14 04:18:41 +00:00

jarynclouatre changed title from ~~WIP: fix(vk): the page files' room to grow counts before the commit rule cuts the textures~~ to fix(vk): the page files' room to grow counts before the commit rule cuts the textures

2026-11-14 05:30:09 +00:00

tonesi referenced this pull request

2026-11-14 07:53:02 +00:00

Game: on 16 GB of RAM the game's memory outgrows RAM within a minute of loading a save, then swap fills on area changes until RAM is at 0 #388

suporte_de_cadeira commented

2026-11-14 13:29:28 +00:00

First-time contributor

Windows compile and game-free checks for head 24c64183:

longshot_vk.dll built with the pinned llvm-mingw 20261104 (RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows, --jobs 6): 0 failed, linked.
tests/test_commit_limit.py and tests/test_commit_room.py: pass.

No game run here, so the inventory freeze on a real Windows GPU still needs the scene from issue 336. The build and the two checks are clean on Windows.

Windows compile and game-free checks for head `24c64183`: - `longshot_vk.dll` built with the pinned llvm-mingw 20261104 (`RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows`, `--jobs 6`): 0 failed, linked. - `tests/test_commit_limit.py` and `tests/test_commit_room.py`: pass. No game run here, so the inventory freeze on a real Windows GPU still needs the scene from issue 336. The build and the two checks are clean on Windows.

mooki added the

area/renderer

label

2026-11-14 16:27:40 +00:00

PR description / Description follows the template (pull_request_target) Successful in 4s

Details

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

Some workflows are waiting to be reviewed.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'fix/commit-room-growing-page-file:jarynclouatre-fix/commit-room-growing-page-file'

git switch 'jarynclouatre-fix/commit-room-growing-page-file'

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!346

No description provided.

Rows
Columns