WIP: feat(agents): pin test requests and results to commits (restored from Hookshot) #285
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/upscaling
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
testing wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!285
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:restore/test-request-pins"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
Test requests and their results were not tied to a commit, so a result for one head of a PR could be taken for a later
one. Hookshot fixed that after Longshot branched; this brings it back on its own, since it changes
scripts/test_requests.py's commands for the whole team. Split out of #209.What changed
Split out of #209 as its reviewer asked (review on #209, point 4, group b). Each commit is the merged Hookshot pull request under its original author, carried through Longshot's rename; a
Restored-from:trailer names it, and the bare Hookshot numbers in the messages and the restored text are now full URLs.Credit to the authors of the restored work: Mooki.
scripts/test_requests.pypins a request to the PR's head when it is made,claimnames the commit to buildand refuses (showing both) when the head moved, and results carry the commit they tested. Ported to Forgejo:
pr_inforeads the head and base from git.magicbean.dev and keeps Longshot's writer checkdocs/test-requests.md("Which commit?"), the request-testing and testing skills,AGENTS.mdtests/test_test_requests.pySplit siblings: tools, checks and docs #284, rc.4 player fixes #286, renderer fixes #287, new defaults and speed-ups #288.
Commits, in order:
e3995648feat(agents): pin test requests and results to commits (Hookshot 2830, by Mooki)e76ff0d6docs: the restored Hookshot references as full URLs (mine)Flags and settings
test_requests.py claim <id> --commit <sha>requestMeasurements
No game change: the measurement is the game-free checks, main and this PR on the same PC.
main:
d9648863(2026-11-13)this PR: restore/test-request-pins @ 8ca57d0d (the runs; now
e76ff0d6, after the docs-only rebase onto main's514591a3)Hardware: RTX 4070 Ti (driver 595.99.02), Ryzen 7 9800X3D, Ubuntu 26.04.1
Scene: none (game-free checks)
Method:
python3 -I -B tests/run_all.py --jobs 6, once on eachHow to reproduce: the same command on each commit
d9648863run_all.py: passed / failed / skippedThe numbers still hold on
514591a3: main's #274 changed a Discord link in 11 docs files and nothing these checks or builds compile; the checks that read those docs were run again on this head.Testing
Tested:
python3 -I -B tests/run_all.py --jobs 6on Linux (Ubuntu 26.04.1, Python 3.14, Vulkan and SPIR-V headers found): this PR @8ca57d0d: 513 passed, 2 failed, 18 skipped (test_lift_cache.py, test_menu_i18n.py); main @d9648863on the same PC: 513 passed, 2 failed, 18 skipped (test_lift_cache.py, test_menu_i18n.py).test_lift_cachefails on main the same way (the lift's scripts do not import here), andtest_menu_i18nfails on that main too. Main then gained514591a3(#274, a Discord link in 11 docs files only); after the rebase onto it, the checks that read those docs passed again ate76ff0d6.Not tested: a request, claim and result through the room with this client (it would post to the team's room); old
cards still replay in the tests. No hardware is involved; one request end to end after it merges would show it live.
Needs other testers: None
Screenshots
Nothing on screen
Risk and rollback
Changes the commands everyone uses for test requests. Old cards still replay; reverting the commit restores the current
client.
Reviewer notes
Please merge with rebase, not squash, so that its author keeps the commit.
Issues
See #209
Checklist
For everyone
type(scope): description).main.python -I -B tests/run_all.pyrun and passing (any failure that also fails onmainis named above).third_party/untouched (a new folder with aPROVENANCE.mdinstead).If applicable
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.