feat(graphics): extend the FOV slider to 300 percent #199

Open
brunobaccari wants to merge 3 commits from brunobaccari/Longshot:feat/longshot-fov-range-300 into main
First-time contributor

Why

Players who want a wider gameplay view currently reach the slider's limit at 150%. This extends the existing Field of view control to 300% and places it under Graphics.

What changed

  • Move the existing row from Gameplay to Graphics → Detail; extend 50–150% to 50–300%, in steps of 5.
  • Extend the accepted range in host/oot_fov.c. Preserve default 100%, the saved field_of_view key, option ID, the 5–140 degree angular clamp, gameplay camera ownership and event-camera exclusion.
  • Update the existing FOV fixture, menu option comment, README and development reference. Record four historical runs at their original commit identities.

Flags and settings

Flag What it does Default now Recommendation Helps on Doesn't help on Untested on
Graphics → Field of view / field_of_view Multiply the current native vertical gameplay angle by 50–300%; final angle remains within 5–140 degrees 100% Keep 100% for the original camera; larger values widen and distort the view Players wanting a wider view Performance optimization; more geometry can increase GPU work Current rebased runtime; aiming/zoom at 300%; Linux gameplay

No new environment variable, option ID, save format or renderer interface.

Measurements

main: 514591a3 (2026-11-13)
this PR: feat/longshot-fov-range-300 @ e2e7f320
Hardware: Windows 11 Pro, Ryzen 5 3600, 64 GB RAM, Radeon RX 5500 XT 8 GB / AMD 26.10.1.
Scene and settings for current runtime comparison: pending. The intended comparison is Kokiri Forest with identical save/camera, 1920×1080 native, upscaler/FG/V-Sync off, uncapped, audio 0, visible NoActivate window.
Method: read-only API/Git review identifies current head e2e7f320 on main 514591a3. Its three topic patches match the previously checked 3439a77a series (git range-diff); the intervening main change updates Discord links. The earlier focused checks below retain their original commit identities. No new suite, build or gameplay result is claimed. Full current-head suite, application build and interleaved gameplay measurements remain pending; shared build/GPU resources are reserved for the separate PR200 validation.

Check main @ 514591a3 this PR @ e2e7f320
Source range / location 50–150%, Gameplay 50–300%, Graphics
Default / angular clamp 100% / 5–140° Unchanged
Focused Windows checks Not rerun on this main; prior d9648863 translation failure is recorded below Not rerun on this head; 4 checks passed at 3439a77a and an earlier 76aad7d2 run had 7 passed / 1 baseline failure
Full current Windows suite Not rerun on this main Not run on this head
Current interleaved runtime comparison Pending Pending

Historical evidence only: main 0c74253d and FOV 446c856e had two interleaved 600-frame windows each at FOV 100%. Median run FPS was 21.3899 / 21.8349; the baseline runs varied 11.6%, so no gain, regression or zero-cost conclusion was established. The four runs are retained in docs/tested-configurations.md. Main has since changed GPU occlusion handling; these results do not validate the present commits.

Testing

Tested: Current read-only Git/API verification confirms e2e7f320 on 514591a3, with all three topic patches unchanged from 3439a77a. The current diff remains seven files, 17 insertions and 9 deletions; git diff --check and merge simulation pass. No source test, application build or game session was started for this metadata update.

Earlier rebase checkpoint at 3439a77a: all three remote topic commits from bd8912e7 were rebased onto d9648863. The README conflict retains upstream HDR/AMD FSR 4 documentation and the Graphics FOV row. The menu header retains upstream Damage taken and the FOV default/range comment. The later mouse and controller-layout fixes are included unchanged. The final diff is still seven files, 17 insertions and 9 deletions. git diff --check passes; local merge simulation against d9648863 has no conflicts. An independent source review found no issue in the conflict resolution.

At intermediate head 76aad7d2, eight serial Windows checks completed: seven passed (damage_debug_menu, framegen_preset, menu_keys, oot_damage, oot_fov, option_ids, readme_menu_rows), and menu_i18n failed because the PT-BR table still contains an old Debug help key. The same assertion was independently reproduced using the exact four required blobs from both main d906c8f4 and then-current main d9648863: four unit tests passed and one failed in each. The translation key ends in own speed., while the current menu help ends in own speed and damage.. No translation or assertion was changed by this FOV PR.

After incorporating the final upstream controller-layout fix, 3439a77a passed all four repeated/new checks: framegen_preset, oot_fov, pad_layout, and readme_menu_rows (4 passed, 0 failed, 0 skipped in 74 s, serial Windows run). The prior eight-check run took 271 s while the manual Launcher preparation was active. These elapsed times are test-run durations, not game performance measurements.

Reproduce focused checks using Builder Python and llvm-mingw with LONGSHOT_MINGW and RX_CPM configured: python -I -B tests/run_all.py --jobs 1 oot_fov readme_menu_rows menu_keys option_ids framegen_preset menu_i18n damage_debug_menu oot_damage pad_layout.

Earlier completed suite, explicitly at 4e0d71f9: 492 passed, 4 failed, 33 skipped in 883 s. All four failure names reproduced on clean main f647a072: nx2/test_nup_paths.py needs Windows symlink privilege 1314; test_bug_report.py rejects byte 0xe3 in an OS diagnostic as UTF-8; test_check_third_party.py fails its authored clean-tree fixture; test_release.py needs OpenSSL and encounters a non-Win32 git-cliff fixture plus a CRLF/LF assertion. These are historical baseline results, not a current-main reproduction or a clean pass.

Earlier Linux focal validation at 4e0d71f9 passed in disposable Alpine 3.22 containers (GCC/G++ 14.2.0, Python 3.12.16): the FOV Python/C fixture, menu-key fixture, and object compilation of actual host/oot_fov.c with official runtime headers generated by the existing helper. FOV source and those fixtures remain unchanged. No full Linux application or gameplay validation is claimed.

Not tested: Focused checks, full suite and complete Windows application/renderer build at current e2e7f320; current gameplay at 100/150/200/300%, reset, event cameras, aiming/zoom at 300%; new interleaved measurements/screenshots. Earlier full-suite/build attempts at 5844f707 were stopped to yield resources to the user's manual Launcher build; its processes were left untouched. Only lightweight serial checks were run at the earlier named checkpoints, without game assets or GPU; none were rerun for this metadata update. Earlier visible FOV/event-camera checks at 446c856e are historical.

Needs other testers: None. Author validation remains incomplete; no external testing is requested. The PR remains WIP until the pending author checks and measurements listed above are completed.

Screenshots

Historical captures only; new captures from the rebased build are pending.

Historical main @ 0c74253d, FOV 100%, Kokiri Forest
Historical FOV @ 446c856e, FOV 100%, Kokiri Forest
Historical FOV @ 446c856e, FOV 300%, Kokiri Forest
Historical FOV @ 446c856e, Graphics Detail slider at 100%
Historical FOV @ 446c856e, native Great Deku Tree event with option at 300%

Risk and rollback

High FOV values cause strong peripheral distortion and may increase rendering work. The percentage multiplies the native vertical angle subject to the retained 140-degree ceiling. Select 100% to restore the native gameplay angle on the next update. Revert the topic commits to restore the old range and location; no save migration or assets change.

Reviewer notes

Start at hos_oot_fov() and the Graphics row in gpu/vk/vk_menu.cpp. The diff contains only the existing FOV feature and its documentation/tests; upstream Damage taken, HDR/FSR 4, mouse and controller-layout behavior is preserved. The earlier push of 3439a77a used an explicit lease for remote bd8912e7; this metadata update does not push or alter the current e2e7f320 head.

Issues

Player-requested camera adjustment; no issue is closed.

Checklist

For everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description).
  • Rebased on current main. — 514591a3, verified by API/Git on 2026-11-13.
  • python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above). — Not run on this head; earlier 492/4/33 and baseline reproductions are identified above.
  • Tested in the game, or what wasn't is named under Testing. — Current-build game validation pending and named above.
  • Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
  • Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. — Current-build runs pending; old runs are explicitly historical.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Flags noted, and the switch reference updated (docs/development.md, the README).
  • Screenshots for a change that shows on screen. — Historical captures attached; current-head captures pending.
  • A row in docs/tested-configurations.md for each measured run. — Four historical runs, explicitly identified.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. — Linux actual host unit compiled and fixtures passed; current Windows application build pending.
  • Docs updated.
## Why Players who want a wider gameplay view currently reach the slider's limit at 150%. This extends the existing Field of view control to 300% and places it under Graphics. ## What changed - Move the existing row from Gameplay to Graphics → Detail; extend 50–150% to 50–300%, in steps of 5. - Extend the accepted range in `host/oot_fov.c`. Preserve default 100%, the saved `field_of_view` key, option ID, the 5–140 degree angular clamp, gameplay camera ownership and event-camera exclusion. - Update the existing FOV fixture, menu option comment, README and development reference. Record four historical runs at their original commit identities. ## Flags and settings | Flag | What it does | Default now | Recommendation | Helps on | Doesn't help on | Untested on | |---|---|---|---|---|---|---| | Graphics → Field of view / `field_of_view` | Multiply the current native vertical gameplay angle by 50–300%; final angle remains within 5–140 degrees | 100% | Keep 100% for the original camera; larger values widen and distort the view | Players wanting a wider view | Performance optimization; more geometry can increase GPU work | Current rebased runtime; aiming/zoom at 300%; Linux gameplay | No new environment variable, option ID, save format or renderer interface. ## Measurements main: 514591a3 (2026-11-13) this PR: feat/longshot-fov-range-300 @ e2e7f320 Hardware: Windows 11 Pro, Ryzen 5 3600, 64 GB RAM, Radeon RX 5500 XT 8 GB / AMD 26.10.1. Scene and settings for current runtime comparison: pending. The intended comparison is Kokiri Forest with identical save/camera, 1920×1080 native, upscaler/FG/V-Sync off, uncapped, audio 0, visible NoActivate window. Method: read-only API/Git review identifies current head e2e7f320 on main 514591a3. Its three topic patches match the previously checked 3439a77a series (git range-diff); the intervening main change updates Discord links. The earlier focused checks below retain their original commit identities. No new suite, build or gameplay result is claimed. Full current-head suite, application build and interleaved gameplay measurements remain pending; shared build/GPU resources are reserved for the separate PR200 validation. | Check | main @ 514591a3 | this PR @ e2e7f320 | |---|---|---| | Source range / location | 50–150%, Gameplay | 50–300%, Graphics | | Default / angular clamp | 100% / 5–140° | Unchanged | | Focused Windows checks | Not rerun on this main; prior d9648863 translation failure is recorded below | Not rerun on this head; 4 checks passed at 3439a77a and an earlier 76aad7d2 run had 7 passed / 1 baseline failure | | Full current Windows suite | Not rerun on this main | Not run on this head | | Current interleaved runtime comparison | Pending | Pending | Historical evidence only: main `0c74253d` and FOV `446c856e` had two interleaved 600-frame windows each at FOV 100%. Median run FPS was 21.3899 / 21.8349; the baseline runs varied 11.6%, so no gain, regression or zero-cost conclusion was established. The four runs are retained in `docs/tested-configurations.md`. Main has since changed GPU occlusion handling; these results do not validate the present commits. ## Testing **Tested:** Current read-only Git/API verification confirms `e2e7f320` on `514591a3`, with all three topic patches unchanged from `3439a77a`. The current diff remains seven files, 17 insertions and 9 deletions; `git diff --check` and merge simulation pass. No source test, application build or game session was started for this metadata update. Earlier rebase checkpoint at `3439a77a`: all three remote topic commits from `bd8912e7` were rebased onto `d9648863`. The README conflict retains upstream HDR/AMD FSR 4 documentation and the Graphics FOV row. The menu header retains upstream Damage taken and the FOV default/range comment. The later mouse and controller-layout fixes are included unchanged. The final diff is still seven files, 17 insertions and 9 deletions. `git diff --check` passes; local merge simulation against `d9648863` has no conflicts. An independent source review found no issue in the conflict resolution. At intermediate head `76aad7d2`, eight serial Windows checks completed: seven passed (`damage_debug_menu`, `framegen_preset`, `menu_keys`, `oot_damage`, `oot_fov`, `option_ids`, `readme_menu_rows`), and `menu_i18n` failed because the PT-BR table still contains an old Debug help key. The same assertion was independently reproduced using the exact four required blobs from both main `d906c8f4` and then-current main `d9648863`: four unit tests passed and one failed in each. The translation key ends in `own speed.`, while the current menu help ends in `own speed and damage.`. No translation or assertion was changed by this FOV PR. After incorporating the final upstream controller-layout fix, `3439a77a` passed all four repeated/new checks: `framegen_preset`, `oot_fov`, `pad_layout`, and `readme_menu_rows` (4 passed, 0 failed, 0 skipped in 74 s, serial Windows run). The prior eight-check run took 271 s while the manual Launcher preparation was active. These elapsed times are test-run durations, not game performance measurements. Reproduce focused checks using Builder Python and llvm-mingw with `LONGSHOT_MINGW` and `RX_CPM` configured: `python -I -B tests/run_all.py --jobs 1 oot_fov readme_menu_rows menu_keys option_ids framegen_preset menu_i18n damage_debug_menu oot_damage pad_layout`. Earlier completed suite, explicitly at `4e0d71f9`: 492 passed, 4 failed, 33 skipped in 883 s. All four failure names reproduced on clean main `f647a072`: `nx2/test_nup_paths.py` needs Windows symlink privilege 1314; `test_bug_report.py` rejects byte `0xe3` in an OS diagnostic as UTF-8; `test_check_third_party.py` fails its authored clean-tree fixture; `test_release.py` needs OpenSSL and encounters a non-Win32 git-cliff fixture plus a CRLF/LF assertion. These are historical baseline results, not a current-main reproduction or a clean pass. Earlier Linux focal validation at `4e0d71f9` passed in disposable Alpine 3.22 containers (GCC/G++ 14.2.0, Python 3.12.16): the FOV Python/C fixture, menu-key fixture, and object compilation of actual `host/oot_fov.c` with official runtime headers generated by the existing helper. FOV source and those fixtures remain unchanged. No full Linux application or gameplay validation is claimed. **Not tested:** Focused checks, full suite and complete Windows application/renderer build at current `e2e7f320`; current gameplay at 100/150/200/300%, reset, event cameras, aiming/zoom at 300%; new interleaved measurements/screenshots. Earlier full-suite/build attempts at `5844f707` were stopped to yield resources to the user's manual Launcher build; its processes were left untouched. Only lightweight serial checks were run at the earlier named checkpoints, without game assets or GPU; none were rerun for this metadata update. Earlier visible FOV/event-camera checks at `446c856e` are historical. **Needs other testers:** None. Author validation remains incomplete; no external testing is requested. The PR remains WIP until the pending author checks and measurements listed above are completed. ## Screenshots Historical captures only; new captures from the rebased build are pending. ![Historical main @ 0c74253d, FOV 100%, Kokiri Forest](https://git.magicbean.dev/attachments/be96f87e-9ccb-412f-b326-c46900dc34c4) ![Historical FOV @ 446c856e, FOV 100%, Kokiri Forest](https://git.magicbean.dev/attachments/9a8c144b-3a9d-4625-b667-525906ac005e) ![Historical FOV @ 446c856e, FOV 300%, Kokiri Forest](https://git.magicbean.dev/attachments/2d12aa42-bcc6-41a8-ad92-1c8cc5e1aae9) ![Historical FOV @ 446c856e, Graphics Detail slider at 100%](https://git.magicbean.dev/attachments/ff037e4e-bfd0-4477-8ebe-f83fa61ab2ae) ![Historical FOV @ 446c856e, native Great Deku Tree event with option at 300%](https://git.magicbean.dev/attachments/e47d452d-7dce-4001-92e2-cffb5ed31f44) ## Risk and rollback High FOV values cause strong peripheral distortion and may increase rendering work. The percentage multiplies the native vertical angle subject to the retained 140-degree ceiling. Select 100% to restore the native gameplay angle on the next update. Revert the topic commits to restore the old range and location; no save migration or assets change. ## Reviewer notes Start at `hos_oot_fov()` and the Graphics row in `gpu/vk/vk_menu.cpp`. The diff contains only the existing FOV feature and its documentation/tests; upstream Damage taken, HDR/FSR 4, mouse and controller-layout behavior is preserved. The earlier push of `3439a77a` used an explicit lease for remote `bd8912e7`; this metadata update does not push or alter the current `e2e7f320` head. ## Issues Player-requested camera adjustment; no issue is closed. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. — `514591a3`, verified by API/Git on 2026-11-13. - [ ] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). — Not run on this head; earlier 492/4/33 and baseline reproductions are identified above. - [ ] Tested in the game, or what wasn't is named under Testing. — Current-build game validation pending and named above. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [ ] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. — Current-build runs pending; old runs are explicitly historical. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Flags noted, and the switch reference updated (docs/development.md, the README). - [ ] Screenshots for a change that shows on screen. — Historical captures attached; current-head captures pending. - [x] A row in `docs/tested-configurations.md` for each measured run. — Four historical runs, explicitly identified. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. — Linux actual host unit compiled and fixtures passed; current Windows application build pending. - [x] Docs updated.
Keep the native camera projection and angular bounds, move the existing slider to Graphics, and cover the extended range.

Assisted-by: Codex

Co-Authored-By: OpenAI Codex <[email protected]>
docs: align FOV option table with Graphics slider
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
446c856ef9
Document the Graphics location and 50–300% range of the FOV slider.

Assisted-by: Codex

Co-Authored-By: OpenAI Codex <[email protected]>
Author
First-time contributor

Ran the full Windows suite: 482 passed, 7 failed, 33 skipped, with source and fixture hashes unchanged. Baseline reproductions and the passing serial cleanup recheck are documented in the description. The actual changed host C also compiled on Linux. Release builds and in-game measurements are still in progress; this remains WIP.

Ran the full Windows suite: 482 passed, 7 failed, 33 skipped, with source and fixture hashes unchanged. Baseline reproductions and the passing serial cleanup recheck are documented in the description. The actual changed host C also compiled on Linux. Release builds and in-game measurements are still in progress; this remains WIP.
Author
First-time contributor

The complete Windows standalone build linked the executable and Vulkan renderer with zero failures. The actual changed host translation unit also compiled on Linux; this is not a full Linux application or GPU run. Main has advanced only in README/CONTRIBUTING since the named build base; the final rebase is pending while the current runtime comparison is preserved. A warmed Kokiri baseline image is attached. Scripted, visible in-game comparisons are in progress; WIP remains until the repeated measurements and FOV captures are complete.

The complete Windows standalone build linked the executable and Vulkan renderer with zero failures. The actual changed host translation unit also compiled on Linux; this is not a full Linux application or GPU run. Main has advanced only in README/CONTRIBUTING since the named build base; the final rebase is pending while the current runtime comparison is preserved. A warmed Kokiri baseline image is attached. Scripted, visible in-game comparisons are in progress; WIP remains until the repeated measurements and FOV captures are complete.
brunobaccari changed title from WIP: feat(graphics): extend the FOV slider to 300 percent to feat(graphics): extend the FOV slider to 300 percent 2026-11-13 15:34:17 +00:00
Merge branch 'main' into feat/longshot-fov-range-300
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 10s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
6af043c322
brunobaccari force-pushed feat/longshot-fov-range-300 from 6af043c322
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 10s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 32227d8fb3
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 33s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-13 16:10:39 +00:00
Compare
Merge branch 'main' into feat/longshot-fov-range-300
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
73e84b49b1
brunobaccari changed title from feat(graphics): extend the FOV slider to 300 percent to WIP: feat(graphics): extend the FOV slider to 300 percent 2026-11-13 16:54:11 +00:00
brunobaccari force-pushed feat/longshot-fov-range-300 from 73e84b49b1
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to f4213d2d4b
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-13 16:56:05 +00:00
Compare
brunobaccari force-pushed feat/longshot-fov-range-300 from f4213d2d4b
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 4e0d71f9f4
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 27s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-13 16:57:03 +00:00
Compare
Author
First-time contributor

Rebased all three topic commits onto main f647a072, preserving the upstream HDR text and every existing tested-configuration row while resolving the two documentation conflicts. Remote updates used explicit expected-head leases. Seven focused checks pass on 4e0d71f9. The description now separates historical evidence from current validation; WIP is restored until the current full suite, builds and visible game comparison are completed.

Rebased all three topic commits onto main f647a072, preserving the upstream HDR text and every existing tested-configuration row while resolving the two documentation conflicts. Remote updates used explicit expected-head leases. Seven focused checks pass on 4e0d71f9. The description now separates historical evidence from current validation; WIP is restored until the current full suite, builds and visible game comparison are completed.
brunobaccari force-pushed feat/longshot-fov-range-300 from 4e0d71f9f4
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 27s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 5844f7071d
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-13 17:19:24 +00:00
Compare
Author
First-time contributor

Rebased onto main fbd42024 as 5844f707 without conflicts; the topic diff remains seven files. The prior full Windows run at 4e0d71f9 completed with 492 passed, 4 failed and 33 skips; all four failure names reproduced on clean main with the same causes, now described in Testing. Linux FOV/menu fixtures and actual host-unit compilation passed, and those sources are unchanged in this rebase. A new full run and builds are in progress because the new upstream renderer change must be present on both sides of the runtime comparison. WIP remains.

Rebased onto main fbd42024 as 5844f707 without conflicts; the topic diff remains seven files. The prior full Windows run at 4e0d71f9 completed with 492 passed, 4 failed and 33 skips; all four failure names reproduced on clean main with the same causes, now described in Testing. Linux FOV/menu fixtures and actual host-unit compilation passed, and those sources are unchanged in this rebase. A new full run and builds are in progress because the new upstream renderer change must be present on both sides of the runtime comparison. WIP remains.
Author
First-time contributor

The new validation attempt and shared development build were deliberately interrupted to give the user manual Launcher build exclusive resources. Only the validation process trees were stopped; their logs and partial files are preserved, and the user build was left untouched. This interruption is not a test failure or a completed current-head suite. Rebase and prior completed evidence are unchanged; WIP remains until validation can resume.

The new validation attempt and shared development build were deliberately interrupted to give the user manual Launcher build exclusive resources. Only the validation process trees were stopped; their logs and partial files are preserved, and the user build was left untouched. This interruption is not a test failure or a completed current-head suite. Rebase and prior completed evidence are unchanged; WIP remains until validation can resume.
brunobaccari changed title from WIP: feat(graphics): extend the FOV slider to 300 percent to feat(graphics): extend the FOV slider to 300 percent 2026-11-13 17:58:40 +00:00
brunobaccari force-pushed feat/longshot-fov-range-300 from 5844f7071d
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to bd8912e78a
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-13 18:13:03 +00:00
Compare
brunobaccari force-pushed feat/longshot-fov-range-300 from bd8912e78a
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 3439a77ae7
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-13 18:39:56 +00:00
Compare
brunobaccari changed title from feat(graphics): extend the FOV slider to 300 percent to WIP: feat(graphics): extend the FOV slider to 300 percent 2026-11-13 18:41:01 +00:00
Author
First-time contributor

Rebased the three existing topic commits from bd8912e7 onto main d9648863; published head 3439a77a with an explicit expected-head force-with-lease. Resolved README.md and gpu/vk/vk_menu.h by retaining upstream HDR/AMD FSR 4 and Damage taken content alongside the FOV change. The later mouse and controller-layout fixes are also preserved. The diff remains 7 files, 17 insertions and 9 deletions; diff --check and local merge simulation pass, and Forgejo confirmed no merge conflicts after the push.

Validation: the intermediate 76aad7d2 run completed with 7 checks passed and menu_i18n failed. That stale PT-BR Debug help key reproduces independently on current main d9648863 (4 unit tests passed, 1 failed). After the final rebase, all 4 selected checks passed: framegen_preset, oot_fov, pad_layout and readme_menu_rows.

Full current-head suite, application build and gameplay measurements remain pending. The user's manual Launcher preparation was preserved; no full build, game or GPU test was started for this rebase. The description distinguishes these checks from older suite/runtime evidence, and WIP remains appropriate until current author validation is completed.

Rebased the three existing topic commits from bd8912e7 onto main d9648863; published head 3439a77a with an explicit expected-head force-with-lease. Resolved README.md and gpu/vk/vk_menu.h by retaining upstream HDR/AMD FSR 4 and Damage taken content alongside the FOV change. The later mouse and controller-layout fixes are also preserved. The diff remains 7 files, 17 insertions and 9 deletions; diff --check and local merge simulation pass, and Forgejo confirmed no merge conflicts after the push. Validation: the intermediate 76aad7d2 run completed with 7 checks passed and menu_i18n failed. That stale PT-BR Debug help key reproduces independently on current main d9648863 (4 unit tests passed, 1 failed). After the final rebase, all 4 selected checks passed: framegen_preset, oot_fov, pad_layout and readme_menu_rows. Full current-head suite, application build and gameplay measurements remain pending. The user's manual Launcher preparation was preserved; no full build, game or GPU test was started for this rebase. The description distinguishes these checks from older suite/runtime evidence, and WIP remains appropriate until current author validation is completed.
brunobaccari changed title from WIP: feat(graphics): extend the FOV slider to 300 percent to feat(graphics): extend the FOV slider to 300 percent 2026-11-13 18:41:25 +00:00
brunobaccari changed title from feat(graphics): extend the FOV slider to 300 percent to WIP: feat(graphics): extend the FOV slider to 300 percent 2026-11-13 18:42:04 +00:00
brunobaccari changed title from WIP: feat(graphics): extend the FOV slider to 300 percent to feat(graphics): extend the FOV slider to 300 percent 2026-11-13 18:50:35 +00:00
brunobaccari changed title from feat(graphics): extend the FOV slider to 300 percent to WIP: feat(graphics): extend the FOV slider to 300 percent 2026-11-13 18:55:23 +00:00
Author
First-time contributor

Description check follow-up: corrected the Needs other testers field to the required None form because validation is still the author's work, with no external test request. Restored WIP status and kept every pending checkbox unchanged: current-head full suite, gameplay, measurements, screenshots and complete platform build validation are still pending. No source, commit, test result or measurement changed. This metadata edit retriggers only the PR-description workflow; no build or GPU run was started.

Description check follow-up: corrected the Needs other testers field to the required None form because validation is still the author's work, with no external test request. Restored WIP status and kept every pending checkbox unchanged: current-head full suite, gameplay, measurements, screenshots and complete platform build validation are still pending. No source, commit, test result or measurement changed. This metadata edit retriggers only the PR-description workflow; no build or GPU run was started.
brunobaccari changed title from WIP: feat(graphics): extend the FOV slider to 300 percent to feat(graphics): extend the FOV slider to 300 percent 2026-11-13 19:11:06 +00:00
brunobaccari force-pushed feat/longshot-fov-range-300 from 3439a77ae7
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to e2e7f3205d
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 3s
2026-11-13 19:11:08 +00:00
Compare
brunobaccari changed title from feat(graphics): extend the FOV slider to 300 percent to WIP: feat(graphics): extend the FOV slider to 300 percent 2026-11-13 20:11:36 +00:00
brunobaccari changed title from WIP: feat(graphics): extend the FOV slider to 300 percent to feat(graphics): extend the FOV slider to 300 percent 2026-11-13 20:19:43 +00:00
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 3s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/longshot-fov-range-300:brunobaccari-feat/longshot-fov-range-300'
git switch 'brunobaccari-feat/longshot-fov-range-300'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!199
No description provided.