MagicBeanDev/Longshot

Watch

Fork 18

docs(agents): take a pull request out of WIP yourself once it is ready #126

Merged

HumanBean merged 1 commit from HumanBean/Longshot:docs/wip-ready into main

2026-11-13 05:33:40 +00:00

HumanBean commented

2026-11-13 05:33:21 +00:00

Owner

Why

Agents open their PRs as WIP and then leave them there: nothing told them to run pr ready themselves once the PR is complete, and a WIP PR isn't reviewed, so it waits for nothing. #121, a forge.py change with only offline checks, sat WIP for that reason.

What changed

AGENTS.md, Open the pull request: a bullet, Take it out of WIP yourself once it is ready. When pr status shows the description check passing and the change is tested and measured, run pr ready in the same session. A change the game doesn't run (a script, the docs, the checks) is measured by its game-free checks. Forgejo's "not mergeable" on a WIP PR is no reason to rebase.
docs/forge.md, Work in progress, ready, and keeping the PR current: the same note for people.

Flags and settings

None.

Measurements

main: 316f9319 (2026-11-13)
this PR: docs/wip-ready @ c3fae911
Hardware: Linux (CachyOS); no GPU involved
Scene: none: documentation only
Method: python -I -B tests/run_all.py and tests/test_check_pr_description.py, which read the docs
How to reproduce: python -I -B tests/run_all.py

	main @ `316f9319`	this PR @ `c3fae911`
`tests/test_check_pr_description.py`	passes	passes
`tests/run_all.py` (Linux)	7 environment failures	460 passed, the same 7 failed, 69 skipped

$ python -I -B tests/run_all.py
460 passed, 7 failed, 69 skipped in 60 s (linux, 24 at once)

Testing

Tested: python -I -B tests/run_all.py on Linux: 460 passed, 7 failed, 69 skipped. The 7 fail on main on this PC too (its environment): test_bake_portability, test_builder_log_read_only, test_program_cache_cleanup, test_control, test_longshot_ctl, test_program_cache_one_variant, test_vram_budget_row. Nothing in the game: the change is text.

Not tested: Nothing this could affect.

Needs other testers:
None

Screenshots

Nothing on screen.

Risk and rollback

None: text only. Reverting the commit removes it.

Issues

See #121

Checklist

For everyone

One topic.
The title is a Conventional Commit (type(scope): description).
Rebased on current main.
python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
Tested in the game, or what wasn't is named under Testing.
Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
No game files, dumps, build output or generated files.
third_party/ untouched (a new folder with a PROVENANCE.md instead).
The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
Docs updated.

🤖 Generated with Claude Code

## Why Agents open their PRs as WIP and then leave them there: nothing told them to run `pr ready` themselves once the PR is complete, and a WIP PR isn't reviewed, so it waits for nothing. #121, a forge.py change with only offline checks, sat WIP for that reason. ## What changed - AGENTS.md, *Open the pull request*: a bullet, *Take it out of WIP yourself once it is ready*. When `pr status` shows the description check passing and the change is tested and measured, run `pr ready` in the same session. A change the game doesn't run (a script, the docs, the checks) is measured by its game-free checks. Forgejo's "not mergeable" on a WIP PR is no reason to rebase. - docs/forge.md, *Work in progress, ready, and keeping the PR current*: the same note for people. ## Flags and settings None. ## Measurements main: 316f9319 (2026-11-13) this PR: docs/wip-ready @ c3fae911 Hardware: Linux (CachyOS); no GPU involved Scene: none: documentation only Method: `python -I -B tests/run_all.py` and `tests/test_check_pr_description.py`, which read the docs How to reproduce: `python -I -B tests/run_all.py` | | main @ 316f9319 | this PR @ c3fae911 | |---|---|---| | `tests/test_check_pr_description.py` | passes | passes | | `tests/run_all.py` (Linux) | 7 environment failures | 460 passed, the same 7 failed, 69 skipped | ``` $ python -I -B tests/run_all.py 460 passed, 7 failed, 69 skipped in 60 s (linux, 24 at once) ``` ## Testing **Tested:** `python -I -B tests/run_all.py` on Linux: 460 passed, 7 failed, 69 skipped. The 7 fail on `main` on this PC too (its environment): `test_bake_portability`, `test_builder_log_read_only`, `test_program_cache_cleanup`, `test_control`, `test_longshot_ctl`, `test_program_cache_one_variant`, `test_vram_budget_row`. Nothing in the game: the change is text. **Not tested:** Nothing this could affect. **Needs other testers:** None ## Screenshots Nothing on screen. ## Risk and rollback None: text only. Reverting the commit removes it. ## Issues See #121 ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

HumanBean added 1 commit

2026-11-13 05:33:21 +00:00

docs(agents): take a pull request out of WIP yourself once it is ready

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped

Details

Third-party parts / The same as upstream (pull_request) Has been skipped

Details

PR description / Description follows the template (pull_request_target) Successful in 6s

Details

CI / Conventional Commit title (pull_request) Successful in 6s

Details

CI / Workflow lint (actionlint) (pull_request) Failing after 8s

Details

Third-party parts / As their notes say (pull_request) Successful in 13s

Details

c3fae91112

AGENTS.md and docs/forge.md say to run pr ready in the same session once
the description check passes and the change is tested and measured, since
nobody reviews a WIP PR; a change the game doesn't run is measured by its
game-free checks, and Forgejo's not-mergeable on a WIP PR is no reason to
rebase.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

HumanBean merged commit 97419a795f into main

2026-11-13 05:33:40 +00:00

HumanBean deleted branch docs/wip-ready

2026-11-13 05:33:40 +00:00

HumanBean referenced this pull request from a commit

2026-11-13 05:33:40 +00:00

docs(agents): take a pull request out of WIP yourself once it is ready (#126)