WIP: refactor(vk): one retire-later holder for the upscalers' dead queues #978

Draft
zeldaootr wants to merge 2 commits from zeldaootr/Longshot:vk-retire-later into main
Contributor

Type: refactor · Risk: medium · Tested on: Linux, Steam Deck (RADV VANGOGH): runs, but the Deck offers no FSR 3, so the holders held nothing · Needs: any GPU with FSR 3 upscaling and frame generation

Why

Nothing a player would notice: this is a code-structure change. Five files in the Vulkan back end each carried their own copy of "hold this until the GPU can no longer be using it, then free it" (all five wait for the submission timeline's value that followed the thing; three also count frames, with the 4 written three times). A fix to the rule had to be made five times. Now it lives in one header with its own check. No issue in the tracker covers it.

What changed

One small header owns when a retired thing may be freed; the five files keep what the thing is and how to free it. Same stamps, thresholds and order of frees as before.

  • gpu/vk/retire_later.h (new): retire_later::Held<Item> with hold(value, item), hold(frame, value, item) and three release rules: free_reached (the timeline has reached the value; a value of 0 is never freed), free_aged (that, and more than kFrameAge = 4 frames past: main's #788 rule for the three frame-counted lists, kept as it is) and free_all. No Vulkan calls.
  • gpu/vk/vk_reactive.cpp, gpu/vk/vk_fsr3_inputs.cpp, gpu/vk/vk_temporal.cpp: later and free_dead are one line each over Held<std::function<void()>> (vk_temporal's free_dead(all) picks free_all or free_aged).
  • gpu/vk/vk_fsr3.cpp, gpu/vk/vk_fsr3fi.cpp: drop_image and free_dead over Held<Image>; destroy_now is unchanged.
  • One difference inside the header: an entry leaves the list before its free runs. The old loops ran a free while it still sat in the vector, so a free that retired something else could move the vector under itself (undefined); now that item is held with its own stamp and waits its turn. No free does that today.
  • tests/test_async_safe_frees.py (main's check of #788's rule, which built the three lists from a struct Dead it found in each file): builds them from the header's holder now, and still from a struct Dead for a tree before this one (--source). It passes here and still fails all six of its cases on the sources before #788.
  • Tests: tests/test_retire_later.py + tests/retire_later_test.cpp (new) check the rule, the boundaries, the order, a free that holds more, and the three frame-stamped holders cut from their sources. tests/test_fsr_image_retirement.py + tests/fsr_image_retirement_test.cpp and tests/test_fsr3_release_frees.py compile the header with the code they cut, instead of a pasted vector of pairs.

Not touched, on purpose: the dead queues in vk_memory.cpp, vk_texture.cpp, vk_imgui.cpp and vk_draw.cpp (their release rules have extra conditions); the frame-stamped holders stay frame-stamped; and free_all is there for vk_temporal.cpp's free_dead(all), which main only ever calls with false: the flag is main's and is left as it is.

Measurements

Verdict: nothing measured: a refactor meant to leave frame time and memory as they are, and the one run in the game (below) could not reach the code that changed, so a number from it would say nothing. It passes its checks.

Flags and settings

None.

Testing

Tested:

  • In the game, on Steam Deck OLED, SteamOS 3.9.5 (20261023.100), AMD Custom GPU 0932 (RADV VANGOGH), Mesa 26.2.0-devel: headless at 1280x720 with the fixture save, from empty shader caches (no preparation): the child save in Kokiri Forest settled 20 s, a teleport to Hyrule Field, 15 s to settle and 30 s there, driven through the control bridge. Four runs, each to the end, no device loss and nothing in the log from these files. In one, the Upscaler row (Off, Catmull-Rom, Lanczos) and the Render resolution row (Auto, 100%, 75%, 67%, 50%) were each stepped through in play, 4 s a step, the game presenting throughout (about 20 frames a second before, during and after, shaders compiling as it went: not a measurement). The build that ran is the three branches of this set merged on main a8a30c22 (v3.0.0-rc.4-120-gd01328f1: this PR with the options reader and the switch rule), built for x86-64-v3, not this branch alone; that run predates main's #788 and this branch's rework onto it (2026-11-16): the holder now carries a frame and a timeline value for the three frame-counted lists, as #788 made them. Nothing in the game has run since the rework.
  • The checks of the five files and the header by name (run_all.py fsr retire reactive temporal) on Linux x86-64 (Ryzen 7 5700U), clang 23.1.5, gcc, glslang, spirv-val, the Vulkan and SPIR-V headers, pass but tests/test_fsr_uniform_ownership.py, which fails the same on main. A full python3 -I -B tests/run_all.py on main e4d035e9 and on this branch rebased onto it, the same day and PC (6 at once, the PC busy with other builds): main 609 passed, 28 failed, 26 skipped; this branch 611 / 27 / 26. By name every failure here is one of main's but tests/test_pipeline_cache_file.py, a timed check that passes alone on both; test_oot_state_tap and test_pipeline_state_sources failed on main's run only (timing). The branch was then rebased onto main bbe421f5 (two files of main's, neither touched here) and pushed; the full run was not repeated for that step.
  • The five .cpp files whole, -fsyntax-only with llvm-mingw 20261104 (Windows), after the rework: clean. (Before the rework also with clang for Linux; not repeated.)
  • An independent review of the diff before this opened: no correctness finding; the note on re-entrancy above and the free_all note come from it.

Not tested: the holders with anything in them. The Deck's Upscaler row has only the game's own upscalers, so FSR 3, frame generation, the reactive mask and the temporal engines (DLSS, FSR 4, XeSS) never ran, and nothing was retired through Held. Windows, in the game.

Must be tested:

  • Any GPU that offers FSR 3 (Windows or Linux), FSR 3 upscaling with frame generation on: in play, change the Output resolution and the Upscaler back and forth several times, and leave it running a few minutes, expecting no device loss, no validation error and no growth in memory (Test Farm: @Beanstalk FSR 3 with frame generation, changing the output resolution and the upscaler in play; or by hand, the same, watching the log and VRAM)

Risks

What could break: an image freed while the GPU still uses it (a device loss on a resolution or upscaler change) or never freed (memory growing), with FSR 3, frame generation or a temporal engine on.
Turning it off: revert the commit.
Compatibility: Nothing changes.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks. Not ticked yet: Risks names memory growth from a holder never freed, and Measurements says nothing was measured for it.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main (bbe421f5, 2026-11-16; head 997e7029; the conflict with #788 in the three frame-counted lists resolved by giving the holder #788's rule).
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
**Type:** refactor · **Risk:** medium · **Tested on:** Linux, Steam Deck (RADV VANGOGH): runs, but the Deck offers no FSR 3, so the holders held nothing · **Needs:** any GPU with FSR 3 upscaling and frame generation ## Why Nothing a player would notice: this is a code-structure change. Five files in the Vulkan back end each carried their own copy of "hold this until the GPU can no longer be using it, then free it" (all five wait for the submission timeline's value that followed the thing; three also count frames, with the `4` written three times). A fix to the rule had to be made five times. Now it lives in one header with its own check. No issue in the tracker covers it. ## What changed One small header owns when a retired thing may be freed; the five files keep what the thing is and how to free it. Same stamps, thresholds and order of frees as before. - `gpu/vk/retire_later.h` (new): `retire_later::Held<Item>` with `hold(value, item)`, `hold(frame, value, item)` and three release rules: `free_reached` (the timeline has reached the value; a value of 0 is never freed), `free_aged` (that, and more than `kFrameAge` = 4 frames past: main's #788 rule for the three frame-counted lists, kept as it is) and `free_all`. No Vulkan calls. - `gpu/vk/vk_reactive.cpp`, `gpu/vk/vk_fsr3_inputs.cpp`, `gpu/vk/vk_temporal.cpp`: `later` and `free_dead` are one line each over `Held<std::function<void()>>` (`vk_temporal`'s `free_dead(all)` picks `free_all` or `free_aged`). - `gpu/vk/vk_fsr3.cpp`, `gpu/vk/vk_fsr3fi.cpp`: `drop_image` and `free_dead` over `Held<Image>`; `destroy_now` is unchanged. - One difference inside the header: an entry leaves the list before its free runs. The old loops ran a free while it still sat in the vector, so a free that retired something else could move the vector under itself (undefined); now that item is held with its own stamp and waits its turn. No free does that today. - `tests/test_async_safe_frees.py` (main's check of #788's rule, which built the three lists from a `struct Dead` it found in each file): builds them from the header's holder now, and still from a `struct Dead` for a tree before this one (`--source`). It passes here and still fails all six of its cases on the sources before #788. - Tests: `tests/test_retire_later.py` + `tests/retire_later_test.cpp` (new) check the rule, the boundaries, the order, a free that holds more, and the three frame-stamped holders cut from their sources. `tests/test_fsr_image_retirement.py` + `tests/fsr_image_retirement_test.cpp` and `tests/test_fsr3_release_frees.py` compile the header with the code they cut, instead of a pasted vector of pairs. Not touched, on purpose: the dead queues in `vk_memory.cpp`, `vk_texture.cpp`, `vk_imgui.cpp` and `vk_draw.cpp` (their release rules have extra conditions); the frame-stamped holders stay frame-stamped; and `free_all` is there for `vk_temporal.cpp`'s `free_dead(all)`, which main only ever calls with `false`: the flag is main's and is left as it is. ## Measurements **Verdict:** nothing measured: a refactor meant to leave frame time and memory as they are, and the one run in the game (below) could not reach the code that changed, so a number from it would say nothing. It passes its checks. ### Flags and settings None. ## Testing **Tested:** - In the game, on Steam Deck OLED, SteamOS 3.9.5 (20261023.100), AMD Custom GPU 0932 (RADV VANGOGH), Mesa 26.2.0-devel: headless at 1280x720 with the fixture save, from empty shader caches (no preparation): the child save in Kokiri Forest settled 20 s, a teleport to Hyrule Field, 15 s to settle and 30 s there, driven through the control bridge. Four runs, each to the end, no device loss and nothing in the log from these files. In one, the Upscaler row (Off, Catmull-Rom, Lanczos) and the Render resolution row (Auto, 100%, 75%, 67%, 50%) were each stepped through in play, 4 s a step, the game presenting throughout (about 20 frames a second before, during and after, shaders compiling as it went: not a measurement). The build that ran is the three branches of this set merged on main a8a30c22 (`v3.0.0-rc.4-120-gd01328f1`: this PR with the options reader and the switch rule), built for x86-64-v3, not this branch alone; that run predates main's #788 and this branch's rework onto it (2026-11-16): the holder now carries a frame and a timeline value for the three frame-counted lists, as #788 made them. Nothing in the game has run since the rework. - The checks of the five files and the header by name (`run_all.py fsr retire reactive temporal`) on Linux x86-64 (Ryzen 7 5700U), clang 23.1.5, gcc, glslang, spirv-val, the Vulkan and SPIR-V headers, pass but `tests/test_fsr_uniform_ownership.py`, which fails the same on main. A full `python3 -I -B tests/run_all.py` on main e4d035e9 and on this branch rebased onto it, the same day and PC (6 at once, the PC busy with other builds): main 609 passed, 28 failed, 26 skipped; this branch 611 / 27 / 26. By name every failure here is one of main's but `tests/test_pipeline_cache_file.py`, a timed check that passes alone on both; `test_oot_state_tap` and `test_pipeline_state_sources` failed on main's run only (timing). The branch was then rebased onto main bbe421f5 (two files of main's, neither touched here) and pushed; the full run was not repeated for that step. - The five `.cpp` files whole, `-fsyntax-only` with llvm-mingw 20261104 (Windows), after the rework: clean. (Before the rework also with clang for Linux; not repeated.) - An independent review of the diff before this opened: no correctness finding; the note on re-entrancy above and the `free_all` note come from it. **Not tested:** the holders with anything in them. The Deck's Upscaler row has only the game's own upscalers, so FSR 3, frame generation, the reactive mask and the temporal engines (DLSS, FSR 4, XeSS) never ran, and nothing was retired through `Held`. Windows, in the game. **Must be tested:** - Any GPU that offers FSR 3 (Windows or Linux), FSR 3 upscaling with frame generation on: in play, change the Output resolution and the Upscaler back and forth several times, and leave it running a few minutes, expecting no device loss, no validation error and no growth in memory (Test Farm: @Beanstalk FSR 3 with frame generation, changing the output resolution and the upscaler in play; or by hand, the same, watching the log and VRAM) ## Risks **What could break:** an image freed while the GPU still uses it (a device loss on a resolution or upscaler change) or never freed (memory growing), with FSR 3, frame generation or a temporal engine on. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [ ] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. Not ticked yet: Risks names memory growth from a holder never freed, and Measurements says nothing was measured for it. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main` (bbe421f5, 2026-11-16; head `997e7029`; the conflict with #788 in the three frame-counted lists resolved by giving the holder #788's rule). - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
Assisted-by: Claude Fable 5.2
Co-Authored-By: Claude Fable 5.2 <[email protected]>
refactor(vk): vk_fsr3 and vk_fsr3fi hold their retired images in retire_later::Held, test_fsr_image_retirement compiles the header
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
6d08865b29
Assisted-by: Claude Fable 5.2
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Author
Contributor

Tested in game: Steam Deck OLED, SteamOS 3.9.5 (20261023.100), AMD Custom GPU 0932 (RADV VANGOGH), Mesa 26.2.0-devel. A build of this branch merged with the two other branches of its set on main a8a30c22 (v3.0.0-rc.4-120-gd01328f1), headless at 1280x720, from empty shader caches: the child save in Kokiri Forest, a teleport to Hyrule Field and 45 s there, four runs, each to its end with no device loss. In one run the Upscaler row (Off, Catmull-Rom, Lanczos) and the Render resolution row were stepped through in play, the game presenting throughout. The Deck offers no FSR 3, frame generation or temporal engine, so the holders this PR changes held nothing in these runs: that still has to be run on a GPU that offers them (Must be tested).

Tested in game: Steam Deck OLED, SteamOS 3.9.5 (20261023.100), AMD Custom GPU 0932 (RADV VANGOGH), Mesa 26.2.0-devel. A build of this branch merged with the two other branches of its set on main a8a30c22 (v3.0.0-rc.4-120-gd01328f1), headless at 1280x720, from empty shader caches: the child save in Kokiri Forest, a teleport to Hyrule Field and 45 s there, four runs, each to its end with no device loss. In one run the Upscaler row (Off, Catmull-Rom, Lanczos) and the Render resolution row were stepped through in play, the game presenting throughout. The Deck offers no FSR 3, frame generation or temporal engine, so the holders this PR changes held nothing in these runs: that still has to be run on a GPU that offers them (Must be tested).
Collaborator

Possibly related, for context:

  • PR #788 fix(vk): free on the GPU's progress, not on a frame count: the upscalers' and the headless overlays' frees — Open PR changes retirement rules in these same upscaler queues; overlap in the files/code.
Possibly related, for context: - PR #788 fix(vk): free on the GPU's progress, not on a frame count: the upscalers' and the headless overlays' frees — Open PR changes retirement rules in these same upscaler queues; overlap in the files/code.
zeldaootr force-pushed vk-retire-later from 6d08865b29
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 997e7029c3
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 10s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 05:04:45 +00:00
Compare
Author
Contributor

Rebased onto main bbe421f5; the description names what changed with it.

Rebased onto main bbe421f5; the description names what changed with it.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: ticked: Testing's Tested: in-game runs on a Steam Deck OLED with this branch in the build, though the holders held nothing.
  • Nothing gets worse that I know of: not ticked: Risks names memory growth from a holder never freed, and Measurements says nothing was measured for it. Measure that cost and state it in Risks, then tick it.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: ticked: Testing's Tested: in-game runs on a Steam Deck OLED with this branch in the build, though the holders held nothing. - *Nothing gets worse that I know of*: not ticked: Risks names memory growth from a holder never freed, and Measurements says nothing was measured for it. Measure that cost and state it in Risks, then tick it.
zeldaootr force-pushed vk-retire-later from 997e7029c3
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 10s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to aa26c5be26
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 9s
2026-11-18 12:30:20 +00:00
Compare
Author
Contributor

Rebased onto main 430eef4f2 (an include-line conflict in gpu/vk/vk_temporal.cpp; both includes kept). tests/run_all.py on Linux at this head and on main in the same environment: no check fails here that passes on main. Main has since gained a sixth copy of the same retire rule in gpu/vk/vk_framegen.cpp; it is not folded in here.

Rebased onto main 430eef4f2 (an include-line conflict in `gpu/vk/vk_temporal.cpp`; both includes kept). `tests/run_all.py` on Linux at this head and on main in the same environment: no check fails here that passes on main. Main has since gained a sixth copy of the same retire rule in `gpu/vk/vk_framegen.cpp`; it is not folded in here.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 9s
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'vk-retire-later:zeldaootr-vk-retire-later'
git switch 'zeldaootr-vk-retire-later'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!978
No description provided.