WIP: fix(mods): a hook entered with BL that goes back with B returns, where that is safe #960

Draft
snaildev99 wants to merge 18 commits from snaildev99/Longshot:mods/bl-return into main
Contributor

Type: fix · Risk: low · Tested on: Windows 11, RTX 3090 (in the game, and the game-free checks) · Needs: nothing more

Why

Many code mods hook the game by writing bl my_hook over one of its instructions, and the hook jumps back with
b <the instruction after the call> because its own calls have used up the return register. On the console that
jump is a return. On a recompiled build it is not: the translator makes bl a C call and the jump a goto, so the
hook's C function runs the rest of the game's function inside the call, then returns into it, and the game runs that
rest a second time with its stack frame gone. It crashes a few calls up. Character Select v0.1.2 crashed on Hookshot
exactly so. With #134 mods' patches are built in, so every such mod would crash the same way.

What changed

The build writes such a jump back as a return before the code is translated, when that is exactly the same thing:
when nothing but that one call can reach the hook's code. Otherwise it leaves the jump and says so.

  • nx2/exefs_patches.py: make_returns() (called by collect()), hooked_returns(), hook_routine(): for each
    bl the patches write into code they write, the routine reached from its target (up to its returns, not past the
    call's next instruction). Its b back becomes RET when the routine was all written by the patches and no other
    branch or call in main, no instruction above it falling in, no unwind start, function symbol, relocated pointer or
    ADR / ADRP+ADD address reaches into it. The RET goes into the writes of the file that wrote the b, so the lift's
    key changes with it. Each case is named in the build's log and in the file's note in exefs_patches.txt (made a
    return; or left, with the reason: entered from elsewhere too, runs the game's own code, or the way back is a
    conditional branch, which has no RET form).
  • Why not BlueShell's rule (every patched b to a patched bl's next instruction becomes RET): it also hits a
    routine that is entered with b and goes back there on purpose, whose b is right; a RET would leave the game's
    function. The test has that case.
  • apply() closes the JSON it reads.

Measurements

Verdict: an offline check on the game's code; nothing measured in the game. The check costs about 2 s of the
build when a mod has such a hook and nothing otherwise.

On build e0f3ccfa, with collect() and a64-kit's walk only (no build): Character Select v0.1.2's patch (its picker hook
was entered with bl and went back with b): two branches made returns; the hook's lifted function is 30
instructions and ends at its own return, where before it was 78 and ran on into the caller. Character Select v0.2.1's
patch (the call is a b since): nothing changed.

exefs: code        CS/exefs/E0F3CCFAF50065AE4EA01EB5AEB13B1A45DA3348.ips (4934 bytes)
exefs: CS/exefs/E0F3CCFAF50065AE4EA01EB5AEB13B1A45DA3348.ips: the branch at main+3C463BC back to the call at main+C15C60 made a return
exefs: CS/exefs/E0F3CCFAF50065AE4EA01EB5AEB13B1A45DA3348.ips: the branch at main+3C463D4 back to the call at main+C15C60 made a return

Flags and settings

None

Testing

Tested:

  • tests/test_exefs_bl_return.py (18 cases: rewritten, left with a note, untouched, and the lifted C before
    and after) and tests/run_all.py on Windows: 539 passed, 25 failed; the same 25 fail on #134's head here. The offline
    check above.

  • In the game, Windows 11, RTX 3090 (driver 610.88), a build of #134's head with this branch (and the other follow-ups) merged in, Character Select v0.1.2 (lite) as the only mod: the build's log says the branch at main+3C463BC back to the call at main+C15C60 made a return and the same for main+3C463D4; in the game the save loads, A on the Characters page changes the character, several picks in a row and closing the menu work, no crash. With #134 alone that press crashed. The same build with the mod's v0.2.1 (no such hook) ran as before.

Not tested: a mod whose hook is left with a note (entered from elsewhere too) in a game.

Must be tested: None

Risks

What could break: a mod whose hook is rewritten behaves differently only if something reaches its code that the
checks do not see (a jump table of the game landing in code the mod overwrote). Mods without such a hook: nothing
changes.

Turning it off: revert the commit.

Compatibility: a mod with such a hook is translated again once (its patched bytes change, and so the lift's key).

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched). (Main session: search it.)
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. (Stacked on #134.)
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 3090 (in the game, and the game-free checks) · **Needs:** nothing more ## Why Many code mods hook the game by writing `bl my_hook` over one of its instructions, and the hook jumps back with `b <the instruction after the call>` because its own calls have used up the return register. On the console that jump is a return. On a recompiled build it is not: the translator makes `bl` a C call and the jump a goto, so the hook's C function runs the rest of the game's function inside the call, then returns into it, and the game runs that rest a second time with its stack frame gone. It crashes a few calls up. Character Select v0.1.2 crashed on Hookshot exactly so. With #134 mods' patches are built in, so every such mod would crash the same way. ## What changed The build writes such a jump back as a return before the code is translated, when that is exactly the same thing: when nothing but that one call can reach the hook's code. Otherwise it leaves the jump and says so. - `nx2/exefs_patches.py`: `make_returns()` (called by `collect()`), `hooked_returns()`, `hook_routine()`: for each `bl` the patches write into code they write, the routine reached from its target (up to its returns, not past the call's next instruction). Its `b` back becomes `RET` when the routine was all written by the patches and no other branch or call in main, no instruction above it falling in, no unwind start, function symbol, relocated pointer or ADR / ADRP+ADD address reaches into it. The RET goes into the writes of the file that wrote the `b`, so the lift's key changes with it. Each case is named in the build's log and in the file's note in `exefs_patches.txt` (made a return; or left, with the reason: entered from elsewhere too, runs the game's own code, or the way back is a conditional branch, which has no RET form). - Why not BlueShell's rule (every patched `b` to a patched `bl`'s next instruction becomes RET): it also hits a routine that is entered with `b` and goes back there on purpose, whose `b` is right; a RET would leave the game's function. The test has that case. - `apply()` closes the JSON it reads. ## Measurements **Verdict:** an offline check on the game's code; nothing measured in the game. The check costs about 2 s of the build when a mod has such a hook and nothing otherwise. On build e0f3ccfa, with collect() and a64-kit's walk only (no build): Character Select v0.1.2's patch (its picker hook was entered with `bl` and went back with `b`): two branches made returns; the hook's lifted function is 30 instructions and ends at its own return, where before it was 78 and ran on into the caller. Character Select v0.2.1's patch (the call is a `b` since): nothing changed. ``` exefs: code CS/exefs/E0F3CCFAF50065AE4EA01EB5AEB13B1A45DA3348.ips (4934 bytes) exefs: CS/exefs/E0F3CCFAF50065AE4EA01EB5AEB13B1A45DA3348.ips: the branch at main+3C463BC back to the call at main+C15C60 made a return exefs: CS/exefs/E0F3CCFAF50065AE4EA01EB5AEB13B1A45DA3348.ips: the branch at main+3C463D4 back to the call at main+C15C60 made a return ``` ### Flags and settings None ## Testing **Tested:** - `tests/test_exefs_bl_return.py` (18 cases: rewritten, left with a note, untouched, and the lifted C before and after) and `tests/run_all.py` on Windows: 539 passed, 25 failed; the same 25 fail on #134's head here. The offline check above. - In the game, Windows 11, RTX 3090 (driver 610.88), a build of #134's head with this branch (and the other follow-ups) merged in, Character Select v0.1.2 (lite) as the only mod: the build's log says `the branch at main+3C463BC back to the call at main+C15C60 made a return` and the same for main+3C463D4; in the game the save loads, A on the Characters page changes the character, several picks in a row and closing the menu work, no crash. With #134 alone that press crashed. The same build with the mod's v0.2.1 (no such hook) ran as before. **Not tested:** a mod whose hook is left with a note (entered from elsewhere too) in a game. **Must be tested:** None ## Risks **What could break:** a mod whose hook is rewritten behaves differently only if something reaches its code that the checks do not see (a jump table of the game landing in code the mod overwrote). Mods without such a hook: nothing changes. **Turning it off:** revert the commit. **Compatibility:** a mod with such a hook is translated again once (its patched bytes change, and so the lift's key). ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [ ] Why gives the reason plainly and links the issues that fit (the tracker searched). (Main session: search it.) - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [ ] Rebased on current `main`. (Stacked on #134.) - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here.
Mods that each grow files (HD texture packs) could not be combined: only one
resource size table was used. Hookshot now merges every enabled mod's table
into the game's at start (the button prompts' entries kept) and raises the
entry of every file a mod serves to fit its size (host/mods.c, host/restbl.c,
host/zs.c). #2270's merge of the prompts' entries into the winning mod's table
stays as the fallback when no merged table can be made.

The Insert menu gets a Mods tab (shown only when there are mods): each mod on
or off and its place in the list, kept in hookshot_mods.txt and applied at the
next start (the restart question names them), and the cheats of the enabled
mods, switched at once.

ExeFS patches (IPS, IPS32, IPSwitch .pchtxt) are applied to main's image when
the game is built (nx2/exefs_patches.py, nx2/image.py), so the code is
translated from the patched instructions; a write into the padding after the
code (a code cave) makes it code. exefs_patches.txt in the game folder lists
what a build applied; the Mods tab says when a patch waits for a build.

Atmosphere cheat-code files (separate from the Debug tab's built-in cheats)
run in a cheat VM after dmnt's (host/cheats.c), every presented frame, on
guest memory the game was given; cheats that write the game's code are
listed as not supported.

The list, order and switches, the size table's merge, the patch formats and
the cheat VM follow valentderah/totk-pc-recomp (MIT), whose notice is kept in
host/restbl.h and nx2/exefs_patches.py.

Co-authored-by: Valiantsin Dzerakh <[email protected]>
Co-authored-by: conongnang <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The control bridge's bridge_fill names each MenuTab and checks the count: with the Mods tab
added before Debug, its table needs "mods" there.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The compact bar (added to main after the Mods tab was written) draws the
selected row of the current tab. The Mods tab has no such rows: its lines come
from the host. With the bar asked for on the Mods tab the full page is drawn.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
- hos_mods_file gives prompts.c no table when the merged one is served.
- A mod that is off: its ExeFS files are not counted as waiting for a build
  (the Mods tab's text and the log's line).
- The Mods tab's texts and longshot_mods.txt's header say Longshot.
- A Restart or Quit waiting for its second press is cleared on the Mods tab.
- The merged size table: a mod file whose path is in another case than the
  game's takes the game's entry (looked up only when the mod's own case
  misses the table).
- exefs_patches.py: bytes into a relocated word are left out and the file's
  note says so; the comment on DT_RELR words says what happens.
- The compact bar on the Mods tab dims the game behind, as the full menu.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Co-Authored-By: Claude Fable 5.2 <[email protected]>
The test cuts restart_values out of vk_menu.cpp; with the Mods tab that
function also fills the mods' slot, so the harness declares the slot (none
here), can_mods and the host's mods_changed beside its pad_raw.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
docs(mods): the file contract's document and its example follow the Mods tab, the merged table and ExeFS patches
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
5192b46f4b
docs/mods.md (from #93) describes the loader as it was: ExeFS left out, one
mod's size table, no Mods tab. With this branch an exefs folder's patches
belong to the build, the size table is merged at a start, and the Mods tab's
longshot_mods.txt can change the order and the switches; without that file
the order is the documented one. The example's check for the old ExeFS log
line now looks for the line that lists the mod with its ExeFS folder.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
fix(mods): a hook entered with BL that goes back with B returns, where that is safe
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
38b592e57f
The lift makes BL a C call and RET a C return; a B to code that is no
function start becomes a goto. A mod's hook is often `bl hook` written over
one of the game's instructions, going back with `b <the call's next
instruction>` because its own calls have used up x30. On the console that B
is a return; translated, the hook's C function runs the rest of its caller
inside the call and then returns into the caller, which runs that rest again
with its frame gone (Character Select v0.1.2 crashed so, two calls up).

collect() now writes such a B as RET (make_returns, hooked_returns) when the
hook's routine (what is reached from the call's target, up to its returns and
up to the call's next instruction) was all written by the patches and is
entered from that one call alone: no other direct branch or call into it, no
instruction above it falling in, no unwind start, function symbol,
relocated pointer or ADR / ADRP+ADD address in it. Then the B goes exactly
where a return goes, whatever x30 holds. Otherwise the B stays and the file's
note says why it may not run as on the console (entered from elsewhere too,
it runs the game's own code, or the way back is conditional).

BlueShell rewrites every patched B to a patched BL's next instruction
(nx2/exefs_mods.py there); that also catches a routine entered with B that
goes back there, whose B is right as it is. The test has that case.

On the game's code, offline: Character Select v0.1.2's patch gets its two
B's back to main+C15C60 made returns (the hook's lifted walk: 30
instructions, before 78 that ran on into the caller); v0.2.1's, whose call
is a B since, is untouched. The check costs about 2 s when a mod has such a
hook and nothing otherwise.

apply() closes the JSON it reads.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 3090 (driver 610.88), a build of #134's head 5192b46f with this branch merged in, Character Select v0.1.2 (lite) as the only mod, the Characters page of the game's menu: the build's log names two branches back to the call at main+C15C60 made returns; A on a character changes it, several picks and closing the menu work, no crash (#134 alone crashed on that press). This branch is stacked on #134 (it depends on it), so the diff shows #134's commits too until that merges.

Tested in game: Windows 11, RTX 3090 (driver 610.88), a build of #134's head 5192b46f with this branch merged in, Character Select v0.1.2 (lite) as the only mod, the Characters page of the game's menu: the build's log names two branches back to the call at main+C15C60 made returns; A on a character changes it, several picks and closing the menu work, no crash (#134 alone crashed on that press). This branch is stacked on #134 (it depends on it), so the diff shows #134's commits too until that merges.
snaildev99 force-pushed mods/bl-return from 38b592e57f
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 6e20446b41
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 02:50:40 +00:00
Compare
Author
Contributor

Moved onto #134's new head fafc7ab2 (it was rebased onto main @ 343a1dfa): head 6e20446b. No conflict, no change in this branch's own files; its tests pass. Not built or played at this head.

Moved onto #134's new head fafc7ab2 (it was rebased onto main @ 343a1dfa): head 6e20446b. No conflict, no change in this branch's own files; its tests pass. Not built or played at this head.
snaildev99 force-pushed mods/bl-return from 6e20446b41
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 07a9030c41
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 04:27:27 +00:00
Compare
Author
Contributor

Moved onto #134's new head fb2a419c (rebased onto main @ e4d035e9; the Mods tab's functions are API version 25 there, after main's audio outputs): head 07a9030c. No conflict, no change in this branch's own files; its tests pass at this head. Not built or played at it.

Moved onto #134's new head fb2a419c (rebased onto main @ e4d035e9; the Mods tab's functions are API version 25 there, after main's audio outputs): head 07a9030c. No conflict, no change in this branch's own files; its tests pass at this head. Not built or played at it.
snaildev99 force-pushed mods/bl-return from 07a9030c41
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to d609270f95
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 10:11:30 +00:00
Compare
Author
Contributor

Moved onto #134's new head 3fbc327a (the list of mods is mods.json there now: #134 (comment)). Head d609270f.

One conflict, in nx2/exefs_patches.py: this branch's section sits right above collect, whose first line #134 changed; both kept. One commit on top: #134's tests/test_mods_list.py gives collect no game image, so it stubs make_returns for its run.

tests/run_all.py on Windows: nothing fails that #134's head passes. Not built or played at this head; the Linux halves of the changed fixtures were read, not run.

Moved onto #134's new head 3fbc327a (the list of mods is `mods.json` there now: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/134#issuecomment-34804). Head **d609270f**. One conflict, in `nx2/exefs_patches.py`: this branch's section sits right above `collect`, whose first line #134 changed; both kept. One commit on top: #134's `tests/test_mods_list.py` gives `collect` no game image, so it stubs `make_returns` for its run. `tests/run_all.py` on Windows: nothing fails that #134's head passes. Not built or played at this head; the Linux halves of the changed fixtures were read, not run.
snaildev99 force-pushed mods/bl-return from d609270f95
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to d2c8c52651
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 11:11:23 +00:00
Compare
Author
Contributor

Moved onto #134's new head 2b52cd1b (#134 was rebased onto main @ 8a4aa282: the Mods tab's functions are API version 26, and the patches' hash is named in the lift's key after main's #22: #134 (comment)). Head d2c8c526.

No conflict; the commits are unchanged. It sets nothing of its own for the lift.

tests/run_all.py on Windows: nothing fails that #134's head passes. Not built or played at this head.

Moved onto #134's new head 2b52cd1b (#134 was rebased onto main @ 8a4aa282: the Mods tab's functions are API version 26, and the patches' hash is named in the lift's key after main's #22: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/134#issuecomment-35102). Head **d2c8c526**. No conflict; the commits are unchanged. It sets nothing of its own for the lift. `tests/run_all.py` on Windows: nothing fails that #134's head passes. Not built or played at this head.
snaildev99 force-pushed mods/bl-return from d2c8c52651
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 3aa6ce93c7
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
2026-11-16 19:47:36 +00:00
Compare
Author
Contributor

Moved onto #134's new head c5cead8d (#134 was rebased onto main @ ac778751 and brings main's new players' mods guide in line with it: #134 (comment)). Head 3aa6ce93.

No conflict; the commits are unchanged.

Nothing fails in tests/run_all.py on Windows that #134's head passes. Not built or played at this head.

Moved onto #134's new head c5cead8d (#134 was rebased onto main @ ac778751 and brings main's new players' mods guide in line with it: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/134#issuecomment-37590). Head **3aa6ce93**. No conflict; the commits are unchanged. Nothing fails in `tests/run_all.py` on Windows that #134's head passes. Not built or played at this head.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'mods/bl-return:snaildev99-mods/bl-return'
git switch 'snaildev99-mods/bl-return'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!960
No description provided.