fix(builder): reject mixed runtime declarations in Windows packages #690

Open
NitnekLeBorgne wants to merge 1 commit from NitnekLeBorgne/Longshot-contributions:fix/windows-package-frameworks-e090-20261115 into main
Contributor

Type: fix · Risk: low · Tested on: Linux full source-only parent/head runner; real native Windows release-layout package with real LLVM readers · Needs: normal end-user Windows startup acceptance

Why

The release ZIP checker can accept contradictory .NET metadata: both an included runtime and a shared-framework dependency, despite requiring a self-contained package. The existing portable-startup test checks publishing output, not rejection of malformed ZIP metadata.

Reference: dotnet/runtime v8.0.0 runtime_config_t::parse_opts. Presence of framework / frameworks conflicts with includedFrameworks; empty arrays and null do not form a valid self-contained configuration. No .NET source copied.

How to reproduce

Seen on: historical Linux/Python 3.12.3; no GPU/game.
Settings and switches: existing --objdump / --readobj path; LLVM output explicitly mocked in unit tests.
Steps: run the new deterministic ZIP tests on original main 53f96d780588832401eadfc27c9cb41b2c2ae25c: required authored members, tfm: net8.0, included Microsoft.NETCore.App 8, plus framework or frameworks (including empty/null properties).
Expected: reject mixed runtime declarations.
Actual: original checker returns 0. This is a historical synthetic reproduction, not a real Windows package.

What changed

Reject shared-framework properties in self-contained package metadata without changing valid packages or other checks.

  • scripts/check_windows_files.py: two-line property-presence rule before existing included-runtime checks; .NET version, WPF, target, version-copy, ZIP/PE checks unchanged.
  • tests/test_windows_package_frameworks.py: nine standard-library methods, five mixed cases and four controls; real Python traversal with only external metadata-reader output mocked.

Measurements

Verdict: No new failed check or lost pass in the exact parent/head source-only comparison; failure signatures and skip reasons match.

Hardware: recorded Linux x86-64 host, 6 logical CPUs, 8074 MiB RAM, GCC 13.3; no GPU/driver used.
Scene: game-free public fixtures, isolated HOME/XDG/TMP; no game or human saves.
Method: one full normal default runner per exact commit, comparing check identities/statuses, skips and failure signatures; not timing, repeated runs or a performance median.
How to reproduce: python -I -B tests/run_all.py --jobs 3 on the pinned parent and head in the table with the same recorded environment and public prerequisites; the omitted instruction file is addressed by the source-only supplement below.

Before: main @ bbe6fdf231 After: this PR @ ef6bab2764
Complete runner checks 606 607
Passed 507 508
Failed, named below 14 14, same failure signatures
Default skips 85 85
Required C++20 checks 4 passed 4 passed

Both full-runner exits are 1, not a fully green suite or hosted-CI result.
Existing main failures: tests/test_appimage_player_build.py, tests/test_bake_portability.py, tests/test_crash_dialog.py, tests/test_env_on.py, tests/test_lift_cleanup_error.py, tests/test_make_game_cache.py, tests/test_missing_nup.py, tests/test_mods_size_table.py, tests/test_options_budget_once.py, tests/test_pipeline_tour.py, tests/test_readback_late.py, tests/test_vk_occlusion_queries.py, tests/test_vk_pgo.py, tests/test_walk_key.py.

AGENTS.md was never materialized. Its public blob was supplied read-only in memory for two unchanged SwitchesRemoved methods, passing on each commit. This is full-runner source-only qualification with that declared omission, not literal exact-tree/checkout or CI equivalence. The receipts retain complete stdout/stderr, unchanged source bytes/modes and empty owned process groups. None of these Linux checks was rerun for this description cleanup; the additional native Windows qualification is separate below.

Historical focused regression evidence

Original executed baseline 53f96d780588832401eadfc27c9cb41b2c2ae25c; historical publication rebuilt on e090cc48b63e2fb4e655133807903ac59149b723, with old published head 81c2a6a969f964bde1b2ed71b3ac64a04e8e6e5a. Those original labels are preserved, not substituted for the current parent/head. The old baseline-to-rebuild delta was confined to assets/saves; ten inspected code/test/workflow/documentation inputs retained bytes/modes. That was bounded source-provenance carryover, not a native replay on e090...; unrelated save objects were not test fixtures.

Initial RED/GREEN and an independent historical Linux/Python 3.12.3 replay retain identical ZIP bytes: baseline five failed assertions + four passing controls in nine methods; candidate nine passes, no failures/errors. Existing tests/test_windows_on_linux.py (six methods) and tests/test_recomplauncher_json.py (four) pass unchanged on both sides. Seventy-one source-read module checks pass per side, jobs=1, a selected partition rather than the full suite.

Only external reader run() is mocked; real Python main()/files()/pe() traversal runs. ZIP executable members are non-executable authored placeholders and LLVM metadata is fixture text: this is admission-rule proof, not real PE, LLVM, .NET or Windows validation. Source/test/ZIP hashes and complete commands/streams are retained.

New native Windows package qualification

Exact head: ef6bab2764f293c9377675f85608c599c645fb7d. Windows 11 build 26300, x64; private .NET SDK 8.0.428. One native build of the real setup executable and self-contained win-x64 Builder, followed by the unchanged builder_package.py package / zip release-layout steps. Qualification package version: 0.0.0; this is a private qualification build, not an official release or hosted-CI artifact. Optional third-party object acceleration was omitted.

The unmodified checker ran against those actual PE/.NET ZIP members with real llvm-objdump.exe and llvm-readobj.exe, not reader fixtures, and exited 0. Path-abbreviated command:

python -I -B -X utf8 scripts/check_windows_files.py --objdump <llvm-objdump.exe> --readobj <llvm-readobj.exe> <LongshotBuilder-qualification-ef6bab2-windows-x64.zip>
  • ZIP: 43,474,224 bytes; SHA256 8d3250e20c891fc39fe409b186d61704c277cffd4c5dd6e41e9adb6fc8b96e1d.
  • Complete checker stdout SHA256: 462d706b864e69da17af3ff234bcd60870099bb5a92fada533d8c6d176d3f6b4.
  • Public source bytes were verified unchanged. The source export omitted AGENTS.md and used head/tree-only Git objects; this is not a complete-checkout or full-Windows-CI claim. Binaries and private build outputs are not committed or uploaded.
  • The native setup correctly rejected an empty built-game directory. The enclosing build controller nevertheless exited 1 at its later Builder CLI probe: that probe did not establish normal startup or absence of downloads. A separately labelled follow-up is retained, not used to turn that controller into a pass. No successful no-download Builder smoke is claimed.

This supplies the requested real-package/real-reader metadata evidence, separately from the still-unqualified end-user startup path. It is not a game, GPU, Vulkan, Wine or clean-machine runtime test.

Flags and settings

None

Testing

Tested: the full exact Linux parent/head runner in Measurements: 507 → 508 passes, 14 unchanged failures and 85 skips, both exits 1, no new failed check or lost pass, equal failure signatures and declared source-only supplement. Additionally, the exact head's real private native Windows release-layout package passed the unmodified checker with real LLVM readers, exit 0; its package hash and the enclosing controller's later failure are separated above. Historical synthetic/selected-partition receipts remain distinct.

Not tested: successful normal end-user Builder startup/install/build flow, a clean Windows machine without shared runtimes, a valid no-download Builder smoke, Wine, game/GPU behavior, complete Windows CI or later main. The real-package metadata pass does not establish those results.

Must be tested:

  • Windows, by hand by an equipped contributor: complete normal startup acceptance for the pinned private package or an independently built package at this head, expecting the self-contained Builder to start normally without a shared runtime. Retain the exact package/head and native outcome. The real-reader metadata gate is now covered above; startup remains separate.

Review and overlap

HumanBean's review is COMMENT, not approval: "Code review only; nothing was run." The new native qualification above supplies the requested checker run on this branch's real release-layout package with real LLVM readers, privately rather than as a hosted build-job result. It does not turn that review into approval or supply the remaining startup acceptance.

#98 adds optional Authenticode handling in the same file but leaves this runtimeOptions block unchanged in the inspected diff. Combined Authenticode behavior is untested; no signing key or native signing tool was used.

Risks

What could break: contradictory shared-framework metadata now fails admission even if an included runtime is present; not general runtimeconfig schema validation.
Turning it off: revert.
Compatibility: no Builder/runtime, saves/options/caches, Vulkan ABI, release layout or external invocation changes; only public code/authored fixtures, no real package or binary committed.

Readiness provenance

Captured state: non-WIP / author-ready, not approved or merged. The real-package metadata check now has native evidence; normal Windows startup acceptance remains outstanding pre-merge evidence.

Head ef6bab2764f293c9377675f85608c599c645fb7d; actual pinned parent/base bbe6fdf23170310117c714958248e60ec0686a62. The later input-snapshot main 30cedbc5203bf5c6f79fbb58394d8d5634881e8f is distinct and is not qualified by these receipts. This update adds the native package qualification without a new rebase or Linux-suite rerun.

Rebase credit: HumanBean: "No tests were run here; the test boxes stay yours." Rebase and subsequent author test evidence are separate. The rebase box records the main used then; a ticked full-runner box uses the template's named-baseline-failure allowance, not an all-green claim.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. Pinned maintainer rebase only; actual parent and later unqualified main are distinguished under Readiness provenance.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
**Type:** fix · **Risk:** low · **Tested on:** Linux full source-only parent/head runner; real native Windows release-layout package with real LLVM readers · **Needs:** normal end-user Windows startup acceptance ## Why The release ZIP checker can accept contradictory .NET metadata: both an included runtime and a shared-framework dependency, despite requiring a self-contained package. The existing portable-startup test checks publishing output, not rejection of malformed ZIP metadata. Reference: [dotnet/runtime v8.0.0 `runtime_config_t::parse_opts`](https://github.com/dotnet/runtime/blob/v8.0.0/src/native/corehost/runtime_config.cpp). Presence of `framework` / `frameworks` conflicts with `includedFrameworks`; empty arrays and null do not form a valid self-contained configuration. No .NET source copied. ## How to reproduce **Seen on:** historical Linux/Python 3.12.3; no GPU/game. **Settings and switches:** existing `--objdump` / `--readobj` path; LLVM output explicitly mocked in unit tests. **Steps:** run the new deterministic ZIP tests on original main `53f96d780588832401eadfc27c9cb41b2c2ae25c`: required authored members, `tfm: net8.0`, included Microsoft.NETCore.App 8, plus `framework` or `frameworks` (including empty/null properties). **Expected:** reject mixed runtime declarations. **Actual:** original checker returns 0. This is a historical synthetic reproduction, not a real Windows package. ## What changed Reject shared-framework properties in self-contained package metadata without changing valid packages or other checks. - `scripts/check_windows_files.py`: two-line property-presence rule before existing included-runtime checks; .NET version, WPF, target, version-copy, ZIP/PE checks unchanged. - `tests/test_windows_package_frameworks.py`: nine standard-library methods, five mixed cases and four controls; real Python traversal with only external metadata-reader output mocked. ## Measurements **Verdict:** No new failed check or lost pass in the exact parent/head source-only comparison; failure signatures and skip reasons match. Hardware: recorded Linux x86-64 host, 6 logical CPUs, 8074 MiB RAM, GCC 13.3; no GPU/driver used. Scene: game-free public fixtures, isolated HOME/XDG/TMP; no game or human saves. Method: one full normal default runner per exact commit, comparing check identities/statuses, skips and failure signatures; not timing, repeated runs or a performance median. How to reproduce: `python -I -B tests/run_all.py --jobs 3` on the pinned parent and head in the table with the same recorded environment and public prerequisites; the omitted instruction file is addressed by the source-only supplement below. | | Before: main @ bbe6fdf23170310117c714958248e60ec0686a62 | After: this PR @ ef6bab2764f293c9377675f85608c599c645fb7d | |---|---|---| | Complete runner checks | 606 | 607 | | Passed | 507 | 508 | | Failed, named below | 14 | 14, same failure signatures | | Default skips | 85 | 85 | | Required C++20 checks | 4 passed | 4 passed | Both full-runner exits are **1**, not a fully green suite or hosted-CI result. Existing main failures: `tests/test_appimage_player_build.py`, `tests/test_bake_portability.py`, `tests/test_crash_dialog.py`, `tests/test_env_on.py`, `tests/test_lift_cleanup_error.py`, `tests/test_make_game_cache.py`, `tests/test_missing_nup.py`, `tests/test_mods_size_table.py`, `tests/test_options_budget_once.py`, `tests/test_pipeline_tour.py`, `tests/test_readback_late.py`, `tests/test_vk_occlusion_queries.py`, `tests/test_vk_pgo.py`, `tests/test_walk_key.py`. `AGENTS.md` was never materialized. Its public blob was supplied read-only in memory for two unchanged `SwitchesRemoved` methods, passing on each commit. This is full-runner **source-only** qualification with that declared omission, not literal exact-tree/checkout or CI equivalence. The receipts retain complete stdout/stderr, unchanged source bytes/modes and empty owned process groups. None of these Linux checks was rerun for this description cleanup; the additional native Windows qualification is separate below. ### Historical focused regression evidence Original executed baseline `53f96d780588832401eadfc27c9cb41b2c2ae25c`; historical publication rebuilt on `e090cc48b63e2fb4e655133807903ac59149b723`, with old published head `81c2a6a969f964bde1b2ed71b3ac64a04e8e6e5a`. Those original labels are preserved, not substituted for the current parent/head. The old baseline-to-rebuild delta was confined to `assets/saves`; ten inspected code/test/workflow/documentation inputs retained bytes/modes. That was bounded source-provenance carryover, not a native replay on `e090...`; unrelated save objects were not test fixtures. Initial RED/GREEN and an independent historical Linux/Python 3.12.3 replay retain identical ZIP bytes: baseline five failed assertions + four passing controls in nine methods; candidate nine passes, no failures/errors. Existing `tests/test_windows_on_linux.py` (six methods) and `tests/test_recomplauncher_json.py` (four) pass unchanged on both sides. Seventy-one source-read module checks pass per side, jobs=1, a selected partition rather than the full suite. Only external reader `run()` is mocked; real Python `main()`/`files()`/`pe()` traversal runs. ZIP executable members are non-executable authored placeholders and LLVM metadata is fixture text: this is admission-rule proof, not real PE, LLVM, .NET or Windows validation. Source/test/ZIP hashes and complete commands/streams are retained. ### New native Windows package qualification Exact head: `ef6bab2764f293c9377675f85608c599c645fb7d`. Windows 11 build 26300, x64; private .NET SDK 8.0.428. One native build of the real setup executable and self-contained `win-x64` Builder, followed by the unchanged `builder_package.py package` / `zip` release-layout steps. Qualification package version: `0.0.0`; this is a private qualification build, not an official release or hosted-CI artifact. Optional third-party object acceleration was omitted. The unmodified checker ran against those actual PE/.NET ZIP members with **real** `llvm-objdump.exe` and `llvm-readobj.exe`, not reader fixtures, and exited **0**. Path-abbreviated command: ```text python -I -B -X utf8 scripts/check_windows_files.py --objdump <llvm-objdump.exe> --readobj <llvm-readobj.exe> <LongshotBuilder-qualification-ef6bab2-windows-x64.zip> ``` - ZIP: 43,474,224 bytes; SHA256 `8d3250e20c891fc39fe409b186d61704c277cffd4c5dd6e41e9adb6fc8b96e1d`. - Complete checker stdout SHA256: `462d706b864e69da17af3ff234bcd60870099bb5a92fada533d8c6d176d3f6b4`. - Public source bytes were verified unchanged. The source export omitted `AGENTS.md` and used head/tree-only Git objects; this is not a complete-checkout or full-Windows-CI claim. Binaries and private build outputs are not committed or uploaded. - The native setup correctly rejected an empty built-game directory. The enclosing build controller nevertheless exited **1** at its later Builder CLI probe: that probe did not establish normal startup or absence of downloads. A separately labelled follow-up is retained, not used to turn that controller into a pass. **No successful no-download Builder smoke is claimed.** This supplies the requested real-package/real-reader metadata evidence, separately from the still-unqualified end-user startup path. It is not a game, GPU, Vulkan, Wine or clean-machine runtime test. ### Flags and settings None ## Testing **Tested:** the full exact Linux parent/head runner in Measurements: 507 → 508 passes, 14 unchanged failures and 85 skips, both exits 1, no new failed check or lost pass, equal failure signatures and declared source-only supplement. Additionally, the exact head's real private native Windows release-layout package passed the unmodified checker with real LLVM readers, exit 0; its package hash and the enclosing controller's later failure are separated above. Historical synthetic/selected-partition receipts remain distinct. **Not tested:** successful normal end-user Builder startup/install/build flow, a clean Windows machine without shared runtimes, a valid no-download Builder smoke, Wine, game/GPU behavior, complete Windows CI or later main. The real-package metadata pass does not establish those results. **Must be tested:** - Windows, by hand by an equipped contributor: complete normal startup acceptance for the pinned private package or an independently built package at this head, expecting the self-contained Builder to start normally without a shared runtime. Retain the exact package/head and native outcome. The real-reader metadata gate is now covered above; startup remains separate. ## Review and overlap [HumanBean's review](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/690#issuecomment-29871) is `COMMENT`, not approval: "Code review only; nothing was run." The new native qualification above supplies the requested checker run on **this branch's real release-layout package** with real LLVM readers, privately rather than as a hosted build-job result. It does not turn that review into approval or supply the remaining startup acceptance. [#98](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/98) adds optional Authenticode handling in the same file but leaves this runtimeOptions block unchanged in the inspected diff. Combined Authenticode behavior is untested; no signing key or native signing tool was used. ## Risks **What could break:** contradictory shared-framework metadata now fails admission even if an included runtime is present; not general runtimeconfig schema validation. **Turning it off:** revert. **Compatibility:** no Builder/runtime, saves/options/caches, Vulkan ABI, release layout or external invocation changes; only public code/authored fixtures, no real package or binary committed. ## Readiness provenance Captured state: **non-WIP / author-ready**, not approved or merged. The real-package metadata check now has native evidence; normal Windows startup acceptance remains outstanding pre-merge evidence. Head `ef6bab2764f293c9377675f85608c599c645fb7d`; actual pinned parent/base `bbe6fdf23170310117c714958248e60ec0686a62`. The later input-snapshot main `30cedbc5203bf5c6f79fbb58394d8d5634881e8f` is distinct and is **not qualified by these receipts**. This update adds the native package qualification without a new rebase or Linux-suite rerun. Rebase credit: [HumanBean](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/690#issuecomment-27775): "No tests were run here; the test boxes stay yours." Rebase and subsequent author test evidence are separate. The rebase box records the main used then; a ticked full-runner box uses the template's named-baseline-failure allowance, not an all-green claim. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. Pinned maintainer rebase only; actual parent and later unqualified main are distinguished under Readiness provenance. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened.
fix(builder): reject mixed runtime declarations in Windows packages
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
81c2a6a969
Reject shared-framework keys in the self-contained Windows ZIP gate.
Cover mixed object, array, empty-array and null declarations with synthetic metadata checks.
Preserve valid included-runtime and existing rejection controls.

Assisted-by: Hermes Agent (OpenAI GPT-6.1-sol)
Co-Authored-By: Claudia (OpenAI GPT-6.1-sol)
HumanBean force-pushed fix/windows-package-frameworks-e090-20261115 from 81c2a6a969
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to ef6bab2764
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 2s
CI / Workflow lint (actionlint) (pull_request) Successful in 4s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 4s
Third-party parts / As their notes say (pull_request) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
2026-11-15 18:42:55 +00:00
Compare
Owner

Rebased onto main @ bbe6fdf: no conflicts. No tests were run here; the test boxes stay yours.

Rebased onto `main` @ bbe6fdf: no conflicts. No tests were run here; the test boxes stay yours.
NitnekLeBorgne changed title from WIP: fix(builder): reject mixed runtime declarations in Windows packages to fix(builder): reject mixed runtime declarations in Windows packages 2026-11-15 20:13:38 +00:00
HumanBean left a comment

Code review only; nothing was run.

The two-line rule in scripts/check_windows_files.py is correct. "framework" in rc or "frameworks" in rc also catches the empty-array and null cases the description names. A real self-contained publish writes includedFrameworks and no framework, so valid packages are unaffected. The new check sits before the existing included-runtime checks, so a mixed config reports both problems and the existing diagnostics still fire.

The tests are sound. Only run() is mocked and main(), files() and pe() really run. The five mixed cases and four controls match the description. Each assertion checks the exact problem count, so a message change can't pass by accident. problems is module-level, but setUp loads a fresh module per test, so there is no leakage.

Remaining points, neither blocking:

  • The description's last sections ("Readiness provenance...", the unchecked current-main box) describe an earlier head, 81c2a6a, and say the PR is blocked. The head is now ef6bab2, rebased on main bbe6fdf. Please trim them so pr ready sees one consistent state.
  • "Must be tested" names a real Windows release-package run with the real LLVM readers. Nobody has posted that run, so this stays a comment rather than an approval. The Windows build job's checker run on this branch's package would cover it. Once it is posted, this is fine to merge.

Overlap: the description mentions an Authenticode PR (#98) touching the same file, but it leaves this block unchanged, so the order doesn't matter.

Code review only; nothing was run. The two-line rule in `scripts/check_windows_files.py` is correct. `"framework" in rc or "frameworks" in rc` also catches the empty-array and null cases the description names. A real self-contained publish writes `includedFrameworks` and no `framework`, so valid packages are unaffected. The new check sits before the existing included-runtime checks, so a mixed config reports both problems and the existing diagnostics still fire. The tests are sound. Only `run()` is mocked and `main()`, `files()` and `pe()` really run. The five mixed cases and four controls match the description. Each assertion checks the exact problem count, so a message change can't pass by accident. `problems` is module-level, but `setUp` loads a fresh module per test, so there is no leakage. Remaining points, neither blocking: - The description's last sections ("Readiness provenance...", the unchecked current-main box) describe an earlier head, `81c2a6a`, and say the PR is blocked. The head is now `ef6bab2`, rebased on main `bbe6fdf`. Please trim them so `pr ready` sees one consistent state. - "Must be tested" names a real Windows release-package run with the real LLVM readers. Nobody has posted that run, so this stays a comment rather than an approval. The Windows build job's checker run on this branch's package would cover it. Once it is posted, this is fine to merge. Overlap: the description mentions an Authenticode PR (#98) touching the same file, but it leaves this block unchanged, so the order doesn't matter.
Author
Contributor

Real-package follow-up to the metadata-check request, at unchanged head ef6bab2764f293c9377675f85608c599c645fb7d:

On native Windows 11 build 26300/x64, private .NET SDK 8.0.428, I built the real setup executable and self-contained win-x64 Builder, then used the unchanged builder_package.py package / zip layout steps. This is a private qualification package (version 0.0.0, optional third-party object acceleration omitted), not an official release or hosted-CI artifact.

The unmodified scripts/check_windows_files.py ran on the actual ZIP's PE/.NET members with real llvm-objdump.exe and llvm-readobj.exe, and exited 0.

  • ZIP: 43,474,224 bytes; SHA256 8d3250e20c891fc39fe409b186d61704c277cffd4c5dd6e41e9adb6fc8b96e1d.
  • Complete checker stdout SHA256: 462d706b864e69da17af3ff234bcd60870099bb5a92fada533d8c6d176d3f6b4.
  • Public source bytes verified unchanged. AGENTS.md was omitted; head/tree-only Git objects were used. No literal complete-checkout or Windows-CI equivalence is claimed, and private binaries remain private.

Important boundary: the later native Builder CLI probe failed, so the enclosing controller exited 1, despite the earlier build/package/checker success. An empty built-game directory was correctly rejected by the native setup, but successful normal startup and a no-download Builder smoke are not established; the separately retained follow-up does not turn that controller into a pass.

The description now reports the real-package/real-reader evidence and that limitation directly, preserving the existing Linux baseline failures and leaving normal end-user startup acceptance as separate pre-merge evidence. This is not game/GPU, Vulkan, Wine or clean-machine runtime validation.

Real-package follow-up to the metadata-check request, at unchanged head `ef6bab2764f293c9377675f85608c599c645fb7d`: On native Windows 11 build 26300/x64, private .NET SDK 8.0.428, I built the real setup executable and self-contained `win-x64` Builder, then used the unchanged `builder_package.py package` / `zip` layout steps. This is a private qualification package (version `0.0.0`, optional third-party object acceleration omitted), not an official release or hosted-CI artifact. The unmodified `scripts/check_windows_files.py` ran on the actual ZIP's PE/.NET members with **real `llvm-objdump.exe` and `llvm-readobj.exe`**, and exited **0**. - ZIP: **43,474,224 bytes**; SHA256 `8d3250e20c891fc39fe409b186d61704c277cffd4c5dd6e41e9adb6fc8b96e1d`. - Complete checker stdout SHA256: `462d706b864e69da17af3ff234bcd60870099bb5a92fada533d8c6d176d3f6b4`. - Public source bytes verified unchanged. `AGENTS.md` was omitted; head/tree-only Git objects were used. No literal complete-checkout or Windows-CI equivalence is claimed, and private binaries remain private. Important boundary: the later native Builder CLI probe failed, so the **enclosing controller exited 1**, despite the earlier build/package/checker success. An empty built-game directory was correctly rejected by the native setup, but **successful normal startup and a no-download Builder smoke are not established**; the separately retained follow-up does not turn that controller into a pass. The description now reports the real-package/real-reader evidence and that limitation directly, preserving the existing Linux baseline failures and leaving normal end-user startup acceptance as separate pre-merge evidence. This is not game/GPU, Vulkan, Wine or clean-machine runtime validation.
Member

Code-only review of ef6bab2764; informational findings, with final approval left to another reviewer.

No new defect found in the checker change or its nine regression tests. The presence check rejects both shared-framework properties even when null or empty, and leaves the existing included-runtime checks intact. Removing that guard would make the five mixed-configuration tests fail; the valid-package control guards against rejecting all packages. I found no unexplained external effects in the new test.

The native Windows follow-up now reports the real-package/real-LLVM-reader pass requested in the earlier review, at this exact head. That addresses the earlier missing metadata-check evidence. It is distinct from the later failed CLI probe: the description still explicitly requires normal self-contained Builder startup acceptance on Windows before merge. This is the remaining declared validation gap, not an additional game/GPU test request or a demonstrated regression from these two lines.

I also checked the Authenticode PR overlap: its checker changes leave this runtime-options block untouched, so I found no source-level ordering dependency. Combined signing behavior was not validated here.

Read the complete diff, surrounding checker, tests, prior review and current evidence. No tests, builds, package launches or PR code were run.

Code-only review of ef6bab2764f293c9377675f85608c599c645fb7d; informational findings, with final approval left to another reviewer. No new defect found in the checker change or its nine regression tests. The presence check rejects both shared-framework properties even when null or empty, and leaves the existing included-runtime checks intact. Removing that guard would make the five mixed-configuration tests fail; the valid-package control guards against rejecting all packages. I found no unexplained external effects in the new test. The [native Windows follow-up](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/690#issuecomment-31269) now reports the real-package/real-LLVM-reader pass requested in the earlier review, at this exact head. That addresses the earlier missing metadata-check evidence. It is distinct from the later failed CLI probe: the description still explicitly requires normal self-contained Builder startup acceptance on Windows before merge. This is the remaining declared validation gap, not an additional game/GPU test request or a demonstrated regression from these two lines. I also checked the [Authenticode PR](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/98) overlap: its checker changes leave this runtime-options block untouched, so I found no source-level ordering dependency. Combined signing behavior was not validated here. Read the complete diff, surrounding checker, tests, prior review and current evidence. No tests, builds, package launches or PR code were run.
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 2s
CI / Workflow lint (actionlint) (pull_request) Successful in 4s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 4s
Third-party parts / As their notes say (pull_request) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/windows-package-frameworks-e090-20261115:NitnekLeBorgne-fix/windows-package-frameworks-e090-20261115'
git switch 'NitnekLeBorgne-fix/windows-package-frameworks-e090-20261115'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!690
No description provided.