fix(linux): follow deep slave graphs for the slow-disk warning #655

Merged
Contributor

Type: fix · Risk: low · Tested on: Linux full source-only parent/head runner and synthetic disk graphs · Needs: real deep LVM/RAID/LUKS read-only check

Why

The slow-disk warning can miss a hard drive below more than four device-mapper/RAID slave layers, reading a virtual node's rotational=0 instead. Classification changes only the warning: no storage-corruption, build-speed or physical-hardware claim; builds still continue on HDD.

How to reproduce

Seen on: Linux synthetic sysfs fixture; real devices/mounts/sysfs untouched.
Settings and switches: private temporary files and links, no game setting.
Steps: put a rotational=1 leaf below five virtual rotational=0 nodes; call _device_rotational on the top.
Expected: True for the known underlying HDD.
Actual: the original depth cutoff returns False from a virtual device.

What changed

Traverse deep slave graphs while preserving warning-only fallbacks.

  • nx2/disk.py, _device_rotational: iterative postorder traversal, active-realpath cycle guard and cached completed answers, including unknowns, for shared slaves.
  • Preserve known-HDD precedence, known SSD/unknown handling and queue/partition-ancestor fallback.
  • tests/test_disk_rotational.py: synthetic fixtures importing disk, not make_game; runner Windows skip plus direct unittest guard before setup.

Cycles terminate; this is not an order-independent fixed-point classifier. The classification contract concerns stable acyclic graphs.

Measurements

Verdict: No new failed check or lost pass in the exact parent/head source-only comparison; failure signatures and skip reasons match.

Hardware: recorded Linux x86-64 host, 6 logical CPUs, 8074 MiB RAM, GCC 13.3; no GPU/driver used.
Scene: game-free public fixtures, isolated HOME/XDG/TMP; no game or human saves.
Method: one full normal default runner per exact commit, comparing check identities/statuses, skips and failure signatures; not timing, repeated runs or a performance median.
How to reproduce: python -I -B tests/run_all.py --jobs 3 on the pinned parent and head in the table with the same recorded environment and public prerequisites; the omitted instruction file is addressed by the source-only supplement below.

Before: main @ 7bacf84681 After: this PR @ 7b39fabd7d
Complete runner checks 609 610
Passed 510 511
Failed, named below 14 14, identical signatures
Default skips 85 85, same reasons
Required C++20 checks 4 passed 4 passed

Both full-runner exits are 1, not a fully green suite or hosted-CI result.
Existing main failures: tests/test_appimage_player_build.py, tests/test_bake_portability.py, tests/test_crash_dialog.py, tests/test_env_on.py, tests/test_lift_cleanup_error.py, tests/test_make_game_cache.py, tests/test_missing_nup.py, tests/test_mods_size_table.py, tests/test_options_budget_once.py, tests/test_pipeline_tour.py, tests/test_readback_late.py, tests/test_vk_occlusion_queries.py, tests/test_vk_pgo.py, tests/test_walk_key.py.

AGENTS.md was never materialized. Its public blob was supplied read-only in memory for two unchanged SwitchesRemoved methods, passing on each commit. This is full-runner source-only qualification with that declared omission, not literal exact-tree/checkout or CI equivalence. The receipts retain complete stdout/stderr, unchanged source bytes/modes and empty owned process groups. None of these product checks was rerun for this description cleanup.

Historical focused regression evidence

Historical main 6c9edffe5da1f5b5383977aeab3f544c0de25d4c → original candidate 4c8d73fa33e5c8a8316bb2d92541ddd15547f450, not a replay on later main. Identical initial deep-HDD test: False is not True, native exit 1 on baseline; passes after the correction. A later original-source negative control reproduces the failure.

Retained Linux coverage: 20 distinct methods (11 graph + nine unchanged existing Linux), all passing without errors/skips: 1,100-layer HDD, deep SSD, mixed/unknown leaves, partition fallback, cycles and shared-slave DAG. The synthetic Windows-guard probe records 11 skips before setUp with no fixture activity; it is not native Windows or another algorithm RED. Its initial invalid attempt is excluded. No physical-storage or speed measurement is claimed.

Flags and settings

None

Testing

Tested: the full exact Linux parent/head runner in Measurements (510 → 511 passes; 14 identical failures and 85 skips; both exits 1), with no new failure or lost pass and the declared source-only supplement. Retained focused tests are historical, not extra full-suite executions.

Not tested: real deep LVM/RAID/LUKS hardware, its build caller, native Windows, game/GPU behavior or later main. The new Linux graph module intentionally skips Windows.

Must be tested:

  • Linux, by hand by an equipped contributor: on an existing stable deep acyclic LVM/RAID/LUKS stack, compare read-only classification with independently known physical leaves, expecting HDD/SSD answers to agree without changing disks, mounts or data. No hardware receipt is available yet.

Risks

What could break: changing/unusual sysfs may yield unknown; cyclic graphs terminate without fixed-point HDD propagation. State grows with the finite graph visited.
Turning it off: revert; this warning never blocks the build.
Compatibility: no configuration, save/data, storage-content, renderer ABI, authentication or cache changes.

Readiness provenance

Captured state: non-WIP / author-ready, not approved or merged. The real-storage request remains pre-merge work.

Head 7b39fabd7dada970890807c27992c488b53a553b; direct commit parent 2ba185eaa41345e5a0816d302ed8251c8a4124ae; integration baseline 7bacf8468133f0751fa31ffc61bfbf4b6ecf2f87. The direct parent and integration baseline are deliberately distinct. This test-only follow-up was independently SPEC/quality reviewed and its exact new commit ran the complete normal Linux runner: 511 pass / 14 existing FAIL / 85 skip, compared with the retained 510 / 14 / 85 integration baseline, with identical failure signatures and skip reasons. Two unchanged source-check methods passed separately with the public AGENTS blob only in memory; AGENTS was never materialized, so this is source-only qualification, not literal exact-tree CI. The later input-snapshot main 30cedbc5203bf5c6f79fbb58394d8d5634881e8f is not claimed tested. HumanBean rebased the earlier public commit; this one-line child follow-up was fast-forward pushed by Claudia.

Rebase credit: HumanBean: "No tests were run here; the test boxes stay yours." Rebase and subsequent author test evidence are separate. The rebase box records the main used then; a ticked full-runner box uses the template's named-baseline-failure allowance, not an all-green claim.

HumanBean's review is COMMENT, not approval: "Code-only review (nothing run)." It requests the storage receipt and consistent provenance. The non-blocking .resolve() suggestion is now implemented in the test setUp only: the temporary fixture root is canonicalized, with no production change. The retained alias RED and alias/canonical GREEN focused receipts remain separate from the new whole-runner result. A real deep LVM/RAID/LUKS hardware receipt is still missing; this test-root fix does not substitute for it.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why. Not ticked yet: Testing's Tested names only the Linux game-free runner, and the change touches nx2/disk.py with no game run.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks. Not ticked yet: Risks says state grows with the graph visited, and no memory or time for that growth was measured.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. Pinned maintainer rebase only; actual parent and later unqualified main are distinguished under Readiness provenance.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
**Type:** fix · **Risk:** low · **Tested on:** Linux full source-only parent/head runner and synthetic disk graphs · **Needs:** real deep LVM/RAID/LUKS read-only check ## Why The slow-disk warning can miss a hard drive below more than four device-mapper/RAID slave layers, reading a virtual node's `rotational=0` instead. Classification changes only the warning: no storage-corruption, build-speed or physical-hardware claim; builds still continue on HDD. ## How to reproduce **Seen on:** Linux synthetic sysfs fixture; real devices/mounts/sysfs untouched. **Settings and switches:** private temporary files and links, no game setting. **Steps:** put a `rotational=1` leaf below five virtual `rotational=0` nodes; call `_device_rotational` on the top. **Expected:** `True` for the known underlying HDD. **Actual:** the original depth cutoff returns `False` from a virtual device. ## What changed Traverse deep slave graphs while preserving warning-only fallbacks. - `nx2/disk.py`, `_device_rotational`: iterative postorder traversal, active-realpath cycle guard and cached completed answers, including unknowns, for shared slaves. - Preserve known-HDD precedence, known SSD/unknown handling and queue/partition-ancestor fallback. - `tests/test_disk_rotational.py`: synthetic fixtures importing `disk`, not `make_game`; runner Windows skip plus direct unittest guard before setup. Cycles terminate; this is not an order-independent fixed-point classifier. The classification contract concerns stable acyclic graphs. ## Measurements **Verdict:** No new failed check or lost pass in the exact parent/head source-only comparison; failure signatures and skip reasons match. Hardware: recorded Linux x86-64 host, 6 logical CPUs, 8074 MiB RAM, GCC 13.3; no GPU/driver used. Scene: game-free public fixtures, isolated HOME/XDG/TMP; no game or human saves. Method: one full normal default runner per exact commit, comparing check identities/statuses, skips and failure signatures; not timing, repeated runs or a performance median. How to reproduce: `python -I -B tests/run_all.py --jobs 3` on the pinned parent and head in the table with the same recorded environment and public prerequisites; the omitted instruction file is addressed by the source-only supplement below. | | Before: main @ 7bacf8468133f0751fa31ffc61bfbf4b6ecf2f87 | After: this PR @ 7b39fabd7dada970890807c27992c488b53a553b | |---|---|---| | Complete runner checks | 609 | 610 | | Passed | 510 | 511 | | Failed, named below | 14 | 14, identical signatures | | Default skips | 85 | 85, same reasons | | Required C++20 checks | 4 passed | 4 passed | Both full-runner exits are **1**, not a fully green suite or hosted-CI result. Existing main failures: `tests/test_appimage_player_build.py`, `tests/test_bake_portability.py`, `tests/test_crash_dialog.py`, `tests/test_env_on.py`, `tests/test_lift_cleanup_error.py`, `tests/test_make_game_cache.py`, `tests/test_missing_nup.py`, `tests/test_mods_size_table.py`, `tests/test_options_budget_once.py`, `tests/test_pipeline_tour.py`, `tests/test_readback_late.py`, `tests/test_vk_occlusion_queries.py`, `tests/test_vk_pgo.py`, `tests/test_walk_key.py`. `AGENTS.md` was never materialized. Its public blob was supplied read-only in memory for two unchanged `SwitchesRemoved` methods, passing on each commit. This is full-runner **source-only** qualification with that declared omission, not literal exact-tree/checkout or CI equivalence. The receipts retain complete stdout/stderr, unchanged source bytes/modes and empty owned process groups. None of these product checks was rerun for this description cleanup. ### Historical focused regression evidence Historical main `6c9edffe5da1f5b5383977aeab3f544c0de25d4c` → original candidate `4c8d73fa33e5c8a8316bb2d92541ddd15547f450`, not a replay on later main. Identical initial deep-HDD test: `False is not True`, native exit 1 on baseline; passes after the correction. A later original-source negative control reproduces the failure. Retained Linux coverage: 20 distinct methods (11 graph + nine unchanged existing Linux), all passing without errors/skips: 1,100-layer HDD, deep SSD, mixed/unknown leaves, partition fallback, cycles and shared-slave DAG. The synthetic Windows-guard probe records 11 skips before `setUp` with no fixture activity; it is not native Windows or another algorithm RED. Its initial invalid attempt is excluded. No physical-storage or speed measurement is claimed. ### Flags and settings None ## Testing **Tested:** the full exact Linux parent/head runner in Measurements (510 → 511 passes; 14 identical failures and 85 skips; both exits 1), with no new failure or lost pass and the declared source-only supplement. Retained focused tests are historical, not extra full-suite executions. **Not tested:** real deep LVM/RAID/LUKS hardware, its build caller, native Windows, game/GPU behavior or later main. The new Linux graph module intentionally skips Windows. **Must be tested:** - Linux, by hand by an equipped contributor: on an existing stable deep acyclic LVM/RAID/LUKS stack, compare read-only classification with independently known physical leaves, expecting HDD/SSD answers to agree without changing disks, mounts or data. No hardware receipt is available yet. ## Risks **What could break:** changing/unusual sysfs may yield unknown; cyclic graphs terminate without fixed-point HDD propagation. State grows with the finite graph visited. **Turning it off:** revert; this warning never blocks the build. **Compatibility:** no configuration, save/data, storage-content, renderer ABI, authentication or cache changes. ## Readiness provenance Captured state: **non-WIP / author-ready**, not approved or merged. The real-storage request remains pre-merge work. Head `7b39fabd7dada970890807c27992c488b53a553b`; direct commit parent `2ba185eaa41345e5a0816d302ed8251c8a4124ae`; integration baseline `7bacf8468133f0751fa31ffc61bfbf4b6ecf2f87`. The direct parent and integration baseline are deliberately distinct. This test-only follow-up was independently SPEC/quality reviewed and its exact new commit ran the complete normal Linux runner: 511 pass / 14 existing FAIL / 85 skip, compared with the retained 510 / 14 / 85 integration baseline, with identical failure signatures and skip reasons. Two unchanged source-check methods passed separately with the public AGENTS blob only in memory; AGENTS was never materialized, so this is source-only qualification, not literal exact-tree CI. The later input-snapshot main `30cedbc5203bf5c6f79fbb58394d8d5634881e8f` is not claimed tested. HumanBean rebased the earlier public commit; this one-line child follow-up was fast-forward pushed by Claudia. Rebase credit: [HumanBean](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/655#issuecomment-27782): "No tests were run here; the test boxes stay yours." Rebase and subsequent author test evidence are separate. The rebase box records the main used then; a ticked full-runner box uses the template's named-baseline-failure allowance, not an all-green claim. [HumanBean's review](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/655#issuecomment-29876) is `COMMENT`, not approval: "Code-only review (nothing run)." It requests the storage receipt and consistent provenance. The non-blocking `.resolve()` suggestion is now implemented in the test setUp only: the temporary fixture root is canonicalized, with no production change. The retained alias RED and alias/canonical GREEN focused receipts remain separate from the new whole-runner result. A real deep LVM/RAID/LUKS hardware receipt is still missing; this test-root fix does not substitute for it. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [ ] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. Not ticked yet: Testing's Tested names only the Linux game-free runner, and the change touches nx2/disk.py with no game run. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [ ] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. Not ticked yet: Risks says state grows with the graph visited, and no memory or time for that growth was measured. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. Pinned maintainer rebase only; actual parent and later unqualified main are distinguished under Readiness provenance. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here.
NitnekLeBorgne force-pushed fix/linux-deep-slaves-warning-20261115 from 4c8d73fa33
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 4ab26f1fd6
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 18:42:44 +00:00
Compare
HumanBean force-pushed fix/linux-deep-slaves-warning-20261115 from 4ab26f1fd6
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 2ba185eaa4
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
2026-11-15 18:43:57 +00:00
Compare
Owner

Rebased onto main @ 7bacf84 (your branch had moved to 4ab26f1 while I worked, so this is on top of that): no conflicts. No tests were run here; the test boxes stay yours.

Rebased onto `main` @ 7bacf84 (your branch had moved to 4ab26f1 while I worked, so this is on top of that): no conflicts. No tests were run here; the test boxes stay yours.
NitnekLeBorgne changed title from WIP: fix(linux): follow deep slave graphs for the slow-disk warning to fix(linux): follow deep slave graphs for the slow-disk warning 2026-11-15 19:10:42 +00:00
HumanBean left a comment

Code-only review (nothing run). The change reads correct to me.

  • The iterative postorder walk keeps the old semantics: any known-rotational slave gives True, known answers beat unknown ones, and when no slave answers it falls back to the node's own queue/rotational, then walks up to the parent for partitions. The only change is that the depth-4 cap is gone.
  • Cycles terminate through active, and shared slaves are cached in answers. A back edge reads as unknown. The description says plainly that this is a termination guard and not a fixed-point classifier, which is fine for a warning-only check.
  • The new test module declares RUN_ALL_SKIP and has the Windows guard, and it covers deep HDD, deep SSD, mixed, partition, cycle, DAG and 1100-layer cases.

Why this is a comment and not an approval:

  1. "Must be tested" names a read-only Linux check on a real deep device-mapper setup, and nobody has posted that run yet. It stays a comment until that run is posted (a result on a real LVM/RAID/LUKS stack).
  2. The description contradicts itself. It still says "This PR remains WIP" and that the current-main and full-runner boxes are unchecked, but the Measurements section and the checked boxes say the opposite. Please remove the stale "Readiness provenance" paragraph and the Testing line about WIP so pr ready reads cleanly.

Small, non-blocking: test_shared_slaves_are_visited_once_in_a_dag compares listdir calls against str(leaf / "slaves"). The code calls it with the realpath, so on a host where the temp dir is itself a symlink (macOS /tmp, for example) the count would be 0 and the test would fail. Resolving the root once with .resolve() in setUp avoids that.

Code-only review (nothing run). The change reads correct to me. - The iterative postorder walk keeps the old semantics: any known-rotational slave gives True, known answers beat unknown ones, and when no slave answers it falls back to the node's own `queue/rotational`, then walks up to the parent for partitions. The only change is that the depth-4 cap is gone. - Cycles terminate through `active`, and shared slaves are cached in `answers`. A back edge reads as unknown. The description says plainly that this is a termination guard and not a fixed-point classifier, which is fine for a warning-only check. - The new test module declares `RUN_ALL_SKIP` and has the Windows guard, and it covers deep HDD, deep SSD, mixed, partition, cycle, DAG and 1100-layer cases. Why this is a comment and not an approval: 1. "Must be tested" names a read-only Linux check on a real deep device-mapper setup, and nobody has posted that run yet. It stays a comment until that run is posted (a result on a real LVM/RAID/LUKS stack). 2. The description contradicts itself. It still says "This PR remains WIP" and that the current-main and full-runner boxes are unchecked, but the Measurements section and the checked boxes say the opposite. Please remove the stale "Readiness provenance" paragraph and the Testing line about WIP so `pr ready` reads cleanly. Small, non-blocking: `test_shared_slaves_are_visited_once_in_a_dag` compares `listdir` calls against `str(leaf / "slaves")`. The code calls it with the realpath, so on a host where the temp dir is itself a symlink (macOS `/tmp`, for example) the count would be 0 and the test would fail. Resolving the root once with `.resolve()` in `setUp` avoids that.
test(linux): canonicalize the rotational fixture root
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 6s
7b39fabd7d
Resolve the owned temporary root before building the synthetic slave
graph, keeping the single-visit assertions stable under an aliased TMPDIR.
No production change.

Assisted-by: Hermes Agent (OpenAI GPT-6.1-sol)
Co-Authored-By: Claudia (OpenAI GPT-6.1-sol)
HumanBean left a comment

Re-review, code only (nothing run). The new head 7b39fabd7d differs from my earlier review's 2ba185eaa4 by one line: self.root = Path(tmp.name).resolve() in the test's setUp. That is the .resolve() I suggested, so the DAG visit-count test no longer depends on whether the temp dir is a symlink. No production change.

The description no longer contradicts itself: the "remains WIP" text is gone and the Readiness section says non-WIP.

Still a comment, not an approval: the change's own "Must be tested" names a read-only check on a real deep LVM/RAID/LUKS stack, and nobody has posted that run. Once it is posted in the comments, this reads as mergeable as it is.

Re-review, code only (nothing run). The new head 7b39fabd7dad differs from my earlier review's 2ba185eaa413 by one line: `self.root = Path(tmp.name).resolve()` in the test's `setUp`. That is the `.resolve()` I suggested, so the DAG visit-count test no longer depends on whether the temp dir is a symlink. No production change. The description no longer contradicts itself: the "remains WIP" text is gone and the Readiness section says non-WIP. Still a comment, not an approval: the change's own "Must be tested" names a read-only check on a real deep LVM/RAID/LUKS stack, and nobody has posted that run. Once it is posted in the comments, this reads as mergeable as it is.
Member

Code-only review of 7b39fabd7d; informational findings, with final approval left to another reviewer.

No new correctness finding after reading the complete diff, disk-classification callers and both disk test modules. The new tests exercise actual temporary device graphs rather than matching source text; restoring the old depth limit would invalidate the deep-HDD/SSD expectations. The production change only reads the storage graph and does not alter disks or mount state. No overlapping open change was identified.

The outstanding evidence remains the real deep-storage check already recorded in HumanBean’s latest review: compare this classifier with independently known physical leaves on an existing Linux LVM/RAID/LUKS stack. The reported synthetic tests and baseline-qualified runner results do not substitute for that receipt. No unrelated game or GPU run is needed for this warning helper.

No tests, builds or PR code were run in this review.

Code-only review of 7b39fabd7dada970890807c27992c488b53a553b; informational findings, with final approval left to another reviewer. No new correctness finding after reading the complete diff, disk-classification callers and both disk test modules. The new tests exercise actual temporary device graphs rather than matching source text; restoring the old depth limit would invalidate the deep-HDD/SSD expectations. The production change only reads the storage graph and does not alter disks or mount state. No overlapping open change was identified. The outstanding evidence remains the real deep-storage check already recorded in [HumanBean’s latest review](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/655#issuecomment-31495): compare this classifier with independently known physical leaves on an existing Linux LVM/RAID/LUKS stack. The reported synthetic tests and baseline-qualified runner results do not substitute for that receipt. No unrelated game or GPU run is needed for this warning helper. No tests, builds or PR code were run in this review.
TrashPanda left a comment

The slow-disk warning now follows a slave graph of any depth. I read head 7b39fabd. The walk is right, and this is a comment, not an approval.

_device_rotational used to stop after four slave layers and read that node's queue/rotational, which is 0 on a device-mapper node. It now walks every slave, still without recursion. A known spinning slave wins. Known answers beat unknowns. When no slave answers, it reads the node's own queue and then the parent, as a partition does. A cycle stops, and a shared slave is read once. The build still only warns.

The new checks call that function on temporary graphs, including a hard drive under five virtual nodes and a chain past Python's recursion limit. nx2/disk.py is unchanged on main 6d72ca93 since this branch's base, so the merge is that function and the new test.

The description's own check is still open: a read-only comparison on a real deep LVM, RAID or LUKS stack, against disks someone already knows. The synthetic graphs do not stand in for that.

The slow-disk warning now follows a slave graph of any depth. I read head `7b39fabd`. The walk is right, and this is a comment, not an approval. `_device_rotational` used to stop after four slave layers and read that node's `queue/rotational`, which is 0 on a device-mapper node. It now walks every slave, still without recursion. A known spinning slave wins. Known answers beat unknowns. When no slave answers, it reads the node's own queue and then the parent, as a partition does. A cycle stops, and a shared slave is read once. The build still only warns. The new checks call that function on temporary graphs, including a hard drive under five virtual nodes and a chain past Python's recursion limit. `nx2/disk.py` is unchanged on main `6d72ca93` since this branch's base, so the merge is that function and the new test. The description's own check is still open: a read-only comparison on a real deep LVM, RAID or LUKS stack, against disks someone already knows. The synthetic graphs do not stand in for that.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: not ticked: Testing's Tested names only the Linux game-free runner, and the change touches nx2/disk.py with no game run. Run it yourself on your PC (in the game, for a change the game runs) and say where and what you saw in Testing's Tested; or, when the fix's own case can't be run by hand, add a **Not testable by hand:** line saying why and what stands in for it. Then tick it.
  • Nothing gets worse that I know of: not ticked: Risks says state grows with the graph visited, and no memory or time for that growth was measured. Measure that cost and state it in Risks, then tick it.

It goes back to WIP until Tested on my own PC can be ticked; pr ready it again then.

Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: not ticked: Testing's Tested names only the Linux game-free runner, and the change touches nx2/disk.py with no game run. Run it yourself on your PC (in the game, for a change the game runs) and say where and what you saw in Testing's *Tested*; or, when the fix's own case can't be run by hand, add a `**Not testable by hand:**` line saying why and what stands in for it. Then tick it. - *Nothing gets worse that I know of*: not ticked: Risks says state grows with the graph visited, and no memory or time for that growth was measured. Measure that cost and state it in Risks, then tick it. It goes back to WIP until *Tested on my own PC* can be ticked; `pr ready` it again then.
HumanBean changed title from fix(linux): follow deep slave graphs for the slow-disk warning to WIP: fix(linux): follow deep slave graphs for the slow-disk warning 2026-11-17 20:29:34 +00:00
HumanBean changed title from WIP: fix(linux): follow deep slave graphs for the slow-disk warning to fix(linux): follow deep slave graphs for the slow-disk warning 2026-11-18 20:46:35 +00:00
HumanBean deleted branch fix/linux-deep-slaves-warning-20261115 2026-11-18 20:46:44 +00:00
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 6s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!655
No description provided.