docs(website): add a theme-aware trails hero #634
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/upscaling
beanstalk: approved @ 1697603
beanstalk: approved @ 2c5a62e
beanstalk: approved @ 4fd82b7
beanstalk: approved @ 64d6d09
beanstalk: approved @ 6f91fae
beanstalk: approved @ 70a78f9
beanstalk: approved @ 8015c9a
beanstalk: approved @ 8d361dc
beanstalk: approved @ 9d8356e
beanstalk: approved @ abf2227
beanstalk: approved @ d82f202
beanstalk: approved @ e5f1e40
beanstalk: approved @ ee8ab5f
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
testing wanted
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!634
Loading…
Reference in a new issue
No description provided.
Delete branch "bibiburl/Longshot:docs/trails-hero"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Superseded by Jordan’s hero #768. Closed at the author’s request. The direct launcher download, compatibility information and “Bring your own copy” note are preserved in #611 at 60a1df54, in a panel that composes with the replacement hero. #638 has been moved directly onto main and no longer depends on this branch. Nothing has been merged or deployed by this follow-up.
Historical design and validation follow:
Type: docs · Risk: low · Tested on: Linux, Chromium, website and game-free checks · Needs: #611 approval/merge; progress-feed publication check; final reconciliation and deployment review
Why
Give the homepage the agreed Longshot hero: an oversized wordmark, the existing grappling-hook mascot, and restrained forest-green trails, with a matching light theme. The earlier bright diagonal treatment and additional hero tagline were rejected during design review. The primary Get started action should match the page's other primary buttons.
The issue tracker was searched; no separate issue specifically requests this hero. See #264 and #611 for the prerequisite guide and frontend work. This does not claim to fix download throughput or a game issue.
What changed
Replace the homepage hero presentation while keeping its product explanation, ownership disclosure, original mascot/fairy interaction, responsive artwork and existing navigation. Dark and light palettes follow the site's existing manual and automatic theme selection; reduced-motion preferences disable the small mouse-follow effect.
website/src/components/LongshotHero.astro: full-width composition, Atkinson Hyperlegible Next wordmark, scoped theme styling, shared primary-button styling and bounded pointer movement. Preserve #611's direct launcher download, compatibility guidance and live launcher status in the hero's secondary information row, and retain the live site's Contribute link. No additional Team MagicBean tagline is introduced into the hero; existing header/footer credits remain.website/src/assets/hero/: two original decorative SVG backgrounds, their provenance and license. No new package, external font service, game imagery or raster generator is needed.website/README.md: describe the new theme and motion behavior.Stack: this branch starts at #611 head
02f0299c73ab94314066b9a3ff0df8a3d504bca1, which already contains #264 heada0a93f11fe1edd80626de3538d8b638378e5ed6d. The new work is only hero commit a826af4c; the upstream comparison temporarily includes the prerequisites' commits until they land. Their pending review fixes must be incorporated before this PR becomes ready. No files in either existing PR are changed by opening this branch.Measurements
Verdict: website presentation change, with no gameplay or performance claim. Website tests and rendered browser checks are the validation; no runtime benchmark applies.
02f0299ca826af4cHardware: Linux; no GPU, driver, CPU or RAM benchmark is claimed.
Scene: homepage at 320–1920px, dark/light themes; website build and unit suite.
Method: deterministic page/test counts from build and test output, one final run each; these are validation results, not timing samples or medians. The baseline counts are the earlier #611 evidence.
How to reproduce: Node 26.13.1, unchanged pinned lockfile; in
website/, runnpm ci,npm run build, andnode --test tests/*.test.ts. For browser checks runnpx wrangler dev --localand open the homepage at the widths/themes above. The full publication check is blocked as described under Testing.Baseline: #611 at
02f0299c, because this hero is deliberately stacked after it, rather than compared against a main branch without the prerequisite frontend and guide changes. Before: #611 @02f0299c; After: this PR @a826af4c. Screenshot captions use these revisions.Flags and settings
None in the hero delta. No runtime flags, menu settings, build flags or website theme-preference semantics change. The full stacked diff also contains #264’s unchanged capture-helper settings:
HOS_DISPLAY_MODES=1280x720, a temporaryLONGSHOT_LAUNCHER_HOME,LONGSHOT_LAUNCHER_OFFLINE=1andLONGSHOT_LAUNCHER_REDUCED_MOTION=1. Their scope and provenance remain in #264; no capture helper was run here.Testing
Tested: Linux, Node 26.13.1, pinned npm lockfile, Chromium 153 through
agent-browser-linux-x64, and the local Wrangler Worker at127.0.0.1:4331.npm run build: 16 pages built successfully on the final hero source.node --test tests/*.test.ts: 92/92 pass.npm run checkis blocked:Progress issue:615: game branding remains in public copy. The live feed now collects successfully, but the unchanged publication guard rejects wording in that report. No guard was bypassed and the feed collector/normalizer is untouched by this hero delta. Resolve the feed wording through the normal source/curation policy and rerun the full check before publication.Preview launcher: v1.0.0-rc.4at capture time. Get started, Contribute, Discord, direct Download launcher and compatibility links remain present.python -I -B tests/run_all.py --jobs 4: 500 passed, 13 failed, 69 skipped in 100s. The failure set matches the unchanged-main6c9edffecomparison already recorded in #611 (498 passed, the same 13 failed, 69 skipped):test_appimage_player_build.py,test_bake_portability.py,test_cpm_discovery.py,test_crash_dialog.py,test_env_on.py,test_lift_cleanup_error.py,test_linux_preflight.py,test_make_game_cache.py,test_pipeline_tour.py,test_readback_late.py,test_vk_pgo.py,test_vram_budget_row.py,test_walk_key.py. The main result is earlier baseline evidence, not a new main run in this hero task. No runtime/test source is changed by the hero delta.git diff --checkpasses. The delta from #611 is limited to the hero component, website README and three new hero-art source/provenance files. #264's guide images/provenance and all existing branding/font source files are unchanged.Not tested: Firefox, Safari, real mobile devices or a screen reader; no gameplay, runtime build, save transfer, hosted preview or production deployment was performed. Chromium viewport emulation is not a real-device test.
Must be tested:
npm ci,npm run buildandnpm run checkinwebsite/, resolving the #615 live-feed wording blocker through the existing publication policy first. By hand in the resulting Worker preview, check the homepage in both themes at desktop/mobile widths, keyboard focus and the three-activation fairy interaction, and confirm launcher metadata/download links remain functional. Expect no page overflow and no lost prerequisite content. Only then request this PR's review and deployment approval.Risks
What could break: full-width artwork, wrapping links and shared theme styles may differ in browsers not tested here. Future changes to #264/#611 may require conflict resolution and new screenshots. The existing automated
maindeployment makes premature merge inappropriate.Turning it off: revert the hero commit; leave the prerequisite guide and frontend commits intact.
Compatibility: no change to saves, options, shader/pipeline caches, Vulkan ABI or builder tools. Only the website homepage presentation and its documentation change relative to #611.
Checklist
Everyone
type(scope): description) of the status line's type.main: reconcile the merged #264 result and remaining stack, resolve the documented conflicts and rerun validation before merge.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named in Testing).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.Visual evidence for hero commit
a826af4c. These screenshots are from actual built Astro pages, not the earlier standalone design study. Linux Chromium 153, desktop 1440×1000 and mobile 390×1100; full-page captures are included for sharing. The site’s random bean caption and live launcher/activity metadata may differ between captures.Approval/deployment hold: #264 first, #611 second, then #634. Both native dependencies and the
status/blockedlabel are present. No hosted preview or production deployment has been requested. The publication check remains blocked by public wording in live progress issue #615; the guard is unchanged.Before: #611 @
02f0299cAfter: this PR @
a826af4cFull-page PNGs: dark · light.
Document width matches the viewport at 320, 390, 768, 1024, 1440 and 1920px in both themes. The manual theme picker and Auto respond correctly; three Enter presses unlock the fairy and announce it. Reduced motion disables image transition and pointer offsets. Hero-scoped axe reports zero violations in each theme, with one incomplete contrast category for decorated/overlapping elements; this is not full accessibility certification. The separate website suite passes 92/92, and production generation builds 16 pages; the full publication check is still blocked as described above.
Attached eight before/after and full-page screenshots from the built site, added native dependencies on #264 and #611 plus status/blocked, and clarified validation and the ordered approval/deployment hold. This remains WIP; the live-feed publication check is blocked by issue #615 wording. No deployment was requested.
WIP: docs(website): add a theme-aware trails heroto docs(website): add a theme-aware trails heroMarked ready for review at the author’s explicit request (#611 was already non-WIP). #264 is merged; the remaining approval/merge order stays #611 → #634 → #638. The description records the current merge conflicts and outstanding validation; unchecked work remains unchecked. Dependencies and blocked labels are preserved. No code, approval, merge or deployment was performed.
Thanks for this. Jordan's hero design is now in #768, and you've agreed to go with it, so this hero won't merge as it is. Two things from it are worth keeping, on top of #768 or #611:
#638 is built on this branch, so it will need moving onto main (or #611) once this one is closed.
Review drafted with Claude Code and checked by Jordan.
Closing this in favor of Jordan’s #768, as agreed. Download launcher, compatibility guidance and the bring-your-own-copy note are preserved in #611 at
60a1df54. #638 is now based directly on main; its obsolete dependencies on this PR and #611 have been removed. A local combination of #611, #638, #709 and #768 merges cleanly and builds. No merge or deployment was performed.Pull request closed