fix: honor WIP titles in local PR description checks #600
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!600
Loading…
Reference in a new issue
No description provided.
Delete branch "NitnekLeBorgne/Longshot-contributions:fix/pr-description-local-wip-20261114"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux/Python 3.14.9, game-free (no GPU) · Needs: none for this contributor-tool fix
Why
Local
--file --titlechecks reject unfinished descriptions even withWIP:/[WIP], unlike the documented policy and API path. Honor those prefixes locally without weakening ready-review validation.How to reproduce
Seen on: historical Linux/Python 3.14.9; no GPU/game.
Settings and switches: existing
--file/--title, without explicit--wip.Steps: on original main
82886e89b970daf89a07535eaec083c6018e32ae, use an incompletebody.md:python -I -B scripts/check_pr_description.py --file body.md --title 'WIP: fix: synthetic example'.Expected: exit 0 with a WIP notice and informational diagnostics.
Actual: original baseline exits 1 with blocking
::error::annotations. This is retained reproduction, not a fresh run on later main.What changed
Use the existing draft-title helper for local files. Preserve pure review, Markdown parsing, API behavior and ready-review policy.
scripts/check_pr_description.py,main():is_draft(title, a.wip)replacesa.wiponly in file mode.tests/test_check_pr_description.py,Running: four supported prefixes, five non-WIP boundaries and a pure-review control; existing assertions unchanged.Measurements
No game-performance measurement applies: this is a Python contributor-tool fix with focused RED/GREEN evidence and baseline-aware full game-free runner evidence below, not a rendering or gameplay change.
Historical focused regression evidence
Original baseline
82886e89b970daf89a07535eaec083c6018e32ae; original contribution/attribution commit3f3bbb2f30436f84e841e7e7af25822acf3b16e9, not the rebased published head. Linux/Python 3.14.9, synthetic Markdown:--wip/--draftstill pass. Ordinary/interior-WIP/WIPE:/missing/empty titles and purereview()/problems()remain blocking.Commands retained:
python -I -B tests/test_check_pr_description.py Running.test_file_mode_uses_wip_title -v,python -I -B tests/test_check_pr_description.py -v,python -I -B tests/run_all.py --jobs 1 --timeout 60 --strict check_pr_description.Private preparation used an empty
nx2/for enumeration. An initial privateDEVNULLguard failure was preserved, corrected and requalified; neither it nor fixture preparation was a product RED or public-source edit. No system-wide network-isolation claim.Flags and settings
None. No new option or default; existing
--wip/--draftremain.Testing
Tested: Linux/Python 3.14.9, no GPU/game: the normal default full runner
python -I -B tests/run_all.py --jobs 3completed on published heade1d4da06904b9bccb134ece1bf59e5d156d268aeon 15 November 2026 at 23:29:21 UTC (254.880863 seconds, actual exit 1). Compared with the retained parent/main runbbe6fdf23170310117c714958248e60ec0686a62(216.627278 seconds, actual exit 1). Each has 507 passed, 14 failed, 85 skipped; 606 unique check IDs. All IDs, statuses and skip reasons match; all 14 failure logs have equal signatures after normalizing only source/home/temp paths, unittest elapsed times and object addresses. No added failure, lost pass or skipped-check change. The changedtests/test_check_pr_description.pypasses. The 521 progress lines and 606 final-table rows are two reports of the same checks, not 1,127 executions. Historical focused RED/GREEN proof is retained above.All 14 failures also present on that pinned main baseline, named individually:
tests/test_appimage_player_build.pytests/test_bake_portability.pytests/test_crash_dialog.pytests/test_env_on.pytests/test_lift_cleanup_error.pytests/test_make_game_cache.pytests/test_missing_nup.pytests/test_mods_size_table.pytests/test_options_budget_once.pytests/test_pipeline_tour.pytests/test_readback_late.pytests/test_vk_occlusion_queries.pytests/test_vk_pgo.pytests/test_walk_key.pyAll 85 skipped checks and their actual runner reasons (identical on both pins)
nx2/test_bc_storage_views.py: needs a Windows Vulkan devicenx2/test_coop_spirv.py: not found here: spirv_headers, spirv_valnx2/test_default_point_size.py: not found here: spirv_headers, spirv_valnx2/test_depth_sample_types.py: not found here: spirv_headers, spirv_valnx2/test_dll.py: needs a full game build (work/build/longshot_game.dll) and Unicornnx2/test_draw_parameters.py: not found here: spirv_headers, spirv_valnx2/test_insn.py: needs the game's modules (work/dump) and Unicornnx2/test_leaf.py: needs the game's modules (work/dump) and Unicornnx2/test_mesh_first_types.py: not found here: spirv_headersnx2/test_nup_codec.py: not found here: zstandardnx2/test_nup_read_name.py: not found here: zstandardnx2/test_nup_stand_in.py: not found here: zstandardnx2/test_nup_verify.py: not found here: zstandardnx2/test_spirv_struct_identity.py: not found here: spirv_headers, spirv_valnx2/test_texture_init_barrier.py: not found here: vulkan_headersnx2/test_texture_phi_dominance.py: not found here: spirv_headers, spirv_valnx2/test_unsigned_image_types.py: not found here: spirv_headers, spirv_valtests/test_antilag.py: not found here: vulkan_headerstests/test_bake_mimo.py: not found here: spirv_headerstests/test_capture_dimensions.py: not found here: vulkan_headerstests/test_capture_readback_visibility.py: not found here: vulkan_headerstests/test_capture_resources.py: not found here: vulkan_headerstests/test_dav1d_av1.py: not found here: dav1dtests/test_draw_stream_visibility.py: not found here: vulkan_headerstests/test_dummy_views.py: not found here: vulkan_headerstests/test_dump_readback.py: not found here: vulkan_headerstests/test_exclusive_marks.py: not found here: clangtests/test_fallback_pipeline_state.py: not found here: vulkan_headerstests/test_framegen_resources.py: not found here: vulkan_headerstests/test_framelog_sink.py: not found here: vulkan_headerstests/test_fs_path_utf8.py: native Windows filesystem conversion APIstests/test_fsr3_shaders.py: not found here: glslang, spirv_valtests/test_fsr4_tune.py: not found here: spirv_valtests/test_fsr_image_retirement.py: not found here: vulkan_headerstests/test_fsr_uniform_ownership.py: not found here: vulkan_headerstests/test_host_shaders.py: not found here: glslangtests/test_image_view_retry.py: not found here: vulkan_headerstests/test_import_buffer_binding.py: not found here: vulkan_headerstests/test_inline_write_order.py: not found here: vulkan_headerstests/test_linux_preflight.py: not found here: clangtests/test_log_batch.py: the Windows log writer: SRW locks and threadstests/test_low_vram_texture_mips.py: not found here: vulkan_headerstests/test_lower_depbar.py: not found here: clang++tests/test_lower_lds_after_sts.py: not found here: clang++tests/test_lower_register_markers.py: not found here: clang++tests/test_mesh_unreachable_outputs.py: not found here: spirv_headers, spirv_valtests/test_native_float_atomic_add.py: not found here: spirv_headers, spirv_valtests/test_native_suatom.py: not found here: clang++tests/test_native_zstd.py: not found here: zstandardtests/test_nvn_null_pool.py: not found here: clangtests/test_nvn_tex_builder_guard.py: not found here: clangtests/test_parallel_init_order.py: not found here: vulkan_headerstests/test_pcache_header_read.py: not found here: vulkan_headerstests/test_pipeline_state_portable.py: not found here: vulkan_headerstests/test_pipeline_states.py: not found here: vulkan_headerstests/test_portable_builder_home.py: Windows portable Builder home and Windows path semantics; native .NET fixture on Windowstests/test_portable_builder_startup.py: Windows Builder startup (a win-x64 self-contained program)tests/test_portable_setup_paths.py: Windows native setup MAX_PATH contracttests/test_portable_setup_start.py: Windows setup startup contracttests/test_portable_setup_transaction.py: Windows setup directory transactionstests/test_precompile_compute_guard.py: Windows structured exceptionstests/test_present_aspect_vulkan.py: needs a Vulkan 1.3 device for offscreen transfer/readbacktests/test_present_source_crop.py: not found here: vulkan_headerstests/test_program_answer_domains.py: not found here: vulkan_headers, clang++tests/test_prompt_speed.py: not found here: zstandardtests/test_recorder_own_idle.py: not found here: vulkan_headerstests/test_recorder_sync.py: not found here: vulkan_headerstests/test_recording_admission.py: not found here: vulkan_headerstests/test_sampler_admission.py: not found here: vulkan_headerstests/test_setup_runtime.py: Windows setup uses Win32 file APIstests/test_setup_runtime_paths.py: Windows setup entry pathstests/test_shader_module_guard.py: Windows structured exceptionstests/test_split_giants.py: not found here: clangtests/test_system_header_cache.py: not found here: clangtests/test_taau_typed_dispatch.py: not found here: vulkan_headerstests/test_texel_buffer_ownership.py: not found here: vulkan_headerstests/test_texture_staging_publication.py: not found here: vulkan_headerstests/test_ui_record.py: not found here: vulkan_headerstests/test_ui_texture_upload.py: not found here: vulkan_headerstests/test_vendor_fixes.py: not found here: vulkan_headerstests/test_vendor_translation.py: not found here: spirv_headers, spirv_valtests/test_vulkan_clear_mip.py: not found here: vulkan_headerstests/test_vulkan_copy_span.py: not found here: vulkan_headerstests/test_vulkan_copy_span_gpu_compile.py: not found here: vulkan_headerstests/test_wb_diff_observations_gpu.py: not found here: vulkan_headersThe source-only candidate export contains 2,477 materialized tracked files: before/after SHA-256 inventories and a fresh byte/size/Git-blob check agree. Current file modes match Git. Historical snapshots did not record modes separately, so this does not assert historical mode monitoring. The raw commit header proves the parent despite the shallow checkout's empty
%P. The original process group is empty on a fresh/proccheck. No campaign-wide memory-monitor receipt exists for this candidate; no minimum-RAM claim is inferred from the later preflight.AGENTS.mdwas deliberately not materialized. On 16 November 2026, a separate bounded supplement ran exactly the two unchanged upstreamSwitchesRemovedmethods, adding the pinned public instruction blob only as read-only in-memory data: 2 tests passed, exit 0. The method bodies and all product sources are unchanged; the iterator adds the omitted blob, Git blob1f67a3ecd769dfb499d3a8f4b04a013e9fc130db, SHA-2566f69bfb19314250978f8e20e778bb8f8d01e46b072eb7a7cd8a58361c4f68b38. This is a supplement, not another full run or an addition to the 606 runner checks.Not tested: literal exact-tree/hosted CI equivalence (instruction file omitted from disk), actual API requests, Windows or game/GPU behavior. These are not claimed by this Linux, game-free contributor-tool qualification; no unrelated game run is required.
Must be tested: None for this contributor-tool fix. The full-runner checklist uses the template's named-baseline-failure allowance, not an all-green claim. The exact-tree and platform limitations above remain explicit.
Risks
What could break: recognized local WIP prefixes intentionally exempt incomplete bodies; boundary tests keep incidental WIP text blocking.
Turning it off: revert the commit.
Compatibility: no game, saves, options, caches, Vulkan ABI or Builder runtime changes; only redundant local
--wipbecomes unnecessary.Readiness provenance
Author evidence is complete for the pinned maintainer rebase: head
e1d4da06904b9bccb134ece1bf59e5d156d268ae, treedfb0cd98c11b7781b01aa84e50a72951e7bb6d05, actual parent/main baselinebbe6fdf23170310117c714958248e60ec0686a62. The later input-snapshot main30cedbc5203bf5c6f79fbb58394d8d5634881e8fis distinct and is not qualified by this pair. The rebase box records the maintainer rebase, not a new claim that upstream has remained stationary. Publication must recheck the current PR head and applicable rules before adopting this body and restoring ready; this document itself performs no publication, approval, merge or rebase.Rebase credit: HumanBean: "No tests were run here; the test boxes stay yours." The subsequent author full-runner receipts above now discharge that missing evidence for the pinned head, with named baseline failures and explicit source-only limitations. Prior WIP descriptions and original receipts remain preserved as historical records, not present-tense missing-test claims.
Checklist
Everyone
type(scope): description) of the status line's type.main. Pinned maintainer rebase only; actual parent and later unqualified main are distinguished under Readiness provenance.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). Normal default runner with--jobs 3: 507 passed / 14 named baseline failures / 85 identical skips on each pinned commit; two-method in-memory supplement passes separately. Source-only, not exact-tree CI; see Testing.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers. Hermes Agent / Claudia (OpenAI GPT-6.1-sol), recorded in commit3f3bbb2f30436f84e841e7e7af25822acf3b16e9.mainand passing here.tests/that reads changed source updated in this PR, not weakened.3f3bbb2f30e1d4da0690Rebased onto
main@bbe6fdf: no conflicts. No tests were run here; the test boxes stay yours.WIP: fix: honor WIP titles in local PR description checksto fix: honor WIP titles in local PR description checksRead the diff only; nothing was run.
--file --titlenow goes through the sameis_draft(title, a.wip)helper the API path uses, so aWIP:/[WIP]title is honoured locally.wip_prefixalready handles a missing or empty title, so--filewithout--titlestays blocking. Purereview()/problems()are untouched, as the description says.The three new tests cover the four prefixes, the non-WIP boundaries (
WIPE:, interior WIP, empty or missing title) and the pure review control. The full-runner comparison against main is posted in the description (same 14 failures as main).Small, low-risk, game-free. Approving.