fix(vk): a timed-out read-back's source images are kept until the GPU is past the copy #554

Merged
HumanBean merged 3 commits from zeldaootr/Longshot:readback-timeout-keeps-source-textures into main 2026-11-15 19:20:08 +00:00
Contributor

Type: fix · Risk: low · Tested on: Linux x86-64 (game-free); Steam Deck OLED, SteamOS 3.9.5, RADV (a tester's run) · Needs: none

Why

When a texture read-back timed out (the GPU stuck for 5 s), the textures it copied from were freed, or handed to a new render target, while the copy could still run on the GPU: a read from freed memory, which can corrupt a picture or crash the driver. The tracker has no issue for it (searched).

How to reproduce

Seen on: the source, found by reading gpu/vk/vk_texture.cpp; a 5 s GPU stall cannot be made on demand in the game, so the game-free test reproduces it against stub Vulkan, VMA and pool calls
Settings and switches: defaults
Steps: at the test-only commit 1b907d6b (main aa95d35f plus the test), run python3 -I -B tests/test_readback_timeout_source.py --cxx g++
Expected: the image a timed-out read-back copies from outlives the copy, then goes
Actual: on main the source image is destroyed (a texture) or pooled (a render target) at completed 10, before the GPU is past the copy, while its staging buffer waits for 11

What changed

After a timed-out read-back, the textures it copies from now live until the GPU is past that copy, the same rule its staging buffers already followed. Nothing changes when no read-back times out.

  • vk: flush_textures() in gpu/vk/vk_texture.cpp, on a timed-out read-back, raises each source texture's last_value to the submission after it (rec_value + 1), so the eviction's destroy_later keeps the image until the GPU is past the copy.
  • tests: tests/test_readback_timeout_source.py cuts the read-back state and functions, Dead, Flush, flush_textures, destroy_later and texture_frame's loop over the dead list out of the source and runs them against stub Vulkan, VMA and pool calls: the image must outlive the copy, then go.

Measurements

Verdict: pass. The fix is proven by the game-free test (2 of 2 cases fail on main, 0 with this PR). In the game it is a non-regression result: on a tester's Steam Deck OLED the timed-out read-back never happened (no did not complete in time line in 4 runs), and fps, faults and texture evictions were the same as main within main's own run-to-run spread.

Hardware: Steam Deck OLED, AMD Custom APU 0932 (RADV VANGOGH), 16 GB, Mesa 26.2.0-devel git-5c65d4fc31, SteamOS 3.9.5 (build 20261023.100), kernel 7.2.7-valve2, Game Mode, docked, stock clocks (dukenheimer's run, test request T-GQD8, the same runs as T-4H95 for #553); game-free: Linux x86-64 server, no GPU or game
Scene: a route through the control bridge: Continue into Kokiri Forest, then 10 debug teleports with about 45 s in each area (Hyrule Field, Kakariko, the Market, Hyrule Field, the Lost Woods, Goron City, Death Mountain Trail, Zora's River, Gerudo Valley, Kokiri Forest), about 11 minutes a run; the Minimum (4GB) preset (render 50% of 1280x720, a 2.2 GB VRAM budget, Handheld profile), the game's own upscaler, frame generation off
Method: fps from the bridge's status every 5 s, averaged over the time in play; the log lines from each run's longshot_log.txt; the kernel's amdgpu lines (journalctl -k, each start to its end); one picture at each arrival. Four runs, interleaved (this PR, main, main, this PR), one test folder with warm caches and the binaries swapped; the median of each build's two runs. Game-free: python3 -I -B tests/test_readback_timeout_source.py --cxx g++ at 1b907d6b and at 9287f171 (rebased onto main aa95d35f), with g++ 13.3 and with clang 23.1.5; before that, at 4cf946a1 and fa5b6da6 on main 53f96d78, and before the first rebase at f5bfead9 and a235b180, twice each, alternating
How to reproduce: build main 7ff5256e and the combined build (main 7ff5256e with #550 to #558 merged in order), both x86-64-v3 with the release play profile and LLVM 23.1.5; choose the Minimum (4GB) preset, then drive the route above; for the game-free check, run the test command at each commit

Before: main @ 7ff5256e After: this PR @ 6c76d0eb (in the combined build)
fps over the route (run 1 / run 2; median) 16.6 / 17.7; 17.15 16.8 / 17.1; 16.95
did not complete in time lines 0 / 0 0 / 0
device lost / device fault / GPU stalled / crash 0 / 0 / 0 / 0 in both runs 0 / 0 / 0 / 0 in both runs
kernel amdgpu lines (of them reset / timeout / hang / fault) 6 / 6 (0) 12 / 6 (0)
evicted, made again lines 17 / 14 17 / 14

The Deck ran this PR at 6c76d0eb. Its fix is now 9287f171 (fa5b6da6 on main 53f96d78, and a235b180 before that, the same change by git patch-id), whose code is that of 6c76d0eb: it differs only in tests/test_readback_timeout_source.py (5 lines that check the fixture's precondition), and that test passes with LLVM 23.1.5. By area, the two builds' means are within 2 fps everywhere, in both directions (Goron City +1.9, Gerudo Valley -1.6); main's own two runs differ by more than the builds do. The kernel's amdgpu lines were only the display's [drm] Losing delta precision while programming shaper LUT notices. The textures were under pressure in every run: 2.7 to 2.8 GB against a 2,560 MB texture budget, VRAM in use peaking at 4.5 to 5.1 GB of the 5.3 to 6.1 GB allowed, about 4.3 GB swapped, MemAvailable down to 281-471 MB. The tester's report: #554 (comment)

Before: main @ aa95d35f (with the test, 1b907d6b) After: this PR @ 9287f171
source image freed or pooled before the GPU is past the copy, of 2 cases (g++ and clang the same) 2 (texture, render target) 0
1b907d6b: FAIL: the image a timed-out read-back copies from was destroyed at completed 10, before the GPU is past the copy (its staging buffer waits for 11) / timed-out read-back's source image: failed: texture, target (exit 1, g++ and clang)
9287f171: timed-out read-back's source image (texture): ok / (render target): ok (exit 0, g++ and clang)

Flags and settings

None.

Testing

Tested: Linux x86-64, game-free. The new test fails on the test-only commit 1b907d6b and passes at 9287f171, this branch rebased onto main aa95d35f, with g++ 13.3 and with clang 23.1.5 (before, it did the same at 4cf946a1 and fa5b6da6 on main 53f96d78, and at f5bfead9 and a235b180, twice each, alternating) (python3 -I -B tests/test_readback_timeout_source.py --cxx g++); it also builds and passes with clang 23.1.5 under its own -Wall -Wextra -Werror at both commits. This PR's own tests and the checks its fix commit edits ran at both commits, and once more on land/integration 27553c83 (main 7ff5256e with this PR and twelve other fixes merged), where the thirteen fixes' tests and edited checks pass, 16 of 16; the full python3 -I -B tests/run_all.py ran on that branch too (see the checklist).

In the game: dukenheimer ran test request T-GQD8 on a Steam Deck OLED (RADV VANGOGH, Mesa 26.2.0-devel, SteamOS 3.9.5, Game Mode, docked) and reported a pass on 2026-11-15 at 03:12 UTC (#554 (comment)). These are the same four runs as T-4H95 for #553: the combined build of main 7ff5256e with #550 to #558 merged in order, this PR at 6c76d0eb, against main 7ff5256e, the 11-minute route above, interleaved. No did not complete in time line in any run, so the timed-out read-back whose source images this PR keeps never happened there: it is a non-regression run, not a run of the fix. No crash, device lost, device fault or GPU stall; no GPU reset, ring timeout, hang or page fault in the kernel log; no garbled or rainbow textures in the 44 arrival pictures (the sheet is on #553). fps was the same within main's own spread.

The branch has been rebased since the tester's run, onto main aa95d35f, with its commits re-authored under the forge's noreply address; each commit's change is identical to before by git patch-id, so the commits named above are the ones tested and the result stands for this head (68606017).

Not tested: A real 5 s GPU stall, in the game or on any GPU: the fixed path is proven only against the stubs, since a stall that long cannot be made on demand. The head in the game (its code is that of the 6c76d0eb the Deck ran). Windows in the game (the renderer was built for Windows, see the checklist).

Must be tested: None

Risks

What could break: This is a separate defect on main from the read-back reuse one (#553), and touches the lines next to that fix in flush_textures (the timed-out branch): the two merge without a conflict (git's automatic merge of gpu/vk/vk_texture.cpp), and on land/integration they compose, with both tests passing there (a texture kept for a later pass is not evicted at all). After a timeout, the source images now live one submission longer.

Turning it off: revert the commit

Compatibility: Nothing changes

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. Onto main 94abdd57 (head 77a84d96) with no conflict, with the commit subjects made Conventional Commits, which CI's lint job now checks for every commit, on a base that has CI's config (#417); each commit's change is the same as before by git patch-id. The commits named in this description are from before this rebase: 1b907d6b is now 6a5dfdf7, 9287f171 is now ead1b345, 68606017 is now 77a84d96. Re-run on 94abdd57: test_readback_timeout_source fails at the test-only commit 6a5dfdf7 and passes at the head, with g++ 13.3 and clang 23.1.5; of the 37 checks that are this PR's or read its files (g++ 13.3), 35 pass and the 2 that fail fail on main 94abdd57 too (test_bc_storage_views, test_texture_init_barrier).
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). Run on this branch at 0dfefc41 on main 53f96d78, before this rebase (68606017 now, the same patches by git patch-id; the Vulkan and SPIR-V headers from the CPM cache, 8 at once, on a loaded Linux x86-64 server): 530 passed, 16 failed, 48 skipped. 15 of them fail on main 53f96d78 in the same run: test_appimage_player_build, test_bake_portability, test_cpm_discovery, test_crash_dialog, test_env_on, test_lift_cache, test_lift_cleanup_error, test_make_game_cache, test_pipeline_tour, test_readback_late, test_vk_pgo, test_vram_budget_row, test_walk_key, nx2/test_mesh_first_types.py and nx2/test_texture_init_barrier.py. The 16th, test_pipeline_cache_save (a timing check: wait_until(play_saves, 3)), passed 2 of 2 when run alone on this branch, as on main; main's run timed out test_fpx_sticky instead, which passed here and passes alone on main. After the rebase onto main aa95d35f, at 68606017: 35 checks, this PR's test and those that read its changed files, with g++ 13.3 and with clang 23.1.5: 33 pass; the 2 that fail fail on main aa95d35f too (run alone there, both compilers): nx2/test_bc_storage_views.py (no clang++ on this PC's path), nx2/test_texture_init_barrier.py (#628).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. The tester's four Steam Deck runs (this PR, main, main, this PR); the game-free test twice each, alternating.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md). docs/tested/2026-11-15-readback-timeout-dukenheimer-t-4h95.md, the tester's run; scripts/tested_configurations.py and tests/test_tested_configurations.py pass with it. The same file, byte for byte, is in #553: the two branches merge into main together without a conflict.
  • A game-free test added for the fix, failing on main and passing here.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. Built on Linux for both, in the combined branch 27553c83: RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows with llvm-mingw 20261104 linked longshot_vk.dll (sha256 25117493...), and the same without RX_TARGET linked longshot_vk.so; the changed file has no new warning under -Wall -Wextra on either platform against main. The tester's combined build linked for Linux (x86-64-v3, LLVM 23.1.5). After the rebase onto main aa95d35f, gpu/vk/vk_texture.cpp at 68606017 checked whole (-fsyntax-only -Wall -Wextra, clang 23.1.5 for Linux and llvm-mingw 20261104 for Windows): the same warnings as main aa95d35f's, none new.
**Type:** fix · **Risk:** low · **Tested on:** Linux x86-64 (game-free); Steam Deck OLED, SteamOS 3.9.5, RADV (a tester's run) · **Needs:** none ## Why When a texture read-back timed out (the GPU stuck for 5 s), the textures it copied from were freed, or handed to a new render target, while the copy could still run on the GPU: a read from freed memory, which can corrupt a picture or crash the driver. The tracker has no issue for it (searched). ## How to reproduce **Seen on:** the source, found by reading `gpu/vk/vk_texture.cpp`; a 5 s GPU stall cannot be made on demand in the game, so the game-free test reproduces it against stub Vulkan, VMA and pool calls **Settings and switches:** defaults **Steps:** at the test-only commit 1b907d6b (main aa95d35f plus the test), run `python3 -I -B tests/test_readback_timeout_source.py --cxx g++` **Expected:** the image a timed-out read-back copies from outlives the copy, then goes **Actual:** on main the source image is destroyed (a texture) or pooled (a render target) at completed 10, before the GPU is past the copy, while its staging buffer waits for 11 ## What changed After a timed-out read-back, the textures it copies from now live until the GPU is past that copy, the same rule its staging buffers already followed. Nothing changes when no read-back times out. - vk: `flush_textures()` in `gpu/vk/vk_texture.cpp`, on a timed-out read-back, raises each source texture's `last_value` to the submission after it (`rec_value + 1`), so the eviction's `destroy_later` keeps the image until the GPU is past the copy. - tests: `tests/test_readback_timeout_source.py` cuts the read-back state and functions, `Dead`, `Flush`, `flush_textures`, `destroy_later` and `texture_frame`'s loop over the dead list out of the source and runs them against stub Vulkan, VMA and pool calls: the image must outlive the copy, then go. ## Measurements **Verdict:** pass. The fix is proven by the game-free test (2 of 2 cases fail on main, 0 with this PR). In the game it is a non-regression result: on a tester's Steam Deck OLED the timed-out read-back never happened (no `did not complete in time` line in 4 runs), and fps, faults and texture evictions were the same as main within main's own run-to-run spread. Hardware: Steam Deck OLED, AMD Custom APU 0932 (RADV VANGOGH), 16 GB, Mesa 26.2.0-devel git-5c65d4fc31, SteamOS 3.9.5 (build 20261023.100), kernel 7.2.7-valve2, Game Mode, docked, stock clocks (dukenheimer's run, test request T-GQD8, the same runs as T-4H95 for https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553); game-free: Linux x86-64 server, no GPU or game Scene: a route through the control bridge: Continue into Kokiri Forest, then 10 debug teleports with about 45 s in each area (Hyrule Field, Kakariko, the Market, Hyrule Field, the Lost Woods, Goron City, Death Mountain Trail, Zora's River, Gerudo Valley, Kokiri Forest), about 11 minutes a run; the Minimum (4GB) preset (render 50% of 1280x720, a 2.2 GB VRAM budget, Handheld profile), the game's own upscaler, frame generation off Method: fps from the bridge's status every 5 s, averaged over the time in play; the log lines from each run's `longshot_log.txt`; the kernel's amdgpu lines (`journalctl -k`, each start to its end); one picture at each arrival. Four runs, interleaved (this PR, main, main, this PR), one test folder with warm caches and the binaries swapped; the median of each build's two runs. Game-free: `python3 -I -B tests/test_readback_timeout_source.py --cxx g++` at 1b907d6b and at 9287f171 (rebased onto main aa95d35f), with g++ 13.3 and with clang 23.1.5; before that, at 4cf946a1 and fa5b6da6 on main 53f96d78, and before the first rebase at f5bfead9 and a235b180, twice each, alternating How to reproduce: build main 7ff5256e and the combined build (main 7ff5256e with https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/550 to https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/558 merged in order), both x86-64-v3 with the release play profile and LLVM 23.1.5; choose the Minimum (4GB) preset, then drive the route above; for the game-free check, run the test command at each commit | | Before: main @ 7ff5256e | After: this PR @ 6c76d0eb (in the combined build) | |---|---|---| | fps over the route (run 1 / run 2; median) | 16.6 / 17.7; 17.15 | 16.8 / 17.1; 16.95 | | `did not complete in time` lines | 0 / 0 | 0 / 0 | | device lost / device fault / GPU stalled / crash | 0 / 0 / 0 / 0 in both runs | 0 / 0 / 0 / 0 in both runs | | kernel amdgpu lines (of them reset / timeout / hang / fault) | 6 / 6 (0) | 12 / 6 (0) | | `evicted, made again` lines | 17 / 14 | 17 / 14 | The Deck ran this PR at 6c76d0eb. Its fix is now 9287f171 (fa5b6da6 on main 53f96d78, and a235b180 before that, the same change by `git patch-id`), whose code is that of 6c76d0eb: it differs only in `tests/test_readback_timeout_source.py` (5 lines that check the fixture's precondition), and that test passes with LLVM 23.1.5. By area, the two builds' means are within 2 fps everywhere, in both directions (Goron City +1.9, Gerudo Valley -1.6); main's own two runs differ by more than the builds do. The kernel's amdgpu lines were only the display's `[drm] Losing delta precision while programming shaper LUT` notices. The textures were under pressure in every run: 2.7 to 2.8 GB against a 2,560 MB texture budget, VRAM in use peaking at 4.5 to 5.1 GB of the 5.3 to 6.1 GB allowed, about 4.3 GB swapped, MemAvailable down to 281-471 MB. The tester's report: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/554#issuecomment-22331 | | Before: main @ aa95d35f (with the test, 1b907d6b) | After: this PR @ 9287f171 | |---|---|---| | source image freed or pooled before the GPU is past the copy, of 2 cases (g++ and clang the same) | 2 (texture, render target) | 0 | ``` 1b907d6b: FAIL: the image a timed-out read-back copies from was destroyed at completed 10, before the GPU is past the copy (its staging buffer waits for 11) / timed-out read-back's source image: failed: texture, target (exit 1, g++ and clang) 9287f171: timed-out read-back's source image (texture): ok / (render target): ok (exit 0, g++ and clang) ``` ### Flags and settings None. ## Testing **Tested:** Linux x86-64, game-free. The new test fails on the test-only commit 1b907d6b and passes at 9287f171, this branch rebased onto main aa95d35f, with g++ 13.3 and with clang 23.1.5 (before, it did the same at 4cf946a1 and fa5b6da6 on main 53f96d78, and at f5bfead9 and a235b180, twice each, alternating) (`python3 -I -B tests/test_readback_timeout_source.py --cxx g++`); it also builds and passes with clang 23.1.5 under its own `-Wall -Wextra -Werror` at both commits. This PR's own tests and the checks its fix commit edits ran at both commits, and once more on `land/integration` 27553c83 (main 7ff5256e with this PR and twelve other fixes merged), where the thirteen fixes' tests and edited checks pass, 16 of 16; the full `python3 -I -B tests/run_all.py` ran on that branch too (see the checklist). In the game: dukenheimer ran test request T-GQD8 on a Steam Deck OLED (RADV VANGOGH, Mesa 26.2.0-devel, SteamOS 3.9.5, Game Mode, docked) and reported a pass on 2026-11-15 at 03:12 UTC (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/554#issuecomment-22331). These are the same four runs as T-4H95 for https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553: the combined build of main 7ff5256e with https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/550 to https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/558 merged in order, this PR at 6c76d0eb, against main 7ff5256e, the 11-minute route above, interleaved. No `did not complete in time` line in any run, so the timed-out read-back whose source images this PR keeps never happened there: it is a non-regression run, not a run of the fix. No crash, device lost, device fault or GPU stall; no GPU reset, ring timeout, hang or page fault in the kernel log; no garbled or rainbow textures in the 44 arrival pictures (the sheet is on https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553). fps was the same within main's own spread. The branch has been rebased since the tester's run, onto main aa95d35f, with its commits re-authored under the forge's noreply address; each commit's change is identical to before by `git patch-id`, so the commits named above are the ones tested and the result stands for this head (68606017). **Not tested:** A real 5 s GPU stall, in the game or on any GPU: the fixed path is proven only against the stubs, since a stall that long cannot be made on demand. The head in the game (its code is that of the 6c76d0eb the Deck ran). Windows in the game (the renderer was built for Windows, see the checklist). **Must be tested:** None ## Risks **What could break:** This is a separate defect on main from the read-back reuse one (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553), and touches the lines next to that fix in `flush_textures` (the timed-out branch): the two merge without a conflict (git's automatic merge of `gpu/vk/vk_texture.cpp`), and on `land/integration` they compose, with both tests passing there (a texture kept for a later pass is not evicted at all). After a timeout, the source images now live one submission longer. **Turning it off:** revert the commit **Compatibility:** Nothing changes ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. Onto main 94abdd57 (head 77a84d96) with no conflict, with the commit subjects made Conventional Commits, which CI's lint job now checks for every commit, on a base that has CI's config (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/417); each commit's change is the same as before by `git patch-id`. The commits named in this description are from before this rebase: 1b907d6b is now 6a5dfdf7, 9287f171 is now ead1b345, 68606017 is now 77a84d96. Re-run on 94abdd57: `test_readback_timeout_source` fails at the test-only commit 6a5dfdf7 and passes at the head, with g++ 13.3 and clang 23.1.5; of the 37 checks that are this PR's or read its files (g++ 13.3), 35 pass and the 2 that fail fail on main 94abdd57 too (`test_bc_storage_views`, `test_texture_init_barrier`). - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). Run on this branch at 0dfefc41 on main 53f96d78, before this rebase (68606017 now, the same patches by `git patch-id`; the Vulkan and SPIR-V headers from the CPM cache, 8 at once, on a loaded Linux x86-64 server): 530 passed, 16 failed, 48 skipped. 15 of them fail on main 53f96d78 in the same run: `test_appimage_player_build`, `test_bake_portability`, `test_cpm_discovery`, `test_crash_dialog`, `test_env_on`, `test_lift_cache`, `test_lift_cleanup_error`, `test_make_game_cache`, `test_pipeline_tour`, `test_readback_late`, `test_vk_pgo`, `test_vram_budget_row`, `test_walk_key`, `nx2/test_mesh_first_types.py` and `nx2/test_texture_init_barrier.py`. The 16th, `test_pipeline_cache_save` (a timing check: `wait_until(play_saves, 3)`), passed 2 of 2 when run alone on this branch, as on main; main's run timed out `test_fpx_sticky` instead, which passed here and passes alone on main. After the rebase onto main aa95d35f, at 68606017: 35 checks, this PR's test and those that read its changed files, with g++ 13.3 and with clang 23.1.5: 33 pass; the 2 that fail fail on main aa95d35f too (run alone there, both compilers): `nx2/test_bc_storage_views.py` (no `clang++` on this PC's path), `nx2/test_texture_init_barrier.py` (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/628). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. The tester's four Steam Deck runs (this PR, main, main, this PR); the game-free test twice each, alternating. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). `docs/tested/2026-11-15-readback-timeout-dukenheimer-t-4h95.md`, the tester's run; `scripts/tested_configurations.py` and `tests/test_tested_configurations.py` pass with it. The same file, byte for byte, is in https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553: the two branches merge into main together without a conflict. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. Built on Linux for both, in the combined branch 27553c83: `RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows` with llvm-mingw 20261104 linked `longshot_vk.dll` (sha256 25117493...), and the same without `RX_TARGET` linked `longshot_vk.so`; the changed file has no new warning under `-Wall -Wextra` on either platform against `main`. The tester's combined build linked for Linux (x86-64-v3, LLVM 23.1.5). After the rebase onto main aa95d35f, `gpu/vk/vk_texture.cpp` at 68606017 checked whole (`-fsyntax-only -Wall -Wextra`, clang 23.1.5 for Linux and llvm-mingw 20261104 for Windows): the same warnings as main aa95d35f's, none new.
Assisted-by: Claude
keep the source textures of a timed-out read-back until the GPU is past it
Some checks failed
beanstalk/approval awaiting maintainer approval
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
6c76d0eb90
Assisted-by: Claude
Author
Contributor

Filled in: the full game-free suite on the combined branch, the Windows and Linux builds, and the test request T-GQD8. Still work in progress until a Steam Deck run is in.

Filled in: the full game-free suite on the combined branch, the Windows and Linux builds, and the test request T-GQD8. Still work in progress until a Steam Deck run is in.
Author
Contributor

Thank you for catching this. The fixture's destroy_gen is now used (the test checks that the eviction really retired the texture before it looks at the dead list), so it compiles with clang 23.1.5 under the test's own -Wall -Wextra -Werror; checked here with that clang at both commits. The fix commit is unchanged. #553's test had no such warning.

Thank you for catching this. The fixture's destroy_gen is now used (the test checks that the eviction really retired the texture before it looks at the dead list), so it compiles with clang 23.1.5 under the test's own -Wall -Wextra -Werror; checked here with that clang at both commits. The fix commit is unchanged. #553's test had no such warning.
zeldaootr force-pushed readback-timeout-keeps-source-textures from 6c76d0eb90
Some checks failed
beanstalk/approval awaiting maintainer approval
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to a235b18035
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 16s
beanstalk/approval Test farm not requested
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-14 20:36:11 +00:00
Compare
Contributor

Test request T-GQD8: pass

Built in a combined build of main 7ff5256e with #550 to #558 merged in order, this PR at 6c76d0eb. The comparison is main 7ff5256e.
This PR's head is now a235b180, whose code is the same: it differs from 6c76d0eb only in tests/test_readback_timeout_source.py
(5 lines added). That test passes with LLVM 23.1.5. The same runs as for #553 (T-4H95). Setup and method below.

Result

run build fps over the route 'did not complete in time' device lost / device fault / GPU stalled / crash kernel amdgpu lines of them reset / timeout / hang / fault
1 combined 16.8 0 0 / 0 / 0 / 0 12 0
2 main 16.6 0 0 / 0 / 0 / 0 6 0
3 main 17.7 0 0 / 0 / 0 / 0 6 0
4 combined 17.1 0 0 / 0 / 0 / 0 6 0
  • Kernel log (journalctl -k | grep -i amdgpu, from each start to its end): the lines were only the display's
    [drm] Losing delta precision while programming shaper LUT notices, 6 a start (12 in run 1). No GPU reset, ring timeout, hang or
    page fault in any run.
  • 'did not complete in time': no such line in any of the four runs, so there are no lines to post. The timed-out read-back
    whose source images this PR keeps never happened here: this is a non-regression result.
  • fps: 16.8 and 17.1 with this PR, 16.6 and 17.7 on main. Main's own two runs differ by more than the builds do. By area, the
    two builds' means are within 2 fps everywhere, in both directions (Goron City +1.9, Gerudo Valley -1.6).
  • Texture pressure: textures were evicted and made again in every run (14 to 17 evicted, made again lines).
    • In play the textures reached 2.7 to 2.8 GB against a 2,560 MB texture budget.
    • VRAM in use peaked at 4.5 to 5.1 GB of the 5.3 to 6.1 GB allowed.
    • Memory was short too: about 4.3 GB swapped in every run, with MemAvailable down to 281-471 MB.
  • Picture: no garbled or rainbow textures in the 44 arrival pictures (the sheet is on #553). They differ only in timing: an
    arrival still fading in, Navi's place, and when the area title showed (it dissolves in and out, the same on main).

Setup

  • Steam Deck OLED: AMD Custom APU 0932 (RADV VANGOGH), 16 GB; Mesa 26.2.0-devel git-5c65d4fc31; SteamOS 3.9.5 (build 20261023.100),
    kernel 7.2.7-valve2. Game Mode, docked, stock clocks.
  • Builds: main 7ff5256e, and the combined build: main + #550 to #558, merged in order, all clean. Both for x86-64-v3 with the
    release play profile and LLVM 23.1.5. One test folder (warm caches) with the binaries swapped.
  • Settings: the Minimum (4GB) preset, chosen through the menu's own setter in a start of its own. Every run then used that
    options file.
    • On this Deck main's own defaults (Auto) already have Minimum's render resolution (50% of 1280x720) and its 2.2 GB VRAM budget.
    • So Minimum changed the Profile to Handheld, the window scaling filter, and sharpness to 30.
    • Upscaler: the game's own; frame generation off.
  • Route, the same each run, through the control bridge: Continue into Kokiri Forest, then 10 debug teleports with about 45 s in
    each area: Hyrule Field, Kakariko, the Market, Hyrule Field, the Lost Woods, Goron City, Death Mountain Trail, Zora's River, Gerudo
    Valley, Kokiri Forest. About 11 minutes of play a run; every teleport was taken on the first try.
  • Measured: fps is the bridge's status every 5 s, averaged over the time in play. The log lines are from each run's
    longshot_log.txt.
  • Order: combined, main, main, combined.
Test request T-GQD8: pass Built in a combined build of main 7ff5256e with #550 to #558 merged in order, this PR at 6c76d0eb. The comparison is main 7ff5256e. This PR's head is now a235b180, whose code is the same: it differs from 6c76d0eb only in `tests/test_readback_timeout_source.py` (5 lines added). That test passes with LLVM 23.1.5. The same runs as for #553 (T-4H95). Setup and method below. **Result** | run | build | fps over the route | 'did not complete in time' | device lost / device fault / GPU stalled / crash | kernel amdgpu lines | of them reset / timeout / hang / fault | |---|---|---|---|---|---|---| | 1 | combined | 16.8 | 0 | 0 / 0 / 0 / 0 | 12 | 0 | | 2 | main | 16.6 | 0 | 0 / 0 / 0 / 0 | 6 | 0 | | 3 | main | 17.7 | 0 | 0 / 0 / 0 / 0 | 6 | 0 | | 4 | combined | 17.1 | 0 | 0 / 0 / 0 / 0 | 6 | 0 | - **Kernel log** (`journalctl -k | grep -i amdgpu`, from each start to its end): the lines were only the display's `[drm] Losing delta precision while programming shaper LUT` notices, 6 a start (12 in run 1). No GPU reset, ring timeout, hang or page fault in any run. - **'did not complete in time':** no such line in any of the four runs, so there are no lines to post. The timed-out read-back whose source images this PR keeps never happened here: this is a non-regression result. - **fps:** 16.8 and 17.1 with this PR, 16.6 and 17.7 on main. Main's own two runs differ by more than the builds do. By area, the two builds' means are within 2 fps everywhere, in both directions (Goron City +1.9, Gerudo Valley -1.6). - **Texture pressure:** textures were evicted and made again in every run (14 to 17 `evicted, made again` lines). - In play the textures reached 2.7 to 2.8 GB against a 2,560 MB texture budget. - VRAM in use peaked at 4.5 to 5.1 GB of the 5.3 to 6.1 GB allowed. - Memory was short too: about 4.3 GB swapped in every run, with MemAvailable down to 281-471 MB. - **Picture:** no garbled or rainbow textures in the 44 arrival pictures (the sheet is on #553). They differ only in timing: an arrival still fading in, Navi's place, and when the area title showed (it dissolves in and out, the same on main). **Setup** - Steam Deck OLED: AMD Custom APU 0932 (RADV VANGOGH), 16 GB; Mesa 26.2.0-devel git-5c65d4fc31; SteamOS 3.9.5 (build 20261023.100), kernel 7.2.7-valve2. Game Mode, docked, stock clocks. - **Builds:** main 7ff5256e, and the combined build: main + #550 to #558, merged in order, all clean. Both for x86-64-v3 with the release play profile and LLVM 23.1.5. One test folder (warm caches) with the binaries swapped. - **Settings:** the Minimum (4GB) preset, chosen through the menu's own setter in a start of its own. Every run then used that options file. - On this Deck main's own defaults (Auto) already have Minimum's render resolution (50% of 1280x720) and its 2.2 GB VRAM budget. - So Minimum changed the Profile to Handheld, the window scaling filter, and sharpness to 30. - Upscaler: the game's own; frame generation off. - **Route, the same each run, through the control bridge:** Continue into Kokiri Forest, then 10 debug teleports with about 45 s in each area: Hyrule Field, Kakariko, the Market, Hyrule Field, the Lost Woods, Goron City, Death Mountain Trail, Zora's River, Gerudo Valley, Kokiri Forest. About 11 minutes of play a run; every teleport was taken on the first try. - **Measured:** fps is the bridge's status every 5 s, averaged over the time in play. The log lines are from each run's `longshot_log.txt`. - **Order:** combined, main, main, combined.
Author
Contributor

Thank you, dukenheimer, for T-GQD8 on the Steam Deck (#554 (comment)).

Rebased onto main 53f96d78 with no conflict: the test and fix commits are the same as before (git range-diff: f5bfead9 is now 4cf946a1, a235b180 is now fa5b6da6), and the run is added as docs/tested/2026-11-15-readback-timeout-dukenheimer-t-4h95.md in a third commit, 0dfefc41 (the same file as in #553; the two merge into main together without a conflict). The description now ticks the rebase and docs/tested/ boxes.

Tests run again after the rebase: tests/test_readback_timeout_source.py fails at 4cf946a1 (texture, render target) and passes at the tip, with g++ 13.3 and with clang 23.1.5. The full python3 -I -B tests/run_all.py on this branch: 530 passed, 16 failed, 48 skipped; 15 of them fail on main 53f96d78 in the same run (named in the checklist), and the 16th, test_pipeline_cache_save, a timing check, passed 2 of 2 run alone, as on main. gpu/vk/vk_texture.cpp checked whole for Linux and Windows: the same warnings as main's, none new.

Why the Deck result still holds: main changed nothing in the lines this PR changes, and the Deck's 6c76d0eb has the same code as the head (a235b180 added 5 lines to the test only). Since the tested base 7ff5256e, main changed gpu/vk/vk_texture.cpp in one commit, b2911d33 (weak Intel laptops): system_ram_bytes(), the low-VRAM mip rule (an integrated GPU with 16 GB of RAM or less now counts as small at Minimum's budgets, which includes the Deck at the preset the tester used), a lower squeeze line on integrated GPUs and a squeeze after the driver refuses pipelines for want of memory, in texture_frame, and the integrated GPU budget's log line. None of it is in flush_textures' timed-out branch, destroy_later or the dead list's loop this PR relies on. Those rules change how many textures the Deck keeps and evicts on main and on this PR alike, so the fps and eviction counts measured on 7ff5256e are 7ff5256e's; the result itself, a non-regression run in which no read-back timed out, does not depend on them, and the fix stays proven by the game-free test.

Thank you, dukenheimer, for T-GQD8 on the Steam Deck (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/554#issuecomment-22331). Rebased onto main 53f96d78 with no conflict: the test and fix commits are the same as before (`git range-diff`: f5bfead9 is now 4cf946a1, a235b180 is now fa5b6da6), and the run is added as `docs/tested/2026-11-15-readback-timeout-dukenheimer-t-4h95.md` in a third commit, 0dfefc41 (the same file as in https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553; the two merge into main together without a conflict). The description now ticks the rebase and `docs/tested/` boxes. Tests run again after the rebase: `tests/test_readback_timeout_source.py` fails at 4cf946a1 (texture, render target) and passes at the tip, with g++ 13.3 and with clang 23.1.5. The full `python3 -I -B tests/run_all.py` on this branch: 530 passed, 16 failed, 48 skipped; 15 of them fail on main 53f96d78 in the same run (named in the checklist), and the 16th, `test_pipeline_cache_save`, a timing check, passed 2 of 2 run alone, as on main. `gpu/vk/vk_texture.cpp` checked whole for Linux and Windows: the same warnings as main's, none new. Why the Deck result still holds: main changed nothing in the lines this PR changes, and the Deck's 6c76d0eb has the same code as the head (a235b180 added 5 lines to the test only). Since the tested base 7ff5256e, main changed `gpu/vk/vk_texture.cpp` in one commit, b2911d33 (weak Intel laptops): `system_ram_bytes()`, the low-VRAM mip rule (an integrated GPU with 16 GB of RAM or less now counts as small at Minimum's budgets, which includes the Deck at the preset the tester used), a lower squeeze line on integrated GPUs and a squeeze after the driver refuses pipelines for want of memory, in `texture_frame`, and the integrated GPU budget's log line. None of it is in `flush_textures`' timed-out branch, `destroy_later` or the dead list's loop this PR relies on. Those rules change how many textures the Deck keeps and evicts on main and on this PR alike, so the fps and eviction counts measured on 7ff5256e are 7ff5256e's; the result itself, a non-regression run in which no read-back timed out, does not depend on them, and the fix stays proven by the game-free test.
zeldaootr force-pushed readback-timeout-keeps-source-textures from a235b18035
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 16s
beanstalk/approval Test farm not requested
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 0dfefc41ba
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 17s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 05:35:23 +00:00
Compare
zeldaootr changed title from WIP: fix(vk): a timed-out read-back's source images are kept until the GPU is past the copy to fix(vk): a timed-out read-back's source images are kept until the GPU is past the copy 2026-11-15 05:35:24 +00:00
zeldaootr force-pushed readback-timeout-keeps-source-textures from 0dfefc41ba
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 17s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 686060178d
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 17:11:25 +00:00
Compare
Author
Contributor

Rebased onto main aa95d35f (head 68606017); the commits are re-authored with the forge's noreply address: no code change, the same patches by git patch-id.
Tests re-run on the new base, g++ 13.3 and clang 23.1.5: test_readback_timeout_source fails at the test-only commit 1b907d6b (texture, target) and passes at 9287f171; of the 35 checks that are this PR's or read its files, 33 pass and the 2 that fail fail on main too. The Deck run (T-GQD8) stands; the description names the new commits.

Rebased onto `main` aa95d35f (head 68606017); the commits are re-authored with the forge's noreply address: no code change, the same patches by `git patch-id`. Tests re-run on the new base, g++ 13.3 and clang 23.1.5: `test_readback_timeout_source` fails at the test-only commit 1b907d6b (texture, target) and passes at 9287f171; of the 35 checks that are this PR's or read its files, 33 pass and the 2 that fail fail on main too. The Deck run (T-GQD8) stands; the description names the new commits.
HumanBean approved these changes 2026-11-15 19:05:03 +00:00
Dismissed
HumanBean left a comment

Read the diff and the surrounding code. When a batch's 5 s wait runs out, the staging buffers already waited for rec_value + 1, but the source images only waited for their old last_value, so an eviction could destroy or pool them under the copy. Raising each texture's last_value to rec_value + 1 gives them the same lifetime. Flush::t is always set where the batch is built, so the unguarded deref is fine, and the last_value > completed checks in the eviction pick just keep the texture off the candidate list until then.

It fits with #553 (which keeps the batch's textures resident while the read-back is pending; this PR still matters for an eviction without a write-back and for texture_flush_to_guest's single flushes). The two merge cleanly in either order. The test cuts the real flush_textures, destroy_later and the dead-list loop out of the source and checks the texture and render-target cases.

#788 makes the same last_value change in the same lines plus a conflicting read-back design; I asked for that part to be dropped there.

Read the diff and the surrounding code. When a batch's 5 s wait runs out, the staging buffers already waited for `rec_value + 1`, but the source images only waited for their old `last_value`, so an eviction could destroy or pool them under the copy. Raising each texture's `last_value` to `rec_value + 1` gives them the same lifetime. `Flush::t` is always set where the batch is built, so the unguarded deref is fine, and the `last_value > completed` checks in the eviction pick just keep the texture off the candidate list until then. It fits with https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/553 (which keeps the batch's textures resident while the read-back is pending; this PR still matters for an eviction without a write-back and for `texture_flush_to_guest`'s single flushes). The two merge cleanly in either order. The test cuts the real `flush_textures`, `destroy_later` and the dead-list loop out of the source and checks the texture and render-target cases. https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/788 makes the same `last_value` change in the same lines plus a conflicting read-back design; I asked for that part to be dropped there.
zeldaootr force-pushed readback-timeout-keeps-source-textures from 686060178d
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 77a84d96dd
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 7s
2026-11-15 19:14:56 +00:00
Compare
zeldaootr dismissed HumanBean's review 2026-11-15 19:14:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Author
Contributor

Rebased onto main 94abdd57 (head 77a84d96), with no conflict; the commit subjects are now Conventional Commits, which CircleCI's lint job checks for every commit of a pull request (#417), and the base has the CI's config, which a fork's pull request needs at its own head. No other change: each commit's change is the same as before by git patch-id.
Re-run on 94abdd57: test_readback_timeout_source fails at the test-only commit 6a5dfdf7 and passes at the head, with g++ 13.3 and clang 23.1.5; of the 37 checks that are this PR's or read its files (g++ 13.3), 35 pass and the 2 that fail fail on main 94abdd57 too (test_bc_storage_views, test_texture_init_barrier). The description names the new commits.

Rebased onto `main` 94abdd57 (head 77a84d96), with no conflict; the commit subjects are now Conventional Commits, which CircleCI's lint job checks for every commit of a pull request (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/417), and the base has the CI's config, which a fork's pull request needs at its own head. No other change: each commit's change is the same as before by `git patch-id`. Re-run on 94abdd57: `test_readback_timeout_source` fails at the test-only commit 6a5dfdf7 and passes at the head, with g++ 13.3 and clang 23.1.5; of the 37 checks that are this PR's or read its files (g++ 13.3), 35 pass and the 2 that fail fail on main 94abdd57 too (`test_bc_storage_views`, `test_texture_init_barrier`). The description names the new commits.
HumanBean deleted branch readback-timeout-keeps-source-textures 2026-11-15 19:20:09 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 7s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!554
No description provided.