fix(vk): count every program not translated, past the 30 lines that name them #423

Open

mooki wants to merge 2 commits from mooki/Longshot:fix/network-log-count into main

pull from: mooki/Longshot:fix/network-log-count

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 0 Commits 2 Files changed 5 +290 -10

mooki commented 2026-11-14 13:05:59 +00:00

Member

• Copy link
• Copy Markdown

Type: fix · Risk: low · Tested on: macOS 26.7.1, Apple M4 Max (game-free checks, no game run) · Needs: Windows or Linux, AMD or Intel GPU

Why

The log's vk: prepared N shader programs (... M failed ...) can count more failed programs than the log ever names or
counts anywhere. Each "not translated" line stops after 30 programs, so the rest are invisible. On a Mac start, 70 failed named 31 programs: 30 networks left out on purpose and 1 stage that did not parse. The other 39, networks past
that line's 30, appeared nowhere. A reader of the log cannot tell a deliberate exclusion from a real failure.

How to reproduce

Seen on: macOS 26.7.1, Apple M4 Max, MoltenVK (a game start's longshot_log.txt). The caps are the same code on
every OS, so any start with more than 30 programs failed for one reason shows it.
Settings and switches: defaults.
Steps: start the game on main where programs are left out (on a card without the movie-upscaler networks: not NVIDIA)
and read longshot_log.txt after vk: prepared N shader programs (... M failed ...). Game-free:
python -I -B tests/test_not_translated_counts.py --cxx clang++ --source <a tree of main>.
Expected: every failed program counted under a reason, the counts adding up to M.
Actual: 70 failed named 31 programs (30 networks and 1 stage that did not parse); the other 39 appear nowhere. The
test on main: FAIL: vk_shader.cpp: no count of every program each "not translated" line stands for.

What changed

Each of the four "not translated" reasons now has a counter that counts every program, past the 30 the log names, and
the preparation logs one count line per reason right after its prepared line. The lines add up to the failed count;
the per-program lines and their cap of 30 are unchanged.

• Read first: the four ++ < kFailNamed sites in vk_shader.cpp, with shader_fail_lines.
• vk: gpu/vk/vk_shader.cpp.
  • Four counters next to st_failed: st_left_out, st_not_translated, st_mesh_not_translated and
    st_stage_failed, plus kFailNamed = 30.
  • They replace the function-local static std::atomic<int> caps of the four "not translated" lines: translate_into's
    catch (network left out, and anything else), translate_mesh_into's catch, and seed_stage_failed. Each counter is
    the one its line is capped by, so it counts every failure the line stands for, past the 30 too.
  • Each failure st_failed counts lands in exactly one of them. A seed_compute trial answer is in none, as before.
• vk: shader_fail_lines() (vk_shader.cpp, declared in vk_shader.h) logs one line for each counter that counted
  anything, for example:
  vk: not translated, a network left out on this card: 69 programs (the first 30 named at trace level). The lines add up
  to M. Each says where its programs are named: the networks' per-program lines are trace lines, hidden at the default
  level, so their count line says "at trace level"; the other three say "above".
• vk: prepare_run (gpu/vk/vk_draw.cpp) calls it right after its prepared line.
• The per-program lines, their levels (the network's is [trace]), their text and their cap of 30 are unchanged.
• tests: tests/test_not_translated_counts.py (new).
  • It cuts the two catch blocks, seed_stage_failed, the counters and shader_fail_lines from the source and runs them
    against small stand-ins.
  • The stand-ins: 69 networks, 40 other failures from 8 threads, 2 mesh, 1 stage that does not parse, and 2 answers
    seed_compute only tries.
  • It expects the same 30/30/2/1 named lines as before, then the four count lines adding up to the 112 counted. With
    no failure it expects no line.
  • It also checks that prepare_run logs the lines right after its own.
  • It fails on main.
• tests: tests/test_log_levels.py reads the network's cap by its new name (st_left_out++ < kFailNamed). Its check is
  the same: a network left out is a trace line with a count of its own.
• Left out: a program failed in play after the preparation is counted too, but it only shows in the next preparation's
  lines. Logging the counts again at quit was left out to keep this to the preparation's own line.

Measurements

Verdict: fixed, and nothing else moves: the new test fails on main and passes here, and the full game-free suite
changes only by that test (532 passed against main's 531, the same 32 failures and 17 skips). A log fix: nothing to
time.

Commits: main 6c9edffe5d (2026-11-14); this PR fix/network-log-count @
1b2b686615.
Hardware: Apple M4 Max (16 CPUs), macOS 26.7.1, Apple clang 21. Game-free: no GPU, no game
Scene: none (a log fix; its proof is the test, as CONTRIBUTING's fix row allows)
Method: tests/test_not_translated_counts.py against main's gpu/vk/vk_shader.cpp and vk_draw.cpp (git show) and
against this PR; the full game-free suite on both
How to reproduce: python -I -B tests/test_not_translated_counts.py --cxx clang++ (add
--source <a tree of main> for main's side)

	Before: main @ 6c9edffe	After: this PR @ 1b2b6866
tests/test_not_translated_counts.py	FAIL: no count past the 30 lines	PASS: 69, 40, 2 and 1, adding up to 112
full game-free suite on macOS (tests/run_all.py --jobs 6)	531 passed, 32 failed, 17 skipped	532 passed, 32 failed, 17 skipped

main @ 6c9edffe:
FAIL: vk_shader.cpp: no count of every program each "not translated" line stands for (kFailNamed and the four st_ counts)

this PR @ 1b2b6866:
PASS: each reason a program was not translated has a count line after the preparation's, the ones past its 30 named lines included, adding up to the failed

The count lines the test expects, after 30 trace lines, 30 lines, 2 lines and 1 line naming the programs:

vk: not translated, a network left out on this card: 69 programs (the first 30 named at trace level)
vk: not translated: 40 programs (the first 30 named above)
vk: not translated, mesh: 2 programs (named above)
vk: not translated, a seed stage that does not parse: 1 program (named above)

Screenshots: none; nothing on screen changes.

Flags and settings

None.

Testing

Tested:

• On an Apple M4 Max with macOS 26.7.1, game-free only.
• tests/test_not_translated_counts.py fails on main and passes here.
• tests/test_log_levels.py passes.
• The full suite on both sides, compared by test name, at 1b2b6866 and main 6c9edffe.
  • By test name, against main 6c9edffe's run on the same Mac: only one status changed: test_not_translated_counts,
    absent on main, passes here.
  • These 32 checks fail here and on main on this Mac, by name (not triaged here: some need the macOS port's other pull
    requests, some are checks main added or changed since 5e072fc8): test_appimage_package_retry,
    test_appimage_player_build, test_collect_wide, test_control, test_cpm_discovery, test_crash_dialog,
    test_crash_record, test_env_on, test_game_layout, test_lift_cleanup_error, test_linux_preflight,
    test_longshot_ctl, test_low_memory_notice, test_make_game_cache, test_mem_gate, test_mem_gate_children,
    test_mirror_trim, test_oot_state_tap, test_pcache_header_read, test_pipeline_cache_file,
    test_pipeline_cache_save, test_pipeline_play_cache, test_pipeline_tour, test_prof_symbols,
    test_program_cache_cleanup, test_program_cache_one_variant, test_readback_late, test_report_run,
    test_split_giants, test_vk_pgo, test_vram_budget_row, test_walk_key.
  • The same 17 checks skipped as on main.
  • Crash reports during the run: none (main's run: fault-arm64-2026-11-14-180704.ips,
    recorder_sync_test.exe-2026-11-14-180744.ips).
• Object compiles of gpu/vk/vk_shader.cpp and gpu/vk/vk_draw.cpp with the renderer's flags (nx2/build.py), Apple
  clang 21, arm64 and x86_64.
  • Main's renderer does not build on macOS as it is: environ (vk_shader.cpp) and posix_fallocate
    (pipeline_cache_file.h).
  • With a compile-only prelude declaring those names, all 8 objects build, 4 on main and 4 here.
• After the rebase onto main aa95d35f, at 155b6f11 (1b2b6866 before the rebases onto e090cc48 and aa95d35f):
  Sweep3's checks of this head (the C/C++ it changes compiled, and its own tests run, on arm64 and x86_64 where they
  apply) gave the same results as before; python -I -B tests/run_all.py on wave S1's merge 11a5b4e7, which carries
  this head: 568/22/17 (passed/failed/skipped) against main aa95d35f's 543/33/17 on this Mac, no new failure
  (reports/2026-11-15-rebase-sweep-3.md).

Not tested:

• A build on Windows (llvm-mingw) or Linux. The change uses only std::atomic<int64_t>, logf and a lambda, as the
  code around it does.
• An in-game start on Windows or Linux. The change is four counters and four log lines, with no translation, no
  program cache format and no draw affected. A start with any failed program shows the new lines right after
  vk: prepared ….

Must be tested:

• Windows or Linux, an AMD or Intel GPU, any driver: build this PR (head 155b6f11) and main aa95d35f, start each once to
  the title and read longshot_log.txt after vk: prepared …, expecting this PR's log to add vk: not translated, a network left out on this card: N programs (the first 30 named at trace level) (and a line for each other reason that
  counted) right after it, the count lines adding up to that line's failed, and main's log to have no such lines (by
  hand: test request T-R6CX).

Risks

What could break: low. The only output added is up to four log lines after the preparation's. The counters are
64-bit atomics where the caps were 32-bit ones, so the caps can no longer wrap.

Turning it off: revert the commit.

Compatibility: vk_shader.cpp is one of the translator stamp's files (nx2/translator_files.py since main's #370),
so the first start after updating translates every program again, as any change to that file does. Saves, the options
file and the vk ABI are unchanged.

Checklist

Everyone

• One topic.
• The title is a Conventional Commit (type(scope): description) of the status line's type.
• Why gives the reason plainly and links the issues that fit (the tracker searched).
• Measurements has a verdict, or one line saying why there is nothing to measure.
• Testing names what was tested, what wasn't, and what must still be tested, where and how.
• Rebased on current main: on aa95d35f (#761, 2026-11-15), head 155b6f11, without a conflict; this PR's own
  commits, old → new: e0c1ec62 → 2feca0bb, 1b2b6866 → 155b6f11; the commit names elsewhere in this description
  are from before the rebase.
• python -I -B tests/run_all.py passes (any failure that also fails on main is named). On macOS: 532 passed, 17
  skipped, and 32 failures that also fail on main 6c9edffe on this Mac, named under Testing. After the rebase onto main
  aa95d35f (head 155b6f11): wave S1's merge 11a5b4e7, 568/22/17 against main aa95d35f's 543/33/17, no new failure.
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• A game-free test added for the fix, failing on main and passing here.
• A check under tests/ that reads changed source updated in this PR, not weakened.

**Type:** fix · **Risk:** low · **Tested on:** macOS 26.7.1, Apple M4 Max (game-free checks, no game run) · **Needs:** Windows or Linux, AMD or Intel GPU ## Why The log's `vk: prepared N shader programs (... M failed ...)` can count more failed programs than the log ever names or counts anywhere. Each "not translated" line stops after 30 programs, so the rest are invisible. On a Mac start, `70 failed` named 31 programs: 30 networks left out on purpose and 1 stage that did not parse. The other 39, networks past that line's 30, appeared nowhere. A reader of the log cannot tell a deliberate exclusion from a real failure. ## How to reproduce **Seen on:** macOS 26.7.1, Apple M4 Max, MoltenVK (a game start's `longshot_log.txt`). The caps are the same code on every OS, so any start with more than 30 programs failed for one reason shows it. **Settings and switches:** defaults. **Steps:** start the game on main where programs are left out (on a card without the movie-upscaler networks: not NVIDIA) and read `longshot_log.txt` after `vk: prepared N shader programs (... M failed ...)`. Game-free: `python -I -B tests/test_not_translated_counts.py --cxx clang++ --source <a tree of main>`. **Expected:** every failed program counted under a reason, the counts adding up to M. **Actual:** `70 failed` named 31 programs (30 networks and 1 stage that did not parse); the other 39 appear nowhere. The test on main: `FAIL: vk_shader.cpp: no count of every program each "not translated" line stands for`. ## What changed Each of the four "not translated" reasons now has a counter that counts every program, past the 30 the log names, and the preparation logs one count line per reason right after its `prepared` line. The lines add up to the `failed` count; the per-program lines and their cap of 30 are unchanged. - Read first: the four `++ < kFailNamed` sites in `vk_shader.cpp`, with `shader_fail_lines`. - vk: `gpu/vk/vk_shader.cpp`. - Four counters next to `st_failed`: `st_left_out`, `st_not_translated`, `st_mesh_not_translated` and `st_stage_failed`, plus `kFailNamed = 30`. - They replace the function-local `static std::atomic<int>` caps of the four "not translated" lines: `translate_into`'s catch (network left out, and anything else), `translate_mesh_into`'s catch, and `seed_stage_failed`. Each counter is the one its line is capped by, so it counts every failure the line stands for, past the 30 too. - Each failure `st_failed` counts lands in exactly one of them. A seed_compute trial answer is in none, as before. - vk: `shader_fail_lines()` (`vk_shader.cpp`, declared in `vk_shader.h`) logs one line for each counter that counted anything, for example: `vk: not translated, a network left out on this card: 69 programs (the first 30 named at trace level)`. The lines add up to M. Each says where its programs are named: the networks' per-program lines are trace lines, hidden at the default level, so their count line says "at trace level"; the other three say "above". - vk: `prepare_run` (`gpu/vk/vk_draw.cpp`) calls it right after its `prepared` line. - The per-program lines, their levels (the network's is `[trace]`), their text and their cap of 30 are unchanged. - tests: `tests/test_not_translated_counts.py` (new). - It cuts the two catch blocks, `seed_stage_failed`, the counters and `shader_fail_lines` from the source and runs them against small stand-ins. - The stand-ins: 69 networks, 40 other failures from 8 threads, 2 mesh, 1 stage that does not parse, and 2 answers seed_compute only tries. - It expects the same 30/30/2/1 named lines as before, then the four count lines adding up to the 112 counted. With no failure it expects no line. - It also checks that `prepare_run` logs the lines right after its own. - It fails on main. - tests: `tests/test_log_levels.py` reads the network's cap by its new name (`st_left_out++ < kFailNamed`). Its check is the same: a network left out is a trace line with a count of its own. - Left out: a program failed in play after the preparation is counted too, but it only shows in the next preparation's lines. Logging the counts again at quit was left out to keep this to the preparation's own line. ## Measurements **Verdict:** fixed, and nothing else moves: the new test fails on main and passes here, and the full game-free suite changes only by that test (532 passed against main's 531, the same 32 failures and 17 skips). A log fix: nothing to time. Commits: main 6c9edffe5da1f5b5383977aeab3f544c0de25d4c (2026-11-14); this PR fix/network-log-count @ 1b2b686615762bf086ceadc3c136e39fe0008b85. Hardware: Apple M4 Max (16 CPUs), macOS 26.7.1, Apple clang 21. Game-free: no GPU, no game Scene: none (a log fix; its proof is the test, as CONTRIBUTING's `fix` row allows) Method: `tests/test_not_translated_counts.py` against main's `gpu/vk/vk_shader.cpp` and `vk_draw.cpp` (`git show`) and against this PR; the full game-free suite on both How to reproduce: `python -I -B tests/test_not_translated_counts.py --cxx clang++` (add `--source <a tree of main>` for main's side) | | Before: main @ 6c9edffe | After: this PR @ 1b2b6866 | |---|---|---| | `tests/test_not_translated_counts.py` | FAIL: no count past the 30 lines | PASS: 69, 40, 2 and 1, adding up to 112 | | full game-free suite on macOS (`tests/run_all.py --jobs 6`) | 531 passed, 32 failed, 17 skipped | 532 passed, 32 failed, 17 skipped | ``` main @ 6c9edffe: FAIL: vk_shader.cpp: no count of every program each "not translated" line stands for (kFailNamed and the four st_ counts) this PR @ 1b2b6866: PASS: each reason a program was not translated has a count line after the preparation's, the ones past its 30 named lines included, adding up to the failed ``` The count lines the test expects, after 30 trace lines, 30 lines, 2 lines and 1 line naming the programs: ``` vk: not translated, a network left out on this card: 69 programs (the first 30 named at trace level) vk: not translated: 40 programs (the first 30 named above) vk: not translated, mesh: 2 programs (named above) vk: not translated, a seed stage that does not parse: 1 program (named above) ``` Screenshots: none; nothing on screen changes. ### Flags and settings None. ## Testing **Tested:** - On an Apple M4 Max with macOS 26.7.1, game-free only. - `tests/test_not_translated_counts.py` fails on main and passes here. - `tests/test_log_levels.py` passes. - The full suite on both sides, compared by test name, at 1b2b6866 and main 6c9edffe. - By test name, against main 6c9edffe's run on the same Mac: only one status changed: `test_not_translated_counts`, absent on main, passes here. - These 32 checks fail here and on main on this Mac, by name (not triaged here: some need the macOS port's other pull requests, some are checks main added or changed since 5e072fc8): `test_appimage_package_retry`, `test_appimage_player_build`, `test_collect_wide`, `test_control`, `test_cpm_discovery`, `test_crash_dialog`, `test_crash_record`, `test_env_on`, `test_game_layout`, `test_lift_cleanup_error`, `test_linux_preflight`, `test_longshot_ctl`, `test_low_memory_notice`, `test_make_game_cache`, `test_mem_gate`, `test_mem_gate_children`, `test_mirror_trim`, `test_oot_state_tap`, `test_pcache_header_read`, `test_pipeline_cache_file`, `test_pipeline_cache_save`, `test_pipeline_play_cache`, `test_pipeline_tour`, `test_prof_symbols`, `test_program_cache_cleanup`, `test_program_cache_one_variant`, `test_readback_late`, `test_report_run`, `test_split_giants`, `test_vk_pgo`, `test_vram_budget_row`, `test_walk_key`. - The same 17 checks skipped as on main. - Crash reports during the run: none (main's run: fault-arm64-2026-11-14-180704.ips, recorder_sync_test.exe-2026-11-14-180744.ips). - Object compiles of `gpu/vk/vk_shader.cpp` and `gpu/vk/vk_draw.cpp` with the renderer's flags (`nx2/build.py`), Apple clang 21, arm64 and x86_64. - Main's renderer does not build on macOS as it is: `environ` (vk_shader.cpp) and `posix_fallocate` (pipeline_cache_file.h). - With a compile-only prelude declaring those names, all 8 objects build, 4 on main and 4 here. - **After the rebase onto main aa95d35f**, at `155b6f11` (`1b2b6866` before the rebases onto e090cc48 and aa95d35f): Sweep3's checks of this head (the C/C++ it changes compiled, and its own tests run, on arm64 and x86_64 where they apply) gave the same results as before; `python -I -B tests/run_all.py` on wave S1's merge `11a5b4e7`, which carries this head: 568/22/17 (passed/failed/skipped) against main aa95d35f's 543/33/17 on this Mac, no new failure (`reports/2026-11-15-rebase-sweep-3.md`). **Not tested:** - A build on Windows (llvm-mingw) or Linux. The change uses only `std::atomic<int64_t>`, `logf` and a lambda, as the code around it does. - An in-game start on Windows or Linux. The change is four counters and four log lines, with no translation, no program cache format and no draw affected. A start with any failed program shows the new lines right after `vk: prepared …`. **Must be tested:** - Windows or Linux, an AMD or Intel GPU, any driver: build this PR (head 155b6f11) and main aa95d35f, start each once to the title and read `longshot_log.txt` after `vk: prepared …`, expecting this PR's log to add `vk: not translated, a network left out on this card: N programs (the first 30 named at trace level)` (and a line for each other reason that counted) right after it, the count lines adding up to that line's `failed`, and main's log to have no such lines (by hand: test request T-R6CX). ## Risks **What could break:** low. The only output added is up to four log lines after the preparation's. The counters are 64-bit atomics where the caps were 32-bit ones, so the caps can no longer wrap. **Turning it off:** revert the commit. **Compatibility:** `vk_shader.cpp` is one of the translator stamp's files (`nx2/translator_files.py` since main's #370), so the first start after updating translates every program again, as any change to that file does. Saves, the options file and the vk ABI are unchanged. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`: on aa95d35f (#761, 2026-11-15), head `155b6f11`, without a conflict; this PR's own commits, old → new: `e0c1ec62` → `2feca0bb`, `1b2b6866` → `155b6f11`; the commit names elsewhere in this description are from before the rebase. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). On macOS: 532 passed, 17 skipped, and 32 failures that also fail on main 6c9edffe on this Mac, named under Testing. After the rebase onto main aa95d35f (head `155b6f11`): wave S1's merge `11a5b4e7`, 568/22/17 against main aa95d35f's 543/33/17, no new failure. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened.

mooki added 2 commits 2026-11-14 13:06:00 +00:00

fix(vk): count every program not translated, past the 30 lines that name them ... 16816014d8

The preparation's "vk: prepared N shader programs (... M failed ...)" counts four kinds of failure, each with a "not
translated" line that names 30 programs, so that a log is not flooded: a network left out on purpose (a trace line), any
other failure in translate_into, a mesh program, and a seed stage that does not parse. Past 30 the rest were counted
nowhere: a start on a Mac logged "70 failed" and named 31 programs, 30 of them networks; the other 39 networks went
unnamed and uncounted.

Each line's count is now a counter of its own (st_left_out, st_not_translated, st_mesh_not_translated, st_stage_failed in
vk_shader.cpp), the one it is capped by, so it counts every failure it stands for. shader_fail_lines, right after the
preparation's line, logs one line for each that counted any, for example "vk: not translated, a network left out on this
card: 69 programs (the first 30 named above)". The four add up to M. The per-program lines and their cap are as before.

tests/test_not_translated_counts.py runs the catch blocks, seed_stage_failed, the counters and shader_fail_lines cut from
the source against stand-ins (69 networks, 40 other failures from 8 threads, 2 mesh, 1 stage, 2 tried answers); it fails
on main, where nothing counts past the 30. tests/test_log_levels.py reads the network's counter by its new name.

Assisted-by: Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <[email protected]>

fix(vk): the networks' count line says they are named at trace level ... 3b67e9faf6

The per-program lines of a network left out on purpose are trace lines, hidden at the default level, so the count line's
"(the first 30 named above)" was not true there. shader_fail_lines now says where each reason's lines are: "at trace
level" for the networks, "above" for the other three. tests/test_not_translated_counts.py checks the wording against the
level its named lines are logged at.

Assisted-by: Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <[email protected]>

mooki added the

kind

bug

priority

high

labels 2026-11-14 13:34:09 +00:00

mooki added the

area/renderer

label 2026-11-14 16:27:54 +00:00

mooki added the

platform/linux

platform/windows

labels 2026-11-14 18:23:48 +00:00

mooki force-pushed fix/network-log-count from 3b67e9faf6 to 1b2b686615 2026-11-15 01:51:41 +00:00 Compare

mooki referenced this pull request 2026-11-15 02:17:42 +00:00

WIP: fix(macos): let MoltenVK's precompile go on behind the title and name slow compiles #652

mooki referenced this pull request 2026-11-15 02:55:02 +00:00

WIP: fix(macos): leave MoltenVK's compute pipelines to the precompile and bound its giant compiles #664

mooki referenced this pull request 2026-11-15 02:55:05 +00:00

WIP: fix(macos): hold MoltenVK's giant compiles behind the game until its first frame, at a lower QoS class #665

mooki referenced this pull request 2026-11-15 03:11:09 +00:00

fix(vk): a timeline wait that comes back device-lost is said as a lost device, not as a timeout #670

mooki changed title from WIP: fix(vk): count every program not translated, past the 30 lines that name them to fix(vk): count every program not translated, past the 30 lines that name them 2026-11-15 04:33:13 +00:00

mooki force-pushed fix/network-log-count from 1b2b686615 to 9488e28a5f 2026-11-15 07:01:08 +00:00 Compare

mooki force-pushed fix/network-log-count from 9488e28a5f to 155b6f117a 2026-11-15 13:02:33 +00:00 Compare

SocialWare referenced this pull request 2026-11-15 13:27:34 +00:00

Game: Crash in Hyrule field after opening and closing map #809

mooki referenced this pull request 2026-11-15 18:14:44 +00:00

Idea: a native macOS build (Apple silicon, x86-64 under Rosetta) with Vulkan on Metal through MoltenVK #420

Some checks failed

Hide checks

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped

Details

Third-party parts / The same as upstream (pull_request) Has been skipped

Details

Website / Website on Cloudflare (pull_request) Has been skipped

Details

CI / Conventional Commit title (pull_request) Successful in 5s

Details

CI / Workflow lint (actionlint) (pull_request) Successful in 8s

Details

Guide screenshots / Guide images and local UI source review (pull_request) Failing after 7s

Details

Third-party parts / As their notes say (pull_request) Successful in 15s

Details

PR description / Description follows the template (pull_request_target) Successful in 6s

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'fix/network-log-count:mooki-fix/network-log-count'

git switch 'mooki-fix/network-log-count'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/upscaling

DLSS, FSR, frame generation

  

beanstalk: approved @ 1697603

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 2c5a62e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 4fd82b7

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 64d6d09

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 6f91fae

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 70a78f9

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8015c9a

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8d361dc

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 9d8356e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ abf2227

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ d82f202

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ e5f1e40

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ ee8ab5f

Set by Beanstalk for show; the farm's database is what counts

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/upscaling

beanstalk: approved @ 1697603

beanstalk: approved @ 2c5a62e

beanstalk: approved @ 4fd82b7

beanstalk: approved @ 64d6d09

beanstalk: approved @ 6f91fae

beanstalk: approved @ 70a78f9

beanstalk: approved @ 8015c9a

beanstalk: approved @ 8d361dc

beanstalk: approved @ 9d8356e

beanstalk: approved @ abf2227

beanstalk: approved @ d82f202

beanstalk: approved @ e5f1e40

beanstalk: approved @ ee8ab5f

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!423

No description provided.