test(vk): the simulated-turf pools check asserts the stock floor #2174 set #2202
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2202
Loading…
Reference in a new issue
No description provided.
Delete branch "dazemc/Longshot:fix/sim-turf-floor-check"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
tests/test_sim_turf_pools.py's wiring check still pinned the floor #2093 gave the adaptive simulated-turf lists: 0 records ("maximum, 0u"). #2174 changed that floor to the game's own size — 143360 blade records and 138240 pool records — because a list released to 0 in an area without turf (Market) came back to Hyrule Field empty and grew list by list, each growth's first write into the game's records a write-back that a capture waited 250 ms for. It addedtests/test_sim_turf_floor.py, which plays that policy for both lists, but did not update this check, sotest_sim_turf_pools.pyhas been red onmainsince #2174 withFAIL: adaptive buffers do not default to their measured minimum floor.What changed: the assertion states the new contract — the constructor passes
kSimTurfPoolCapfor a pool andkSimTurfBladeCapfor the blade list (whitespace removed before matching, so a re-indent does not fail it), andRX_VK_SIM_TURF_SUBSTOCKstill may not exist. It is kept rather than deleted:test_sim_turf_floor.pyplays the floor's behaviour for both lists, and this is the wiring's cheap text-level guard; deleting it would weaken a check to make a failure go away.No product change: the branch differs from
mainonly intests/test_sim_turf_pools.py.Testing
Tested: the full suite,
--jobs 3in an 8 GiB memory scope with the pinned headers: here 912 passed, 22 failed, 18 skipped in 626 s againstmain @ a2dc5385's 911 / 23 / 18. The only name in the baseline and not here istests/test_sim_turf_pools.py, the check this change updates; no name fails here that does not fail on main. Onmain @ a2dc5385the old check fails withFAIL: adaptive buffers do not default to their measured minimum floor(the main-red name); with this change it passes. The branch changes no source, so that pass is against the samegpu/vk/vk_draw.cppmainhas, andtests/test_sim_turf_floor.py(#2174's behavioural check for both lists) still passes.Still to test: None.
Measurements
Verdict: the stale assertion is gone and the floor stays guarded: the pools check is green again,
test_sim_turf_floor.pystill plays the policy, and nothing the game runs changes.a2dc5385fcaa932ftest_sim_turf_pools.pytest_sim_turf_floor.pyRisks
A test-only change: nothing the game runs changes — no switch, setting, save or cache. If the constructor's floor moves again, this check fails with the line to read, and
test_sim_turf_floor.pyfails with the capacity it found. Reverting restores the red check.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). (912 / 22 / 18 here against main's 911 / 23 / 18; the only difference istests/test_sim_turf_pools.pypassing, and no name here is absent from main's list)main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened. (the floor assertion states the contract #2174 set;test_sim_turf_floor.pystill plays it)Ready to merge
main, measured again or a comment says why the numbers still hold. (CI has not run on this head)View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.