fix(dev): dev.py ab holds the Render resolution at 67 % where the options leave it at Auto, so a GPU change shows in frames (--dynamic keeps Auto) #2066
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2066
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/ab-fixed-render-resolution"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
dev.py abgave confident verdicts on noise for any change that saves (or costs) GPU time. It pins every menu row atits default, and the default Render resolution is Auto: the game's dynamic resolution, which sizes the 3D to the GPU's
load. A GPU saving then comes out as a larger picture, not as frames, and each run settles at a 3D size of its own.
Measured on one switch (dropping the renderer's barriers between back-to-back compute dispatches), Hyrule Field at 4K on
an RTX 3090:
run;
This PR makes
dev.py abwriteresolution=3(67 %, DLSS's and FSR's Quality share) into the pinned options file whenthe options leave the Render resolution at Auto, and say so in the plan it prints. A player's own fixed share
(
--optionswithresolution=N) is kept.--dynamickeeps Auto, to see what a player on Auto gets. The Setup linealready names the resolution each run used (
resolution 67% (2560x1440)).Read first:
pin_optionsanddynamic_resolutioninscripts/devtools/ab.py.Open perf PRs that quote
dev.py ab --scene ...with the defaults (for example #2002, #2004) may want their numberstaken again with this.
Testing
Tested: Linux (CachyOS, kernel 7.3.3), RTX 3090 (NVIDIA 620.70.06), main
9dd41326. The six-run comparisons above:two at Auto (the defaults), one with
--optionsholdingresolution=3, which is what this change writes; plus a Marketcomparison at 67 %.
dev.py ab --dry-runprints the new line,dev.py ab --helplists--dynamic. The test commitcomes first:
tests/test_dev_ab.py'stest_pin_optionsand the newtest_pin_options_resolutionfail on main(
resolution=3missing,pin_optionstakes nodynamic) and pass with the fix, per CI.Still to test:
Measurements
Nothing to measure in the game: this changes how
dev.py absets up its runs, not the game; the spread it removes is in the Summary.Risks
this aren't comparable. The Setup line says which.
Auto sees;
--dynamickeeps Auto.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). (waiting for CI)main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
mainand passes here.tests/that reads changed source is updated, not weakened.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
https://claude.ai/code/session_017vw8dyLUnPP6CBn2bn8Gub
Tested in game: Linux (CachyOS 7.3.3), RTX 3090, NVIDIA 620.70.06, main
9dd41326: dev.py ab in Hyrule Field at 4K, one switch, three interleaved pairs each: at Auto (the defaults) +6.0 % then -6.5 % on the same comparison, every run of one side past the other both times; with resolution=3 pinned (what this change writes) +1.1 %, each side within 1 %. Market at 67 % too. dev.py ab --dry-run prints the new line.Possibly related, for context:
WIP: fix(dev): dev.py ab holds the Render resolution at 67 % where the options leave it at Auto, so a GPU change shows in frames (--dynamic keeps Auto)to fix(dev): dev.py ab holds the Render resolution at 67 % where the options leave it at Auto, so a GPU change shows in frames (--dynamic keeps Auto)